blob: fe6e009b6c108d1315eb2169c24b26fe63231de3 [file] [log] [blame]
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <map>
#include <string>
#include <vector>
#include "base/basictypes.h"
#include "base/bind.h"
#include "base/message_loop.h"
#include "base/run_loop.h"
#include "base/string_number_conversions.h"
#include "base/string_split.h"
#include "base/string_util.h"
#include "base/time.h"
#include "cobalt/media/base/media_log.h"
#include "cobalt/media/base/media_util.h"
#include "cobalt/media/base/mock_filters.h"
#include "cobalt/media/base/test_helpers.h"
#include "cobalt/media/base/timestamp_constants.h"
#include "cobalt/media/filters/chunk_demuxer.h"
#include "cobalt/media/filters/frame_processor.h"
#include "starboard/types.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::InSequence;
using ::testing::StrictMock;
using ::testing::Values;
namespace cobalt {
namespace media {
typedef StreamParser::BufferQueue BufferQueue;
typedef StreamParser::TrackId TrackId;
// Used for setting expectations on callbacks. Using a StrictMock also lets us
// test for missing or extra callbacks.
class FrameProcessorTestCallbackHelper {
public:
FrameProcessorTestCallbackHelper() {}
virtual ~FrameProcessorTestCallbackHelper() {}
MOCK_METHOD1(PossibleDurationIncrease, void(base::TimeDelta new_duration));
// Helper that calls the mock method as well as does basic sanity checks on
// |new_duration|.
void OnPossibleDurationIncrease(base::TimeDelta new_duration) {
PossibleDurationIncrease(new_duration);
ASSERT_NE(kNoTimestamp, new_duration);
ASSERT_NE(kInfiniteDuration, new_duration);
}
private:
DISALLOW_COPY_AND_ASSIGN(FrameProcessorTestCallbackHelper);
};
// Test parameter determines indicates if the TEST_P instance is targeted for
// sequence mode (if true), or segments mode (if false).
class FrameProcessorTest : public testing::TestWithParam<bool> {
protected:
FrameProcessorTest()
: frame_processor_(new FrameProcessor(
base::Bind(
&FrameProcessorTestCallbackHelper::OnPossibleDurationIncrease,
base::Unretained(&callbacks_)),
new MediaLog())),
append_window_end_(kInfiniteDuration),
frame_duration_(base::TimeDelta::FromMilliseconds(10)),
audio_id_(1),
video_id_(2) {}
enum StreamFlags { HAS_AUDIO = 1 << 0, HAS_VIDEO = 1 << 1 };
void AddTestTracks(int stream_flags) {
const bool has_audio = (stream_flags & HAS_AUDIO) != 0;
const bool has_video = (stream_flags & HAS_VIDEO) != 0;
ASSERT_TRUE(has_audio || has_video);
if (has_audio) {
CreateAndConfigureStream(DemuxerStream::AUDIO);
ASSERT_TRUE(audio_);
EXPECT_TRUE(frame_processor_->AddTrack(audio_id_, audio_.get()));
seek(audio_.get(), base::TimeDelta());
}
if (has_video) {
CreateAndConfigureStream(DemuxerStream::VIDEO);
ASSERT_TRUE(video_);
EXPECT_TRUE(frame_processor_->AddTrack(video_id_, video_.get()));
seek(video_.get(), base::TimeDelta());
}
}
void SetTimestampOffset(base::TimeDelta new_offset) {
timestamp_offset_ = new_offset;
frame_processor_->SetGroupStartTimestampIfInSequenceMode(timestamp_offset_);
}
BufferQueue StringToBufferQueue(const std::string& buffers_to_append,
const TrackId track_id,
const DemuxerStream::Type type) {
std::vector<std::string> timestamps = base::SplitString(
buffers_to_append, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
BufferQueue buffers;
for (size_t i = 0; i < timestamps.size(); i++) {
bool is_keyframe = false;
if (base::EndsWith(timestamps[i], "K", base::CompareCase::SENSITIVE)) {
is_keyframe = true;
// Remove the "K" off of the token.
timestamps[i] = timestamps[i].substr(0, timestamps[i].length() - 1);
}
// Use custom decode timestamp if included.
std::vector<std::string> buffer_timestamps = base::SplitString(
timestamps[i], "|", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (buffer_timestamps.size() == 1)
buffer_timestamps.push_back(buffer_timestamps[0]);
CHECK_EQ(2u, buffer_timestamps.size());
double time_in_ms, decode_time_in_ms;
CHECK(base::StringToDouble(buffer_timestamps[0], &time_in_ms));
CHECK(base::StringToDouble(buffer_timestamps[1], &decode_time_in_ms));
// Create buffer. Encode the original time_in_ms as the buffer's data to
// enable later verification of possible buffer relocation in presentation
// timeline due to coded frame processing.
const uint8_t* timestamp_as_data =
reinterpret_cast<uint8_t*>(&time_in_ms);
scoped_refptr<StreamParserBuffer> buffer = StreamParserBuffer::CopyFrom(
timestamp_as_data, sizeof(time_in_ms), is_keyframe, type, track_id);
ASSERT_TRUE(buffer);
base::TimeDelta timestamp = base::TimeDelta::FromSecondsD(
time_in_ms / base::Time::kMillisecondsPerSecond);
buffer->set_timestamp(timestamp);
if (time_in_ms != decode_time_in_ms) {
DecodeTimestamp decode_timestamp = DecodeTimestamp::FromSecondsD(
decode_time_in_ms / base::Time::kMillisecondsPerSecond);
buffer->SetDecodeTimestamp(decode_timestamp);
}
buffer->set_duration(frame_duration_);
buffers.push_back(buffer);
}
return buffers;
}
void ProcessFrames(const std::string& audio_timestamps,
const std::string& video_timestamps) {
StreamParser::BufferQueueMap buffer_queue_map;
const auto& audio_buffers =
StringToBufferQueue(audio_timestamps, audio_id_, DemuxerStream::AUDIO);
if (!audio_buffers.empty())
buffer_queue_map.insert(std::make_pair(audio_id_, audio_buffers));
const auto& video_buffers =
StringToBufferQueue(video_timestamps, video_id_, DemuxerStream::VIDEO);
if (!video_buffers.empty())
buffer_queue_map.insert(std::make_pair(video_id_, video_buffers));
ASSERT_TRUE(frame_processor_->ProcessFrames(
buffer_queue_map, append_window_start_, append_window_end_,
&timestamp_offset_));
}
void CheckExpectedRangesByTimestamp(ChunkDemuxerStream* stream,
const std::string& expected) {
// Note, DemuxerStream::TEXT streams return [0,duration (==infinity here))
Ranges<base::TimeDelta> r = stream->GetBufferedRanges(kInfiniteDuration);
std::stringstream ss;
ss << "{ ";
for (size_t i = 0; i < r.size(); ++i) {
int64_t start = r.start(i).InMilliseconds();
int64_t end = r.end(i).InMilliseconds();
ss << "[" << start << "," << end << ") ";
}
ss << "}";
EXPECT_EQ(expected, ss.str());
}
void CheckReadStalls(ChunkDemuxerStream* stream) {
int loop_count = 0;
do {
read_callback_called_ = false;
stream->Read(base::Bind(&FrameProcessorTest::StoreStatusAndBuffer,
base::Unretained(this)));
base::RunLoop().RunUntilIdle();
} while (++loop_count < 2 && read_callback_called_ &&
last_read_status_ == DemuxerStream::kAborted);
ASSERT_FALSE(read_callback_called_ &&
last_read_status_ == DemuxerStream::kAborted)
<< "2 kAborted reads in a row. Giving up.";
EXPECT_FALSE(read_callback_called_);
}
// Format of |expected| is a space-delimited sequence of
// timestamp_in_ms:original_timestamp_in_ms
// original_timestamp_in_ms (and the colon) must be omitted if it is the same
// as timestamp_in_ms.
void CheckReadsThenReadStalls(ChunkDemuxerStream* stream,
const std::string& expected) {
std::vector<std::string> timestamps = base::SplitString(
expected, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
std::stringstream ss;
for (size_t i = 0; i < timestamps.size(); ++i) {
int loop_count = 0;
do {
read_callback_called_ = false;
stream->Read(base::Bind(&FrameProcessorTest::StoreStatusAndBuffer,
base::Unretained(this)));
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(read_callback_called_);
} while (++loop_count < 2 &&
last_read_status_ == DemuxerStream::kAborted);
ASSERT_FALSE(last_read_status_ == DemuxerStream::kAborted)
<< "2 kAborted reads in a row. Giving up.";
EXPECT_EQ(DemuxerStream::kOk, last_read_status_);
EXPECT_FALSE(last_read_buffer_->end_of_stream());
if (i > 0) ss << " ";
int time_in_ms = last_read_buffer_->timestamp().InMilliseconds();
ss << time_in_ms;
// Decode the original_time_in_ms from the buffer's data.
double original_time_in_ms;
ASSERT_EQ(sizeof(original_time_in_ms), last_read_buffer_->data_size());
original_time_in_ms =
*(reinterpret_cast<const double*>(last_read_buffer_->data()));
if (original_time_in_ms != time_in_ms) ss << ":" << original_time_in_ms;
// Detect full-discard preroll buffer.
if (last_read_buffer_->discard_padding().first == kInfiniteDuration &&
last_read_buffer_->discard_padding().second.is_zero()) {
ss << "P";
}
}
EXPECT_EQ(expected, ss.str());
CheckReadStalls(stream);
}
// TODO(wolenetz): Refactor to instead verify the expected signalling or lack
// thereof of new coded frame group by the FrameProcessor. See
// https://crbug.com/580613.
bool in_coded_frame_group() {
return frame_processor_->coded_frame_group_last_dts_ !=
kNoDecodeTimestamp();
}
void seek(ChunkDemuxerStream* stream, base::TimeDelta seek_time) {
stream->AbortReads();
stream->Seek(seek_time);
stream->StartReturningData();
}
base::MessageLoop message_loop_;
StrictMock<FrameProcessorTestCallbackHelper> callbacks_;
std::unique_ptr<FrameProcessor> frame_processor_;
base::TimeDelta append_window_start_;
base::TimeDelta append_window_end_;
base::TimeDelta timestamp_offset_;
base::TimeDelta frame_duration_;
std::unique_ptr<ChunkDemuxerStream> audio_;
std::unique_ptr<ChunkDemuxerStream> video_;
const TrackId audio_id_;
const TrackId video_id_;
const BufferQueue empty_queue_;
// StoreStatusAndBuffer's most recent result.
DemuxerStream::Status last_read_status_;
scoped_refptr<DecoderBuffer> last_read_buffer_;
bool read_callback_called_;
private:
void StoreStatusAndBuffer(DemuxerStream::Status status,
const scoped_refptr<DecoderBuffer>& buffer) {
if (status == DemuxerStream::kOk && buffer.get()) {
DVLOG(3) << __FUNCTION__ << "status: " << status
<< " ts: " << buffer->timestamp().InSecondsF();
} else {
DVLOG(3) << __FUNCTION__ << "status: " << status << " ts: n/a";
}
read_callback_called_ = true;
last_read_status_ = status;
last_read_buffer_ = buffer;
}
void CreateAndConfigureStream(DemuxerStream::Type type) {
// TODO(wolenetz/dalecurtis): Also test with splicing disabled?
switch (type) {
case DemuxerStream::AUDIO: {
ASSERT_FALSE(audio_);
audio_.reset(new ChunkDemuxerStream(DemuxerStream::AUDIO, true, "1"));
AudioDecoderConfig decoder_config(kCodecVorbis, kSampleFormatPlanarF32,
CHANNEL_LAYOUT_STEREO, 1000,
EmptyExtraData(), Unencrypted());
frame_processor_->OnPossibleAudioConfigUpdate(decoder_config);
ASSERT_TRUE(audio_->UpdateAudioConfig(decoder_config, new MediaLog()));
break;
}
case DemuxerStream::VIDEO: {
ASSERT_FALSE(video_);
video_.reset(new ChunkDemuxerStream(DemuxerStream::VIDEO, true, "2"));
ASSERT_TRUE(video_->UpdateVideoConfig(TestVideoConfig::Normal(),
new MediaLog()));
break;
}
// TODO(wolenetz): Test text coded frame processing.
case DemuxerStream::TEXT:
case DemuxerStream::UNKNOWN:
case DemuxerStream::NUM_TYPES: {
ASSERT_FALSE(true);
}
}
}
DISALLOW_COPY_AND_ASSIGN(FrameProcessorTest);
};
TEST_F(FrameProcessorTest, WrongTypeInAppendedBuffer) {
AddTestTracks(HAS_AUDIO);
EXPECT_FALSE(in_coded_frame_group());
StreamParser::BufferQueueMap buffer_queue_map;
const auto& audio_buffers =
StringToBufferQueue("0K", audio_id_, DemuxerStream::VIDEO);
buffer_queue_map.insert(std::make_pair(audio_id_, audio_buffers));
ASSERT_FALSE(
frame_processor_->ProcessFrames(buffer_queue_map, append_window_start_,
append_window_end_, &timestamp_offset_));
EXPECT_FALSE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ }");
CheckReadStalls(audio_.get());
}
TEST_F(FrameProcessorTest, NonMonotonicallyIncreasingTimestampInOneCall) {
AddTestTracks(HAS_AUDIO);
StreamParser::BufferQueueMap buffer_queue_map;
const auto& audio_buffers =
StringToBufferQueue("10K 0K", audio_id_, DemuxerStream::AUDIO);
buffer_queue_map.insert(std::make_pair(audio_id_, audio_buffers));
ASSERT_FALSE(
frame_processor_->ProcessFrames(buffer_queue_map, append_window_start_,
append_window_end_, &timestamp_offset_));
EXPECT_FALSE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ }");
CheckReadStalls(audio_.get());
}
TEST_P(FrameProcessorTest, AudioOnly_SingleFrame) {
// Tests A: P(A) -> (a)
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("0K", "");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,10) }");
CheckReadsThenReadStalls(audio_.get(), "0");
}
TEST_P(FrameProcessorTest, VideoOnly_SingleFrame) {
// Tests V: P(V) -> (v)
InSequence s;
AddTestTracks(HAS_VIDEO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("", "0K");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(video_.get(), "{ [0,10) }");
CheckReadsThenReadStalls(video_.get(), "0");
}
TEST_P(FrameProcessorTest, AudioOnly_TwoFrames) {
// Tests A: P(A0, A10) -> (a0, a10)
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
ProcessFrames("0K 10K", "");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
CheckReadsThenReadStalls(audio_.get(), "0 10");
}
TEST_P(FrameProcessorTest, AudioOnly_SetOffsetThenSingleFrame) {
// Tests A: STSO(50)+P(A0) -> TSO==50,(a0@50)
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
const base::TimeDelta fifty_ms = base::TimeDelta::FromMilliseconds(50);
SetTimestampOffset(fifty_ms);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ + fifty_ms));
ProcessFrames("0K", "");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(fifty_ms, timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [50,60) }");
// We do not stall on reading without seeking to 50ms due to
// SourceBufferStream::kSeekToStartFudgeRoom().
CheckReadsThenReadStalls(audio_.get(), "50:0");
}
TEST_P(FrameProcessorTest, AudioOnly_SetOffsetThenFrameTimestampBelowOffset) {
// Tests A: STSO(50)+P(A20) ->
// if sequence mode: TSO==30,(a20@50)
// if segments mode: TSO==50,(a20@70)
InSequence s;
AddTestTracks(HAS_AUDIO);
bool using_sequence_mode = GetParam();
if (using_sequence_mode) frame_processor_->SetSequenceMode(true);
const base::TimeDelta fifty_ms = base::TimeDelta::FromMilliseconds(50);
const base::TimeDelta twenty_ms = base::TimeDelta::FromMilliseconds(20);
SetTimestampOffset(fifty_ms);
if (using_sequence_mode) {
EXPECT_CALL(callbacks_,
PossibleDurationIncrease(fifty_ms + frame_duration_));
} else {
EXPECT_CALL(callbacks_, PossibleDurationIncrease(fifty_ms + twenty_ms +
frame_duration_));
}
ProcessFrames("20K", "");
EXPECT_TRUE(in_coded_frame_group());
// We do not stall on reading without seeking to 50ms / 70ms due to
// SourceBufferStream::kSeekToStartFudgeRoom().
if (using_sequence_mode) {
EXPECT_EQ(fifty_ms - twenty_ms, timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [50,60) }");
CheckReadsThenReadStalls(audio_.get(), "50:20");
} else {
EXPECT_EQ(fifty_ms, timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [70,80) }");
CheckReadsThenReadStalls(audio_.get(), "70:20");
}
}
TEST_P(FrameProcessorTest, AudioOnly_SequentialProcessFrames) {
// Tests A: P(A0,A10)+P(A20,A30) -> (a0,a10,a20,a30)
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
ProcessFrames("0K 10K", "");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 4));
ProcessFrames("20K 30K", "");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,40) }");
CheckReadsThenReadStalls(audio_.get(), "0 10 20 30");
}
TEST_P(FrameProcessorTest, AudioOnly_NonSequentialProcessFrames) {
// Tests A: P(A20,A30)+P(A0,A10) ->
// if sequence mode: TSO==-20 after first P(), 20 after second P(), and
// a(20@0,a30@10,a0@20,a10@30)
// if segments mode: TSO==0,(a0,a10,a20,a30)
InSequence s;
AddTestTracks(HAS_AUDIO);
bool using_sequence_mode = GetParam();
if (using_sequence_mode) {
frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
} else {
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 4));
}
ProcessFrames("20K 30K", "");
EXPECT_TRUE(in_coded_frame_group());
if (using_sequence_mode) {
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
EXPECT_EQ(frame_duration_ * -2, timestamp_offset_);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 4));
} else {
CheckExpectedRangesByTimestamp(audio_.get(), "{ [20,40) }");
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
}
ProcessFrames("0K 10K", "");
EXPECT_TRUE(in_coded_frame_group());
if (using_sequence_mode) {
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,40) }");
EXPECT_EQ(frame_duration_ * 2, timestamp_offset_);
CheckReadsThenReadStalls(audio_.get(), "0:20 10:30 20:0 30:10");
} else {
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,40) }");
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
// Re-seek to 0ms now that we've appended data earlier than what has already
// satisfied our initial seek to start, above.
seek(audio_.get(), base::TimeDelta());
CheckReadsThenReadStalls(audio_.get(), "0 10 20 30");
}
}
TEST_P(FrameProcessorTest, AudioVideo_SequentialProcessFrames) {
// Tests AV: P(A0,A10;V0k,V10,V20)+P(A20,A30,A40,V30) ->
// (a0,a10,a20,a30,a40);(v0,v10,v20,v30)
InSequence s;
AddTestTracks(HAS_AUDIO | HAS_VIDEO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 3));
ProcessFrames("0K 10K", "0K 10 20");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [0,30) }");
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 5));
ProcessFrames("20K 30K 40K", "30");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,50) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [0,40) }");
CheckReadsThenReadStalls(audio_.get(), "0 10 20 30 40");
CheckReadsThenReadStalls(video_.get(), "0 10 20 30");
}
TEST_P(FrameProcessorTest, AudioVideo_Discontinuity) {
// Tests AV: P(A0,A10,A30,A40,A50;V0k,V10,V40,V50key) ->
// if sequence mode: TSO==10,(a0,a10,a30,a40,a50@60);(v0,v10,v50@60)
// if segments mode: TSO==0,(a0,a10,a30,a40,a50);(v0,v10,v50)
// This assumes A40K is processed before V40, which depends currently on
// MergeBufferQueues() behavior.
InSequence s;
AddTestTracks(HAS_AUDIO | HAS_VIDEO);
bool using_sequence_mode = GetParam();
if (using_sequence_mode) {
frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 7));
} else {
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 6));
}
ProcessFrames("0K 10K 30K 40K 50K", "0K 10 40 50K");
EXPECT_TRUE(in_coded_frame_group());
if (using_sequence_mode) {
EXPECT_EQ(frame_duration_, timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,70) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [0,70) }");
CheckReadsThenReadStalls(audio_.get(), "0 10 30 40 60:50");
CheckReadsThenReadStalls(video_.get(), "0 10 60:50");
} else {
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,60) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [0,20) [50,60) }");
CheckReadsThenReadStalls(audio_.get(), "0 10 30 40 50");
CheckReadsThenReadStalls(video_.get(), "0 10");
seek(video_.get(), frame_duration_ * 5);
CheckReadsThenReadStalls(video_.get(), "50");
}
}
TEST_P(FrameProcessorTest, AudioVideo_Discontinuity_TimestampOffset) {
// If in 'sequence' mode, a new coded frame group is *only* started if the
// processed frame sequence outputs something that goes backwards in DTS
// order. This helps retain the intent of 'sequence' mode: it both collapses
// gaps as well as allows app to override the timeline placement and so needs
// to handle overlap-appends, too.
InSequence s;
AddTestTracks(HAS_AUDIO | HAS_VIDEO);
bool using_sequence_mode = GetParam();
frame_processor_->SetSequenceMode(using_sequence_mode);
// Start a coded frame group at time 100ms. Note the jagged start still uses
// the coded frame group's start time as the range start for both streams.
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 14));
SetTimestampOffset(frame_duration_ * 10);
ProcessFrames("0K 10K 20K", "10K 20K 30K");
EXPECT_EQ(frame_duration_ * 10, timestamp_offset_);
EXPECT_TRUE(in_coded_frame_group());
CheckExpectedRangesByTimestamp(audio_.get(), "{ [100,130) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [100,140) }");
// Test the differentiation between 'sequence' and 'segments' mode results if
// the coded frame sequence jumps forward beyond the normal discontinuity
// threshold.
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 24));
SetTimestampOffset(frame_duration_ * 20);
ProcessFrames("0K 10K 20K", "10K 20K 30K");
EXPECT_EQ(frame_duration_ * 20, timestamp_offset_);
EXPECT_TRUE(in_coded_frame_group());
if (using_sequence_mode) {
CheckExpectedRangesByTimestamp(audio_.get(), "{ [100,230) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [100,240) }");
} else {
CheckExpectedRangesByTimestamp(audio_.get(), "{ [100,130) [200,230) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [100,140) [200,240) }");
}
// Test the behavior when timestampOffset adjustment causes next frames to be
// in the past relative to the previously processed frame and triggers a new
// coded frame group, even in 'sequence' mode.
base::TimeDelta fifty_five_ms = base::TimeDelta::FromMilliseconds(55);
EXPECT_CALL(callbacks_,
PossibleDurationIncrease(fifty_five_ms + frame_duration_ * 4));
SetTimestampOffset(fifty_five_ms);
ProcessFrames("0K 10K 20K", "10K 20K 30K");
EXPECT_EQ(fifty_five_ms, timestamp_offset_);
EXPECT_TRUE(in_coded_frame_group());
// The new audio range is not within SourceBufferStream's coalescing threshold
// relative to the next range, but the new video range is within the
// threshold.
if (using_sequence_mode) {
// TODO(wolenetz/chcunningham): The large explicit-timestampOffset-induced
// jump forward (from timestamp 130 to 200) while in a sequence mode coded
// frame group makes our adjacency threshold in SourceBuffer, based on
// max-interbuffer-distance-within-coded-frame-group, very lenient.
// This causes [55,85) to merge with [100,230) here for audio, and similar
// for video. See also https://crbug.com/620523.
CheckExpectedRangesByTimestamp(audio_.get(), "{ [55,230) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [55,240) }");
} else {
CheckExpectedRangesByTimestamp(audio_.get(),
"{ [55,85) [100,130) [200,230) }");
// Note that the range adjacency logic used in this case is doesn't consider
// DTS 85 to be close enough to [100,140), since the first DTS in video
// range [100,140) is actually 110. The muxed data started a coded frame
// group at time 100, but actual DTS is used for adjacency checks while
// appending.
CheckExpectedRangesByTimestamp(video_.get(),
"{ [55,95) [100,140) [200,240) }");
}
// Verify the buffers.
// Re-seek now that we've appended data earlier than what already satisfied
// our initial seek to start.
seek(audio_.get(), fifty_five_ms);
seek(video_.get(), fifty_five_ms);
if (using_sequence_mode) {
CheckReadsThenReadStalls(
audio_.get(),
"55:0 65:10 75:20 100:0 110:10 120:20 200:0 210:10 220:20");
CheckReadsThenReadStalls(
video_.get(),
"65:10 75:20 85:30 110:10 120:20 130:30 210:10 220:20 230:30");
} else {
CheckReadsThenReadStalls(audio_.get(), "55:0 65:10 75:20");
CheckReadsThenReadStalls(video_.get(), "65:10 75:20 85:30");
seek(audio_.get(), frame_duration_ * 10);
seek(video_.get(), frame_duration_ * 10);
CheckReadsThenReadStalls(audio_.get(), "100:0 110:10 120:20");
CheckReadsThenReadStalls(video_.get(), "110:10 120:20 130:30");
seek(audio_.get(), frame_duration_ * 20);
seek(video_.get(), frame_duration_ * 20);
CheckReadsThenReadStalls(audio_.get(), "200:0 210:10 220:20");
CheckReadsThenReadStalls(video_.get(), "210:10 220:20 230:30");
}
}
TEST_P(FrameProcessorTest,
AppendWindowFilterOfNegativeBufferTimestampsWithPrerollDiscard) {
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
SetTimestampOffset(frame_duration_ * -2);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("0K 10K 20K", "");
EXPECT_TRUE(in_coded_frame_group());
EXPECT_EQ(frame_duration_ * -2, timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,10) }");
CheckReadsThenReadStalls(audio_.get(), "0:10P 0:20");
}
TEST_P(FrameProcessorTest, AppendWindowFilterWithInexactPreroll) {
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
SetTimestampOffset(-frame_duration_);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
ProcessFrames("0K 9.75K 20K", "");
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
CheckReadsThenReadStalls(audio_.get(), "0P 0:9.75 10:20");
}
TEST_P(FrameProcessorTest, AppendWindowFilterWithInexactPreroll_2) {
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
SetTimestampOffset(-frame_duration_);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
ProcessFrames("0K 10.25K 20K", "");
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
CheckReadsThenReadStalls(audio_.get(), "0P 0:10.25 10:20");
}
TEST_P(FrameProcessorTest, AllowNegativeFramePTSAndDTSBeforeOffsetAdjustment) {
InSequence s;
AddTestTracks(HAS_AUDIO);
bool using_sequence_mode = GetParam();
if (using_sequence_mode) {
frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 3));
} else {
EXPECT_CALL(callbacks_,
PossibleDurationIncrease((frame_duration_ * 5) / 2));
}
ProcessFrames("-5K 5K 15K", "");
if (using_sequence_mode) {
EXPECT_EQ(frame_duration_ / 2, timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,30) }");
CheckReadsThenReadStalls(audio_.get(), "0:-5 10:5 20:15");
} else {
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,25) }");
CheckReadsThenReadStalls(audio_.get(), "0:-5 5 15");
}
}
TEST_P(FrameProcessorTest, PartialAppendWindowFilterNoDiscontinuity) {
// Tests that spurious discontinuity is not introduced by a partially
// trimmed frame.
InSequence s;
AddTestTracks(HAS_AUDIO);
if (GetParam()) frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_,
PossibleDurationIncrease(base::TimeDelta::FromMilliseconds(29)));
append_window_start_ = base::TimeDelta::FromMilliseconds(7);
ProcessFrames("0K 19K", "");
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
CheckExpectedRangesByTimestamp(audio_.get(), "{ [7,29) }");
CheckReadsThenReadStalls(audio_.get(), "7:0 19");
}
TEST_P(FrameProcessorTest,
PartialAppendWindowFilterNoDiscontinuity_DtsAfterPts) {
// Tests that spurious discontinuity is not introduced by a partially trimmed
// frame that originally had DTS > PTS.
InSequence s;
AddTestTracks(HAS_AUDIO);
bool using_sequence_mode = GetParam();
if (using_sequence_mode) {
frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(
base::TimeDelta::FromMilliseconds(20)));
} else {
EXPECT_CALL(callbacks_, PossibleDurationIncrease(
base::TimeDelta::FromMilliseconds(13)));
}
ProcessFrames("-7|10K 3|20K", "");
if (using_sequence_mode) {
EXPECT_EQ(base::TimeDelta::FromMilliseconds(7), timestamp_offset_);
// TODO(wolenetz): Adjust the following expectation to use PTS instead of
// DTS once https://crbug.com/398130 is fixed.
CheckExpectedRangesByTimestamp(audio_.get(), "{ [17,37) }");
CheckReadsThenReadStalls(audio_.get(), "0:-7 10:3");
} else {
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
// TODO(wolenetz): Adjust the following expectation to use PTS instead of
// DTS once https://crbug.com/398130 is fixed.
CheckExpectedRangesByTimestamp(audio_.get(), "{ [17,30) }");
CheckReadsThenReadStalls(audio_.get(), "0:-7 3");
}
}
TEST_P(FrameProcessorTest, PartialAppendWindowFilterNoNewMediaSegment) {
// Tests that a new media segment is not forcibly signalled for audio frame
// partial front trim, to prevent incorrect introduction of a discontinuity
// and potentially a non-keyframe video frame to be processed next after the
// discontinuity.
InSequence s;
AddTestTracks(HAS_AUDIO | HAS_VIDEO);
frame_processor_->SetSequenceMode(GetParam());
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("", "0K");
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("-5K", "");
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
ProcessFrames("", "10");
EXPECT_EQ(base::TimeDelta(), timestamp_offset_);
EXPECT_TRUE(in_coded_frame_group());
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,5) }");
CheckExpectedRangesByTimestamp(video_.get(), "{ [0,20) }");
CheckReadsThenReadStalls(audio_.get(), "0:-5");
CheckReadsThenReadStalls(video_.get(), "0 10");
}
TEST_F(FrameProcessorTest, AudioOnly_SequenceModeContinuityAcrossReset) {
InSequence s;
AddTestTracks(HAS_AUDIO);
frame_processor_->SetSequenceMode(true);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("0K", "");
frame_processor_->Reset();
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_ * 2));
ProcessFrames("100K", "");
EXPECT_EQ(frame_duration_ * -9, timestamp_offset_);
EXPECT_TRUE(in_coded_frame_group());
CheckExpectedRangesByTimestamp(audio_.get(), "{ [0,20) }");
CheckReadsThenReadStalls(audio_.get(), "0 10:100");
}
TEST_P(FrameProcessorTest, PartialAppendWindowZeroDurationPreroll) {
InSequence s;
AddTestTracks(HAS_AUDIO);
bool is_sequence_mode = GetParam();
frame_processor_->SetSequenceMode(is_sequence_mode);
append_window_start_ = base::TimeDelta::FromMilliseconds(5);
// Append a 0 duration frame that falls just before the append window.
frame_duration_ = base::TimeDelta::FromMilliseconds(0);
EXPECT_FALSE(in_coded_frame_group());
EXPECT_CALL(callbacks_, PossibleDurationIncrease(frame_duration_));
ProcessFrames("4K", "");
// Verify buffer is not part of ranges. It should be silently saved for
// preroll for future append.
CheckExpectedRangesByTimestamp(audio_.get(), "{ }");
CheckReadsThenReadStalls(audio_.get(), "");
EXPECT_FALSE(in_coded_frame_group());
// Abort the reads from last stall. We don't want those reads to "complete"
// when we append below. We will initiate new reads to confirm the buffer
// looks as we expect.
seek(audio_.get(), base::TimeDelta());
// Append a frame with 10ms duration, with 9ms falling after the window start.
base::TimeDelta expected_duration =
base::TimeDelta::FromMilliseconds(is_sequence_mode ? 10 : 14);
EXPECT_CALL(callbacks_, PossibleDurationIncrease(expected_duration));
frame_duration_ = base::TimeDelta::FromMilliseconds(10);
ProcessFrames("4K", "");
EXPECT_TRUE(in_coded_frame_group());
// Verify range updated to reflect last append was processed and trimmed, and
// also that zero duration buffer was saved and attached as preroll.
if (is_sequence_mode) {
// For sequence mode, append window trimming is applied after the append
// is adjusted for timestampOffset. Basically, everything gets rebased to 0
// and trimming then removes 5 seconds from the front.
CheckExpectedRangesByTimestamp(audio_.get(), "{ [5,10) }");
CheckReadsThenReadStalls(audio_.get(), "5:4P 5:4");
} else { // segments mode
CheckExpectedRangesByTimestamp(audio_.get(), "{ [5,14) }");
CheckReadsThenReadStalls(audio_.get(), "5:4P 5:4");
}
// Verify the preroll buffer still has zero duration.
StreamParserBuffer* last_read_parser_buffer =
static_cast<StreamParserBuffer*>(last_read_buffer_.get());
ASSERT_EQ(base::TimeDelta::FromMilliseconds(0),
last_read_parser_buffer->preroll_buffer()->duration());
}
INSTANTIATE_TEST_CASE_P(SequenceMode, FrameProcessorTest, Values(true));
INSTANTIATE_TEST_CASE_P(SegmentsMode, FrameProcessorTest, Values(false));
} // namespace media
} // namespace cobalt