tree c41436243665f9c7aae46b90485ed708f8084d39
parent 83f4767a60113a4dd18b265888302c6b04af6c27
author agable@chromium.org <agable@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> 1395263258 +0000
committer agable@chromium.org <agable@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> 1395263258 +0000

Remove force push from GitCheckout.commit()

The CQ should not be able to force push -- this allows it to wipe out legitimate
commits if something goes wrong internally. This happened recently, with a CQ
commit orphaning 20 commits from the previous few days. This may have happened
any number of times previously, probably only wiping out one commit at a time,
whenever there was a race between the CQ and a developer's direct commit+push.

Repositories should also protect themselves by disallowing force push in their
ACLs.

BUG=261619

Review URL: https://codereview.chromium.org/196573041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258092 0039d316-1c4b-4281-b951-d872f2087c98