Don't throw "line too long" presubmit error on python import statements or when pylint "line too long" is disabled.
BUG=
Review URL: https://codereview.chromium.org/1234333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296035 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 620661f..5ed8656 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -345,11 +345,14 @@
OBJC_FILE_EXTS = ('h', 'm', 'mm')
OBJC_EXCEPTIONS = ('#define', '#endif', '#if', '#import', '#include',
'#pragma')
+ PY_FILE_EXTS = ('py')
+ PY_EXCEPTIONS = ('import', 'from')
LANGUAGE_EXCEPTIONS = [
(CPP_FILE_EXTS, CPP_EXCEPTIONS),
(JAVA_FILE_EXTS, JAVA_EXCEPTIONS),
(OBJC_FILE_EXTS, OBJC_EXCEPTIONS),
+ (PY_FILE_EXTS, PY_EXCEPTIONS),
]
def no_long_lines(file_extension, line):
@@ -381,6 +384,9 @@
if '<include' in line and file_extension in ('css', 'html', 'js'):
return True
+ if 'pylint: disable=line-too-long' in line and file_extension == 'py':
+ return True
+
return input_api.re.match(
r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line)
