commit | 1152229e674d70654a852c73f0354581d3ab6b95 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Fri Feb 22 19:25:31 2019 +0100 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 18:36:45 2019 +0000 |
tree | 3c8e1b877e50e34e35773a21b23e0efb14d86cc0 | |
parent | 01237e9cd0f7e4e1bd4f09a7971b4eb9b8a3c390 [diff] |
gen.py: Pass -pthread via ldflags, not libs This reverts part of commit 0ac93dd2 ("For proper order put -lpthreads as a 'library' not a 'linker flag'"). As explained in https://gn-review.googlesource.com/c/gn/+/4020, we just need to revert commit 082fbe39 and start passing -pthread in ldflags again, there is no need to switch to using |libs| instead. Bug: chromium:934793 Change-Id: I28a32340f858dc8f5369840e6f7e6995d5f3e729 Reviewed-on: https://gn-review.googlesource.com/c/4081 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.