|author||Petr Hosek <email@example.com>||Mon Oct 28 19:54:25 2019 -0700|
|committer||Commit Bot <firstname.lastname@example.org>||Wed Oct 30 03:32:48 2019 +0000|
Handle metadata walk_keys relative to the target directory Don't process relative labels relative to root, process them relative to the target directory. To illustrate this, take the following example: //x:x //x:meta //x/z:z Where x is a target that depends on z, and meta is a generated_file target that sets walk_keys to just "z", the collection would fail because generated_file would try to resolve "z" (which is a relative path) against the root (i.e. as //z:z). This patches changes the logic to always resolve the walk_keys against the target current directory, i.e. in case of //x:meta it'll be resolved against //x which is correct since "z" is relative to that. Bug: 117 Change-Id: I4da2a3d5e279a970794cdf163f596d8c9a107f4b Reviewed-on: https://gn-review.googlesource.com/c/gn/+/6380 Reviewed-by: Brett Wilson <email@example.com> Commit-Queue: Brett Wilson <firstname.lastname@example.org>
GN is a meta-build system that generates build files for Ninja.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
There is a simple example in examples/simple_build directory that is a good place to get started with the minimal configuration.
For a maximal configuration see the Chromium setup:
and the Fuchsia setup:
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along with GN‘s development on Chromium’s gn-dev@ Google Group.