|author||Nico Weber <firstname.lastname@example.org>||Sat Nov 16 15:09:53 2019 -0500|
|committer||Commit Bot <email@example.com>||Mon Nov 18 17:22:15 2019 +0000|
Delete some unused code in src/base. The motivation was that I wanted to fix the one -Wc++11-narrowing warning that clang-cl emitted in File::DeleteOnClose() (...given the warning doesn't fire on win-only code, we apparently deemed this a valuable warning). I saw that the method was dead, so then I went through other File::Flags and removed unused ones, and I removed some unused functions in file_util that kepts some of the remaining flags alive. No behavior change. With this, gn builds with clang-cl without any custom CFLAGS. Bug: none Change-Id: I7663c886022ffecbd8a1811952805467c9a163b4 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/6640 Reviewed-by: Brett Wilson <firstname.lastname@example.org> Commit-Queue: Brett Wilson <email@example.com>
GN is a meta-build system that generates build files for Ninja.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
There is a simple example in examples/simple_build directory that is a good place to get started with the minimal configuration.
To build and run the simple example with the default gcc compiler:
cd examples/simple_build ../../out/gn gen -C out ninja -C out ./out/hello
For a maximal configuration see the Chromium setup:
and the Fuchsia setup:
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git push origin HEAD:refs/for/master
When revising a change, use:
git commit --amend git push origin HEAD:refs/for/master
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along with GN‘s development on Chromium’s gn-dev@ Google Group.