Remove minor compiler warning
Replace 'const auto' with 'const auto&' to remove a compiler
warning when compiling src/gn/rust_project_writer.cc with a recent
Clang toolchain (e.g. the prebuilt CIPD package from the Fuchsia
project), which looks like:
../src/gn/rust_project_writer.cc:305:19: warning: loop variable 'cfg'
creates a copy from type 'const
std::__2::tuple<std::__2::basic_string<char,
std::__2::char_traits<char>, std::__2::allocator<char> >,
std::__2::basic_string<char, std::__2::char_traits<char>,
std::__2::allocator<char> > >' [-Wrange-loop-construct]
for (const auto cfg : kvs) {
^
../src/gn/rust_project_writer.cc:305:8: note: use
reference type 'const
std::__2::tuple<std::__2::basic_string<char,
std::__2::char_traits<char>,
std::__2::allocator<char> >,
std::__2::basic_string<char,
std::__2::char_traits<char>,
std::__2::allocator<char> > > &' to prevent copying
for (const auto cfg : kvs) {
^~~~~~~~~~~~~~~~
&
Change-Id: Ia325fec7bd2303e8a762bfd7bf38397f3b1eb522
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/8120
Reviewed-by: Benjamin Brittain <bwb@google.com>
Reviewed-by: Petr Hosek <phosek@google.com>
Commit-Queue: Petr Hosek <phosek@google.com>
diff --git a/src/gn/rust_project_writer.cc b/src/gn/rust_project_writer.cc
index a3a1dd4..754f9b6 100644
--- a/src/gn/rust_project_writer.cc
+++ b/src/gn/rust_project_writer.cc
@@ -302,7 +302,7 @@
rust_project << " \"key_value_cfgs\": {";
bool first_kv = true;
- for (const auto cfg : kvs) {
+ for (const auto& cfg : kvs) {
if (!first_kv) {
rust_project << ",";
}
