)]}' { "commit": "5ed3c9cc67b090d5e311e4bd2aba072173e82db9", "tree": "a333c04332e1da5a192f306d619add941dec568f", "parents": [ "2a18133d4bf048bf6564d5bc43cd7fb71659c87a" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Fri Mar 20 19:19:24 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 23 16:57:34 2020 +0000" }, "message": "Match all toolchains by default.\n\nGN was originally designed expecting that most users would only want to\ninteract with the default toolchain. As a result, most introspection\ncommands match only targets in the default toolchain by default.\n\nBut some builds have made greater use of the toolchain feature. For\nexample, in Fuchsia, allshared libraries and all of their dependencies\nare compiled in a special \"shared\" toolchain with \"position independent\ncode\" enabled. Most users are not aware of this. So in such builds,\nhaving introspection commands only match targets in the default\ntoolchain can be surprising and look broken.\n\nThis changes the default to match all toolchains for introspection\ncommands that can take labels. A new --default-toolchain flag is added\nfor the default behavior, and the previous --all-toolchains flag is\nremoved.\n\nChange-Id: Ifa0dfa5b8c792c115443776f3b992d2d6b03bf02\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/7840\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "7122d027c542d22a4bd67cc5d9da1e37d2454aef", "old_mode": 33188, "old_path": "src/gn/command_check.cc", "new_id": "98a5e1c51e9efe9656f9f85dc435994f035618bf", "new_mode": 33188, "new_path": "src/gn/command_check.cc" }, { "type": "modify", "old_id": "086d5f1ce0697e12c4fd81228d68b6162f8c53d4", "old_mode": 33188, "old_path": "src/gn/command_desc.cc", "new_id": "081ae83045257d2f9b971125b486a222f324dddb", "new_mode": 33188, "new_path": "src/gn/command_desc.cc" }, { "type": "modify", "old_id": "e95730f2b2dff0810edc03b11e7e4f4fc7b4c9f9", "old_mode": 33188, "old_path": "src/gn/command_ls.cc", "new_id": "cfd7b0f3de0fe24e21bea2dabe8f8c44f4888c9b", "new_mode": 33188, "new_path": "src/gn/command_ls.cc" }, { "type": "modify", "old_id": "376405b736e6829a71336e852527569122333c1f", "old_mode": 33188, "old_path": "src/gn/command_outputs.cc", "new_id": "9360eadc877c67fef78ac6425ae715bc8e5e3fd5", "new_mode": 33188, "new_path": "src/gn/command_outputs.cc" }, { "type": "modify", "old_id": "4f9ba05122118a81b88f00b3ed0c7a8af197c367", "old_mode": 33188, "old_path": "src/gn/command_refs.cc", "new_id": "c30d4c42164c44245107bfb9322d7b3e455c7018", "new_mode": 33188, "new_path": "src/gn/command_refs.cc" }, { "type": "modify", "old_id": "1941cba65cec2c5b499d00a07b145adf527a1132", "old_mode": 33188, "old_path": "src/gn/commands.cc", "new_id": "431f8d2554c0e4d977be054a29ae3ff10f29fbc6", "new_mode": 33188, "new_path": "src/gn/commands.cc" }, { "type": "modify", "old_id": "a3e6e42e91a64a6360f666ac6c061937bb91dda1", "old_mode": 33188, "old_path": "src/gn/commands.h", "new_id": "41b99bc7d910d9caf05902ed7e2cde76aa0b1965", "new_mode": 33188, "new_path": "src/gn/commands.h" }, { "type": "modify", "old_id": "dea73c64ce0259f59b018ccdfd9f9e08940f71b4", "old_mode": 33188, "old_path": "src/gn/switches.cc", "new_id": "e7b3a8136fe1514a4b43b8550a514f76f641f2f9", "new_mode": 33188, "new_path": "src/gn/switches.cc" }, { "type": "modify", "old_id": "900104a0b4bfef59943d8200821578da120e90e1", "old_mode": 33188, "old_path": "src/gn/switches.h", "new_id": "69c47b66399269c25cce1e83a56635657cbc2cf7", "new_mode": 33188, "new_path": "src/gn/switches.h" } ] }