|author||Scott Graham <email@example.com>||Mon Apr 06 14:05:42 2020 -0700|
|committer||Commit Bot <firstname.lastname@example.org>||Tue Apr 07 00:03:08 2020 +0000|
format: Don't crash on non-literal import import() with non-literal as argument was crashing in attempting to sort them during format. There's no much intelligent that we can do to sort for example a function call in import() so just treat them as empty so they go before the literal ones. A stable sort guarantees that as a group the relative order stays the same. Crash found by afl-fuzz. Bug: gn:156 Change-Id: If38d4d81a20bc90f28dd60332e3bb66206c0293e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/7980 Reviewed-by: Brett Wilson <email@example.com> Commit-Queue: Scott Graham <firstname.lastname@example.org>
GN is a meta-build system that generates build files for Ninja.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
There is a simple example in examples/simple_build directory that is a good place to get started with the minimal configuration.
To build and run the simple example with the default gcc compiler:
cd examples/simple_build ../../out/gn gen -C out ninja -C out ./out/hello
For a maximal configuration see the Chromium setup:
and the Fuchsia setup:
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git push origin HEAD:refs/for/master
The first time you do this you'll get an error from the server about a missing change-ID. Follow the directions in the error message to install the change-ID hook and run
git commit --amend to apply the hook to the current commit.
When revising a change, use:
git commit --amend git push origin HEAD:refs/for/master
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along with GN‘s development on Chromium’s gn-dev@ Google Group.