commit eb18f84fd1c3d7d9d8caccde4b44e7c5ec0df833
author Petr Hosek <phosek@google.com> Thu Dec 05 13:24:37 2019 -0800
committer Commit Bot <commit-bot@chromium.org> Fri Dec 06 00:53:34 2019 +0000
tree f384262414560409db2a97dfa563401f075a28e8
parent 171ab91c389018e5ae1fa23a467028d557fe0f6a

Delete the default Token assignment opoerator

Recent Clang issues a warning for this:

  warning: definition of implicit copy assignment operator for 'Token' is deprecated because it has a user-declared copy constructor

Change-Id: I61345d30ff50fd51c587d1a6fbebd777ae3cbd60
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/6760
Commit-Queue: Petr Hosek <phosek@google.com>
Reviewed-by: Brett Wilson <brettw@chromium.org>

src/gn/token.cc

diff --git a/src/gn/token.cc b/src/gn/token.cc
index c648371..0466ce7 100644
--- a/src/gn/token.cc
+++ b/src/gn/token.cc
@@ -11,8 +11,6 @@
 Token::Token(const Location& location, Type t, const std::string_view& v)
     : type_(t), value_(v), location_(location) {}
 
-Token::Token(const Token& other) = default;
-
 bool Token::IsIdentifierEqualTo(const char* v) const {
   return type_ == IDENTIFIER && value_ == v;
 }

src/gn/token.h

diff --git a/src/gn/token.h b/src/gn/token.h
index 8837466..c074620 100644
--- a/src/gn/token.h
+++ b/src/gn/token.h
@@ -59,7 +59,6 @@
 
   Token();
   Token(const Location& location, Type t, const std::string_view& v);
-  Token(const Token& other);
 
   Type type() const { return type_; }
   const std::string_view& value() const { return value_; }