)]}' { "log": [ { "commit": "df4a8e68510787e17f87cea99f6a8fe6227fd188", "tree": "70f100c501849a4422ba9accb890c0f9f03e50ae", "parents": [ "39a87c0b36310bdf06b692c098f199a0d97fc810" ], "author": { "name": "Andrew Savage", "email": "andrewsavage@google.com", "time": "Wed Jun 02 10:41:34 2021 -0700" }, "committer": { "name": "Andrew Savage", "email": "andrewsavage@google.com", "time": "Wed Jun 02 10:41:34 2021 -0700" }, "message": "Add GYP to GN conversion cookbook\n" }, { "commit": "39a87c0b36310bdf06b692c098f199a0d97fc810", "tree": "25add407b7352cc74707262a9c2cbbe9ba89712e", "parents": [ "281c994dc67772cc2a6f5c5fa1c4bafb9dcb733e" ], "author": { "name": "Robert Sesek", "email": "rsesek@chromium.org", "time": "Fri May 07 17:48:14 2021 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 07 22:18:45 2021 +0000" }, "message": "Escape solibs in case the output name contains a space character.\n\nBug: chromium:1197495\nChange-Id: I464c1a507294ced04c6274149d33b3b9615801e4\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11500\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\n" }, { "commit": "281c994dc67772cc2a6f5c5fa1c4bafb9dcb733e", "tree": "55ce9297af6b18b2560145d8ddef06748dd32a7c", "parents": [ "7b23bd91f996722e5e55e0ccf0c80c0a984efca5" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu May 06 15:09:54 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 07 10:18:44 2021 +0000" }, "message": "Use std::set instead of std::unordered_set\n\nThe recommendation in Chromium is to avoid using std::unordered_set\nand instead to use base::flat_set if the number of items is small\nor std::set if unsure.\n\nGiven that there are many targets, use std::set\u003c\u003e.\n\nRemove some unnecessary include of unorderset_set.\n\nBug: none\nChange-Id: I2a9d1026e4458a89f3bdb41ab6869cd11d193acb\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11402\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "7b23bd91f996722e5e55e0ccf0c80c0a984efca5", "tree": "aa6c623827f137705b2e4b7d3cdb93017cbb0fcc", "parents": [ "0710521ff0467b23bf55b390ecf7943b5957b962" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Thu May 06 15:05:32 2021 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 22:19:23 2021 +0000" }, "message": "[infra] Use correct URL for the console\n\nChange-Id: Idee1703dd53335a542ddc21d056f501cdf732fe2\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11480\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "0710521ff0467b23bf55b390ecf7943b5957b962", "tree": "06244f692b1c8e9d8551c117dee65b16f7fc089b", "parents": [ "7e2d04e09e253c065d769dc84a507b6d496aed0c" ], "author": { "name": "Andrii Shyshkalov", "email": "tandrii@google.com", "time": "Thu May 06 22:33:48 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 20:54:43 2021 +0000" }, "message": "[infra] upgrade upstream recipes-py dep to \"main\".\n\nAlso, I need to poke ci builders after another \"main\" fix\nin https://crrev.com/i/3813486\n\nR\u003dphosek\n\nBug: chromium:1205320\nChange-Id: I9894af0557f7d387f1f65315bccfd0a731b00dfc\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11461\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "7e2d04e09e253c065d769dc84a507b6d496aed0c", "tree": "b681bd9d93dce4ab9a7cec11353d3c2280c54d0e", "parents": [ "548d0e6a949b5d89cf3dc72eefaffb6223775766" ], "author": { "name": "Andrii Shyshkalov", "email": "tandrii@google.com", "time": "Thu May 06 11:50:02 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 19:21:31 2021 +0000" }, "message": "[infra] remove redundant ACL.\n\nR\u003dphosek\n\nChange-Id: I7a74e555242350bd2f9f57b2250f1dc75a19ed64\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11443\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "548d0e6a949b5d89cf3dc72eefaffb6223775766", "tree": "5447a24e1aed792bfb238a30cc22f4153c710515", "parents": [ "c35fe76a93eb2b2f1b94f0f21f58f03fa8e2efe3" ], "author": { "name": "Andrii Shyshkalov", "email": "tandrii@google.com", "time": "Thu May 06 21:01:05 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 19:21:01 2021 +0000" }, "message": "[infra] fix typo in group name.\n\nR\u003dphosek\n\nChange-Id: I76dd1ec7faf471fe5b47bafb077b598dbead434b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11460\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "c35fe76a93eb2b2f1b94f0f21f58f03fa8e2efe3", "tree": "9b4c4c50551e3cb645e6e7217b4bc5d062a9319c", "parents": [ "46f9f594030d4d47ae17699acfd92f9536055a88" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed May 05 22:50:10 2021 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 18:54:21 2021 +0000" }, "message": "Switch from master to main branch\n\nThis changes switch infra configuration to use main branch.\n\nChange-Id: Id713b0bc6007c7ee7290b30fd10b9cc389f0dcb2\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11421\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "46f9f594030d4d47ae17699acfd92f9536055a88", "tree": "b2e397d4701d9fada88c85493937924566947ed7", "parents": [ "bbd4ab0c3d992c15ec50850d72195d0fcc9dfe84" ], "author": { "name": "Andrii Shyshkalov", "email": "tandrii@google.com", "time": "Thu May 06 11:49:02 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 18:29:01 2021 +0000" }, "message": "[realms] switch GN to LUCI realms.\n\nR\u003dphosek\n\nBug: chromium:1204962\nChange-Id: If010f250ca283c0308d5299a6d2082cb63c4f495\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11442\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "bbd4ab0c3d992c15ec50850d72195d0fcc9dfe84", "tree": "cfa2d2ff88089b468e1ef4daefa2d1aec9e6c3f9", "parents": [ "0d00acaef051e63969f936be5dc06ff7aac7213b" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Mon May 03 16:51:11 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 11:23:41 2021 +0000" }, "message": "Use StringOutputBuffer to write file\n\nThe class StringOutputBuffer performs the comparison between the\nmemory buffer and the destination file in chunks instead of reading\nthe file in one huge string. This is slightly more performant when\ngenerating Chromium build files for iOS and macOS (~ 4% faster).\n\nBug: none\nChange-Id: Iba763c5f58bf16233cc3e6833a3b38294dce2de8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11401\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "0d00acaef051e63969f936be5dc06ff7aac7213b", "tree": "482a61ef335461b81a891d23936bd25388ea2a54", "parents": [ "efa1e2e0a1249edaef4399bf45b535f43ea27099" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Mon May 03 16:45:33 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 06 10:29:31 2021 +0000" }, "message": "Pass std::string_view by value\n\nAs std::string_view is a relatively small structure it can be passed\nby value. The code was using a mix of passing it either by value or\nby const reference. Settle on passing by value.\n\nRemove some unnecessary templated functions that was only overloaded\nfor `const std::string\u0026` and `const std::string_view` as the latter\nwas enough.\n\nFix IWYU by adding `#include \u003cstring_view\u003e` in all header files that\nuses std::string_view.\n\nBug: none\nChange-Id: If42ab28342e8d73f6f0543e77319fdf6380c41b5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11400\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "efa1e2e0a1249edaef4399bf45b535f43ea27099", "tree": "39830f92c66d0c456a691e0891de8cfaa26ad187", "parents": [ "dfd036f3be5422c7b61cf16369bde28b3a8cccc8" ], "author": { "name": "Andrii Shyshkalov", "email": "tandrii@google.com", "time": "Thu May 06 11:22:55 2021 +0200" }, "committer": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu May 06 09:30:20 2021 +0000" }, "message": "[infra] finish migration to the `main` branch.\n\nR\u003dsdefresne\n\nBug: 1205320\nChange-Id: I4502caa072c7eab54ea0a8b3bb6c3077070755d6\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11440\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "dfd036f3be5422c7b61cf16369bde28b3a8cccc8", "tree": "b97df781e0facbca469337a55fe0d730b6aa7aa9", "parents": [ "6771ce569fb4803dad7a427aa2e2c23e960b917e" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Tue Mar 30 11:10:44 2021 -0700" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Thu May 06 05:53:11 2021 +0000" }, "message": "[infra] Remove refs.cfg\n\nThis file is no longer being used.\n\nChange-Id: I148095a690ea4f233b32da151da05613b8acc2a0\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11300\nReviewed-by: Robbie Iannucci \u003ciannucci@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "6771ce569fb4803dad7a427aa2e2c23e960b917e", "tree": "49d294c12d608c8a332baba10e2126edb3088a32", "parents": [ "dba01723a441c358d843a575cb7720d54ddcdf92" ], "author": { "name": "Eli Lipsitz", "email": "elipsitz@fb.com", "time": "Wed Mar 31 10:10:57 2021 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 29 20:05:24 2021 +0000" }, "message": "Allow Rust targets to link against Rust cdylibs\n\nThere was previously a deficiency in the Rust binary target\ngenerator that caused GN to fail to emit a link argument for\nRust cdylib dependencies.\n\nThis fixes the issue by linking against Rust cdylibs the same way\nthat other non-Rust native dependencies are handled. This also\nfixes an issue in the unit test toolchain that prevented Rust\ncdylib/dylib outputs from being set.\n\nFixes https://bugs.chromium.org/p/gn/issues/detail?id\u003d233 .\n\nChange-Id: Ief9c5f0dd652c0430ada756cbe09b5800d069962\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11320\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "dba01723a441c358d843a575cb7720d54ddcdf92", "tree": "3845ebfdab0fb566365a8f923d20ff603d7bcd13", "parents": [ "a95c8a3ccc7de65eb740aa68a0d021cdc8550205" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Tue Apr 06 08:56:46 2021 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 06 17:41:35 2021 +0000" }, "message": "Update \"help analyze\" after a95c8a3ccc7de\n\n...and update reference with `out/gn --markdown help all \u003e docs/reference.md`\n\nChange-Id: Ia1546111cf2990ebcf455786251800796921997d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11360\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n" }, { "commit": "a95c8a3ccc7de65eb740aa68a0d021cdc8550205", "tree": "72271bbb29da124759f6e606006e9807bac4093e", "parents": [ "5667cc61018864b17542e0baff8b790f245583b0" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Sat Apr 03 11:34:58 2021 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 05 17:01:34 2021 +0000" }, "message": "analyze: Make additional_compile_targets input key optional\n\nIt looks like it was required so that if people put in\n\"compile_targets\" instead, they get an error about\nadditional_compile_targets missing. Instead, error out\non unknown keys.\n\nChange-Id: Ib14b68085ee64348f248fbebad2ef05183a5059d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11340\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n" }, { "commit": "5667cc61018864b17542e0baff8b790f245583b0", "tree": "ba9be63c835aa37def8cfec277418907c45ea9ad", "parents": [ "b2e3d8622c1ce1bd853c7a11f62a739946669cdd" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Tue Mar 30 01:48:37 2021 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 30 18:46:22 2021 +0000" }, "message": "[infra] Use lucicfg for infra configuration\n\nThe generated files should match handwritten ones on infra/config branch.\n\nChange-Id: Idbd59689afcfcd70c37f9a93a7ce672264df1bb7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11280\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\n" }, { "commit": "b2e3d8622c1ce1bd853c7a11f62a739946669cdd", "tree": "6746b3b6c4685017d0b0e5baa54b67e08cf80f50", "parents": [ "64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Mar 26 08:50:24 2021 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Mar 27 02:56:54 2021 +0000" }, "message": "Add \"assert_no_deps\" to gn.vim\n\nChange-Id: Ie1e2984aea84b4b72c564f3fe437ae0148d611c9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11260\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8", "tree": "1f5f13f6a7b8e669ea03e052a324e1f343348f50", "parents": [ "e0358b49272c8b354eda0a595e1d7887343fab27" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Mar 12 16:37:14 2021 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 12 23:53:24 2021 +0000" }, "message": "Rename extra_hard_deps to additional_hard_deps\n\nEvery time I read this code I wondered what makes a dependency extra\nhard. Turns out it was supposed to be (extra (hard deps)),\nnot ((extra hard) deps). Maybe s/extra/additional/ makes this more\nclear.\n\nNo behavior change.\n\nChange-Id: I2ed17795c8ba29fab5ae0e5bbfcbf73ea897a358\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11220\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n" }, { "commit": "e0358b49272c8b354eda0a595e1d7887343fab27", "tree": "4292d012e764bf3b62a94b0aefb356b13978a3b0", "parents": [ "dfcbc6fed0a8352696f92d67ccad54048ad182b3" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Thu Mar 11 16:57:01 2021 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 11 23:12:52 2021 +0000" }, "message": "Fix a few typos\n\nI\u0027m trying to set up an autoroller for GN in Chromium. It\u0027s currently\nstuck in a bad state, and the easiest way to try and get it unstuck\nis to have a new upstream GN commit. Apologies.\n\nChange-Id: I6beff0dff7140a88fa5a205961f4dc6a40b7d22a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11200\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n" }, { "commit": "dfcbc6fed0a8352696f92d67ccad54048ad182b3", "tree": "13f0f92489f363a377a72d838de0fa99b2e4cc37", "parents": [ "55e535a6716e57320fdd3901f0347a5c30562199" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Mon Feb 08 15:08:39 2021 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 09 09:48:40 2021 +0000" }, "message": "[xcode] Fix detection of XCTests by Xcode 12.0+\n\nFor Xcode to detect the XCTests automatically in a project, the\nsource files used by the tests needs to be listed in the project.\nHowever, if the files are listed, then Xcode tries to build them.\n\nWith version of Xcode prior to 12.0, the project was configured\nso that Xcode would do nothing while trying to compile them (by\npassing `--help` flag to the compiler). This stopped working with\nXcode 12.0 which started to expect the compilation to produce\nsome output.\n\nInstead of configuring the compilation to be a no-op, instead\nconfigure Xcode so that those files are not compiled by setting\na pattern matching all files for \"Excluded Source File Names\".\nThis works with all version of Xcode and both \"legacy\" and \"new\"\nbuild system.\n\nBug: chromium:1103230\nChange-Id: I44eb0df32ca9c8d57b2dc5b378878c5eb308bf38\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11162\nReviewed-by: Justin Cohen \u003cjustincohen@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "55e535a6716e57320fdd3901f0347a5c30562199", "tree": "34cd53756149a29aa38314aa45e4bd55e50d63d1", "parents": [ "8fe02009e71cdb3cdb6b5477641e7651c7870652" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Mon Feb 08 13:37:51 2021 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Feb 08 16:52:09 2021 +0000" }, "message": "Remove `set_sources_assignment_filter` function\n\nThe function has been deprecated since Oct 2020, only accepting an\nempty list. All projects using it should have been converted. If\nany break, they can just remove the function call.\n\nBug: 125\nChange-Id: I49290e4fea588dc9275414479f7867515fceea6e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11160\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "8fe02009e71cdb3cdb6b5477641e7651c7870652", "tree": "c567eb37587bf2a50b59cbea9f1594d3ec72f0f6", "parents": [ "d7cf6238e07f87b51118f9823a1ec024c1f1932b" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Mon Feb 08 13:41:19 2021 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Feb 08 16:49:19 2021 +0000" }, "message": "Add \"else\" to the list of gn keyword\n\nAdd \"else\" as a valid keyword for gn syntax highlighting for\neditor that uses TextMate syntax highlighting rules.\n\nBug: none\nChange-Id: Ib63a61457e88fbc35d6091efea6cffdce5211653\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11161\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "d7cf6238e07f87b51118f9823a1ec024c1f1932b", "tree": "c34baf89f83605df071d34a40b35006f256286d6", "parents": [ "ef13fe92a49fa4458204e1ac3885f767aa1fa0e9" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Tue Feb 02 17:09:07 2021 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Feb 03 03:53:39 2021 +0000" }, "message": "Address readme feedback.\n\nMinor updates to the readme to address feedback from the last update.\n\nChange-Id: I51ea63085f7a4819e8275b7c3bb2bea7f3ff9638\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11140\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "ef13fe92a49fa4458204e1ac3885f767aa1fa0e9", "tree": "3272192e5805c46e729c98820bd8ef7a608ee8c1", "parents": [ "09c9e5ee5ea9c1018deefc5e5f7daad84f6a0ab8" ], "author": { "name": "qinxialei", "email": "xialeiqin@gmail.com", "time": "Mon Feb 01 16:57:04 2021 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 02 03:30:39 2021 +0000" }, "message": "Change python to python3\n\nthe problem is that sometimes /usr/bin/python does not exist.\nFor example: debian 11 has been confirmed that the python command will not be provided.\n\nChange-Id: I9bbe08ed10b126b92e9a43613fc379a84e614422\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11120\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "09c9e5ee5ea9c1018deefc5e5f7daad84f6a0ab8", "tree": "b42ed7990a0669ab2954619c10decfe3bbf21988", "parents": [ "335dd456f93d9817210a537bb847ad2bc4f66803" ], "author": { "name": "Ricardo Ribalda", "email": "ribalda@chromium.org", "time": "Mon Jan 25 19:07:20 2021 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 28 19:11:44 2021 +0000" }, "message": "Fix some typos\n\nlintian (a debian package helper) showed the following\nspelling-errors:\n\nribalda@alco:/tmp/gn-debian (master *%)$ lintian ../generate-ninja_0.0~git20201124.53d9201-1.1*changes --pedantic --display-info --display-experimental --no-tag-display-limit\nI: generate-ninja: spelling-error-in-binary usr/bin/gn \"allows to\" \"allows one to\"\nI: generate-ninja: spelling-error-in-binary usr/bin/gn Verfication Verification\nI: generate-ninja: spelling-error-in-binary usr/bin/gn appropiate appropriate\nI: generate-ninja: spelling-error-in-binary usr/bin/gn defaut default\nI: generate-ninja: spelling-error-in-binary usr/bin/gn dependant dependent\nI: generate-ninja: spelling-error-in-binary usr/bin/gn occurence occurrence\nI: generate-ninja: spelling-error-in-binary usr/bin/gn ouput output\nI: generate-ninja: spelling-error-in-binary usr/bin/gn ouputs outputs\nI: generate-ninja: spelling-error-in-binary usr/bin/gn overriden overridden\n\nFirst seen at: https://salsa.debian.org/debian/gn/-/blob/eb11997ea5fb2165ebe8af52e1f44eaf0c364b78/debian/patches/Fix-spelling-error.patch\n\nChange-Id: I68f69d5bfad68e5a1e9c80081d131c129a1861a5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11020\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n" }, { "commit": "335dd456f93d9817210a537bb847ad2bc4f66803", "tree": "713a1850957b919c876c924e43ef0ddc4d8a8144", "parents": [ "94bda7cce36ab07c0f43da66507572eb00802829" ], "author": { "name": "Ricardo Ribalda", "email": "ribalda@chromium.org", "time": "Thu Jan 28 18:53:31 2021 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 28 18:52:04 2021 +0000" }, "message": "Fix build for riscv64 arch\n\nFixes:\nIn file included from ../src/base/environment.cc:5:\nIn file included from ../src/base/environment.h:13:\n../src/util/build_config.h:171:2: error: Please add support for your architecture in build_config.h\n #error Please add support for your architecture in build_config.h\n ^\n1 error generated.\n\nChange-Id: I140d6ef5daeeceaa46ce2c1888e8a549aa40f8d8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11100\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "94bda7cce36ab07c0f43da66507572eb00802829", "tree": "e125750f21fa07f9b2068423c6e0c76a49975946", "parents": [ "5f30bbf96a759995eeb763e88b08bb529563af42" ], "author": { "name": "Anthony DiGirolamo", "email": "tonymd@google.com", "time": "Mon Jan 25 20:07:38 2021 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 26 17:04:22 2021 +0000" }, "message": "Reword command format error messages\n\nAs a new user to gn I found these messages very confusing. The joke was\nlost on me. At worst I feel it could potentially turn away new users.\n\nPlease take a look at this suggestion. Open to any changes on wording!\n\nChange-Id: I33e2851dbd90bd829326f225bdf82d8e82c252c2\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11040\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "5f30bbf96a759995eeb763e88b08bb529563af42", "tree": "7879aeba4249a5b9a06223c9b27635d7dc1d4684", "parents": [ "55ad154c961d8326315b1c8147f4e504cd95e9e6" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Mon Jan 25 16:07:26 2021 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 26 16:31:45 2021 +0000" }, "message": "Add more README documentation.\n\nAdds benefits and disadvantages and talk about versioning.\n\nChange-Id: I1cbf3ab7112f1183f7670a451e63a77e15d860bf\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11060\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "55ad154c961d8326315b1c8147f4e504cd95e9e6", "tree": "706fdb438bffd9acfa31219993a3d3715fe49e24", "parents": [ "30032b24a2224a7f6349f8ccaea23e1a2395af01" ], "author": { "name": "Dirk Pranke", "email": "dpranke@google.com", "time": "Mon Jan 25 13:24:43 2021 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 25 21:39:52 2021 +0000" }, "message": "Fix bug in analyze related to sub-configs.\n\nAnalyze had a bug where if you modified a build file containing\na config that was only used as a sub-config, analyze wouldn\u0027t\nthing changes to the file would matter.\n\nThis apparently is due to sub-configs not being treated as fully\ndefined items in the builder (which is sensible), which led to\nthe analyze code not seeing them directly.\n\nA fix for this is to walk any configs that *are* defined as part\nof analyze and explicitly check them for subconfigs that might\nbe relevant.\n\nBug: 131\nChange-Id: I0323c2340ccda58b341699ed221d2fd54d9d261c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/11000\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "30032b24a2224a7f6349f8ccaea23e1a2395af01", "tree": "5a4619d43a9eb2751028b764dfc8a9b4a8a96003", "parents": [ "d62642c920e6a0d1756316d225a90fd6faa9e21e" ], "author": { "name": "SSE4", "email": "tomskside@gmail.com", "time": "Thu Jan 07 11:42:26 2021 +0300" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 25 17:38:32 2021 +0000" }, "message": "Add Elbrus 2000 (e2k) support\n\nSigned-off-by: SSE4 \u003ctomskside@gmail.com\u003e\nChange-Id: I4860d1620b7fd0f25fc9c4b04f6cdc2535ed03d9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10980\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "d62642c920e6a0d1756316d225a90fd6faa9e21e", "tree": "0181cd588f3b91fb2a7362168de9ee5a8edec6f5", "parents": [ "3a9aa56168e793f2c898e706f7c3643f70dccc85" ], "author": { "name": "Dirk Pranke", "email": "dpranke@google.com", "time": "Thu Jan 14 14:02:43 2021 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 14 22:22:48 2021 +0000" }, "message": "Roll recipe_engine to latest version.\n\nThe recipe engine version the GN builders are using dates from\n2019 and no longer works. This rolls the config to the latest\nversion.\n\nChange-Id: Ia62b5c9c22fa7837545903e3cc6bf232c815800b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10960\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\n" }, { "commit": "3a9aa56168e793f2c898e706f7c3643f70dccc85", "tree": "7f2837db087359f61f039d877451cdcdeda18042", "parents": [ "1b4a9dfca280dbac068ba7ccf99cac8e51f60137" ], "author": { "name": "BogDan Vatra", "email": "bogdan@kde.org", "time": "Sun Jan 10 16:36:56 2021 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 13 16:42:22 2021 +0000" }, "message": "Write toochains info to json project info\n\nToolchains info is needed by IDEs to offer better code completion.\n\nChange-Id: Ifd17fedbebefd5141a2bb41555503af970f781de\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10940\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "1b4a9dfca280dbac068ba7ccf99cac8e51f60137", "tree": "d6eae39c968ad9c6f82c3bd7949b350ab7fa8313", "parents": [ "595e3be7c8381d4eeefce62a63ec12bae9ce5140" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Fri Jan 08 16:08:56 2021 -1000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 12 18:16:31 2021 +0000" }, "message": "Rewriting python search logic\n\nThe various rewrites to properly search for Python on Windows whether\nspecified on the command-line, dotfile, or implicitly were done a bit\nhurriedly and accumulated some inconsistencies and unhandled cases. This\ncleans up the code to make it more obviously correct.\n\nThe initial goal was to have set_python_path call ProcessFileExtensions\nbut in the end that seemed to cause more problems that it solves.\n\nChange-Id: I46133b6f015bfa5bfa77a3aa405ff906497c4045\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10920\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\n" }, { "commit": "595e3be7c8381d4eeefce62a63ec12bae9ce5140", "tree": "2da33bb67db3658eb3243a9a68a013dbb1b04730", "parents": [ "0d67e272bdb8145f87d238bc0b2cb8bf80ccec90" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Wed Jan 06 20:46:58 2021 -1000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jan 07 20:24:50 2021 +0000" }, "message": "Find python/python3 from dotfile entries\n\nThis is the third (and final?) step in getting gn to properly find\nPython3 on Windows. The first attempt got it to translate python3.bat.\nThe second attempt added the ability to handle python3. This change adds\nsupport for the directive being in the dotfile.\n\nThis is all in aid of moving Chromium (and any other projects using\ngn) to Python 3.\n\nThis has been tested with the recently reverted dotfile change in\nChromium (crrev.com/c/2591588) and it successfully did an otherwise-\nfailing \"gn gen\" and a chrome build is succeeding. It was also tested\nwith \"gn gen out\\arg --script-executable\u003dpython3\" and this worked.\n\nChange-Id: I7449a989d488dd107929e997a5e7d21daadd9757\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10900\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "0d67e272bdb8145f87d238bc0b2cb8bf80ccec90", "tree": "650db5e78c68914320f225b9e2f02883b7307863", "parents": [ "4e260f1dc17864cdedc31bec1ff658404a9d703e" ], "author": { "name": "Hector Dearman", "email": "hector.dearman@gmail.com", "time": "Tue Dec 22 01:37:16 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 22 16:56:25 2020 +0000" }, "message": "Replace relative_target_gen_dir with target_gen_dir in docs\n\nIt seems relative_target_gen_dir was removed some time ago:\nhttps://codereview.chromium.org/23606031\n\nChange-Id: I8f58291607945a54bbe2cd21b533d0868ec6f974\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10880\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "4e260f1dc17864cdedc31bec1ff658404a9d703e", "tree": "e3587166d4ddbf25e248e9508acaee7eabc53bba", "parents": [ "2b683eff60274dbe5874e81ee98a78c47169283e" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Mon Oct 19 17:41:51 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Dec 17 19:23:57 2020 +0000" }, "message": "Add clean_stale command\n\nThis CL adds a utility command to gn for cleaning out stale data from\nbuild directories. As users change configurations, arguments or gn\nfiles, the ninja build graph gets updated, but files and ninja database\nentries remain. This command is effectively a wrapper around a pair of\nninja tools: cleandead and recompact. The former removes no longer\nneeded output files from the build directory and the latter prunes their\nentries from the .ninja_log and .ninja_deps files.\n\nAdditionally, --clean-stale has been added as an option to the gen\ncommand.\n\nChange-Id: Ic931c1ac9fdf954d9a40318c7747ac9992a64045\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10401\nCommit-Queue: RJ Ascani \u003crjascani@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "2b683eff60274dbe5874e81ee98a78c47169283e", "tree": "9dc64a9c415bbae6199804f7011f52e30b9100c9", "parents": [ "6966efb0f6ff0f80b1a6bc5ee6ac2f343ecf3523" ], "author": { "name": "Ian McKellar", "email": "ianloic@google.com", "time": "Mon Dec 14 12:19:16 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Dec 14 21:03:34 2020 +0000" }, "message": "Fix crash in invalid scope subscript access\n\nWhen accessing a missing scope member through the string subscript\nsyntax (scope[\"member\"]) the error check didn\u0027t actually return\nresulting in a NULL dereference. This fixes that and adds tests.\n\nIt also fixes some of the parse tree unit tests which weren\u0027t correctly\nresetting their error values.\n\nBug: 209\nChange-Id: Ida1415b63ce1bca1d479c732126d5336eec13fc9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10860\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "6966efb0f6ff0f80b1a6bc5ee6ac2f343ecf3523", "tree": "f094107d1e05a2a0648ca1db3bfd66ba0e5a97bb", "parents": [ "2d9fd62c6572e324ae893e2c5bc2f054b7f70fa4" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Mon Oct 19 16:50:11 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 11 17:17:17 2020 +0000" }, "message": "Restat build.ninja after gen\n\nAs of version 1.8, ninja caches mtimes in the .ninja_log file and will\nnot restat a file if it has an entry in the .ninja_log. This becomes\nproblematic for generator files such as build.ninja. In a scenario where\nthe .ninja_log has an entry for build.ninja (ie, after ninja has had to\ntrigger a re-gen) and a manual run of of `gn gen` has updated the\nbuild.ninja file, a subsequent invocation of ninja will trigger yet\nanother re-gen of build.ninja.\n\nThis can be reproduced like this:\n\n # Initial build\n gn gen out \u0026\u0026 ninja -C out\n # Trigger ninja re-gen so there\u0027s a build.ninja log entry\n touch BUILD.gn \u0026\u0026 ninja -C out\n # Manual re-gen\n gn gen out\n # The following command will re-gen again before building\n ninja -C out\n\nTo work around this, the recommended approach from ninja is to use the\nninja restat tool to get ninja to update the mtime in the .ninja_log.\nThis CL does that by attempting to invoke `ninja -t restat build.ninja`\nimmediately after the build.ninja is generated by `gn gen`. Because this\ntool was only introduced in 1.10, the usage is gated on having a ninja\nbinary of at least that version. The ninja binary can be provided via\nthe --ninja-executable switch.\n\nBug: 136\nChange-Id: If40391aa13e6ef71c4e8ab26aff57d66a8137b8e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10400\nCommit-Queue: RJ Ascani \u003crjascani@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "2d9fd62c6572e324ae893e2c5bc2f054b7f70fa4", "tree": "23150686986888a0a818984e0fc889569a113bd9", "parents": [ "e55664a01f6ee92762210d0c01b13552f8117e11" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Thu Dec 10 21:28:19 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 11 06:05:37 2020 +0000" }, "message": "Clarify usage of target_name list in --export-compile-commands\n\nClarify that the list of target_name applies to the \u0027name\u0027 of targets in\nall build files that are processed by GN.\n\nChange-Id: I9a704f95051fdfc791ccbb958918f037aa306932\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10841\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "e55664a01f6ee92762210d0c01b13552f8117e11", "tree": "e234a75e040cb1fd33ab5904b13c69152445078a", "parents": [ "604d6e216dc4103f163a5503a39ff0c9add838fa" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Sat Nov 28 00:30:59 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Nov 28 00:35:37 2020 +0000" }, "message": "[infra] Simplify infra/recipes/gn.py\n\nIt turns out that it is not necessary to copy the rpmalloc sources after\nall, and that multi-arch builds work properly now, so simplify the\nrecipe script accordingly.\n\nChange-Id: I4a6afbd78ed9e10360759c688b7e0cbc0b7862bc\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10780\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "604d6e216dc4103f163a5503a39ff0c9add838fa", "tree": "30399c92573562854e0bdeef4638f813a9f6cbdc", "parents": [ "f2ddfefdb51d1c933b6f8e2e1a88f603d0bfdc12" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Thu Oct 15 23:40:55 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 27 22:54:17 2020 +0000" }, "message": "gn recipe: Link GN with rpmalloc to speed it up.\n\nNOTE: This is a reland of [1] with an updated rpmalloc\nrevision that includes fixes for the -Wconversion errors\nthat required reverting the original CL.\n\nThis CL changes the GN recipe to link the executable with the\nrpmalloc allocator from https://github.com/mjansson/rpmalloc\n\nThis speeds up the \u0027gn gen\u0027 operation of both Chromium and Fuchsia\noperations by 28% and 12% respectively [1], and has slightly better\nperformance than using tcmalloc from gperftools in the Fuchsia case.\n\nNote that:\n\n- The sources are grabbed directly from github.com, but it might be\n desirable to use a Chromium or Fuchsia supported mirror instead.\n\n- Only Linux has been tested so far, so only this platform enables\n this build mode.\n\n[1] Median measurements from 10 runs of \u0027gn gen\u0027 using the default\n Linux allocator (glibc), gperftools\u0027 tcmalloc, and rpmalloc:\n\n Fuchsia:\n glibc (default): 9917 ms\n gperftools: 7858 ms (26% faster)\n rpmalloc: 7752 ms (28% faster)\n\n Chromium:\n glibc (default): 4742 ms\n gperftools: 4186 ms (13% faster)\n rpmalloc: 4235 ms (12% faster)\n\n[1] https://gn-review.googlesource.com/c/gn/+/9920\n\nChange-Id: I0860c34437faee7c1f97e01f831cbf25f49c819e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10420\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "f2ddfefdb51d1c933b6f8e2e1a88f603d0bfdc12", "tree": "afee7ce0036f383dd3f4994c4d5c69d951e053a1", "parents": [ "646a62e029de4827e384c8517dc62fd3c7f85207" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Fri Nov 20 18:17:08 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 23 20:25:45 2020 +0000" }, "message": "Build GN for mac-arm64\n\nThis enables cross-compiling GN for mac-arm64 and uploading the\npackage to CIPD. Unfortunately, Fuchsia\u0027s Clang toolchain that GN\nuses doesn\u0027t yet contain universal libc++ that would support both\nx86_64 and arm64 macOS, so we need to temporarily revert back to\nusing the system libc++ until the universal one is availabile in\nthe toolchain.\n\nChange-Id: I958fd2ea3b3ae1304b706bd977a7e3875dfaab6a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10740\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "646a62e029de4827e384c8517dc62fd3c7f85207", "tree": "0d0378b483a8586f688a5c35ca72fe414d4e2368", "parents": [ "4a164c8f55619e2bf79f9f62c86b8e4448c931d4" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Nov 20 12:45:00 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 20:55:36 2020 +0000" }, "message": "[rust] Fix command arguments for non-rust native dependencies.\n\nThe ninja Rust binary target writer did the following to generate\nthe command arguments set to \u0027rustc\u0027 for non-rust native library\ndependencies (e.g. any native object file or shared library):\n\n 1- Collect the ordered set of each dependency\u0027s directory,\n then write it as a series of `-Lnative\u003d\u003cdir\u003e` arguments.\n\n 2- For any dependency whose name begins with \u0027lib\u0027, write it\n as `-l\u003cname\u003e`, where \u003cname\u003e is the dependency\u0027s file name\n without a \"lib\" prefix and without a file extension.\n\n 2- For non-\"lib\" dependencies, just use `-Clink-arg\u003d\u003cpath\u003e`\n instead.\n\nHowever, while working on the Fuchsia build system, I found that rules 1\nand 2 are both problematic:\n\n - Rule 1 means there is a possibility of linking the wrong library\n in the final binary. E.g. consider a dependency list like:\n\n dir1/libfoo.so\n dir2/libbar.so\n\n This gets translated into:\n\n -Lnative\u003ddir1 -Lnative\u003ddir2 -lfoo -lbar\n\n And if dir1/libbar.so happens to exist, it will be wrongly selected\n by the linker.\n\n - Rule 2 assumes the file extension is something like \".so\", \".dylib\"\n or \".a\" , i.e. something the linker will look for automatically,\n however, in the Fuchsia build, we have to link against files named\n \"libc.so.debug\" and \"libzircon.so.debug\" (where the \".debug\" prefix\n means these are the unstripped versions of the libraries). This\n ends up translated into:\n\n -Lnative\u003d\u003cdir2\u003e -Lnative\u003d\u003cdir1\u003e -lc.so -lzircon.so\n\n And the linker will look for libc.so.so and libzircon.so.so instead\n of the real files (and of course print an error message). Our\n current work-around is to create link scripts with this name that\n redirect to the real file, but this is ugly.\n\nThis CL simply fixes the issue by using `-Clink-arg\u003d\u003cpath\u003e` in all\ncases. The `-Lnative\u003d\u003cdir\u003e` arguments are still required to make\n`#[link(...)]` directives work correctly.\n\nBug: 217\nChange-Id: I5f7210300eea0effe3ed99b4f6aff5f07fb05518\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10721\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "4a164c8f55619e2bf79f9f62c86b8e4448c931d4", "tree": "33667120ee5c5dd5657d718594269c9ca9547df5", "parents": [ "f9bd630375efb21f00e28f6671cc9ab257b0c85d" ], "author": { "name": "Scott Graham", "email": "scottmg@chromium.org", "time": "Wed Nov 18 13:43:59 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 20:38:13 2020 +0000" }, "message": "Support `format --read-tree\u003djson`\n\nAllows roundtripping to json and back with `gn format --dump-tree\u003djson\na.gn` and then `gn format --read-tree\u003djson a.gn`. The preexisting\n.json format is not the most pleasant to work with, but this does at\nleast allow for programmatic editing of the gn files with knowledge of\nstructure, going beyond naive string replacement.\n\nFor example, a python script to change `deps` inside `source_sets` from\n`\u003d` to `+\u003d` to support a BUILDCONFIG.gn change:\nhttps://gist.github.com/sgraham/bd9ffee312f307d5f417019a9c0f0777\n\nThe .json format was extended slightly, mostly to include location\ninformation which is necessary to faithfully roundtrip including\nwhitespace. If the input .gn is formatted by `gn format`, then it can\nroundtrip to json without change. This was confirmed by running\n--dump-tree\u003djson \u003d\u003e --read-tree\u003djson on all .gn and .gni files in both\nthe Fuchsia and Chromium trees\n(https://gist.github.com/sgraham/bc561f19cd354746dd2469103e1f97d4), as\nwell as by adding a roundtrip step to the formatter tests in-repo.\n\nChange-Id: Ie10bbbcb32b8184400ca9bb1f6ab63e5ca9c89e7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10700\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "f9bd630375efb21f00e28f6671cc9ab257b0c85d", "tree": "63590ca3f1a1eeda26fc5d04d28dcf2550d33fc5", "parents": [ "bdfd6086fe3ea30c6149c7097548a281969db0b9" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Nov 20 12:29:03 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 18:18:53 2020 +0000" }, "message": "Display toolchain name in dependency cycle error message.\n\nWhen a dependency cycle is detected, GN would print the cycle without\ntoolchain labels for each target, which can make the output confusing,\nmasking the real error. For example, consider something like:\n\n //foo/bar --\u003e //foo/bar(//toolchain:zoo) --\u003e //foo/bar\n\nGN used to print:\n\n ERROR: Dependency cycle:\n //foo/bar -\u003e\n //foo/bar -\u003e\n //foo/bar\n\nWhich completely masked the issue. This patch forces the error message\nto include the label with the toolchain.\n\nChange-Id: If22fdfa6ecc0ac0a83115ad328fba61fa80e2abc\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10720\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "bdfd6086fe3ea30c6149c7097548a281969db0b9", "tree": "6341506db2f0ba4c505af0a042264c548437b25a", "parents": [ "ad9eab2d3be016682b43ce9ee2bb1d661d88cd43" ], "author": { "name": "Alfred Zien", "email": "zienag@yandex-team.ru", "time": "Wed Oct 21 17:56:17 2020 +0300" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 16 18:12:00 2020 +0000" }, "message": "Put gn generator rule to console pool\n\nThis allows gn to emit colorful diagnostics while regenerating\nfrom ninja\n\nChange-Id: I1160234db161899c9c762ddca25b1c63f9baa95f\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10421\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "ad9eab2d3be016682b43ce9ee2bb1d661d88cd43", "tree": "300ef6ad1771ad71368533b841a70d51f312cdd4", "parents": [ "0ae75f90df148d19083055b29c4c940b136904b4" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Sun Nov 15 22:20:28 2020 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 16 17:51:20 2020 +0000" }, "message": "docs: Fix some stray quote chars in help strings.\n\nI downloaded the raw diff from\nhttps://codereview.chromium.org/2481423002 and looked for `^-.*[^n]\"$`.\nThis found a few places where stray quotes where at line ends and\nsometimes at line starts -- in particular, in the \"String literals\"\nBNF, where they confused me.\n\nAlso, re-run `out/gn --markdown help all \u003e docs/reference.md`, which\npicks up a few other doc changes too.\n\nNo behavior change.\n\nChange-Id: Ic1f83a74396c188ba8ccbba0ef64efee9eab53d1\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10680\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "0ae75f90df148d19083055b29c4c940b136904b4", "tree": "ceb2e4bdb05a3e946a604a5282e163dd832d6d0b", "parents": [ "ff1b8b8aa267ad55a90086707dd58cbb6683a7ac" ], "author": { "name": "Slav Ishutin", "email": "ishutinvv@yandex-team.ru", "time": "Wed Aug 19 23:43:19 2020 +0300" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 09 18:53:58 2020 +0000" }, "message": "[iOS/macOS] consider bundle_data as data-like dependency\n\nBundle data target\u0027s output file doesn\u0027t show up as an input\ndependency for actions and groups anymore. It\u0027s considered as just\norder-only dependency. This removes redundant executable linking\nstep when changes occur in a bundle data.\n\nChange-Id: I79cc4c00af5a4102800d58457b71c81ca6591b68\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9760\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "ff1b8b8aa267ad55a90086707dd58cbb6683a7ac", "tree": "699d900f90c0778f25c841570da4cab4321d7eec", "parents": [ "fe9e5db149b0cc78e03511d52c452039dbf5ac1b" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Mon Nov 09 11:49:33 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 09 17:26:28 2020 +0000" }, "message": "Fix typo \"currend\" to \"current\"\n\nChange-Id: Ie4fef7f63bcdf9e81b34ee5a869c25fbecd24e67\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10660\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "fe9e5db149b0cc78e03511d52c452039dbf5ac1b", "tree": "7f3ffdc6e393914ed5f0d68b55751118a3af9600", "parents": [ "af38b66973780c99c6a95cdfcc8f3007fd35d8a5" ], "author": { "name": "Vasili Skurydzin", "email": "vasili.skurydzin@ibm.com", "time": "Fri Nov 06 11:03:29 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 06 19:31:58 2020 +0000" }, "message": "Arch detection: select ppc64 arch on os400 operating system.\n\nChange-Id: Ib2ca3cb38f1a6ba3378eb0dab24baf2b8c3f79b6\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10640\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "af38b66973780c99c6a95cdfcc8f3007fd35d8a5", "tree": "69167da7efbda3a9937c3543dc980bbbe87b9d59", "parents": [ "53d92014bf94c3893886470a1c7c1289f8818db0" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Mon Oct 26 16:02:14 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 06 18:59:48 2020 +0000" }, "message": "Always link dependencies into Rust static libraries\n\nRust handling of static libraries differs from C/C++ where we always\nneed to link all dependencies, but they are not considered final.\n\nChange-Id: I843b0d0b9db435560b5b6da75f0696852a11ace8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10500\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "53d92014bf94c3893886470a1c7c1289f8818db0", "tree": "a9d663427c767cee75a107ae0953a1dcb50a443e", "parents": [ "843b50030ce7ee1f86b8f1bf284ce8ca92985c3b" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Wed Nov 04 16:43:11 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 05 20:15:38 2020 +0000" }, "message": "Apply path search logic more generally\n\nThe --script-executable option becomes much more portable if \"python\"\n(or \"python3\") can be specified across platforms. On Windows this\nrequires adding a .bat or .exe extension and doing a search of the path.\nThe logic to do this already existed and just needed to be generalized.\n\nRunning clang-format on setup.cc adjusted a few unrelated lines.\n\nChange-Id: If0b44449fa4f4672b5408c3c26dc21b2388dd184\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10600\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "843b50030ce7ee1f86b8f1bf284ce8ca92985c3b", "tree": "4bd852dc8b1aeee6176fd7088b1679371d4dd786", "parents": [ "e431b2f39f4c8ce3b0b5cfcc7b65242209165c7a" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Wed Nov 04 14:49:23 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 05 00:26:28 2020 +0000" }, "message": "Revert phony targets to stamp targets\n\nThis CL reverts 4 previous commits that removed stamp files in favor of\nphony alias targets. This is due to an issue found in the Chromium build\nwith incremental builds.\n\nReverts:\n f5f465b5 Fix runtime_deps for elided targets\n c808630c Move runtime_deps file for phony targets to /obj\n a9eaeb80 Switch remaining stamp targets to phony targets\n 99f72f88 Switch source_set stamp targets to phony targets\n\nBug: 215\nChange-Id: Id83ea946654e597f93012cf1f93fbe3e6704c1d3\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10620\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "e431b2f39f4c8ce3b0b5cfcc7b65242209165c7a", "tree": "5069e68ad0d22d560df471c3e3f7d6133ce04abc", "parents": [ "0310dbe8411c76e7f17643fbe28436cf1391c2ec" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Wed Nov 04 10:49:47 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Nov 04 18:09:28 2020 +0000" }, "message": "Remove one of the overridden meaning of --root-target flag\n\nCL https://gn-review.googlesource.com/c/gn/+/10140 overrode the\nmeaning of the --root-target used by Xcode and QtCreator project\ngenerators to designate the default target to build.\n\nRename the flag used by project generator to --ide-root-target\nto avoid having two separate flags with the same meaning.\n\nBug: chromium:1133101\nChange-Id: I8f95904af0bf4443703a6e634ef1096cd9916f48\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10580\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "0310dbe8411c76e7f17643fbe28436cf1391c2ec", "tree": "5738ad50a338affdfc546a622851a63fe32c3342", "parents": [ "7e2a0f0a8a323fa6b808d4ff486ac1d071f21bc7" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Fri Oct 30 21:47:16 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Oct 31 17:58:57 2020 +0000" }, "message": "Improved Python 3 support\n\nIn order to better support building Chromium with Python 3 on Windows it\nis helpful if --script-executable\u003dc:\\src\\depot_tools\\python3.bat will\ntranslate python3.bat to the appropriate python.exe path. This is mostly\njust a matter of calling PythonBatToExe from FillPythonPath, but it was\nalso necessary to update PythonBatToExe to make it\u0027s Python print\nstatement be Python 3 compatible.\n\nThis change also means that if python.bat is found in the path during\nnormal initialization and points to Python 3 then this will succeed\ninstead of printing a cryptic error message.\n\nChange-Id: I7339034c6c8e817a386ca19f57f64401a3d49b2c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10560\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "7e2a0f0a8a323fa6b808d4ff486ac1d071f21bc7", "tree": "1bb38b3b47c3198c6fdc08e14cdb61784aae84a0", "parents": [ "f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc" ], "author": { "name": "Marc-Antoine Ruel", "email": "maruel@google.com", "time": "Wed Oct 28 15:39:15 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 28 21:22:41 2020 +0000" }, "message": "format: Keep on going in case of error\n\nThe previous behavior would stop on the first file in dry-run, or on first\nfailure otherwise.\n\nPrint out the incorrectly formatted files, makes the try jobs more useful.\n\nBug: 211\nChange-Id: Ic64f754ca76a9f0b9bf87a9be02600cca82595a2\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10520\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc", "tree": "625ea4e54fac9b6c552c505409450cfd0485e0cd", "parents": [ "3d165b905e7ca38cc8c69bcf292c689c6a06d889" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Mon Oct 19 14:54:09 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 21 19:14:51 2020 +0000" }, "message": "Fix runtime_deps for elided targets\n\nTarget types that are represented by phony aliases can be omitted if\nthey lack any real inputs (dependencies that would show up on the ninja\nbuild line). However, these targets could still have runtime_deps, so\nthis CL ensuresthat a .runtime_deps file is generated even if there is\nno dependency_output_file or dependency_output_phony.\n\nChange-Id: Iddaac69050a531bd8876d063812fba32927acb87\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10380\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "3d165b905e7ca38cc8c69bcf292c689c6a06d889", "tree": "a20908c907e442a6146c2ca6ed40bd528c4e83ab", "parents": [ "ad0a7ada45cd7a3781a00175286a05519b4bdefc" ], "author": { "name": "Gary Boone", "email": "gboone@google.com", "time": "Tue Oct 20 16:52:05 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 21 00:40:30 2020 +0000" }, "message": "Correct the `gn format --dump-tree\u003djson ...` command to write to stdout instead of stderr.\n\nChange-Id: I97d13f364ff00e2e853a700df81056498e4f2248\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10440\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "ad0a7ada45cd7a3781a00175286a05519b4bdefc", "tree": "16c952d0e635d424bc2b48fc4d190aaa5955fdbf", "parents": [ "e1ac69b17da0c6d4f5e34e686690ff70c6a43e6f" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Oct 15 15:03:44 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 20 09:23:59 2020 +0000" }, "message": "Remove support for set_sources_assignment_filter function\n\nMark the function deprecated and print an error if it is called with\na non-empty list as a parameter. This is a preliminary until all the\nno-op uses of set_sources_assignment_filter([]) have been removed.\n\nBug: 125\nChange-Id: Ia63e1135202a2921de791135a2b4b2eb6ac3861b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10242\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "e1ac69b17da0c6d4f5e34e686690ff70c6a43e6f", "tree": "39380a1634601f17e548fdb3deb0b5876f63a9a5", "parents": [ "7b2a04d5b451e2ccf5494c2edd113d7b29b8da09" ], "author": { "name": "Honglin Yu", "email": "honglinyu@chromium.org", "time": "Sun Oct 11 00:15:15 2020 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 20 04:53:59 2020 +0000" }, "message": "Add a command line to define/overwrite \"root\" in \".gn\"\n\nThe new command line option \"--root-target\" will tell GN where to find\nthe initial BUILD.gn. This is equivalent to define the \"root\" variable\nin \".gn\" as before. And after this CL if \"root\" is also defined in\n\".gn\", this option will overwite the value defined in \".gn\".\n\nThis is to achieve, to some extend, the \"partial configuration\"\nability. For example, if we only want to configure and build the\ntargets in a subfolder of Chromium like \"//third_party/icu\". We only\nneed to run\n\n```\ngn gen out/icu --root-target\u003d\"//third_party/icu\"\n```\n\nThe motivation of this feature is to make sharing packages between\nChrome and CrOS much easier.\n\nBUG\u003dchromium:1133101\nTEST\u003dIt can indeed only configure subfolder of chromium like\nTEST\u003d\"third_party/icu\" and \"third_party/grpc\".\nTEST\u003dIt can overwrite the \"root\" variable in \".gn\" correctly.\n\nChange-Id: If0742b409a529f34f435c6498de57667fabe7fc1\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10140\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "7b2a04d5b451e2ccf5494c2edd113d7b29b8da09", "tree": "2986a1c5badd8c4f52736b39ed6cdac55ca188b5", "parents": [ "132588e1f9c2bf07b0cc0516e190b445de1153a7" ], "author": { "name": "Jamie Madill", "email": "jmadill@chromium.org", "time": "Sat Oct 17 11:39:54 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 19 20:03:49 2020 +0000" }, "message": "VS: Use most recently installed Windows 10 SDK.\n\nUsing a hard-coded SDK version is a big barrier for new developers.\nUsing \"10\" as the SDK version will automatically pick the most\nrecently installed SDK.\n\nBug: gn:128\nChange-Id: I01e1f810f9300302b8fbe369da01e3221d9e8f81\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10340\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "132588e1f9c2bf07b0cc0516e190b445de1153a7", "tree": "fd69e5e5f0dfba483daf3387a64042ba9b9b98f2", "parents": [ "3281c6697cbb7d5488f5e650dfce60b1999bcfab" ], "author": { "name": "David Turner", "email": "digit@google.com", "time": "Mon Oct 19 18:46:52 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 19 18:47:11 2020 +0000" }, "message": "Revert \"gn recipe: Link GN with rpmalloc to speed it up.\"\n\nThis reverts commit 4323e7015d8a7f74208962dd11f2d1065ae8aa15.\n\nReason for revert: https://bugs.chromium.org/p/gn/issues/detail?id\u003d208\n\nOriginal change\u0027s description:\n\u003e gn recipe: Link GN with rpmalloc to speed it up.\n\u003e\n\u003e This CL changes the GN recipe to link the executable with the\n\u003e rpmalloc allocator from https://github.com/mjansson/rpmalloc\n\u003e\n\u003e This speeds up the \u0027gn gen\u0027 operation of both Chromium and Fuchsia\n\u003e operations by 28% and 12% respectively [1], and has slightly better\n\u003e performance than using tcmalloc from gperftools in the Fuchsia case.\n\u003e\n\u003e Note that:\n\u003e\n\u003e - The sources are grabbed directly from github.com, but it might be\n\u003e desirable to use a Chromium or Fuchsia supported mirror instead.\n\u003e\n\u003e - Only Linux has been tested so far, so only this platform enables\n\u003e this build mode.\n\u003e\n\u003e [1] Median measurements from 10 runs of \u0027gn gen\u0027 using the default\n\u003e Linux allocator (glibc), gperftools\u0027 tcmalloc, and rpmalloc:\n\u003e\n\u003e Fuchsia:\n\u003e glibc (default): 9917 ms\n\u003e gperftools: 7858 ms (26% faster)\n\u003e rpmalloc: 7752 ms (28% faster)\n\u003e\n\u003e Chromium:\n\u003e glibc (default): 4742 ms\n\u003e gperftools: 4186 ms (13% faster)\n\u003e rpmalloc: 4235 ms (12% faster)\n\u003e\n\u003e Change-Id: Ia52134ef602f546d6e8b33bef0146c620d214b58\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/9920\n\u003e Commit-Queue: David Turner \u003cdigit@google.com\u003e\n\u003e Reviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n\u003e Reviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n\nTBR\u003dphosek@google.com,scottmg@chromium.org,pylaligand@google.com,digit@google.com\n\nChange-Id: I654d4646dae1d75d0aa2c110dbd7128dc0dd0911\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10360\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "3281c6697cbb7d5488f5e650dfce60b1999bcfab", "tree": "bfcce370707545cd119089fa9a4d94d118031694", "parents": [ "4323e7015d8a7f74208962dd11f2d1065ae8aa15" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Oct 15 15:00:37 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 19 10:21:49 2020 +0000" }, "message": "Add \"framework_dirs\" and \"frameworks\" to syntax highlighting rules\n\nBug: none\nChange-Id: I1dd73b0bec524592b5cc68b0446815ad4347cd65\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10240\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "4323e7015d8a7f74208962dd11f2d1065ae8aa15", "tree": "289db836ece464508b5740b8416227ffd8824895", "parents": [ "c808630cea75d153382df3b29e0ddbc2798e1b4a" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Thu Oct 15 23:40:55 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 19 09:22:49 2020 +0000" }, "message": "gn recipe: Link GN with rpmalloc to speed it up.\n\nThis CL changes the GN recipe to link the executable with the\nrpmalloc allocator from https://github.com/mjansson/rpmalloc\n\nThis speeds up the \u0027gn gen\u0027 operation of both Chromium and Fuchsia\noperations by 28% and 12% respectively [1], and has slightly better\nperformance than using tcmalloc from gperftools in the Fuchsia case.\n\nNote that:\n\n- The sources are grabbed directly from github.com, but it might be\n desirable to use a Chromium or Fuchsia supported mirror instead.\n\n- Only Linux has been tested so far, so only this platform enables\n this build mode.\n\n[1] Median measurements from 10 runs of \u0027gn gen\u0027 using the default\n Linux allocator (glibc), gperftools\u0027 tcmalloc, and rpmalloc:\n\n Fuchsia:\n glibc (default): 9917 ms\n gperftools: 7858 ms (26% faster)\n rpmalloc: 7752 ms (28% faster)\n\n Chromium:\n glibc (default): 4742 ms\n gperftools: 4186 ms (13% faster)\n rpmalloc: 4235 ms (12% faster)\n\nChange-Id: Ia52134ef602f546d6e8b33bef0146c620d214b58\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9920\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "c808630cea75d153382df3b29e0ddbc2798e1b4a", "tree": "4403e6dac9feabba22f39dd4fc08b742d2c876f9", "parents": [ "8855c522a80fcd0b6c200e9ef280abf09ecfdc39" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Wed Oct 14 15:13:11 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 16 19:30:04 2020 +0000" }, "message": "Move runtime_deps file for phony targets to /obj\n\nFor targets that use phony aliases, we generate a dependency_output in\nthe PHONY BuildDir. Since this doesn\u0027t actually create any files, the\n\"phony\" directory is never actually generated. However, when the caller\nrequests runtime_deps files to be written, the phony target path was\nbeing used to generate the runtime_deps file name. This resulted in\nout/phony/foo/bar.runtime_deps being generated.\n\nThis CL fixes the runtime_deps file path for phony targets to be in the\nOBJ BuildDir.\n\nChange-Id: I3ac9fcc2597241b1bb4ce85cf8c57ad2a1b1e24c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10181\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "8855c522a80fcd0b6c200e9ef280abf09ecfdc39", "tree": "4562e1f7165998b24c2a2ea5bc621fd603efb47a", "parents": [ "76f9b6ad1cb75aa06269a7608c13fe077335e936" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed Oct 14 15:44:07 2020 -0700" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Thu Oct 15 21:52:20 2020 +0000" }, "message": "Update Clang and Xcode SDK to 12B5025f\n\nNow that we use 10.15 on our Mac bots, we can reroll Clang and Xcode.\n\nChange-Id: I074bf9cc045654b38b03fe15bf6d011c0093e068\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10262\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "76f9b6ad1cb75aa06269a7608c13fe077335e936", "tree": "5162e933574d7e5a6fa9d559554f0e38ce362aca", "parents": [ "a3d69e87fca721a2dbdb48231bedf1523749a818" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed Oct 14 15:18:30 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 15 18:47:23 2020 +0000" }, "message": "Use fetch instead of cherry-pick for Gerrit changes\n\nThis enables support for dependent changes.\n\nFixed: 182\nChange-Id: I962e19b5ee6dffec0c2044abb671edf0438b1418\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10180\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "a3d69e87fca721a2dbdb48231bedf1523749a818", "tree": "59a11f3fb09eb49e302005c20e23d79351c4f474", "parents": [ "36ff17cb13c216b98664a5f0087b88bd07b14685" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed Oct 14 15:31:07 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 15 18:41:33 2020 +0000" }, "message": "Don\u0027t return if package is up-to-date\n\nNow that we build multiple configurations, we need to continue.\n\nChange-Id: Ieb972070bc2452e0d1eeb275a19caaa543e3e6a7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10182\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "36ff17cb13c216b98664a5f0087b88bd07b14685", "tree": "ec5da41fc96d31506aa6728cd593a4c10b49c943", "parents": [ "7bcc0eb382a687dcf24a2e5c178229dccc0b2f95" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed Oct 14 21:29:34 2020 -0700" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Thu Oct 15 17:31:44 2020 +0000" }, "message": "Switch back to the older Clang version\n\nThe new version requires new Xcode which in turns requires macOS 10.15.\n\nChange-Id: Ie9b198642832ff1c7eb6c62fdaff38bcaf6ea227\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10220\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\n" }, { "commit": "7bcc0eb382a687dcf24a2e5c178229dccc0b2f95", "tree": "593cf1d9ef169faa0bcb77d31c5fbc0453dc7a8e", "parents": [ "e5f1f5877073a557c1ceea43a73d1cc343e2d3a7" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Thu Oct 15 04:27:56 2020 +0000" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Thu Oct 15 04:28:11 2020 +0000" }, "message": "Revert \"Update Xcode SDK to 12B5025f\"\n\nThis reverts commit e5f1f5877073a557c1ceea43a73d1cc343e2d3a7.\n\nReason for revert: This requires macOS 10.15 but we only have 10.13.\n\nOriginal change\u0027s description:\n\u003e Update Xcode SDK to 12B5025f\n\u003e\n\u003e Change-Id: I8203eb2093d76e4e8a23cf5090dcd258a4526e4e\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/10183\n\u003e Reviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n\nTBR\u003dphosek@google.com,scottmg@chromium.org,dpranke@chromium.org,dpranke@google.com\n\nChange-Id: I5f185b44b475c622fdb10f48dcaa3f18949f2f38\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10200\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "e5f1f5877073a557c1ceea43a73d1cc343e2d3a7", "tree": "69918b1b7fbc719ca370e38391d1e2c8d11ad9e0", "parents": [ "6453c5def990b671c4cb3760c7d7d7a55187e168" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed Oct 14 15:44:07 2020 -0700" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Wed Oct 14 23:05:31 2020 +0000" }, "message": "Update Xcode SDK to 12B5025f\n\nChange-Id: I8203eb2093d76e4e8a23cf5090dcd258a4526e4e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10183\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "6453c5def990b671c4cb3760c7d7d7a55187e168", "tree": "593cf1d9ef169faa0bcb77d31c5fbc0453dc7a8e", "parents": [ "42d6de6e391c2a02ce328691240ec347098d24b4" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Sat Jan 12 21:32:25 2019 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 14 21:02:04 2020 +0000" }, "message": "Support cross-compiling GN for other targets\n\nThis change extends the recipe used by builders with support for\ncross-compiling GN to different platforms beyond the host one, and\nsets up cross compilation for Linux as an example.\n\nChange-Id: I0d9aa1a104b14842c875d1a8d9082b6949e47e14\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/3760\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "42d6de6e391c2a02ce328691240ec347098d24b4", "tree": "eaa5ebe686b7a68f857a3df5de534213d273b17c", "parents": [ "a9eaeb80cb02c33d99dea76efcaa69d2e83bafc2" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Tue Oct 13 23:23:57 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 14 17:10:13 2020 +0000" }, "message": "Don\u0027t classify Rust static libraries as final\n\nc5a0ec650 made an incorrect assumption that Rust static libraries,\nunlike their C/C++ counterparts are always considered final which\nis not actually true and has manifested as link errors in practice.\nThis change is effectively a revert of c5a0ec650.\n\nChange-Id: I92c4568ec3e1ea994f11e2332b066e8300bb5716\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10160\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "a9eaeb80cb02c33d99dea76efcaa69d2e83bafc2", "tree": "f8739ec49a01c221b47d816358dada4800537c98", "parents": [ "ff45cf2a6f41c0a2e81dc3654dd1226614567df1" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Wed Sep 16 10:34:35 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 07 17:20:54 2020 +0000" }, "message": "Switch remaining stamp targets to phony targets\n\nGN uses stamp files for a variety of output types as a mechanism for\ncompleting a group of dependencies. Ninja\u0027s phony targets can be used in\na similar manner.\n\nThe GN \u0027group\u0027, \u0027generated_file\u0027, \u0027bundle_data\u0027, \u0027copy\u0027, \u0027action\u0027,\n\u0027action_for_each\u0027 and \u0027create_bundle\u0027 output types each generate a stamp\nfile as an output for other targets to depend on. This CL replaces those\nstamp targets with a phony alias target.\n\nFor a few target types, GN optionally creates a \"\u003ctarget\u003e.inputdeps\"\nand/or \"\u003ctarget\u003e.input\" stamp files to represent a group of input\ndependencies or inputs, respectively. This is useful for limiting the\nsize of ninja files because the dependencies only have to be listed\nonce. As with the stamp files generated for the aforementioned output\ntypes, this CL also replaces those stamp targets with a phony alias\ntarget.\n\nFinally, there are several intermediate stamp files that are created for\ncertain outputs, such as the code signing stamp for `create_bundle`\ntargets. Where possible, these are also replaced with phony alias\ntargets.\n\nBug: 186, 188, 191, 194\nChange-Id: I5b257147affc55bb8b093a3f39c7e9a5b56b6f6c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10100\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "ff45cf2a6f41c0a2e81dc3654dd1226614567df1", "tree": "fefb5b881036142c604da98e9b1cab37da5b186b", "parents": [ "de5a8348b2eef6833146542d8b376e1e79bfeb8b" ], "author": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Sat Oct 03 21:53:19 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sun Oct 04 16:51:58 2020 +0000" }, "message": "Show config.visibility in `gn desc`\n\nCan now enter:\n`gn desc \u003cout_dir\u003e \u003clabel or pattern\u003e visibility`\nThe result is as expected.\n\nChange-Id: I6dcade587a3a15247829969e1d0f610ccfbfb844\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10120\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "de5a8348b2eef6833146542d8b376e1e79bfeb8b", "tree": "f412bc76ef78fcb341934cb6b18f39e4ee133f94", "parents": [ "4c684398996e54f0d860292dd355d00d7dc97474" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Tue Sep 29 16:19:04 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 30 18:56:53 2020 +0000" }, "message": "[rust project] removing obsolete std libraries\n\nThese have been consolidated into other libs, and/or are no longer\npart of the std lib distribution that\u0027s part of the rust compiler\ndistribution.\n\nChange-Id: Ia913e0e7b46f06a7087fc6d7986a94b9c59b5ee4\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10080\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\nReviewed-by: Paul Daniel Faria \u003cpaulfaria@google.com\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "4c684398996e54f0d860292dd355d00d7dc97474", "tree": "c434cf82898a7d63336759854969bbad2be44323", "parents": [ "99f72f881a3acdadb1572eaee8467b7f17b3338a" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Thu Sep 17 16:22:34 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 29 18:49:02 2020 +0000" }, "message": "Fix \"gn outputs\" for bundle data.\n\nPreviously some conditions on the target type were duplicated.\n\nChange-Id: I0cf34fd019ef32a68b43b60fc774f13bb46630b9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10040\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "99f72f881a3acdadb1572eaee8467b7f17b3338a", "tree": "dfeeb90a1d5b082d343511a45a26f63224a7334e", "parents": [ "5233fa13e84fa4adddaf6e00f22aaee16f94342f" ], "author": { "name": "RJ Ascani", "email": "rjascani@google.com", "time": "Mon Aug 24 18:52:23 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 28 20:06:45 2020 +0000" }, "message": "Switch source_set stamp targets to phony targets\n\nGN uses stamp files for a variety of output types as a mechanism for\ncompleting a group of dependencies. Ninja\u0027s phony targets can be used in\nthe same manner. Semantically, stamp and phony only differ in one way:\nif a phony target has no dependencies, then it is treated as always\ndirty and is run every time.\n\nThe source_set output type always generates a stamp file in the target\nninja file. This CL replaces the source_set\u0027s stamp target with a phony\ntarget. In the case where the source_set\u0027s new phony target does not\nhave any inputs, no targets will depend on it. An example of where that\nmight happen is a header only source_set. There are no object files to\ngenerate, but targets that depend on the header only source_set will\ngenerate dependencies on those headers through depfiles.\n\nBug: 187\nChange-Id: I159f2f39a988eea189e4df9f5d9207fda6db5c58\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9820\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "5233fa13e84fa4adddaf6e00f22aaee16f94342f", "tree": "5ce3e0f02b993bab3ad092cf92421a7f41774694", "parents": [ "e002e68a48d1c82648eadde2f6aafa20d08c36f2" ], "author": { "name": "Hector Dearman", "email": "hjd@google.com", "time": "Fri Sep 11 12:18:21 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 11 15:01:29 2020 +0000" }, "message": "Remove extra * in gn output docs\n\nIt was making markdown unhappy.\n\nChange-Id: Iad7102b63fb614036d6b2909f78441ddbd49570b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9980\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "e002e68a48d1c82648eadde2f6aafa20d08c36f2", "tree": "685b8c4b305c72470fb8a0f686c3008d9d01e7c9", "parents": [ "32c8eaf95838a8c72b093dfbefa0cf593b234dd5" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Sep 03 17:31:02 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 09 08:31:19 2020 +0000" }, "message": "Add support for symbolset to bundle_data targets\n\nBug: none\nChange-Id: Ida994e1bf181c19258622e9b0901d406cfba4999\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9881\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "32c8eaf95838a8c72b093dfbefa0cf593b234dd5", "tree": "4cbc99ecae7a6dbf1c25b5b2202bdb908c29719c", "parents": [ "c06693681e62d0876eeec5673ad5ce3bb53ad835" ], "author": { "name": "Maya Rashish", "email": "maya@NetBSD.org", "time": "Fri Aug 14 21:29:29 2020 +0300" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Aug 29 23:32:59 2020 +0000" }, "message": "Add netbsd as a platform\n\nChange-Id: I752029d3ce3bc12b5bce95ddd202fb40517b86c7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9700\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "c06693681e62d0876eeec5673ad5ce3bb53ad835", "tree": "9361e026b3f31823f042bc91bd52651533e48aa2", "parents": [ "58d9b89d133277ef29d0f047938fac9afa182a0c" ], "author": { "name": "Hector Dearman", "email": "hjd@google.com", "time": "Fri Aug 21 23:21:11 2020 +0100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Aug 24 19:42:17 2020 +0000" }, "message": "Allow \".c++\" as a C++ source file extension\n\nSome projects use .c++ as an extension for C++ source files, for\nexample: https://github.com/capnproto/capnproto\nAdding this suffix allows these source files to appear in source_sets\nand makes it possible to build these projects using gn without needing\nto make invasive changes to them.\n\nChange-Id: Ie036ffc81510e79643db2674ee4b39cd5cc9691f\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9800\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "58d9b89d133277ef29d0f047938fac9afa182a0c", "tree": "d002fa31e5e601a5755107ace3a50800cbf888b5", "parents": [ "484245b93ef5cfe49d7ebb5df7046d11b3d48234" ], "author": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Fri Aug 21 10:53:24 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 21 20:41:23 2020 +0000" }, "message": "[format] Sort visibility like deps\n\nBug: 189\nChange-Id: I7e35b6811444c0656de8dc452d105cc92afa2c0d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9780\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "484245b93ef5cfe49d7ebb5df7046d11b3d48234", "tree": "799f65f50f3c8d3bcc0570641e2fbdd821f5f0e4", "parents": [ "b722d8baf1a5ca7f0f5d88081e8378f119396ca8" ], "author": { "name": "Scott Graham", "email": "scottmg@chromium.org", "time": "Tue Aug 11 10:58:50 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 21 19:48:33 2020 +0000" }, "message": "clang: Fixes to module support\n\n1. -fmodules-embed-all-files is a cc1 flag, and should have been passed\n to clang++ via -Xclang.\n\n2. Don\u0027t require a .cc in the target to emit the module_deps variables\n (this is to be able to compile a target that contains only a\n .modulemap, e.g. the C++ std module).\n\n3. Add {{module_deps_no_self}}, which is the same as {{module_deps}}\n except that it excludes the flags to include the pcm for the current\n target.\n\n That is, for A depending on B, and both using modules, when building\n for A, {{module_deps}} will reference both A.pcm and B.pcm, and so\n can be used to build .cc files in A. By contrast,\n {{module_deps_no_self}} for A will only reference B.pcm, and so can\n be used to build A.pcm.\n\nBug: fuchsia:27276\nChange-Id: I239d1c5cd4d5d167251801b1347b02e8d89caeee\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9680\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "b722d8baf1a5ca7f0f5d88081e8378f119396ca8", "tree": "1878adc36116185a280125c0b248f460a22a3220", "parents": [ "6f13aaac55a977e1948910942675c69f2b4f7a94" ], "author": { "name": "Michael Spang", "email": "spang@google.com", "time": "Mon Aug 10 00:02:33 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 19 17:11:18 2020 +0000" }, "message": "Identify current toolchain on error\n\nCurrently errors from GN identify the source location that failed, but\nnot the toolchain. This can be confusing, and adding a\n\n print(current_toolchain)\n\nis often helpful when debugging these errors. This patch changes GN to\ninclude the toolchain in the error message whenever there\u0027s an error\nin a non-default toolchain.\n\nThis produces output like the following:\n\n ERROR at //subdir/BUILD.gn:3:1 (//:toolchain): Assertion failed.\n assert(only_true_in_default_toolchain)\n ^-----\n See //BUILD.gn:51:14: which caused the file to be included.\n deps \u003d [ \"subdir\" ]\n ^-------\n\nBug: 184\n\nChange-Id: I8463f04cf94242c4f7c518d4840ae8f586b4e4fa\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9640\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "6f13aaac55a977e1948910942675c69f2b4f7a94", "tree": "837f0ac3e2246dce79e6b6e9cdc6f54482ffd438", "parents": [ "5da62d5e9d0f10cb8ece7c30563a6a214c78b68d" ], "author": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Sat Aug 15 17:32:23 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Aug 17 23:31:06 2020 +0000" }, "message": "[visibility] Consider configs in visibility check\n\nBug: 22\nChange-Id: I4fa6286ade5a0d612f12f417c07e4319253061a0\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9740\nReviewed-by: Shai Barack \u003cshayba@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "5da62d5e9d0f10cb8ece7c30563a6a214c78b68d", "tree": "e12bb4f6d2a238f40c2a6dabffa528183d5c7e97", "parents": [ "0649bd9a267d7050dcdb027184230e42b7e68531" ], "author": { "name": "Rodrigo Hernandez", "email": "kwizatz@aeongames.com", "time": "Fri Aug 14 18:15:46 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Aug 17 23:00:36 2020 +0000" }, "message": "Fix native MinGW build\n\nThis change silences warnings and changes the build\nto use gcc instead of clang.\n\nIt also removes windows_types.h and changes referenced to\nthe header file to include windows.h instead.\n\nChange-Id: I9a1bdf1dc72021f3dba434174d99863a9624a473\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9720\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "0649bd9a267d7050dcdb027184230e42b7e68531", "tree": "5a8bd0199356d4cba024970521755bb8274a3e13", "parents": [ "501b49a3ab4f0d099457b6e5b62c709a1d2311be" ], "author": { "name": "Rodrigo Hernandez", "email": "kwizatz@aeongames.com", "time": "Mon Aug 10 18:19:57 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 12 19:30:44 2020 +0000" }, "message": "Add MSYS as a platform.\n\nThis adds code to build GN for\nthe MSYS2 platform, NOT mingw,\nmeaning the Cygwin like POSIX layer.\n\nChange-Id: I6e26522c465750e67ce3b26fd11c8b02726dabdb\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9660\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "501b49a3ab4f0d099457b6e5b62c709a1d2311be", "tree": "6303562ae7f1953a23165f8f7b546b48d7fdc7d1", "parents": [ "03df22eb2727dc732928fd0901c3a0cd46c689d7" ], "author": { "name": "Scott Graham", "email": "scottmg@chromium.org", "time": "Wed Aug 05 13:03:37 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Aug 10 18:49:02 2020 +0000" }, "message": "clang: Add support for C++ modules in deps\n\nThis adds support for {{module_deps}}. This expansion is to be used by\nthe \"cxx\" tool. When the deps of a target include dependencies on\nmodules (defined as a target that includes a .modulemap file, which is\nbuilt to a .pcm), module_deps will be filled out with the required flags\nto depend on those modules.\n\nThe targets that are depended upon must currently have a (handwritten)\n.modulemap file in their sources.\n\nThe dependency semantics (as described in NinjaCBinaryTargetWriterTest)\nare:\n- .modulemap are built to .pcm by cxx_module\n- .pcm aren\u0027t linked against\n- The .cc of a target that uses modules depend on the .pcm (\"implicit\"\ndependency in ninja terminology)\n- The .cc sources of targets that depend on a module have implicit\ndependencies on the pcm of the dependent modules target as well.\n- A .a or executable does not depend on the .pcm.\n\nBug: fuchsia:27276\nChange-Id: I84c26975b93db71e5309ad607fce900fe2705f90\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9602\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "03df22eb2727dc732928fd0901c3a0cd46c689d7", "tree": "05a154cc531859f3af54f39cd3858afe943d7f57", "parents": [ "b489f906885e541903ce48eed0f99b56d9ac4acd" ], "author": { "name": "Paul Daniel Faria", "email": "paulfaria@google.com", "time": "Thu Aug 06 15:43:43 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 07 23:23:21 2020 +0000" }, "message": "[rust-project] Add \"proc_macro\" as dep for proc macro targets\n\nThis CL also fixes a bug in the rust_tool selection.\n\nChange-Id: Ib7a87aaa83f72a332158c56f12f70cdfed05cf98\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9620\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "b489f906885e541903ce48eed0f99b56d9ac4acd", "tree": "3fc2596e4fff162f26d4ae41a142fc28d417367c", "parents": [ "e327ffdc503815916db2543ec000226a8df45163" ], "author": { "name": "Patrick Mooney", "email": "pmooney@pfmooney.com", "time": "Sat Apr 25 23:01:09 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 07 22:03:32 2020 +0000" }, "message": "Add support for Solaris and illumos systems\n\nChange-Id: I72406d16c0f15c909219a94dcf396e013a9501db\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9560\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "e327ffdc503815916db2543ec000226a8df45163", "tree": "7b364f3526e39474775f1773c3396be90c09d77f", "parents": [ "89e6425be159d58960cd6a16ef5f2be2c26bfb56" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Fri Aug 07 15:21:24 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 07 13:29:11 2020 +0000" }, "message": "[ios] Add example of building swift on iOS\n\nThe CL also adds necessary scaffolding to build some .swift files\nin examples/ios (to teach how the tool needs to be used).\n\nBug: 121\nChange-Id: I46b553c022484130b867547b2cdedc853689a46b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9541\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "89e6425be159d58960cd6a16ef5f2be2c26bfb56", "tree": "42276d919dfe4d204c529ade2766c004e8d4389a", "parents": [ "070420dbd622706857c89e85fc802445dfb228ca" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Fri Aug 07 13:01:06 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 07 13:09:11 2020 +0000" }, "message": "Add support for building .swift files\n\nThis CL allow listing .swift files in sources of compiler target\n(source_set, executable, static_library, shared_library). Mixing\nwith other types of source files is disallowed due to complexity\nof implementation (difficult to decide in which order the files\nneed to be built).\n\nThis adds a new \"swift\" tool that must always list a .swiftmodule\nfile as output but can generate additional outputs (.h, .o, ...).\nTo support whole module optimisation, the tool can have partial\noutputs (i.e. have 1:1 mapping between source and output) or not.\n\nThe .swiftmodule are propagated both to direct and public deps\nfor generation of module search path (expanded by {{module_dirs}})\nand to linkable target (expanded as {{modules}}) to embed the\nmodule AST in the linked binary.\n\nBased on the investigation at https://goto.google.com/swift-gn.\n\nBug: 121\nChange-Id: If92b49f15e9ebb273feff7c935ca51698c27afa3\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9180\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "070420dbd622706857c89e85fc802445dfb228ca", "tree": "008a2347e7fe04a0e687d514e29f459ea3769a65", "parents": [ "8666632140e9596b868b8e2028fef6e683041130" ], "author": { "name": "Scott Graham", "email": "scottmg@chromium.org", "time": "Wed Aug 05 13:02:21 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Aug 06 21:26:27 2020 +0000" }, "message": "clang: Add support for C++ modulemap files\n\nThis is a first step to support Clang modules in C++ compilation. This\nchange adds .modulemap as a source file extension which will be compiled\nby cxx_module to a .pcm.\n\nThe subsequent patch then uses a new \"module_deps\" entry to refer to\nthese modules.\n\nAdditional test reference here:\nhttps://fuchsia-review.googlesource.com/c/fuchsia/+/412605\n\nChange-Id: Ic42af141b11212249dc55911a42f89268537d59a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9601\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\n" }, { "commit": "8666632140e9596b868b8e2028fef6e683041130", "tree": "8a2aa592ad727b622705efc8f0e3dc65c16fb2e5", "parents": [ "bca0631828a5564a81628680cc6151bc418224f2" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Tue Aug 04 13:23:19 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 05 08:20:30 2020 +0000" }, "message": "Add structure to return classified deps\n\nChange NinjaBinaryTargetWriter::GetDeps() to return its output via\na structure (instead of using multiple output parameters) and also\nrename the method to GetClassifiedDeps().\n\nUsing a structure to return the output will make it easier to add\nother kinds of deps (notably swift requires a new type of deps for\nthe .swiftmodule files).\n\nBug: 121\nChange-Id: I4c8f479f6619e0377244955331e265b03548af65\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9540\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "bca0631828a5564a81628680cc6151bc418224f2", "tree": "22f0ce0fe86c1e5be63d9a7f1fadf642588c75f3", "parents": [ "c5f5cb21078f1278618234a869d5808ac36c8d9e" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Fri Jul 31 11:17:20 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 31 23:06:18 2020 +0000" }, "message": "[rust project] update path to std lib crates\n\nThe standard lib crates have been moved to a new location within\nthe toolchain. This updates the paths in rust-project.json to\naccomodate.\n\nChange-Id: I656c71bbb0c233370a4ce13332f9192deb08a176\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9500\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\n" }, { "commit": "c5f5cb21078f1278618234a869d5808ac36c8d9e", "tree": "49eabd5d57c7261d8b1cc124901239dcd5684c79", "parents": [ "ab16bbdf86242266885c2721198d21466c34b204" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Tue Jul 28 16:48:56 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 31 22:58:28 2020 +0000" }, "message": "[rust project] Add debug printing to test failures\n\nWhen a test comparing the expected JSON output against the actual\nfails, print both so that they can be compared.\n\nChange-Id: Ie024396a7a30750d7f9d6a281eff66119b7dff70\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9480\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\n" }, { "commit": "ab16bbdf86242266885c2721198d21466c34b204", "tree": "effbeb8ffd67e271cbf34e9fe88dcf5d83d5c56e", "parents": [ "783cc138f9ac3e7ca214317e44a3b04bcbb334cb" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Wed Jun 10 14:03:21 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 31 22:49:58 2020 +0000" }, "message": "[rust project] Extract compiler target\n\nExtract the compiler arguments, and then from them, the compilation\ntarget triple that is being passed to rustc.\n\nThis is also a step towards deduplicating targets by compilation\ntarget and options (combining test and non-test, and preferring\ncross-compilation targets over the host (default toolchain over\na separate toolchain, if there are multiple listings of the same\nrlib/binary/test.\n\nChange-Id: I1af0ef2da5dca41729e9367389048a068efd7959\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/8840\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\n" }, { "commit": "783cc138f9ac3e7ca214317e44a3b04bcbb334cb", "tree": "1ff483821f8a11386e1a2ba5705ac4766182045e", "parents": [ "9059b0bb9f7a5651037e44bb4ba1832d665032c1" ], "author": { "name": "Paul Daniel Faria", "email": "paulfaria@google.com", "time": "Tue Jul 28 11:41:43 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 30 21:33:07 2020 +0000" }, "message": "[rust-project] Add \"core\" and \"alloc\" as explicit deps for crates\n\nrust-analyzer does not recognize any crates as beloning to sysroot\nwhen analyzing rust-project.json projects. Because of this, it\u0027s\nnecessary to add \"core\" and \"alloc\" as explicit dependencies to\nevery crate so they can be accessed. There is no harm in including\nthem when they are not used, and this path is actually recommended\nby the rust-analyzer team.\n\nChange-Id: Iad2fe822b03ebc4eebd4bfb5f96b6273c3ecb6ea\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/9440\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\nReviewed-by: Aaron Wood \u003caaronwood@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" } ], "next": "9059b0bb9f7a5651037e44bb4ba1832d665032c1" }