| //===--- AvoidGotoCheck.cpp - clang-tidy-----------------------------------===// |
| // |
| // The LLVM Compiler Infrastructure |
| // |
| // This file is distributed under the University of Illinois Open Source |
| // License. See LICENSE.TXT for details. |
| // |
| //===----------------------------------------------------------------------===// |
| |
| #include "AvoidGotoCheck.h" |
| #include "clang/AST/ASTContext.h" |
| #include "clang/ASTMatchers/ASTMatchFinder.h" |
| |
| using namespace clang::ast_matchers; |
| |
| namespace clang { |
| namespace tidy { |
| namespace cppcoreguidelines { |
| |
| namespace { |
| AST_MATCHER(GotoStmt, isForwardJumping) { |
| return Node.getLocStart() < Node.getLabel()->getLocStart(); |
| } |
| } // namespace |
| |
| void AvoidGotoCheck::registerMatchers(MatchFinder *Finder) { |
| if (!getLangOpts().CPlusPlus) |
| return; |
| |
| // TODO: This check does not recognize `IndirectGotoStmt` which is a |
| // GNU extension. These must be matched separately and an AST matcher |
| // is currently missing for them. |
| |
| // Check if the 'goto' is used for control flow other than jumping |
| // out of a nested loop. |
| auto Loop = stmt(anyOf(forStmt(), cxxForRangeStmt(), whileStmt(), doStmt())); |
| auto NestedLoop = |
| stmt(anyOf(forStmt(hasAncestor(Loop)), cxxForRangeStmt(hasAncestor(Loop)), |
| whileStmt(hasAncestor(Loop)), doStmt(hasAncestor(Loop)))); |
| |
| Finder->addMatcher(gotoStmt(anyOf(unless(hasAncestor(NestedLoop)), |
| unless(isForwardJumping()))) |
| .bind("goto"), |
| this); |
| } |
| |
| void AvoidGotoCheck::check(const MatchFinder::MatchResult &Result) { |
| const auto *Goto = Result.Nodes.getNodeAs<GotoStmt>("goto"); |
| |
| diag(Goto->getGotoLoc(), "avoid using 'goto' for flow control") |
| << Goto->getSourceRange(); |
| diag(Goto->getLabel()->getLocStart(), "label defined here", |
| DiagnosticIDs::Note); |
| } |
| } // namespace cppcoreguidelines |
| } // namespace tidy |
| } // namespace clang |