Import Cobalt 21.lts.1.276711
diff --git a/src/cobalt/CHANGELOG.md b/src/cobalt/CHANGELOG.md
index aadb628..04eb0a6 100644
--- a/src/cobalt/CHANGELOG.md
+++ b/src/cobalt/CHANGELOG.md
@@ -10,6 +10,11 @@
`cobalt_enable_jit` environment variable in `gyp_configuration.py` will
switch V8 to use JIT-less mode. V8 requires at least Starboard version 10.
+ - **Runtime V8 snapshot is no longer supported**
+ V8 has deprecated runtime snapshot and mandated build-time snapshot, Cobalt
+ adopts this change as well. Build-time snapshot greatly improves first
+ startup speed after install and is required for JIT-less mode.
+
- **scratch_surface_cache_size_in_bytes is removed.**
Because it never ended up being used, `scratch_suface_cache_size_in_bytes`
diff --git a/src/cobalt/base/console_log.h b/src/cobalt/base/console_log.h
index b42a4ba..e5de953 100644
--- a/src/cobalt/base/console_log.h
+++ b/src/cobalt/base/console_log.h
@@ -18,6 +18,7 @@
#include <sstream>
#include "base/logging.h"
+#include "cobalt/base/debugger_hooks.h"
namespace base {
diff --git a/src/cobalt/base/tokens.h b/src/cobalt/base/tokens.h
index c460d60..bfe8fee 100644
--- a/src/cobalt/base/tokens.h
+++ b/src/cobalt/base/tokens.h
@@ -56,6 +56,7 @@
MacroOpWithNameOnly(focus) \
MacroOpWithNameOnly(focusin) \
MacroOpWithNameOnly(focusout) \
+ MacroOpWithNameOnly(freeze) \
MacroOpWithNameOnly(gotpointercapture) \
MacroOpWithNameOnly(hashchange) \
MacroOpWithNameOnly(hide) \
diff --git a/src/cobalt/black_box_tests/black_box_tests.py b/src/cobalt/black_box_tests/black_box_tests.py
index 8fdd65f..bc72938 100644
--- a/src/cobalt/black_box_tests/black_box_tests.py
+++ b/src/cobalt/black_box_tests/black_box_tests.py
@@ -31,6 +31,12 @@
from starboard.tools import build
from starboard.tools import command_line
+_DISABLED_BLACKBOXTEST_CONFIGS = [
+ 'android-arm/devel',
+ 'android-arm64/devel',
+ 'raspi-0/devel',
+]
+
_PORT_SELECTION_RETRY_LIMIT = 10
_PORT_SELECTION_RANGE = [5000, 7000]
# List of blocked ports.
@@ -40,6 +46,9 @@
# resume signals.
_TESTS_NEEDING_SYSTEM_SIGNAL = [
'cancel_sync_loads_when_suspended',
+ # TODO: Re-enable once mouseenter, mouseleave, and moveto webdriver
+ # functionality is available.
+ # 'pointer_test',
'preload_font',
'preload_visibility',
'preload_launch_parameter',
@@ -191,10 +200,23 @@
def Run(self):
if self.proxy_port == '-1':
return 1
+
+ # Temporary means to determine if we are running on CI
+ # TODO: Update to IS_CI environment variable or similar
+ out_dir = _launcher_params.out_directory
+ is_ci = out_dir and 'mh_lab' in out_dir
+
+ target = (_launcher_params.platform, _launcher_params.config)
+ if is_ci and '{}/{}'.format(*target) in _DISABLED_BLACKBOXTEST_CONFIGS:
+ logging.warning(
+ 'Blackbox tests disabled for platform:{} config:{}'.format(*target))
+ return 0
+
logging.info('Using proxy port: %s', self.proxy_port)
with ProxyServer(
- port=self.proxy_port, host_resolve_map=self.host_resolve_map,
+ port=self.proxy_port,
+ host_resolve_map=self.host_resolve_map,
client_ips=self.device_ips):
if self.test_name:
suite = unittest.TestLoader().loadTestsFromModule(
diff --git a/src/cobalt/black_box_tests/testdata/pointer_test.html b/src/cobalt/black_box_tests/testdata/pointer_test.html
new file mode 100644
index 0000000..1f1b275
--- /dev/null
+++ b/src/cobalt/black_box_tests/testdata/pointer_test.html
@@ -0,0 +1,548 @@
+<!DOCTYPE html>
+
+<html>
+ <head>
+ <title>Cobalt pointer test</title>
+ <script src='black_box_js_test_utils.js'></script>
+ <style>
+ .size10 {
+ padding: 10px;
+ }
+ .size20 {
+ padding: 20px;
+ }
+ .size40 {
+ padding: 40px;
+ }
+ .black {
+ background-color: #FFF;
+ }
+ .grey {
+ background-color: #888;
+ }
+ .green {
+ background-color: #0F0;
+ }
+ .blue {
+ background-color: #00F;
+ }
+ .cyan {
+ background-color: #0FF;
+ }
+ .purple {
+ background-color: #F0F;
+ }
+ .yellow {
+ background-color: #FF0;
+ }
+ </style>
+ </head>
+ <body class="black">
+ <script>
+ // Fail if the test is not finished within 15 seconds.
+ var kTimeout = 30 * 1000;
+ var failTimer = setTimeout(fail, kTimeout);
+
+ function fail() {
+ console.log("Failing due to timeout!");
+ assertTrue(false);
+ }
+
+ function phasename(phase) {
+ switch(phase) {
+ case 0: return 'none';
+ case 1: return 'capturing';
+ case 2: return 'at target';
+ case 3: return 'bubbling';
+ }
+ return ' [unknown: ' + phase + ']';
+ }
+
+ var expected_events = [
+ // name, id, phase
+ // actions.move_to_element(top_one).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointermove', 'top_one', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_one', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'top_one', 'at target'],
+ ['pointerover', 'top', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'top_one', 'at target'],
+ ['pointerenter', 'top', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'top_one', 'at target'],
+ ['mouseover', 'top', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'top_one', 'at target'],
+ ['mouseenter', 'top', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // actions.move_to_element(top_two).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointerout', 'top_one', 'at target'],
+ ['pointerout', 'top', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'top_one', 'at target'],
+ ['mouseout', 'top_one', 'at target'],
+ ['mouseout', 'top', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'top_one', 'at target'],
+ ['pointermove', 'top_two', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_two', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'top_two', 'at target'],
+ ['pointerover', 'top', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'top_two', 'at target'],
+ ['pointerenter', 'top', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'top_two', 'at target'],
+ ['mouseover', 'top', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'top_two', 'at target'],
+ ['mouseenter', 'top', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // actions.move_to_element_with_offset(top_two, 10, 10).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointermove', 'top_two', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_two', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ // actions.move_to_element_with_offset(top_two, 0, 0).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointermove', 'top_two', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_two', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ // actions.move_to_element_with_offset(top_two, -10, 0).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointerout', 'top_two', 'at target'],
+ ['pointerout', 'top', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'top_two', 'at target'],
+ ['mouseout', 'top_two', 'at target'],
+ ['mouseout', 'top', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'top_two', 'at target'],
+ ['pointermove', 'top_one', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_one', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'top_one', 'at target'],
+ ['pointerover', 'top', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'top_one', 'at target'],
+ ['pointerenter', 'top', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'top_one', 'at target'],
+ ['mouseover', 'top', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'top_one', 'at target'],
+ ['mouseenter', 'top', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // actions.click(top_three)
+ ['pointerout', 'top_one', 'at target'],
+ ['pointerout', 'top', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'top_one', 'at target'],
+ ['mouseout', 'top_one', 'at target'],
+ ['mouseout', 'top', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'top_one', 'at target'],
+ ['pointermove', 'top_three', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_three', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'top_three', 'at target'],
+ ['pointerover', 'top', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'top_three', 'at target'],
+ ['pointerenter', 'top', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'top_three', 'at target'],
+ ['mouseover', 'top', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'top_three', 'at target'],
+ ['mouseenter', 'top', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ ['pointerdown', 'top_three', 'at target'],
+ ['pointerdown', 'top', 'bubbling'],
+ ['pointerdown', 'outer', 'bubbling'],
+ ['mousedown', 'top_three', 'at target'],
+ ['mousedown', 'top', 'bubbling'],
+ ['mousedown', 'outer', 'bubbling'],
+ ['pointerup', 'top_three', 'at target'],
+ ['pointerup', 'top', 'bubbling'],
+ ['pointerup', 'outer', 'bubbling'],
+ ['mouseup', 'top_three', 'at target'],
+ ['mouseup', 'top', 'bubbling'],
+ ['mouseup', 'outer', 'bubbling'],
+ ['click', 'top_three', 'at target'],
+ ['click', 'top', 'bubbling'],
+ ['click', 'outer', 'bubbling'],
+ // actions.click_and_hold(top_four)
+ ['pointerout', 'top_three', 'at target'],
+ ['pointerout', 'top', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'top_three', 'at target'],
+ ['mouseout', 'top_three', 'at target'],
+ ['mouseout', 'top', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'top_three', 'at target'],
+ ['pointermove', 'top_four', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_four', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'top_four', 'at target'],
+ ['pointerover', 'top', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'top_four', 'at target'],
+ ['pointerenter', 'top', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'top_four', 'at target'],
+ ['mouseover', 'top', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'top_four', 'at target'],
+ ['mouseenter', 'top', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ ['pointerdown', 'top_four', 'at target'],
+ ['pointerdown', 'top', 'bubbling'],
+ ['pointerdown', 'outer', 'bubbling'],
+ ['mousedown', 'top_four', 'at target'],
+ ['mousedown', 'top', 'bubbling'],
+ ['mousedown', 'outer', 'bubbling'],
+ // actions.release(top_five)
+ ['pointermove', 'top_four', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_four', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerup', 'top_four', 'at target'],
+ ['pointerup', 'top', 'bubbling'],
+ ['pointerup', 'outer', 'bubbling'],
+ ['mouseup', 'top_four', 'at target'],
+ ['mouseup', 'top', 'bubbling'],
+ ['mouseup', 'outer', 'bubbling'],
+ ['click', 'top_four', 'at target'],
+ ['click', 'top', 'bubbling'],
+ ['click', 'outer', 'bubbling'],
+ // actions.move_to_element(top_six).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointerout', 'top_four', 'at target'],
+ ['pointerout', 'top', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'top_four', 'at target'],
+ ['mouseout', 'top_four', 'at target'],
+ ['mouseout', 'top', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'top_four', 'at target'],
+ ['pointermove', 'top_six', 'at target'],
+ ['pointermove', 'top', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'top_six', 'at target'],
+ ['mousemove', 'top', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'top_six', 'at target'],
+ ['pointerover', 'top', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'top_six', 'at target'],
+ ['pointerenter', 'top', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'top_six', 'at target'],
+ ['mouseover', 'top', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'top_six', 'at target'],
+ ['mouseenter', 'top', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // actions.move_to_element(bottom_six).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointerout', 'top_six', 'at target'],
+ ['pointerout', 'top', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'top_six', 'at target'],
+ ['pointerleave', 'top', 'at target'],
+ ['mouseout', 'top_six', 'at target'],
+ ['mouseout', 'top', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'top_six', 'at target'],
+ ['mouseleave', 'top', 'at target'],
+ ['pointermove', 'bottom_six', 'at target'],
+ ['pointermove', 'bottom', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'bottom_six', 'at target'],
+ ['mousemove', 'bottom', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'bottom_six', 'at target'],
+ ['pointerover', 'bottom', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'bottom_six', 'at target'],
+ ['pointerenter', 'bottom', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'bottom_six', 'at target'],
+ ['mouseover', 'bottom', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'bottom_six', 'at target'],
+ ['mouseenter', 'bottom', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // actions.click(bottom_five)
+ ['pointerout', 'bottom_six', 'at target'],
+ ['pointerout', 'bottom', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'bottom_six', 'at target'],
+ ['mouseout', 'bottom_six', 'at target'],
+ ['mouseout', 'bottom', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'bottom_six', 'at target'],
+ ['pointermove', 'bottom_five', 'at target'],
+ ['pointermove', 'bottom', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'bottom_five', 'at target'],
+ ['mousemove', 'bottom', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'bottom_five', 'at target'],
+ ['pointerover', 'bottom', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'bottom_five', 'at target'],
+ ['pointerenter', 'bottom', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'bottom_five', 'at target'],
+ ['mouseover', 'bottom', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'bottom_five', 'at target'],
+ ['mouseenter', 'bottom', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ ['pointerdown', 'bottom_five', 'at target'],
+ ['pointerdown', 'bottom', 'bubbling'],
+ ['pointerdown', 'outer', 'bubbling'],
+ ['pointerup', 'bottom_five', 'at target'],
+ ['pointerup', 'bottom', 'bubbling'],
+ ['pointerup', 'outer', 'bubbling'],
+ ['click', 'bottom_five', 'at target'],
+ ['click', 'bottom', 'bubbling'],
+ ['click', 'outer', 'bubbling'],
+ // actions.click_and_hold(bottom_four)
+ ['pointerout', 'bottom_five', 'at target'],
+ ['pointerout', 'bottom', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'bottom_five', 'at target'],
+ ['mouseout', 'bottom_five', 'at target'],
+ ['mouseout', 'bottom', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'bottom_five', 'at target'],
+ ['pointermove', 'bottom_four', 'at target'],
+ ['pointermove', 'bottom', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'bottom_four', 'at target'],
+ ['mousemove', 'bottom', 'bubbling'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'bottom_four', 'at target'],
+ ['pointerover', 'bottom', 'bubbling'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'bottom_four', 'at target'],
+ ['pointerenter', 'bottom', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'bottom_four', 'at target'],
+ ['mouseover', 'bottom', 'bubbling'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'bottom_four', 'at target'],
+ ['mouseenter', 'bottom', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ ['pointerdown', 'bottom_four', 'at target'],
+ ['pointerdown', 'bottom', 'bubbling'],
+ ['pointerdown', 'outer', 'bubbling'],
+ // actions.release(bottom_three)
+ ['pointermove', 'bottom_four', 'at target'],
+ ['pointermove', 'bottom', 'bubbling'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['pointerup', 'bottom_four', 'at target'],
+ ['pointerup', 'bottom', 'bubbling'],
+ ['pointerup', 'outer', 'bubbling'],
+ ['click', 'bottom_four', 'at target'],
+ ['click', 'bottom', 'bubbling'],
+ ['click', 'outer', 'bubbling'],
+ // actions.move_to_element(bottom_two).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointerout', 'bottom_four', 'at target'],
+ ['pointerout', 'bottom', 'bubbling'],
+ ['pointerout', 'outer', 'bubbling'],
+ ['pointerleave', 'bottom_four', 'at target'],
+ ['mouseout', 'bottom_four', 'at target'],
+ ['mouseout', 'bottom', 'bubbling'],
+ ['mouseout', 'outer', 'bubbling'],
+ ['mouseleave', 'bottom_four', 'at target'],
+ ['pointermove', 'bottom_two', 'at target'],
+ ['mousemove', 'bottom_two', 'at target'],
+ ['pointerover', 'bottom_two', 'at target'],
+ ['pointerenter', 'bottom_two', 'at target'],
+ ['pointerenter', 'bottom', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'bottom_two', 'at target'],
+ ['mouseenter', 'bottom_two', 'at target'],
+ ['mouseenter', 'bottom', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // actions.move_to_element(bottom_one).pause(_SLEEP_AFTER_MOVE_TIME)
+ ['pointerout', 'bottom_two', 'at target'],
+ ['pointerleave', 'bottom_two', 'at target'],
+ ['mouseout', 'bottom_two', 'at target'],
+ ['mouseleave', 'bottom_two', 'at target'],
+ ['pointermove', 'bottom_one', 'at target'],
+ ['mousemove', 'bottom_one', 'at target'],
+ ['pointerover', 'bottom_one', 'at target'],
+ ['pointerenter', 'bottom_one', 'at target'],
+ ['pointerenter', 'bottom', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'bottom_one', 'at target'],
+ ['mouseenter', 'bottom_one', 'at target'],
+ ['mouseenter', 'bottom', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ // find_element_by_id(runner, 'end').click()
+ ['pointerout', 'bottom_one', 'at target'],
+ ['pointerleave', 'bottom_one', 'at target'],
+ ['pointerleave', 'bottom', 'at target'],
+ ['mouseout', 'bottom_one', 'at target'],
+ ['mouseleave', 'bottom_one', 'at target'],
+ ['mouseleave', 'bottom', 'at target'],
+ ['pointermove', 'end', 'at target'],
+ ['pointermove', 'outer', 'bubbling'],
+ ['mousemove', 'end', 'at target'],
+ ['mousemove', 'outer', 'bubbling'],
+ ['pointerover', 'end', 'at target'],
+ ['pointerover', 'outer', 'bubbling'],
+ ['pointerenter', 'end', 'at target'],
+ ['pointerenter', 'outer', 'at target'],
+ ['mouseover', 'end', 'at target'],
+ ['mouseover', 'outer', 'bubbling'],
+ ['mouseenter', 'end', 'at target'],
+ ['mouseenter', 'outer', 'at target'],
+ ['pointerdown', 'end', 'at target'],
+ ['pointerdown', 'outer', 'bubbling'],
+ ['mousedown', 'end', 'at target'],
+ ['mousedown', 'outer', 'bubbling'],
+ ['pointerup', 'end', 'at target'],
+ ['pointerup', 'outer', 'bubbling'],
+ ['mouseup', 'end', 'at target'],
+ ['mouseup', 'outer', 'bubbling'],
+ ['click', 'end', 'at target'],
+ ['click', 'outer', 'bubbling']];
+
+ var current_event_number = 0
+ var failure_count = 0;
+
+ function CheckEvent(name, id, phase) {
+ while ((current_event_number < expected_events.length) &&
+ ((expected_events[current_event_number][0] != name) ||
+ (expected_events[current_event_number][1] != id) ||
+ (expected_events[current_event_number][2] != phase))) {
+ console.log('ERROR: Missing Event [\'' +
+ expected_events[current_event_number][0] + '\', \'' +
+ expected_events[current_event_number][1] + '\', \'' +
+ expected_events[current_event_number][2] + '\'],');
+ failure_count += 1;
+ current_event_number += 1;
+ }
+ if (current_event_number < expected_events.length) {
+ current_event_number += 1;
+ } else {
+ failure_count += 1;
+ console.log('ERROR: Unexpected Event [\'' + name + '\', \'' +
+ id + '\', \'' + phase + '\'],');
+ }
+ }
+
+ function LogEvent(e) {
+ var pointertype = e.pointerType ? e.pointerType + ' ' : '';
+ var id = this.getAttribute('id')
+ CheckEvent(e.type, id, phasename(e.eventPhase))
+ console.log(e.type + ' ' + pointertype + id +
+ ' (' + this.getAttribute('class') + ')' +
+ ' [' + phasename(e.eventPhase) + ']' +
+ ' (' + e.screenX + ',' + e.screenY + ')');
+ }
+
+ function EndTest(e) {
+ console.log('Ending test.')
+ assertTrue(failure_count == 0);
+ onEndTest();
+ }
+
+ function Cancel(e) {
+ console.log('cancel');
+ e.preventDefault();
+ }
+
+ function Stop(e) {
+ console.log('stop');
+ e.stopPropagation();
+ }
+
+ function Capture(e) {
+ console.log('capture');
+ e.target.setPointerCapture(e.pointerId);
+ }
+
+ function SetHandlers(event, classname, callback) {
+ var elements = document.getElementsByClassName(classname);
+ for (var i = 0; i < elements.length; ++i) {
+ elements[i].addEventListener(event, callback);
+ }
+ }
+
+ function SetAllHandlers(prefix, classname, callback) {
+ SetHandlers(prefix + 'enter', classname, callback);
+ SetHandlers(prefix + 'leave', classname, callback);
+ SetHandlers(prefix + 'over', classname, callback);
+ SetHandlers(prefix + 'out', classname, callback);
+ SetHandlers(prefix + 'down', classname, callback);
+ SetHandlers(prefix + 'up', classname, callback);
+ SetHandlers(prefix + 'move', classname, callback);
+ }
+
+ window.onload = function() {
+ SetAllHandlers('mouse', 'track', LogEvent);
+ SetAllHandlers('pointer', 'track', LogEvent);
+ SetHandlers('click', 'track', LogEvent);
+ SetAllHandlers('mouse', 'cancel', Cancel);
+ SetAllHandlers('pointer', 'cancel', Cancel);
+ SetAllHandlers('mouse', 'stop', Stop);
+ SetAllHandlers('pointer', 'stop', Stop);
+ SetHandlers('pointerdown', 'capture', Capture);
+ SetHandlers('click', 'end', EndTest);
+ console.log("Setup finished");
+ setupFinished();
+ }
+
+ </script>
+ <div id="outer" class="track size40 grey">
+ <div id="top" class="track size20 blue">
+ <span id="top_one" class="track size10 cyan"></span>
+ <span id="top_two" class="track size10 purple"></span>
+ *A*
+ <span id="top_three" class="track size10 yellow"></span>
+ *B*
+ <span id="top_four" class="track capture size10 grey"></span>
+ <span id="top_five" class="track size10 green"></span>
+ <span id="top_six" class="track size10 cyan"></span>
+ </div>
+ <div id="bottom" class="track size20 green">
+ <span id="bottom_one" class="track stop size10 cyan"></span>
+ <span id="bottom_two" class="track stop size10 purple"></span>
+ *A*
+ <span id="bottom_three" class="track cancel size10 yellow"></span>
+ *B*
+ <span id="bottom_four" class="track cancel capture size10 grey"></span>
+ <span id="bottom_five" class="track cancel size10 blue"></span>
+ <span id="bottom_six" class="track size10 cyan"></span>
+ </div>
+ <div id="end" class="end track size10 blue">
+ </div>
+ </body>
+</html>
diff --git a/src/cobalt/black_box_tests/tests/pointer_test.py b/src/cobalt/black_box_tests/tests/pointer_test.py
new file mode 100644
index 0000000..a01556f
--- /dev/null
+++ b/src/cobalt/black_box_tests/tests/pointer_test.py
@@ -0,0 +1,103 @@
+# Copyright 2020 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+"""Tests events for an extended sequence of pointer moves and clicks."""
+
+# This test generates an extended sequence of pointer move and click events,
+# and verifies the corresponding sequence of pointer, mouse, and click events
+# dispatched to the HTML elements. The test includes use of pointer capture and
+# use of preventDefault() and stopPropagation() on the events, as well as event
+# bubbling.
+
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+
+import _env # pylint: disable=unused-import,g-bad-import-order
+
+import traceback
+
+from cobalt.black_box_tests import black_box_tests
+from cobalt.black_box_tests.threaded_web_server import ThreadedWebServer
+from selenium.webdriver.common.action_chains import ActionChains
+
+# Time to sleep after a mouse move to give the device time to process it and
+# to avoid collapsing with subsequent move events.
+_SLEEP_AFTER_MOVE_TIME = 0.5
+
+
+def find_element_by_id(runner, id_selector):
+ return runner.webdriver.find_elements_by_css_selector('#' + id_selector)[0]
+
+
+class PointerTest(black_box_tests.BlackBoxTestCase):
+ """Tests pointer and mouse event."""
+
+ def test_simple(self):
+
+ try:
+ with ThreadedWebServer(
+ binding_address=self.GetBindingAddress()) as server:
+ url = server.GetURL(file_name='testdata/pointer_test.html')
+
+ with self.CreateCobaltRunner(url=url) as runner:
+ print('JS Test Setup WaitForJSTestsSetup')
+ runner.WaitForJSTestsSetup()
+ print('JS Test Setup')
+ self.assertTrue(runner.webdriver)
+
+ top_one = find_element_by_id(runner, 'top_one')
+ top_two = find_element_by_id(runner, 'top_two')
+ top_three = find_element_by_id(runner, 'top_three')
+ top_four = find_element_by_id(runner, 'top_four')
+ top_five = find_element_by_id(runner, 'top_five')
+ top_six = find_element_by_id(runner, 'top_six')
+
+ bottom_one = find_element_by_id(runner, 'bottom_one')
+ bottom_two = find_element_by_id(runner, 'bottom_two')
+ bottom_three = find_element_by_id(runner, 'bottom_three')
+ bottom_four = find_element_by_id(runner, 'bottom_four')
+ bottom_five = find_element_by_id(runner, 'bottom_five')
+ bottom_six = find_element_by_id(runner, 'bottom_six')
+
+ # Perform mouse actions with ActionChains.
+ # https://www.selenium.dev/selenium/docs/api/py/webdriver/selenium.webdriver.common.action_chains.html#module-selenium.webdriver.common.action_chains
+ actions = ActionChains(runner.webdriver)
+ actions.move_to_element(top_one).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.move_to_element(top_two).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.move_to_element_with_offset(top_two, 10,
+ 10).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.move_to_element_with_offset(top_two, 0,
+ 0).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.move_to_element_with_offset(top_two, -10,
+ 0).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.click(top_three)
+ actions.click_and_hold(top_four)
+ actions.release(top_five)
+ actions.move_to_element(top_six).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.move_to_element(bottom_six).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.click(bottom_five)
+ actions.click_and_hold(bottom_four)
+ actions.release(bottom_three)
+ actions.move_to_element(bottom_two).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.move_to_element(bottom_one).pause(_SLEEP_AFTER_MOVE_TIME)
+ actions.perform()
+
+ find_element_by_id(runner, 'end').click()
+ self.assertTrue(runner.JSTestsSucceeded())
+ except: # pylint: disable=bare-except
+ traceback.print_exc()
+ # Consider an exception being thrown as a test failure.
+ self.assertTrue(False)
+ finally:
+ print('Cleaning up.')
diff --git a/src/cobalt/black_box_tests/tests/web_platform_tests.py b/src/cobalt/black_box_tests/tests/web_platform_tests.py
index 9c27785..84df8c3 100644
--- a/src/cobalt/black_box_tests/tests/web_platform_tests.py
+++ b/src/cobalt/black_box_tests/tests/web_platform_tests.py
@@ -76,15 +76,6 @@
if self.launcher_params.target_params:
target_params += self.launcher_params.target_params
- if self.launcher_params.IsEvergreen():
- # TODO: Remove this once the memory leaks when running executables in
- # Evergreen mode have been resolved.
- env_variables_config = {
- 'ASAN_OPTIONS': 'detect_leaks=0:intercept_tls_get_addr=0'
- }
- else:
- env_variables_config = {'ASAN_OPTIONS': 'intercept_tls_get_addr=0'}
-
launcher = abstract_launcher.LauncherFactory(
self.launcher_params.platform,
'web_platform_tests',
@@ -93,7 +84,7 @@
target_params=target_params,
output_file=None,
out_directory=self.launcher_params.out_directory,
- env_variables=env_variables_config,
+ env_variables={'ASAN_OPTIONS': 'intercept_tls_get_addr=0'},
loader_platform=self.launcher_params.loader_platform,
loader_config=self.launcher_params.loader_config,
loader_out_directory=self.launcher_params.loader_out_directory)
diff --git a/src/cobalt/browser/application.cc b/src/cobalt/browser/application.cc
index 879e51d..274b91a 100644
--- a/src/cobalt/browser/application.cc
+++ b/src/cobalt/browser/application.cc
@@ -62,6 +62,7 @@
#include "cobalt/browser/switches.h"
#include "cobalt/browser/user_agent_string.h"
#include "cobalt/configuration/configuration.h"
+#include "cobalt/extension/installation_manager.h"
#include "cobalt/loader/image/image_decoder.h"
#include "cobalt/math/size.h"
#include "cobalt/script/javascript_engine.h"
@@ -742,7 +743,9 @@
network_module_options));
#if SB_IS(EVERGREEN)
- updater_module_.reset(new updater::UpdaterModule(network_module_.get()));
+ if (SbSystemGetExtension(kCobaltExtensionInstallationManagerName)) {
+ updater_module_.reset(new updater::UpdaterModule(network_module_.get()));
+ }
#endif
browser_module_.reset(new BrowserModule(
initial_url,
@@ -1063,7 +1066,7 @@
++app_suspend_count_;
browser_module_->Suspend();
#if SB_IS(EVERGREEN)
- updater_module_->Suspend();
+ if (updater_module_) updater_module_->Suspend();
#endif
DLOG(INFO) << "Finished suspending.";
break;
@@ -1074,7 +1077,7 @@
++app_resume_count_;
browser_module_->Resume();
#if SB_IS(EVERGREEN)
- updater_module_->Resume();
+ if (updater_module_) updater_module_->Resume();
#endif
DLOG(INFO) << "Finished resuming.";
break;
diff --git a/src/cobalt/browser/user_agent_string.cc b/src/cobalt/browser/user_agent_string.cc
index 2240e74..2e7f57d 100644
--- a/src/cobalt/browser/user_agent_string.cc
+++ b/src/cobalt/browser/user_agent_string.cc
@@ -28,7 +28,7 @@
#include "starboard/common/string.h"
#include "starboard/system.h"
#if SB_IS(EVERGREEN)
-#include "cobalt/updater/util.h"
+#include "cobalt/updater/utils.h"
#endif
namespace cobalt {
@@ -255,7 +255,7 @@
// Evergreen version
#if SB_IS(EVERGREEN)
- const std::string evergreen_version = updater::GetEvergreenVersion();
+ const std::string evergreen_version = updater::GetCurrentEvergreenVersion();
if (!evergreen_version.empty()) {
base::StringAppendF(&user_agent, " Evergreen/%s",
evergreen_version.c_str());
diff --git a/src/cobalt/browser/web_module.cc b/src/cobalt/browser/web_module.cc
index af1cb55..1923513 100644
--- a/src/cobalt/browser/web_module.cc
+++ b/src/cobalt/browser/web_module.cc
@@ -526,7 +526,7 @@
DCHECK_LE(0, data.options.encoded_image_cache_capacity);
loader_factory_.reset(new loader::LoaderFactory(
name_.c_str(), fetcher_factory_.get(), resource_provider_,
- data.options.encoded_image_cache_capacity,
+ debugger_hooks_, data.options.encoded_image_cache_capacity,
data.options.loader_thread_priority));
animated_image_tracker_.reset(new loader::image::AnimatedImageTracker(
@@ -534,7 +534,7 @@
DCHECK_LE(0, data.options.image_cache_capacity);
image_cache_ = loader::image::CreateImageCache(
- base::StringPrintf("%s.ImageCache", name_.c_str()),
+ base::StringPrintf("%s.ImageCache", name_.c_str()), debugger_hooks_,
static_cast<uint32>(data.options.image_cache_capacity),
loader_factory_.get());
DCHECK(image_cache_);
@@ -547,13 +547,14 @@
DCHECK_LE(0, data.options.remote_typeface_cache_capacity);
remote_typeface_cache_ = loader::font::CreateRemoteTypefaceCache(
base::StringPrintf("%s.RemoteTypefaceCache", name_.c_str()),
+ debugger_hooks_,
static_cast<uint32>(data.options.remote_typeface_cache_capacity),
loader_factory_.get());
DCHECK(remote_typeface_cache_);
DCHECK_LE(0, data.options.mesh_cache_capacity);
mesh_cache_ = loader::mesh::CreateMeshCache(
- base::StringPrintf("%s.MeshCache", name_.c_str()),
+ base::StringPrintf("%s.MeshCache", name_.c_str()), debugger_hooks_,
static_cast<uint32>(data.options.mesh_cache_capacity),
loader_factory_.get());
DCHECK(mesh_cache_);
diff --git a/src/cobalt/build/all.gyp b/src/cobalt/build/all.gyp
index d73ca7dd..a4cb34e 100644
--- a/src/cobalt/build/all.gyp
+++ b/src/cobalt/build/all.gyp
@@ -90,7 +90,8 @@
'<(DEPTH)/net/net.gyp:net_unittests_deploy',
'<(DEPTH)/sql/sql.gyp:sql_unittests_deploy',
'<(DEPTH)/starboard/elf_loader/elf_loader.gyp:elf_loader_test_deploy',
- '<(DEPTH)/starboard/loader_app/loader_app.gyp:loader_app'
+ '<(DEPTH)/starboard/loader_app/loader_app.gyp:loader_app',
+ '<(DEPTH)/starboard/nplb/nplb_evergreen_compat_tests/nplb_evergreen_compat_tests.gyp:nplb_evergreen_compat_tests_deploy',
],
'conditions': [
['sb_evergreen != 1', {
@@ -111,6 +112,11 @@
'<(DEPTH)/starboard/loader_app/installation_manager.gyp:*',
],
}],
+ ['sb_evergreen_compatible==1', {
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/handler/handler.gyp:crashpad_handler',
+ ],
+ }],
],
},
],
diff --git a/src/cobalt/build/build.id b/src/cobalt/build/build.id
index 4fa2562..0b3308c 100644
--- a/src/cobalt/build/build.id
+++ b/src/cobalt/build/build.id
@@ -1 +1 @@
-272453
\ No newline at end of file
+276711
\ No newline at end of file
diff --git a/src/cobalt/build/cobalt_configuration.gypi b/src/cobalt/build/cobalt_configuration.gypi
index 33e8adb..7f4f3c6 100644
--- a/src/cobalt/build/cobalt_configuration.gypi
+++ b/src/cobalt/build/cobalt_configuration.gypi
@@ -34,7 +34,6 @@
'variables': {
'cobalt_webapi_extension_source_idl_files%': [],
'cobalt_webapi_extension_generated_header_idl_files%': [],
- 'cobalt_v8_buildtime_snapshot%': 1,
'cobalt_v8_enable_embedded_builtins%': 1,
},
@@ -242,9 +241,6 @@
# "file:///cobalt/browser/splash_screen/". If '', no file is copied.
'cobalt_splash_screen_file%': '',
- # Set to "true" to enable v8 snapshot generation at Cobalt build time.
- 'cobalt_v8_buildtime_snapshot%': '<(cobalt_v8_buildtime_snapshot)',
-
# Some compiler can not compile with raw assembly(.S files) and v8
# converts asm to inline assembly for these platforms.
'cobalt_v8_emit_builtins_as_inline_asm%': 1,
@@ -687,11 +683,6 @@
'ENABLE_DEBUGGER',
],
}],
- ['cobalt_v8_buildtime_snapshot == 1', {
- 'defines': [
- 'COBALT_V8_BUILDTIME_SNAPSHOT=1',
- ],
- }],
['host_os=="win"', {
# A few flags to mute MSVC compiler errors that does not appear on Linux.
'compiler_flags_host': [
diff --git a/src/cobalt/content/fonts/config/android/fonts.xml b/src/cobalt/content/fonts/config/android/fonts.xml
index c9dafe1..a39f238 100644
--- a/src/cobalt/content/fonts/config/android/fonts.xml
+++ b/src/cobalt/content/fonts/config/android/fonts.xml
@@ -176,15 +176,21 @@
</family>
<family>
<font weight="400" style="normal">NotoSansArmenian-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansArmenian-Regular.otf</font>
<font weight="700" style="normal">NotoSansArmenian-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansArmenian-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansGeorgian-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansGeorgian-Regular.otf</font>
<font weight="700" style="normal">NotoSansGeorgian-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansGeorgian-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansDevanagariUI-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansDevanagariUI-Regular.otf</font>
<font weight="700" style="normal">NotoSansDevanagariUI-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansDevanagariUI-Bold.otf</font>
</family>
<!-- Gujarati should come after Devanagari -->
<family>
@@ -198,15 +204,21 @@
</family>
<family>
<font weight="400" style="normal">NotoSansTamilUI-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansTamilUI-Regular.otf</font>
<font weight="700" style="normal">NotoSansTamilUI-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansTamilUI-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansMalayalamUI-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansMalayalamUI-Regular.otf</font>
<font weight="700" style="normal">NotoSansMalayalamUI-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansMalayalamUI-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansBengaliUI-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansBengaliUI-Regular.otf</font>
<font weight="700" style="normal">NotoSansBengaliUI-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansBengaliUI-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansTeluguUI-Regular.ttf</font>
@@ -222,7 +234,9 @@
</family>
<family>
<font weight="400" style="normal">NotoSansSinhala-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansSinhala-Regular.otf</font>
<font weight="700" style="normal">NotoSansSinhala-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansSinhala-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansKhmerUI-Regular.ttf</font>
@@ -234,7 +248,9 @@
</family>
<family>
<font weight="400" style="normal">NotoSansMyanmarUI-Regular.ttf</font>
+ <font weight="400" style="normal">NotoSansMyanmarUI-Regular.otf</font>
<font weight="700" style="normal">NotoSansMyanmarUI-Bold.ttf</font>
+ <font weight="700" style="normal">NotoSansMyanmarUI-Bold.otf</font>
</family>
<family>
<font weight="400" style="normal">NotoSansThaana-Regular.ttf</font>
diff --git a/src/cobalt/content/licenses/licenses_cobalt.txt b/src/cobalt/content/licenses/licenses_cobalt.txt
index 195ae09..757106b 100644
--- a/src/cobalt/content/licenses/licenses_cobalt.txt
+++ b/src/cobalt/content/licenses/licenses_cobalt.txt
@@ -209,6 +209,105 @@
+ V8
+
+ This license applies to all parts of V8 that are not externally
+ maintained libraries. The externally maintained libraries used by V8
+ are:
+
+ - PCRE test suite, located in
+ test/mjsunit/third_party/regexp-pcre/regexp-pcre.js. This is based on the
+ test suite from PCRE-7.3, which is copyrighted by the University
+ of Cambridge and Google, Inc. The copyright notice and license
+ are embedded in regexp-pcre.js.
+
+ - Layout tests, located in test/mjsunit/third_party/object-keys. These are
+ based on layout tests from webkit.org which are copyrighted by
+ Apple Computer, Inc. and released under a 3-clause BSD license.
+
+ - Strongtalk assembler, the basis of the files assembler-arm-inl.h,
+ assembler-arm.cc, assembler-arm.h, assembler-ia32-inl.h,
+ assembler-ia32.cc, assembler-ia32.h, assembler-x64-inl.h,
+ assembler-x64.cc, assembler-x64.h, assembler-mips-inl.h,
+ assembler-mips.cc, assembler-mips.h, assembler.cc and assembler.h.
+ This code is copyrighted by Sun Microsystems Inc. and released
+ under a 3-clause BSD license.
+
+ - Valgrind client API header, located at src/third_party/valgrind/valgrind.h
+ This is released under the BSD license.
+
+ - The Wasm C/C++ API headers, located at third_party/wasm-api/wasm.{h,hh}
+ This is released under the Apache license. The API's upstream prototype
+ implementation also formed the basis of V8's implementation in
+ src/wasm/c-api.cc.
+
+ These libraries have their own licenses; we recommend you read them,
+ as their terms may differ from the terms below.
+
+ Further license information can be found in LICENSE files located in
+ sub-directories.
+
+ Copyright 2014, the V8 project authors. All rights reserved.
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are
+ met:
+
+ * Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above
+ copyright notice, this list of conditions and the following
+ disclaimer in the documentation and/or other materials provided
+ with the distribution.
+ * Neither the name of Google Inc. nor the names of its
+ contributors may be used to endorse or promote products derived
+ from this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+
+ devtools
+
+
+ // Copyright 2014 The Chromium Authors. All rights reserved.
+ //
+ // Redistribution and use in source and binary forms, with or without
+ // modification, are permitted provided that the following conditions are
+ // met:
+ //
+ // * Redistributions of source code must retain the above copyright
+ // notice, this list of conditions and the following disclaimer.
+ // * Redistributions in binary form must reproduce the above
+ // copyright notice, this list of conditions and the following disclaimer
+ // in the documentation and/or other materials provided with the
+ // distribution.
+ // * Neither the name of Google Inc. nor the names of its
+ // contributors may be used to endorse or promote products derived from
+ // this software without specific prior written permission.
+ //
+ // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
boringssl
@@ -606,6 +705,34 @@
+ libxml
+
+
+ LibXml Ruby Project
+ Copyright (c) 2008-2013 Charlie Savage and contributors
+ Copyright (c) 2002-2007 Sean Chittenden and contributors
+ Copyright (c) 2001 Wai-Sun "Squidster" Chia
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy of
+ this software and associated documentation files (the "Software"), to deal in
+ the Software without restriction, including without limitation the rights to
+ use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+ of the Software, and to permit persons to whom the Software is furnished to do
+ so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all
+ copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ SOFTWARE.
+
+
+
Netscape Portable Runtime (NSPR)
@@ -2448,15 +2575,6 @@
- SpiderMonkey
-
-
- This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
- If a copy of the MPL was not distributed with this file, You can obtain one at
- https://mozilla.org/MPL/2.0/.
-
-
-
WebKit
Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
@@ -4372,7 +4490,7 @@
angle
- // Copyright (C) 2002-2013 The ANGLE Project Authors.
+ // Copyright 2018 The ANGLE Project Authors.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
@@ -4382,7 +4500,7 @@
// Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
//
- // Redistributions in binary form must reproduce the above
+ // Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
@@ -4393,7 +4511,7 @@
// prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
// COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
@@ -4511,67 +4629,6 @@
- android_crazy_linker
-
-
- // Copyright 2014 The Chromium Authors. All rights reserved.
- //
- // Redistribution and use in source and binary forms, with or without
- // modification, are permitted provided that the following conditions are
- // met:
- //
- // * Redistributions of source code must retain the above copyright
- // notice, this list of conditions and the following disclaimer.
- // * Redistributions in binary form must reproduce the above
- // copyright notice, this list of conditions and the following disclaimer
- // in the documentation and/or other materials provided with the
- // distribution.
- // * Neither the name of Google Inc. nor the names of its
- // contributors may be used to endorse or promote products derived from
- // this software without specific prior written permission.
- //
- // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
- /*
- * Copyright (C) 2012 The Android Open Source Project
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in
- * the documentation and/or other materials provided with the
- * distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
- * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
- * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
- * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
- * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
- * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
- */
-
-
-
pyjson5
@@ -4913,3 +4970,550 @@
not be used in advertising or otherwise to promote the sale, use or other
dealings in this Software without prior written authorization from Silicon
Graphics, Inc.
+
+
+
+ google_benchmark
+
+
+ Apache License
+ Version 2.0, January 2004
+ http://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+ 1. Definitions.
+
+ "License" shall mean the terms and conditions for use, reproduction,
+ and distribution as defined by Sections 1 through 9 of this document.
+
+ "Licensor" shall mean the copyright owner or entity authorized by
+ the copyright owner that is granting the License.
+
+ "Legal Entity" shall mean the union of the acting entity and all
+ other entities that control, are controlled by, or are under common
+ control with that entity. For the purposes of this definition,
+ "control" means (i) the power, direct or indirect, to cause the
+ direction or management of such entity, whether by contract or
+ otherwise, or (ii) ownership of fifty percent (50%) or more of the
+ outstanding shares, or (iii) beneficial ownership of such entity.
+
+ "You" (or "Your") shall mean an individual or Legal Entity
+ exercising permissions granted by this License.
+
+ "Source" form shall mean the preferred form for making modifications,
+ including but not limited to software source code, documentation
+ source, and configuration files.
+
+ "Object" form shall mean any form resulting from mechanical
+ transformation or translation of a Source form, including but
+ not limited to compiled object code, generated documentation,
+ and conversions to other media types.
+
+ "Work" shall mean the work of authorship, whether in Source or
+ Object form, made available under the License, as indicated by a
+ copyright notice that is included in or attached to the work
+ (an example is provided in the Appendix below).
+
+ "Derivative Works" shall mean any work, whether in Source or Object
+ form, that is based on (or derived from) the Work and for which the
+ editorial revisions, annotations, elaborations, or other modifications
+ represent, as a whole, an original work of authorship. For the purposes
+ of this License, Derivative Works shall not include works that remain
+ separable from, or merely link (or bind by name) to the interfaces of,
+ the Work and Derivative Works thereof.
+
+ "Contribution" shall mean any work of authorship, including
+ the original version of the Work and any modifications or additions
+ to that Work or Derivative Works thereof, that is intentionally
+ submitted to Licensor for inclusion in the Work by the copyright owner
+ or by an individual or Legal Entity authorized to submit on behalf of
+ the copyright owner. For the purposes of this definition, "submitted"
+ means any form of electronic, verbal, or written communication sent
+ to the Licensor or its representatives, including but not limited to
+ communication on electronic mailing lists, source code control systems,
+ and issue tracking systems that are managed by, or on behalf of, the
+ Licensor for the purpose of discussing and improving the Work, but
+ excluding communication that is conspicuously marked or otherwise
+ designated in writing by the copyright owner as "Not a Contribution."
+
+ "Contributor" shall mean Licensor and any individual or Legal Entity
+ on behalf of whom a Contribution has been received by Licensor and
+ subsequently incorporated within the Work.
+
+ 2. Grant of Copyright License. Subject to the terms and conditions of
+ this License, each Contributor hereby grants to You a perpetual,
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+ copyright license to reproduce, prepare Derivative Works of,
+ publicly display, publicly perform, sublicense, and distribute the
+ Work and such Derivative Works in Source or Object form.
+
+ 3. Grant of Patent License. Subject to the terms and conditions of
+ this License, each Contributor hereby grants to You a perpetual,
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+ (except as stated in this section) patent license to make, have made,
+ use, offer to sell, sell, import, and otherwise transfer the Work,
+ where such license applies only to those patent claims licensable
+ by such Contributor that are necessarily infringed by their
+ Contribution(s) alone or by combination of their Contribution(s)
+ with the Work to which such Contribution(s) was submitted. If You
+ institute patent litigation against any entity (including a
+ cross-claim or counterclaim in a lawsuit) alleging that the Work
+ or a Contribution incorporated within the Work constitutes direct
+ or contributory patent infringement, then any patent licenses
+ granted to You under this License for that Work shall terminate
+ as of the date such litigation is filed.
+
+ 4. Redistribution. You may reproduce and distribute copies of the
+ Work or Derivative Works thereof in any medium, with or without
+ modifications, and in Source or Object form, provided that You
+ meet the following conditions:
+
+ (a) You must give any other recipients of the Work or
+ Derivative Works a copy of this License; and
+
+ (b) You must cause any modified files to carry prominent notices
+ stating that You changed the files; and
+
+ (c) You must retain, in the Source form of any Derivative Works
+ that You distribute, all copyright, patent, trademark, and
+ attribution notices from the Source form of the Work,
+ excluding those notices that do not pertain to any part of
+ the Derivative Works; and
+
+ (d) If the Work includes a "NOTICE" text file as part of its
+ distribution, then any Derivative Works that You distribute must
+ include a readable copy of the attribution notices contained
+ within such NOTICE file, excluding those notices that do not
+ pertain to any part of the Derivative Works, in at least one
+ of the following places: within a NOTICE text file distributed
+ as part of the Derivative Works; within the Source form or
+ documentation, if provided along with the Derivative Works; or,
+ within a display generated by the Derivative Works, if and
+ wherever such third-party notices normally appear. The contents
+ of the NOTICE file are for informational purposes only and
+ do not modify the License. You may add Your own attribution
+ notices within Derivative Works that You distribute, alongside
+ or as an addendum to the NOTICE text from the Work, provided
+ that such additional attribution notices cannot be construed
+ as modifying the License.
+
+ You may add Your own copyright statement to Your modifications and
+ may provide additional or different license terms and conditions
+ for use, reproduction, or distribution of Your modifications, or
+ for any such Derivative Works as a whole, provided Your use,
+ reproduction, and distribution of the Work otherwise complies with
+ the conditions stated in this License.
+
+ 5. Submission of Contributions. Unless You explicitly state otherwise,
+ any Contribution intentionally submitted for inclusion in the Work
+ by You to the Licensor shall be under the terms and conditions of
+ this License, without any additional terms or conditions.
+ Notwithstanding the above, nothing herein shall supersede or modify
+ the terms of any separate license agreement you may have executed
+ with Licensor regarding such Contributions.
+
+ 6. Trademarks. This License does not grant permission to use the trade
+ names, trademarks, service marks, or product names of the Licensor,
+ except as required for reasonable and customary use in describing the
+ origin of the Work and reproducing the content of the NOTICE file.
+
+ 7. Disclaimer of Warranty. Unless required by applicable law or
+ agreed to in writing, Licensor provides the Work (and each
+ Contributor provides its Contributions) on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied, including, without limitation, any warranties or conditions
+ of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+ PARTICULAR PURPOSE. You are solely responsible for determining the
+ appropriateness of using or redistributing the Work and assume any
+ risks associated with Your exercise of permissions under this License.
+
+ 8. Limitation of Liability. In no event and under no legal theory,
+ whether in tort (including negligence), contract, or otherwise,
+ unless required by applicable law (such as deliberate and grossly
+ negligent acts) or agreed to in writing, shall any Contributor be
+ liable to You for damages, including any direct, indirect, special,
+ incidental, or consequential damages of any character arising as a
+ result of this License or out of the use or inability to use the
+ Work (including but not limited to damages for loss of goodwill,
+ work stoppage, computer failure or malfunction, or any and all
+ other commercial damages or losses), even if such Contributor
+ has been advised of the possibility of such damages.
+
+ 9. Accepting Warranty or Additional Liability. While redistributing
+ the Work or Derivative Works thereof, You may choose to offer,
+ and charge a fee for, acceptance of support, warranty, indemnity,
+ or other liability obligations and/or rights consistent with this
+ License. However, in accepting such obligations, You may act only
+ on Your own behalf and on Your sole responsibility, not on behalf
+ of any other Contributor, and only if You agree to indemnify,
+ defend, and hold each Contributor harmless for any liability
+ incurred by, or claims asserted against, such Contributor by reason
+ of your accepting any such warranty or additional liability.
+
+ END OF TERMS AND CONDITIONS
+
+ APPENDIX: How to apply the Apache License to your work.
+
+ To apply the Apache License to your work, attach the following
+ boilerplate notice, with the fields enclosed by brackets "[]"
+ replaced with your own identifying information. (Don't include
+ the brackets!) The text should be enclosed in the appropriate
+ comment syntax for the file format. We also recommend that a
+ file or class name and description of purpose be included on the
+ same "printed page" as the copyright notice for easier
+ identification within third-party archives.
+
+ Copyright [yyyy] [name of copyright owner]
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+
+
+ crashpad
+
+
+ Apache License
+ Version 2.0, January 2004
+ http://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+ 1. Definitions.
+
+ "License" shall mean the terms and conditions for use, reproduction,
+ and distribution as defined by Sections 1 through 9 of this document.
+
+ "Licensor" shall mean the copyright owner or entity authorized by
+ the copyright owner that is granting the License.
+
+ "Legal Entity" shall mean the union of the acting entity and all
+ other entities that control, are controlled by, or are under common
+ control with that entity. For the purposes of this definition,
+ "control" means (i) the power, direct or indirect, to cause the
+ direction or management of such entity, whether by contract or
+ otherwise, or (ii) ownership of fifty percent (50%) or more of the
+ outstanding shares, or (iii) beneficial ownership of such entity.
+
+ "You" (or "Your") shall mean an individual or Legal Entity
+ exercising permissions granted by this License.
+
+ "Source" form shall mean the preferred form for making modifications,
+ including but not limited to software source code, documentation
+ source, and configuration files.
+
+ "Object" form shall mean any form resulting from mechanical
+ transformation or translation of a Source form, including but
+ not limited to compiled object code, generated documentation,
+ and conversions to other media types.
+
+ "Work" shall mean the work of authorship, whether in Source or
+ Object form, made available under the License, as indicated by a
+ copyright notice that is included in or attached to the work
+ (an example is provided in the Appendix below).
+
+ "Derivative Works" shall mean any work, whether in Source or Object
+ form, that is based on (or derived from) the Work and for which the
+ editorial revisions, annotations, elaborations, or other modifications
+ represent, as a whole, an original work of authorship. For the purposes
+ of this License, Derivative Works shall not include works that remain
+ separable from, or merely link (or bind by name) to the interfaces of,
+ the Work and Derivative Works thereof.
+
+ "Contribution" shall mean any work of authorship, including
+ the original version of the Work and any modifications or additions
+ to that Work or Derivative Works thereof, that is intentionally
+ submitted to Licensor for inclusion in the Work by the copyright owner
+ or by an individual or Legal Entity authorized to submit on behalf of
+ the copyright owner. For the purposes of this definition, "submitted"
+ means any form of electronic, verbal, or written communication sent
+ to the Licensor or its representatives, including but not limited to
+ communication on electronic mailing lists, source code control systems,
+ and issue tracking systems that are managed by, or on behalf of, the
+ Licensor for the purpose of discussing and improving the Work, but
+ excluding communication that is conspicuously marked or otherwise
+ designated in writing by the copyright owner as "Not a Contribution."
+
+ "Contributor" shall mean Licensor and any individual or Legal Entity
+ on behalf of whom a Contribution has been received by Licensor and
+ subsequently incorporated within the Work.
+
+ 2. Grant of Copyright License. Subject to the terms and conditions of
+ this License, each Contributor hereby grants to You a perpetual,
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+ copyright license to reproduce, prepare Derivative Works of,
+ publicly display, publicly perform, sublicense, and distribute the
+ Work and such Derivative Works in Source or Object form.
+
+ 3. Grant of Patent License. Subject to the terms and conditions of
+ this License, each Contributor hereby grants to You a perpetual,
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+ (except as stated in this section) patent license to make, have made,
+ use, offer to sell, sell, import, and otherwise transfer the Work,
+ where such license applies only to those patent claims licensable
+ by such Contributor that are necessarily infringed by their
+ Contribution(s) alone or by combination of their Contribution(s)
+ with the Work to which such Contribution(s) was submitted. If You
+ institute patent litigation against any entity (including a
+ cross-claim or counterclaim in a lawsuit) alleging that the Work
+ or a Contribution incorporated within the Work constitutes direct
+ or contributory patent infringement, then any patent licenses
+ granted to You under this License for that Work shall terminate
+ as of the date such litigation is filed.
+
+ 4. Redistribution. You may reproduce and distribute copies of the
+ Work or Derivative Works thereof in any medium, with or without
+ modifications, and in Source or Object form, provided that You
+ meet the following conditions:
+
+ (a) You must give any other recipients of the Work or
+ Derivative Works a copy of this License; and
+
+ (b) You must cause any modified files to carry prominent notices
+ stating that You changed the files; and
+
+ (c) You must retain, in the Source form of any Derivative Works
+ that You distribute, all copyright, patent, trademark, and
+ attribution notices from the Source form of the Work,
+ excluding those notices that do not pertain to any part of
+ the Derivative Works; and
+
+ (d) If the Work includes a "NOTICE" text file as part of its
+ distribution, then any Derivative Works that You distribute must
+ include a readable copy of the attribution notices contained
+ within such NOTICE file, excluding those notices that do not
+ pertain to any part of the Derivative Works, in at least one
+ of the following places: within a NOTICE text file distributed
+ as part of the Derivative Works; within the Source form or
+ documentation, if provided along with the Derivative Works; or,
+ within a display generated by the Derivative Works, if and
+ wherever such third-party notices normally appear. The contents
+ of the NOTICE file are for informational purposes only and
+ do not modify the License. You may add Your own attribution
+ notices within Derivative Works that You distribute, alongside
+ or as an addendum to the NOTICE text from the Work, provided
+ that such additional attribution notices cannot be construed
+ as modifying the License.
+
+ You may add Your own copyright statement to Your modifications and
+ may provide additional or different license terms and conditions
+ for use, reproduction, or distribution of Your modifications, or
+ for any such Derivative Works as a whole, provided Your use,
+ reproduction, and distribution of the Work otherwise complies with
+ the conditions stated in this License.
+
+ 5. Submission of Contributions. Unless You explicitly state otherwise,
+ any Contribution intentionally submitted for inclusion in the Work
+ by You to the Licensor shall be under the terms and conditions of
+ this License, without any additional terms or conditions.
+ Notwithstanding the above, nothing herein shall supersede or modify
+ the terms of any separate license agreement you may have executed
+ with Licensor regarding such Contributions.
+
+ 6. Trademarks. This License does not grant permission to use the trade
+ names, trademarks, service marks, or product names of the Licensor,
+ except as required for reasonable and customary use in describing the
+ origin of the Work and reproducing the content of the NOTICE file.
+
+ 7. Disclaimer of Warranty. Unless required by applicable law or
+ agreed to in writing, Licensor provides the Work (and each
+ Contributor provides its Contributions) on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied, including, without limitation, any warranties or conditions
+ of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+ PARTICULAR PURPOSE. You are solely responsible for determining the
+ appropriateness of using or redistributing the Work and assume any
+ risks associated with Your exercise of permissions under this License.
+
+ 8. Limitation of Liability. In no event and under no legal theory,
+ whether in tort (including negligence), contract, or otherwise,
+ unless required by applicable law (such as deliberate and grossly
+ negligent acts) or agreed to in writing, shall any Contributor be
+ liable to You for damages, including any direct, indirect, special,
+ incidental, or consequential damages of any character arising as a
+ result of this License or out of the use or inability to use the
+ Work (including but not limited to damages for loss of goodwill,
+ work stoppage, computer failure or malfunction, or any and all
+ other commercial damages or losses), even if such Contributor
+ has been advised of the possibility of such damages.
+
+ 9. Accepting Warranty or Additional Liability. While redistributing
+ the Work or Derivative Works thereof, You may choose to offer,
+ and charge a fee for, acceptance of support, warranty, indemnity,
+ or other liability obligations and/or rights consistent with this
+ License. However, in accepting such obligations, You may act only
+ on Your own behalf and on Your sole responsibility, not on behalf
+ of any other Contributor, and only if You agree to indemnify,
+ defend, and hold each Contributor harmless for any liability
+ incurred by, or claims asserted against, such Contributor by reason
+ of your accepting any such warranty or additional liability.
+
+ END OF TERMS AND CONDITIONS
+
+ APPENDIX: How to apply the Apache License to your work.
+
+ To apply the Apache License to your work, attach the following
+ boilerplate notice, with the fields enclosed by brackets "[]"
+ replaced with your own identifying information. (Don't include
+ the brackets!) The text should be enclosed in the appropriate
+ comment syntax for the file format. We also recommend that a
+ file or class name and description of purpose be included on the
+ same "printed page" as the copyright notice for easier
+ identification within third-party archives.
+
+ Copyright [yyyy] [name of copyright owner]
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+
+
+ libdav1d
+
+
+ Copyright © 2018-2019, VideoLAN and dav1d authors
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are met:
+
+ 1. Redistributions of source code must retain the above copyright notice, this
+ list of conditions and the following disclaimer.
+
+ 2. Redistributions in binary form must reproduce the above copyright notice,
+ this list of conditions and the following disclaimer in the documentation
+ and/or other materials provided with the distribution.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
+ ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+
+ linux-syscall-support
+
+
+ Copyright (c) 2005-2011, Google Inc.
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are
+ met:
+
+ * Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above
+ copyright notice, this list of conditions and the following disclaimer
+ in the documentation and/or other materials provided with the
+ distribution.
+ * Neither the name of Google Inc. nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+ ---
+ Author: Markus Gutschke
+
+
+
+ mini_chromium
+
+
+ // Copyright 2006-2008 The Chromium Authors. All rights reserved.
+ //
+ // Redistribution and use in source and binary forms, with or without
+ // modification, are permitted provided that the following conditions are
+ // met:
+ //
+ // * Redistributions of source code must retain the above copyright
+ // notice, this list of conditions and the following disclaimer.
+ // * Redistributions in binary form must reproduce the above
+ // copyright notice, this list of conditions and the following disclaimer
+ // in the documentation and/or other materials provided with the
+ // distribution.
+ // * Neither the name of Google Inc. nor the names of its
+ // contributors may be used to endorse or promote products derived from
+ // this software without specific prior written permission.
+ //
+ // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+
+ googletest
+
+
+ Copyright 2008, Google Inc.
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are
+ met:
+
+ * Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above
+ copyright notice, this list of conditions and the following disclaimer
+ in the documentation and/or other materials provided with the
+ distribution.
+ * Neither the name of Google Inc. nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/src/cobalt/debug/backend/debug_dispatcher.cc b/src/cobalt/debug/backend/debug_dispatcher.cc
index 4178c2f..e6643c6 100644
--- a/src/cobalt/debug/backend/debug_dispatcher.cc
+++ b/src/cobalt/debug/backend/debug_dispatcher.cc
@@ -107,7 +107,15 @@
}
DomainRegistry::iterator iter = domain_registry_.find(command.GetDomain());
- if (iter != domain_registry_.end()) {
+ if (iter == domain_registry_.end()) {
+ // If the domain isn't even registered, return an error without even trying
+ // to run a C++ or JS command implementation. This helps avoid problems when
+ // commands are received during navigation before agents are ready.
+ std::string err = command.GetDomain() + " domain not supported";
+ DLOG(WARNING) << err << " (" << command.GetMethod() << ")";
+ command.SendErrorResponse(Command::kMethodNotFound, err);
+ return;
+ } else {
auto opt_command = iter->second.Run(std::move(command));
// The agent command implementation kept the command to send the response.
if (!opt_command) return;
diff --git a/src/cobalt/debug/backend/debugger_hooks_impl.cc b/src/cobalt/debug/backend/debugger_hooks_impl.cc
index 6cff320..46f1e33 100644
--- a/src/cobalt/debug/backend/debugger_hooks_impl.cc
+++ b/src/cobalt/debug/backend/debugger_hooks_impl.cc
@@ -37,6 +37,9 @@
} // namespace
+DebuggerHooksImpl::DebuggerHooksImpl()
+ : message_loop_(base::MessageLoop::current()) {}
+
void DebuggerHooksImpl::AttachDebugger(
script::ScriptDebugger* script_debugger) {
script_debugger_ = script_debugger;
@@ -51,6 +54,13 @@
void DebuggerHooksImpl::ConsoleLog(::logging::LogSeverity severity,
std::string message) const {
+ if (base::MessageLoop::current() != message_loop_) {
+ message_loop_->task_runner()->PostTask(
+ FROM_HERE, base::Bind(&DebuggerHooksImpl::ConsoleLog,
+ base::Unretained(this), severity, message));
+ return;
+ }
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (!script_debugger_) return;
std::ostringstream js_code;
js_code << "console." << kConsoleMethodName[severity] << '('
@@ -61,6 +71,7 @@
void DebuggerHooksImpl::AsyncTaskScheduled(const void* task,
const std::string& name,
AsyncTaskFrequency frequency) const {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (script_debugger_) {
script_debugger_->AsyncTaskScheduled(
task, name, (frequency == AsyncTaskFrequency::kRecurring));
@@ -68,18 +79,21 @@
}
void DebuggerHooksImpl::AsyncTaskStarted(const void* task) const {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (script_debugger_) {
script_debugger_->AsyncTaskStarted(task);
}
}
void DebuggerHooksImpl::AsyncTaskFinished(const void* task) const {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (script_debugger_) {
script_debugger_->AsyncTaskFinished(task);
}
}
void DebuggerHooksImpl::AsyncTaskCanceled(const void* task) const {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (script_debugger_) {
script_debugger_->AsyncTaskCanceled(task);
}
diff --git a/src/cobalt/debug/backend/debugger_hooks_impl.h b/src/cobalt/debug/backend/debugger_hooks_impl.h
index ef5928b..2675654 100644
--- a/src/cobalt/debug/backend/debugger_hooks_impl.h
+++ b/src/cobalt/debug/backend/debugger_hooks_impl.h
@@ -16,6 +16,8 @@
#include <string>
+#include "base/message_loop/message_loop.h"
+#include "base/threading/thread_checker.h"
#include "cobalt/base/debugger_hooks.h"
namespace cobalt {
@@ -31,6 +33,8 @@
class DebuggerHooksImpl : public base::DebuggerHooks {
public:
+ DebuggerHooksImpl();
+
void ConsoleLog(::logging::LogSeverity severity,
std::string message) const override;
@@ -47,6 +51,10 @@
void AttachDebugger(script::ScriptDebugger* script_debugger);
void DetachDebugger();
+ // Message loop of the web module these hooks were created on.
+ base::MessageLoop* message_loop_;
+ THREAD_CHECKER(thread_checker_);
+
script::ScriptDebugger* script_debugger_ = nullptr;
};
diff --git a/src/cobalt/debug/backend/tracing_agent.cc b/src/cobalt/debug/backend/tracing_agent.cc
index 666fb7f..1e10129 100644
--- a/src/cobalt/debug/backend/tracing_agent.cc
+++ b/src/cobalt/debug/backend/tracing_agent.cc
@@ -14,9 +14,8 @@
#include "cobalt/debug/backend/tracing_agent.h"
-#include <vector>
-
#include "base/bind.h"
+#include "base/values.h"
#include "cobalt/script/script_debugger.h"
namespace cobalt {
@@ -28,6 +27,10 @@
// https://chromedevtools.github.io/devtools-protocol/tot/Tracing
constexpr char kInspectorDomain[] = "Tracing";
+// State parameters
+constexpr char kStarted[] = "started";
+constexpr char kCategories[] = "categories";
+
// Size in characters of JSON to batch dataCollected events.
constexpr size_t kDataCollectedSize = 24 * 1024;
} // namespace
@@ -47,11 +50,36 @@
void TracingAgent::Thaw(JSONObject agent_state) {
dispatcher_->AddDomain(kInspectorDomain, commands_.Bind());
+ if (!agent_state) return;
+
+ // Restore state
+ categories_.clear();
+ for (const auto& category : agent_state->FindKey(kCategories)->GetList()) {
+ categories_.emplace_back(category.GetString());
+ }
+ tracing_started_ = agent_state->FindKey(kStarted)->GetBool();
+ if (tracing_started_) {
+ script_debugger_->StartTracing(categories_, this);
+ }
}
JSONObject TracingAgent::Freeze() {
+ if (tracing_started_) {
+ script_debugger_->StopTracing();
+ }
+
dispatcher_->RemoveDomain(kInspectorDomain);
- return JSONObject();
+
+ // Save state
+ JSONObject agent_state(new base::DictionaryValue());
+ agent_state->SetKey(kStarted, base::Value(tracing_started_));
+ base::Value::ListStorage categories_list;
+ for (const auto& category : categories_) {
+ categories_list.emplace_back(category);
+ }
+ agent_state->SetKey(kCategories, base::Value(std::move(categories_list)));
+
+ return agent_state;
}
void TracingAgent::End(Command command) {
@@ -61,6 +89,7 @@
return;
}
tracing_started_ = false;
+ categories_.clear();
command.SendResponse();
script_debugger_->StopTracing();
@@ -73,23 +102,23 @@
"Tracing already started");
return;
}
- tracing_started_ = true;
JSONObject params = JSONParse(command.GetParams());
// Parse comma-separated tracing categories parameter.
- std::vector<std::string> categories;
+ categories_.clear();
std::string category_param;
if (params->GetString("categories", &category_param)) {
for (size_t pos = 0, comma; pos < category_param.size(); pos = comma + 1) {
comma = category_param.find(',', pos);
if (comma == std::string::npos) comma = category_param.size();
std::string category = category_param.substr(pos, comma - pos);
- categories.push_back(category);
+ categories_.push_back(category);
}
}
- script_debugger_->StartTracing(categories, this);
+ tracing_started_ = true;
+ script_debugger_->StartTracing(categories_, this);
command.SendResponse();
}
diff --git a/src/cobalt/debug/backend/tracing_agent.h b/src/cobalt/debug/backend/tracing_agent.h
index bf114c8..a9c0bda 100644
--- a/src/cobalt/debug/backend/tracing_agent.h
+++ b/src/cobalt/debug/backend/tracing_agent.h
@@ -16,6 +16,7 @@
#define COBALT_DEBUG_BACKEND_TRACING_AGENT_H_
#include <string>
+#include <vector>
#include "base/threading/thread_checker.h"
#include "base/time/time.h"
@@ -56,6 +57,7 @@
THREAD_CHECKER(thread_checker_);
bool tracing_started_;
+ std::vector<std::string> categories_;
size_t collected_size_;
JSONList collected_events_;
diff --git a/src/cobalt/demos/demos.gyp b/src/cobalt/demos/demos.gyp
index def2599..502ec45 100644
--- a/src/cobalt/demos/demos.gyp
+++ b/src/cobalt/demos/demos.gyp
@@ -22,7 +22,7 @@
'type': 'none',
'variables': {
'content_test_input_files': [ '<(DEPTH)/cobalt/demos/content/' ],
- 'content_test_output_subdir': 'cobalt/demos',
+ 'content_test_output_subdir': 'demos',
},
'includes': ['<(DEPTH)/starboard/build/copy_test_data.gypi'],
},
diff --git a/src/cobalt/demos/readme.md b/src/cobalt/demos/readme.md
index fe530f6..11d511c 100644
--- a/src/cobalt/demos/readme.md
+++ b/src/cobalt/demos/readme.md
@@ -9,12 +9,8 @@
These html pages can be executed by running cobalt and pointing the `--url`
parameter to the file in question. For example:
-`out/.../cobalt.exe --url=file:///cobalt/demos/transparent-animated-webp-demo/index.html`
+`out/.../cobalt --url=file:///demos/transparent-animated-webp-demo/index.html`
-Note that `file:///cobalt/demos` maps to the `src/out/<PLATFORM>/content/data/test/cobalt/demos`
-directory, whose contents are copied from the `src/cobalt/demos/content` source directory when
-`ninja cobalt_with_demos` is run
-
-## HTML test runner
-
-To assist in running the html tests the interactive `html_test_runner.py` in this directory.
+Note that `file:///demos` maps to the `src/out/<PLATFORM>/content/test/demos`
+directory, whose contents are copied from the `src/cobalt/demos/content` source
+directory when `ninja cobalt_with_demos` is run.
diff --git a/src/cobalt/dom/custom_event_test.cc b/src/cobalt/dom/custom_event_test.cc
index e68d44d..ee0b08f 100644
--- a/src/cobalt/dom/custom_event_test.cc
+++ b/src/cobalt/dom/custom_event_test.cc
@@ -64,9 +64,9 @@
css_parser_(css_parser::Parser::Create()),
dom_parser_(new dom_parser::Parser(mock_error_callback_)),
fetcher_factory_(new loader::FetcherFactory(NULL)),
- loader_factory_(
- new loader::LoaderFactory("Test", fetcher_factory_.get(), NULL, 0,
- base::ThreadPriority::DEFAULT)),
+ loader_factory_(new loader::LoaderFactory(
+ "Test", fetcher_factory_.get(), NULL, null_debugger_hooks_, 0,
+ base::ThreadPriority::DEFAULT)),
local_storage_database_(NULL),
url_("about:blank") {
engine_ = script::JavaScriptEngine::CreateEngine();
@@ -96,6 +96,7 @@
private:
base::MessageLoop message_loop_;
+ base::NullDebuggerHooks null_debugger_hooks_;
std::unique_ptr<script::JavaScriptEngine> engine_;
const std::unique_ptr<testing::StubEnvironmentSettings> environment_settings_;
scoped_refptr<script::GlobalEnvironment> global_environment_;
diff --git a/src/cobalt/dom/dom_parser_test.cc b/src/cobalt/dom/dom_parser_test.cc
index 4d159e3..8f8b5b8 100644
--- a/src/cobalt/dom/dom_parser_test.cc
+++ b/src/cobalt/dom/dom_parser_test.cc
@@ -37,6 +37,7 @@
~DOMParserTest() override {}
testing::StubEnvironmentSettings environment_settings_;
+ base::NullDebuggerHooks null_debugger_hooks_;
loader::FetcherFactory fetcher_factory_;
loader::LoaderFactory loader_factory_;
testing::StubCSSParser stub_css_parser_;
@@ -48,9 +49,10 @@
DOMParserTest::DOMParserTest()
: fetcher_factory_(NULL /* network_module */),
- loader_factory_(
- "Test" /* name */, &fetcher_factory_, NULL /* resource provider */,
- 0 /* encoded_image_cache_capacity */, base::ThreadPriority::DEFAULT),
+ loader_factory_("Test" /* name */, &fetcher_factory_,
+ NULL /* resource provider */, null_debugger_hooks_,
+ 0 /* encoded_image_cache_capacity */,
+ base::ThreadPriority::DEFAULT),
dom_parser_parser_(new dom_parser::Parser()),
html_element_context_(
&environment_settings_, &fetcher_factory_, &loader_factory_,
diff --git a/src/cobalt/dom/error_event_test.cc b/src/cobalt/dom/error_event_test.cc
index c4d4c7c..937cd45 100644
--- a/src/cobalt/dom/error_event_test.cc
+++ b/src/cobalt/dom/error_event_test.cc
@@ -64,9 +64,9 @@
css_parser_(css_parser::Parser::Create()),
dom_parser_(new dom_parser::Parser(mock_load_complete_callback_)),
fetcher_factory_(new loader::FetcherFactory(NULL)),
- loader_factory_(
- new loader::LoaderFactory("Test", fetcher_factory_.get(), NULL, 0,
- base::ThreadPriority::DEFAULT)),
+ loader_factory_(new loader::LoaderFactory(
+ "Test", fetcher_factory_.get(), NULL, null_debugger_hooks_, 0,
+ base::ThreadPriority::DEFAULT)),
local_storage_database_(NULL),
url_("about:blank") {
engine_ = script::JavaScriptEngine::CreateEngine();
@@ -99,6 +99,7 @@
private:
base::MessageLoop message_loop_;
+ base::NullDebuggerHooks null_debugger_hooks_;
std::unique_ptr<script::JavaScriptEngine> engine_;
const std::unique_ptr<testing::StubEnvironmentSettings> environment_settings_;
scoped_refptr<script::GlobalEnvironment> global_environment_;
diff --git a/src/cobalt/dom/font_cache_test.cc b/src/cobalt/dom/font_cache_test.cc
index 4b86968..49656eb 100644
--- a/src/cobalt/dom/font_cache_test.cc
+++ b/src/cobalt/dom/font_cache_test.cc
@@ -12,10 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include <memory>
-
#include "cobalt/dom/font_cache.h"
+#include <memory>
+
#include "base/bind.h"
#include "base/memory/ref_counted.h"
#include "cobalt/csp/content_security_policy.h"
@@ -66,6 +66,7 @@
void DummyOnTypefaceLoadEvent() {}
protected:
+ base::NullDebuggerHooks debugger_hooks_;
::testing::StrictMock<loader::MockLoaderFactory> loader_factory_;
scoped_refptr<cobalt::render_tree::Typeface> sample_typeface_;
::testing::StrictMock<cobalt::render_tree::MockResourceProvider>
@@ -82,7 +83,7 @@
mrp(dynamic_cast<cobalt::render_tree::ResourceProvider*>(
&mock_resource_provider_)),
rtc(new loader::font::RemoteTypefaceCache(
- "test_cache", 32 * 1024 /* 32 KB */,
+ "test_cache", debugger_hooks_, 32 * 1024 /* 32 KB */,
true /*are_loading_retries_enabled*/,
base::Bind(&loader::MockLoaderFactory::CreateTypefaceLoader,
base::Unretained(&loader_factory_)))),
diff --git a/src/cobalt/dom/html_element.cc b/src/cobalt/dom/html_element.cc
index ad0c2b8..c2a30ca 100644
--- a/src/cobalt/dom/html_element.cc
+++ b/src/cobalt/dom/html_element.cc
@@ -21,6 +21,7 @@
#include "base/lazy_instance.h"
#include "base/message_loop/message_loop_task_runner.h"
#include "base/strings/string_number_conversions.h"
+#include "cobalt/base/console_log.h"
#include "cobalt/base/tokens.h"
#include "cobalt/cssom/absolute_url_value.h"
#include "cobalt/cssom/cascaded_style.h"
@@ -526,6 +527,9 @@
node_document()->DoSynchronousLayout();
if (!ui_nav_item_ || !ui_nav_item_->IsContainer()) {
+ CLOG(WARNING, debugger_hooks())
+ << "scrollLeft only works on HTML elements with 'overflow' set to "
+ << "'scroll' or 'auto'";
return;
}
@@ -575,6 +579,9 @@
node_document()->DoSynchronousLayout();
if (!ui_nav_item_ || !ui_nav_item_->IsContainer()) {
+ CLOG(WARNING, debugger_hooks())
+ << "scrollTop only works on HTML elements with 'overflow' set to "
+ << "'scroll' or 'auto'";
return;
}
diff --git a/src/cobalt/dom/html_element_factory_test.cc b/src/cobalt/dom/html_element_factory_test.cc
index e088077..c4cb2de 100644
--- a/src/cobalt/dom/html_element_factory_test.cc
+++ b/src/cobalt/dom/html_element_factory_test.cc
@@ -57,7 +57,7 @@
HTMLElementFactoryTest()
: fetcher_factory_(NULL /* network_module */),
loader_factory_("Test" /* name */, &fetcher_factory_,
- NULL /* resource loader */,
+ NULL /* resource loader */, null_debugger_hooks_,
0 /* encoded_image_cache_capacity */,
base::ThreadPriority::DEFAULT),
dom_parser_(new dom_parser::Parser()),
@@ -79,6 +79,7 @@
~HTMLElementFactoryTest() override {}
testing::StubEnvironmentSettings environment_settings_;
+ base::NullDebuggerHooks null_debugger_hooks_;
loader::FetcherFactory fetcher_factory_;
loader::LoaderFactory loader_factory_;
std::unique_ptr<Parser> dom_parser_;
diff --git a/src/cobalt/dom/lottie_player.cc b/src/cobalt/dom/lottie_player.cc
index efd6ebb..fdd508e 100644
--- a/src/cobalt/dom/lottie_player.cc
+++ b/src/cobalt/dom/lottie_player.cc
@@ -82,6 +82,18 @@
SetAttribute("direction", base::Int32ToString(direction));
}
+bool LottiePlayer::hover() const { return GetBooleanAttribute("hover"); }
+
+void LottiePlayer::set_hover(bool hover) {
+ // The value of 'hover' is true when the 'hover' attribute is present.
+ // The value of the attribute is irrelevant.
+ if (hover) {
+ SetBooleanAttribute("hover", true);
+ } else {
+ SetBooleanAttribute("hover", false);
+ }
+}
+
bool LottiePlayer::loop() const { return properties_.loop; }
void LottiePlayer::set_loop(bool loop) {
@@ -199,6 +211,18 @@
return properties_;
}
+void LottiePlayer::OnHover() {
+ if (hover()) {
+ UpdateState(LottieAnimation::LottieState::kPlaying);
+ }
+}
+
+void LottiePlayer::OnUnHover() {
+ if (hover()) {
+ UpdateState(LottieAnimation::LottieState::kStopped);
+ }
+}
+
void LottiePlayer::PurgeCachedBackgroundImagesOfNodeAndDescendants() {
if (!cached_image_loaded_callback_handler_) {
return;
@@ -435,6 +459,14 @@
properties_.onenterframe_callback = base::Bind(
&LottiePlayer::CallOnEnterFrame, callback_task_runner_,
base::Bind(&LottiePlayer::OnEnterFrame, base::AsWeakPtr(this)));
+ properties_.onfreeze_callback =
+ base::Bind(base::IgnoreResult(&base::SingleThreadTaskRunner::PostTask),
+ callback_task_runner_, FROM_HERE,
+ base::Bind(&LottiePlayer::OnFreeze, base::AsWeakPtr(this)));
+ properties_.onunfreeze_callback =
+ base::Bind(base::IgnoreResult(&base::SingleThreadTaskRunner::PostTask),
+ callback_task_runner_, FROM_HERE,
+ base::Bind(&LottiePlayer::OnUnfreeze, base::AsWeakPtr(this)));
}
void LottiePlayer::OnPlay() { ScheduleEvent(base::Tokens::play()); }
@@ -467,5 +499,19 @@
FROM_HERE, base::Bind(enter_frame_callback, frame, seeker));
}
+void LottiePlayer::OnFreeze() {
+ if (properties_.FreezeAnimationState()) {
+ ScheduleEvent(base::Tokens::freeze());
+ UpdateLottieObjects();
+ }
+}
+
+void LottiePlayer::OnUnfreeze() {
+ if (properties_.UnfreezeAnimationState()) {
+ ScheduleEvent(base::Tokens::play());
+ UpdateLottieObjects();
+ }
+}
+
} // namespace dom
} // namespace cobalt
diff --git a/src/cobalt/dom/lottie_player.h b/src/cobalt/dom/lottie_player.h
index bd3358b..c28fb0b 100644
--- a/src/cobalt/dom/lottie_player.h
+++ b/src/cobalt/dom/lottie_player.h
@@ -59,6 +59,8 @@
void set_count(int count);
int direction() const;
void set_direction(int direction);
+ bool hover() const;
+ void set_hover(bool hover);
bool loop() const;
void set_loop(bool loop);
std::string mode() const;
@@ -89,6 +91,11 @@
LottieAnimation::LottieProperties GetProperties() const;
+ // These functions will be called when there is a hover change for the
+ // element.
+ void OnHover();
+ void OnUnHover();
+
DEFINE_WRAPPABLE_TYPE(LottiePlayer);
private:
@@ -137,6 +144,8 @@
scoped_refptr<base::SingleThreadTaskRunner> callback_task_runner,
base::Callback<void(double, double)> enter_frame_callback, double frame,
double seeker);
+ void OnFreeze();
+ void OnUnfreeze();
scoped_refptr<loader::image::CachedImage> cached_image_;
std::unique_ptr<loader::image::CachedImage::OnLoadedCallbackHandler>
diff --git a/src/cobalt/dom/lottie_player.idl b/src/cobalt/dom/lottie_player.idl
index 1a80f0e..9ee1cd7 100644
--- a/src/cobalt/dom/lottie_player.idl
+++ b/src/cobalt/dom/lottie_player.idl
@@ -22,6 +22,7 @@
attribute DOMString background;
attribute long count;
attribute long direction;
+ attribute boolean hover;
attribute DOMString mode;
attribute boolean loop;
attribute double speed;
diff --git a/src/cobalt/dom/on_screen_keyboard_test.cc b/src/cobalt/dom/on_screen_keyboard_test.cc
index 7a98f60..9493146 100644
--- a/src/cobalt/dom/on_screen_keyboard_test.cc
+++ b/src/cobalt/dom/on_screen_keyboard_test.cc
@@ -197,9 +197,9 @@
css_parser_(css_parser::Parser::Create()),
dom_parser_(new dom_parser::Parser(mock_error_callback_)),
fetcher_factory_(new loader::FetcherFactory(NULL)),
- loader_factory_(
- new loader::LoaderFactory("Test", fetcher_factory_.get(), NULL, 0,
- base::ThreadPriority::DEFAULT)),
+ loader_factory_(new loader::LoaderFactory(
+ "Test", fetcher_factory_.get(), NULL, null_debugger_hooks_, 0,
+ base::ThreadPriority::DEFAULT)),
local_storage_database_(NULL),
url_("about:blank"),
engine_(script::JavaScriptEngine::CreateEngine()),
@@ -263,6 +263,7 @@
private:
const std::unique_ptr<testing::StubEnvironmentSettings> environment_settings_;
+ base::NullDebuggerHooks null_debugger_hooks_;
base::MessageLoop message_loop_;
MockErrorCallback mock_error_callback_;
std::unique_ptr<css_parser::Parser> css_parser_;
@@ -708,8 +709,7 @@
)";
EXPECT_TRUE(EvaluateScript(script, NULL));
}
-#else // SB_API_VERSION >= 12 ||
- // SB_HAS(ON_SCREEN_KEYBOARD)
+#else // SB_API_VERSION >= 12 || SB_HAS(ON_SCREEN_KEYBOARD)
TEST_F(OnScreenKeyboardTest, ObjectDoesntExist) {
std::string result;
@@ -738,8 +738,7 @@
EXPECT_TRUE(EvaluateScript(object_script, &result));
EXPECT_EQ("true", result);
}
-#endif // SB_API_VERSION >= 12 ||
- // SB_HAS(ON_SCREEN_KEYBOARD)
+#endif // SB_API_VERSION >= 12 || SB_HAS(ON_SCREEN_KEYBOARD)
} // namespace dom
} // namespace cobalt
diff --git a/src/cobalt/dom/testing/stub_window.h b/src/cobalt/dom/testing/stub_window.h
index 118a010..7377579 100644
--- a/src/cobalt/dom/testing/stub_window.h
+++ b/src/cobalt/dom/testing/stub_window.h
@@ -53,9 +53,9 @@
dom_parser_(
new dom_parser::Parser(base::Bind(&StubLoadCompleteCallback))),
fetcher_factory_(new loader::FetcherFactory(NULL)),
- loader_factory_(
- new loader::LoaderFactory("Test", fetcher_factory_.get(), NULL, 0,
- base::ThreadPriority::DEFAULT)),
+ loader_factory_(new loader::LoaderFactory(
+ "Test", fetcher_factory_.get(), NULL, null_debugger_hooks_, 0,
+ base::ThreadPriority::DEFAULT)),
local_storage_database_(NULL),
url_("about:blank"),
dom_stat_tracker_(new dom::DomStatTracker("StubWindow")) {
@@ -106,6 +106,7 @@
const base::Optional<std::string>& error) {}
base::MessageLoop message_loop_;
+ base::NullDebuggerHooks null_debugger_hooks_;
std::unique_ptr<css_parser::Parser> css_parser_;
std::unique_ptr<dom_parser::Parser> dom_parser_;
std::unique_ptr<loader::FetcherFactory> fetcher_factory_;
@@ -116,7 +117,6 @@
std::unique_ptr<script::EnvironmentSettings> environment_settings_;
std::unique_ptr<script::JavaScriptEngine> engine_;
scoped_refptr<script::GlobalEnvironment> global_environment_;
- base::NullDebuggerHooks null_debugger_hooks_;
scoped_refptr<dom::Window> window_;
};
diff --git a/src/cobalt/dom_parser/html_decoder_test.cc b/src/cobalt/dom_parser/html_decoder_test.cc
index 79736fd..d222a35 100644
--- a/src/cobalt/dom_parser/html_decoder_test.cc
+++ b/src/cobalt/dom_parser/html_decoder_test.cc
@@ -54,6 +54,7 @@
~HTMLDecoderTest() override {}
dom::testing::StubEnvironmentSettings environment_settings_;
+ base::NullDebuggerHooks null_debugger_hooks_;
loader::FetcherFactory fetcher_factory_;
loader::LoaderFactory loader_factory_;
std::unique_ptr<Parser> dom_parser_;
@@ -71,9 +72,10 @@
HTMLDecoderTest::HTMLDecoderTest()
: fetcher_factory_(NULL /* network_module */),
- loader_factory_(
- "Test" /* name */, &fetcher_factory_, NULL /* ResourceProvider */,
- 0 /* encoded_image_cache_capacity */, base::ThreadPriority::DEFAULT),
+ loader_factory_("Test" /* name */, &fetcher_factory_,
+ NULL /* ResourceProvider */, null_debugger_hooks_,
+ 0 /* encoded_image_cache_capacity */,
+ base::ThreadPriority::DEFAULT),
dom_parser_(new Parser()),
dom_stat_tracker_(new dom::DomStatTracker("HTMLDecoderTest")),
html_element_context_(
diff --git a/src/cobalt/extension/extension_test.cc b/src/cobalt/extension/extension_test.cc
index bad7015..3756cba 100644
--- a/src/cobalt/extension/extension_test.cc
+++ b/src/cobalt/extension/extension_test.cc
@@ -106,7 +106,10 @@
EXPECT_TRUE(extension_api->RequestRollForwardToInstallation != NULL);
EXPECT_TRUE(extension_api->GetInstallationPath != NULL);
EXPECT_TRUE(extension_api->SelectNewInstallationIndex != NULL);
-
+ EXPECT_TRUE(extension_api->GetAppKey != NULL);
+ EXPECT_TRUE(extension_api->GetMaxNumberInstallations != NULL);
+ EXPECT_TRUE(extension_api->ResetInstallation != NULL);
+ EXPECT_TRUE(extension_api->Reset != NULL);
const ExtensionApi* second_extension_api =
static_cast<const ExtensionApi*>(SbSystemGetExtension(kExtensionName));
EXPECT_EQ(second_extension_api, extension_api)
diff --git a/src/cobalt/extension/installation_manager.h b/src/cobalt/extension/installation_manager.h
index 6f1e13b..9c96781 100644
--- a/src/cobalt/extension/installation_manager.h
+++ b/src/cobalt/extension/installation_manager.h
@@ -19,6 +19,7 @@
#include "starboard/configuration.h"
+#define IM_EXT_MAX_APP_KEY_LENGTH 1024
#define IM_EXT_INVALID_INDEX -1
#define IM_EXT_ERROR -1
#define IM_EXT_SUCCESS 0
@@ -41,12 +42,17 @@
// Installation Manager API wrapper.
// For more details, check:
// starboard/loader_app/installation_manager.h
+
int (*GetCurrentInstallationIndex)();
int (*MarkInstallationSuccessful)(int installation_index);
int (*RequestRollForwardToInstallation)(int installation_index);
int (*GetInstallationPath)(int installation_index, char* path,
int path_length);
int (*SelectNewInstallationIndex)();
+ int (*GetAppKey)(char* app_key, int app_key_length);
+ int (*GetMaxNumberInstallations)();
+ int (*ResetInstallation)(int installation_index);
+ int (*Reset)();
} CobaltExtensionInstallationManagerApi;
#ifdef __cplusplus
diff --git a/src/cobalt/h5vcc/h5vcc_settings.cc b/src/cobalt/h5vcc/h5vcc_settings.cc
index a8e8280..a0fdce7 100644
--- a/src/cobalt/h5vcc/h5vcc_settings.cc
+++ b/src/cobalt/h5vcc/h5vcc_settings.cc
@@ -33,10 +33,10 @@
}
if (SbStringCompare(name.c_str(), kQUIC, sizeof(kQUIC) - 1) == 0) {
- if (value != 0 || !network_module_) {
+ if (!network_module_) {
return false;
} else {
- network_module_->DisableQuic();
+ network_module_->SetEnableQuic(value != 0);
return true;
}
}
diff --git a/src/cobalt/h5vcc/h5vcc_updater.cc b/src/cobalt/h5vcc/h5vcc_updater.cc
index 82aa9de..7441e70 100644
--- a/src/cobalt/h5vcc/h5vcc_updater.cc
+++ b/src/cobalt/h5vcc/h5vcc_updater.cc
@@ -18,10 +18,18 @@
namespace h5vcc {
std::string H5vccUpdater::GetUpdaterChannel() const {
+ if (!updater_module_) {
+ return "";
+ }
+
return updater_module_->GetUpdaterChannel();
}
void H5vccUpdater::SetUpdaterChannel(const std::string& channel) {
+ if (!updater_module_) {
+ return;
+ }
+
if (updater_module_->GetUpdaterChannel().compare(channel) != 0 &&
updater_module_->IsChannelValid(channel)) {
updater_module_->SetUpdaterChannel(channel);
@@ -31,6 +39,10 @@
}
std::string H5vccUpdater::GetUpdateStatus() const {
+ if (!updater_module_) {
+ return "";
+ }
+
return updater_module_->GetUpdaterStatus();
}
diff --git a/src/cobalt/layout/box_generator.cc b/src/cobalt/layout/box_generator.cc
index c72355d..c622e99 100644
--- a/src/cobalt/layout/box_generator.cc
+++ b/src/cobalt/layout/box_generator.cc
@@ -451,6 +451,12 @@
// This behavior cannot be overridden by setting the "display" property on
// the descendants.
// https://www.w3.org/TR/CSS21/visuren.html#display-prop
+
+ // A LottiePlayer element with "display: none" should potentially trigger
+ // a freeze event.
+ if (!lottie_player->GetProperties().onfreeze_callback.is_null()) {
+ lottie_player->GetProperties().onfreeze_callback.Run();
+ }
return;
}
diff --git a/src/cobalt/layout/intersection_observer_target.cc b/src/cobalt/layout/intersection_observer_target.cc
index a82d1f2..26d863d 100644
--- a/src/cobalt/layout/intersection_observer_target.cc
+++ b/src/cobalt/layout/intersection_observer_target.cc
@@ -69,17 +69,17 @@
// Let intersectionArea be intersectionRect's area.
float intersection_area = intersection_rect.size().GetArea();
+ // Let isIntersecting be true if targetRect and rootBounds intersect or are
+ // edge-adjacent, even if the intersection has zero area (because rootBounds
+ // or targetRect have zero area); otherwise, let isIntersecting be false.
+ bool is_intersecting =
+ intersection_rect.width() != 0 || intersection_rect.height() != 0;
+
// If targetArea is non-zero, let intersectionRatio be intersectionArea
// divided by targetArea. Otherwise, let intersectionRatio be 1 if
- // targetRect and rootBounds are edge-adjacent (in the case that targetRect or
- // rootbounds have zero area), and 0 otherwise.
- float intersection_ratio =
- (intersection_rect.width() != 0 || intersection_rect.height() != 0)
- ? 1.0f
- : 0.0f;
- if (target_area != 0) {
- intersection_ratio = intersection_area / target_area;
- }
+ // isIntersecting is true, or 0 if isIntersecting is false.
+ float intersection_ratio = target_area > 0 ? intersection_area / target_area
+ : is_intersecting ? 1.0f : 0.0f;
// Let thresholdIndex be the index of the first entry in observer.thresholds
// whose value is greater than intersectionRatio, or the length of
@@ -91,13 +91,15 @@
for (threshold_index = 0; threshold_index < thresholds.size();
++threshold_index) {
if (thresholds.at(threshold_index) > intersection_ratio) {
+ // isIntersecting is false if intersectionRatio is less than all
+ // thresholds, sorted ascending. Not in spec but follows Chrome behavior.
+ if (threshold_index == 0) {
+ is_intersecting = false;
+ }
break;
}
}
- // Set isIntersecting to true if |threshold_index| > 0, and false otherwise.
- bool is_intersecting = threshold_index > 0;
-
// If thresholdIndex does not equal previousThresholdIndex or if
// isIntersecting does not equal previousIsIntersecting, queue an
// IntersectionObserverEntry, passing in observer, time, rootBounds,
diff --git a/src/cobalt/layout/replaced_box.cc b/src/cobalt/layout/replaced_box.cc
index 6a8850d..c420851 100644
--- a/src/cobalt/layout/replaced_box.cc
+++ b/src/cobalt/layout/replaced_box.cc
@@ -297,7 +297,7 @@
render_tree::LottieAnimation* lottie =
base::polymorphic_downcast<render_tree::LottieAnimation*>(
animation.get());
- lottie->SetProperties(lottie_properties);
+ lottie->BeginRenderFrame(lottie_properties);
node_builder->animation = lottie;
node_builder->destination_rect = destination_rect;
node_builder->animation_time = time_elapsed;
diff --git a/src/cobalt/layout/topmost_event_target.cc b/src/cobalt/layout/topmost_event_target.cc
index 1bf8f12..75b106d 100644
--- a/src/cobalt/layout/topmost_event_target.cc
+++ b/src/cobalt/layout/topmost_event_target.cc
@@ -23,6 +23,7 @@
#include "cobalt/dom/event.h"
#include "cobalt/dom/html_element.h"
#include "cobalt/dom/html_html_element.h"
+#include "cobalt/dom/lottie_player.h"
#include "cobalt/dom/mouse_event.h"
#include "cobalt/dom/mouse_event_init.h"
#include "cobalt/dom/pointer_event.h"
@@ -144,6 +145,11 @@
// Send out and leave events.
if (previous_element) {
+ // LottiePlayer elements may change playback state.
+ if (previous_element->AsLottiePlayer()) {
+ previous_element->AsLottiePlayer()->OnUnHover();
+ }
+
event_init->set_related_target(target_element);
if (is_pointer_event) {
previous_element->DispatchEvent(new dom::PointerEvent(
@@ -190,6 +196,11 @@
// Send over and enter events.
if (target_element) {
+ // LottiePlayer elements may change playback state.
+ if (target_element->AsLottiePlayer()) {
+ target_element->AsLottiePlayer()->OnHover();
+ }
+
event_init->set_related_target(previous_element);
if (is_pointer_event) {
target_element->DispatchEvent(new dom::PointerEvent(
diff --git a/src/cobalt/layout_tests/testdata/intersection-observer/layout_tests.txt b/src/cobalt/layout_tests/testdata/intersection-observer/layout_tests.txt
index 6f3f547..1236809 100644
--- a/src/cobalt/layout_tests/testdata/intersection-observer/layout_tests.txt
+++ b/src/cobalt/layout_tests/testdata/intersection-observer/layout_tests.txt
@@ -5,7 +5,8 @@
intersection-ratio-is-nonzero-but-is-intersecting-is-false
multiple-observers-with-different-roots-and-targets
no-intersection-when-root-is-not-in-containing-block-chain-of-target
-observers-should-update-when-elements-move
+observers-should-update-when-elements-move-with-threshold
+observers-should-update-when-elements-move-without-threshold
previous-threshold-index-and-is-intersecting-fields-should-be-updated
root-has-nonzero-padding-and-border
root-has-nonzero-padding-and-border-and-overflow-clip
diff --git a/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-expected.png b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-with-threshold-expected.png
similarity index 100%
rename from src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-expected.png
rename to src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-with-threshold-expected.png
Binary files differ
diff --git a/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move.html b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-with-threshold.html
similarity index 66%
rename from src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move.html
rename to src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-with-threshold.html
index eb74022..6e72540 100644
--- a/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move.html
+++ b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-with-threshold.html
@@ -50,6 +50,9 @@
entry.target.style.backgroundColor = "green";
}
});
+ if (window.testRunner) {
+ window.testRunner.DoNonMeasuredLayout();
+ }
}
var options = {
@@ -65,15 +68,25 @@
window.testRunner.DoNonMeasuredLayout();
}
- // Move the target element so that the intersection ratio now crosses
- // the threshold value. An intersection observer update should be
- // triggered and the callback should run.
- targetElement.style.top = "-30px";
+ // Without waiting for requestAnimationFrame, only the movement is observed.
+ requestAnimationFrame(() => {
+ window.setTimeout(() => {
+ // Move the target element so that the intersection ratio now crosses
+ // the threshold value. An intersection observer update should be
+ // triggered and the callback should run.
+ targetElement.style.top = "-30px";
- if (window.testRunner) {
- window.testRunner.DoNonMeasuredLayout();
- window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);
- }
+ if (window.testRunner) {
+ window.testRunner.DoNonMeasuredLayout();
+ window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);
+ }
+ }, 0);
+ });
+
+ // Fail after 3 seconds if requestAnimationFrame never triggered.
+ window.setTimeout(function() {
+ window.testRunner.notifyDone();
+ }, 3000);
});
</script>
diff --git a/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-without-threshold-expected.png b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-without-threshold-expected.png
new file mode 100644
index 0000000..40b311f
--- /dev/null
+++ b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-without-threshold-expected.png
Binary files differ
diff --git a/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-without-threshold.html b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-without-threshold.html
new file mode 100644
index 0000000..7d982cf
--- /dev/null
+++ b/src/cobalt/layout_tests/testdata/intersection-observer/observers-should-update-when-elements-move-without-threshold.html
@@ -0,0 +1,93 @@
+<!DOCTYPE html>
+<!--
+ | This test checks that the observer objects get updated when the elements
+ | themselves move around.
+ | The color of the target element is blue if there is an intersection and
+ | green if there is not. In this test, the initial observation turns the
+ | target blue, but when the target moves above the root, it turns green.
+ | https://www.w3.org/TR/intersection-observer/
+ -->
+<html>
+<head>
+ <style>
+ div {
+ position: absolute;
+ }
+ #root {
+ margin: 100px;
+ background-color: red;
+ width: 250px;
+ height: 150px;
+ }
+ #target {
+ width: 150px;
+ height: 50px;
+ top: 50px;
+ left: 50px;
+ }
+ </style>
+</head>
+<body>
+ <div id="root">
+ <div id="target"></div>
+ </div>
+
+ <script>
+ if (window.testRunner) {
+ window.testRunner.waitUntilDone();
+ }
+
+ window.addEventListener("load", function() {
+ var rootElement = document.querySelector('#root');
+ var targetElement = document.querySelector('#target');
+
+ function handleIntersect(entries, observer) {
+ entries.forEach(function(entry) {
+ if (entry.isIntersecting) {
+ entry.target.style.backgroundColor = "blue";
+ } else {
+ entry.target.style.backgroundColor = "green";
+ }
+ });
+ if (window.testRunner) {
+ window.testRunner.DoNonMeasuredLayout();
+ }
+ }
+
+ var options = {
+ root: rootElement,
+ rootMargin: "0px",
+ };
+
+ var observer = new IntersectionObserver(handleIntersect, options);
+ observer.observe(targetElement);
+
+ if (window.testRunner) {
+ window.testRunner.DoNonMeasuredLayout();
+ }
+
+ // Without waiting for requestAnimationFrame, only the movement is observed.
+ requestAnimationFrame(() => {
+ window.setTimeout(() => {
+ // Move the target element so that it is clearly no longer
+ // intersecting. An intersection observer update should be
+ // triggered and the callback should run.
+ targetElement.style.top = "-60px";
+
+ if (window.testRunner) {
+ window.testRunner.DoNonMeasuredLayout();
+ window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);
+ }
+
+ }, 0);
+ });
+
+ // Fail after 3 seconds if requestAnimationFrame never triggered.
+ window.setTimeout(function() {
+ window.testRunner.notifyDone();
+ }, 3000);
+ });
+ </script>
+
+</body>
+</html>
diff --git a/src/cobalt/layout_tests/testdata/web-platform-tests/intersection-observer/web_platform_tests.txt b/src/cobalt/layout_tests/testdata/web-platform-tests/intersection-observer/web_platform_tests.txt
new file mode 100644
index 0000000..b830268
--- /dev/null
+++ b/src/cobalt/layout_tests/testdata/web-platform-tests/intersection-observer/web_platform_tests.txt
@@ -0,0 +1,76 @@
+# Intersection Observer API tests.
+
+containing-block.html,PASS
+disconnect.html,PASS
+# Updating target display does not trigger an intersection
+display-none.html,DISABLE
+# Empty rootMargin should evaluate to default, not cause error
+empty-root-margin.html,DISABLE
+initial-observation-with-threshold.html,PASS
+inline-with-block-child-client-rect.html,PASS
+isIntersecting-change-events.html,PASS
+# rootMargin default should be "0px 0px 0px 0px", not "0px"
+observer-attributes.html,DISABLE
+# WPT testharness needs to be rebased
+observer-exceptions.html,DISABLE
+#Deleting an element does not trigger an intersection
+remove-element.html,DISABLE
+root-margin-root-element.html,PASS
+# Setting IO target equal to document.documentElement crashes Cobalt
+root-margin-rounding.html,DISABLE
+rtl-clipped-root.html,PASS
+same-document-root.html,PASS
+zero-area-element-hidden.html,PASS
+#Zero-area target does not trigger an intersection
+zero-area-element-visible.html,DISABLE
+
+#No root specified - intersections with viewport incorrectly reported
+inline-client-rect.html,DISABLE
+isIntersecting-threshold.html,DISABLE
+multiple-targets.html,DISABLE
+multiple-thresholds.html,DISABLE
+observer-without-js-reference.html,DISABLE
+root-margin.html,DISABLE
+same-document-no-root.html,DISABLE
+same-document-zero-size-target.html,DISABLE
+text-target.html,DISABLE
+
+#IntersectionObserverV2 not implemented
+v2/blur-filter.html,DISABLE
+v2/delay-test.html,DISABLE
+v2/drop-shadow-filter-vertical-rl.html,DISABLE
+v2/inline-occlusion.html,DISABLE
+v2/position-relative.html,DISABLE
+v2/simple-effects.html,DISABLE
+v2/simple-occlusion-svg-foreign-object.html,DISABLE
+v2/simple-occlusion.html,DISABLE
+v2/text-editor-occlusion.html,DISABLE
+
+#IntersectionObserver doesn't support transforms and animations
+bounding-box.html,DISABLE
+edge-inclusive-intersection.html,DISABLE
+unclipped-root.html,DISABLE
+v2/animated-occlusion.html,DISABLE
+
+#Window.open() and multiple windows not supported
+target-in-different-window.html,DISABLE
+
+# shadow DOM not supported
+shadow-content.html,DISABLE
+
+# <iframe> not supported
+client-rect.html,DISABLE
+cross-origin-iframe.sub.html,DISABLE
+document-scrolling-element-root.html,DISABLE
+iframe-no-root-with-wrapping-scroller.html,DISABLE
+iframe-no-root.html,DISABLE
+nested-cross-origin-iframe.sub.html,DISABLE
+observer-in-iframe.html,DISABLE
+same-origin-grand-child-iframe.sub.html,DISABLE
+timestamp.html,DISABLE
+v2/box-shadow.html,DISABLE
+v2/cross-origin-effects.sub.html,DISABLE
+v2/cross-origin-occlusion.sub.html,DISABLE
+v2/iframe-target.html,DISABLE
+v2/scaled-target.html,DISABLE
+v2/text-shadow.html,DISABLE
\ No newline at end of file
diff --git a/src/cobalt/layout_tests/web_platform_tests.cc b/src/cobalt/layout_tests/web_platform_tests.cc
index 90b82a6..12ebd3a 100644
--- a/src/cobalt/layout_tests/web_platform_tests.cc
+++ b/src/cobalt/layout_tests/web_platform_tests.cc
@@ -145,15 +145,20 @@
FROM_HERE, run_loop->QuitClosure());
}
-// Called when layout completes and results have been produced. We use this
-// signal to stop the WebModule's message loop since our work is done after a
-// layout has been performed.
+// Called upon window.close(), which indicates that the test has finished.
+// We use this signal to stop the WebModule's message loop since our work is
+// done once the window is closed. A timeout will also trigger window.close().
+void WindowCloseCallback(base::RunLoop* run_loop,
+ base::MessageLoop* message_loop,
+ base::TimeDelta delta) {
+ message_loop->task_runner()->PostTask(FROM_HERE, base::Bind(Quit, run_loop));
+}
+
+// Called when layout completes.
void WebModuleOnRenderTreeProducedCallback(
base::Optional<browser::WebModule::LayoutResults>* out_results,
- base::RunLoop* run_loop, base::MessageLoop* message_loop,
const browser::WebModule::LayoutResults& results) {
out_results->emplace(results.render_tree, results.layout_time);
- message_loop->task_runner()->PostTask(FROM_HERE, base::Bind(Quit, run_loop));
}
// This callback, when called, quits a message loop, outputs the error message
@@ -212,11 +217,10 @@
// Create the WebModule and wait for a layout to occur.
browser::WebModule web_module(
url, base::kApplicationStateStarted,
- base::Bind(&WebModuleOnRenderTreeProducedCallback, &results, &run_loop,
- base::MessageLoop::current()),
+ base::Bind(&WebModuleOnRenderTreeProducedCallback, &results),
base::Bind(&WebModuleErrorCallback, &run_loop,
base::MessageLoop::current()),
- browser::WebModule::CloseCallback() /* window_close_callback */,
+ base::Bind(&WindowCloseCallback, &run_loop, base::MessageLoop::current()),
base::Closure() /* window_minimize_callback */,
can_play_type_handler.get(), media_module.get(), &network_module,
kDefaultViewportSize, &resource_provider, 60.0f, web_module_options);
@@ -415,6 +419,11 @@
GetTestName());
INSTANTIATE_TEST_CASE_P(
+ intersection_observer, WebPlatformTest,
+ ::testing::ValuesIn(EnumerateWebPlatformTests("intersection-observer")),
+ GetTestName());
+
+INSTANTIATE_TEST_CASE_P(
mediasession, WebPlatformTest,
::testing::ValuesIn(EnumerateWebPlatformTests("mediasession")),
GetTestName());
diff --git a/src/cobalt/loader/font/remote_typeface_cache.h b/src/cobalt/loader/font/remote_typeface_cache.h
index 47eb642..d6fd0b7 100644
--- a/src/cobalt/loader/font/remote_typeface_cache.h
+++ b/src/cobalt/loader/font/remote_typeface_cache.h
@@ -28,7 +28,7 @@
class Typeface;
-} // render_tree
+} // namespace render_tree
namespace loader {
namespace font {
@@ -55,10 +55,11 @@
// CreateTypefaceCache() provides a mechanism for creating a remote typeface
// cache.
inline static std::unique_ptr<RemoteTypefaceCache> CreateRemoteTypefaceCache(
- const std::string& name, uint32 cache_capacity,
- loader::LoaderFactory* loader_factory) {
+ const std::string& name, const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, loader::LoaderFactory* loader_factory) {
return std::unique_ptr<RemoteTypefaceCache>(new RemoteTypefaceCache(
- name, cache_capacity, true /*are_loading_retries_enabled*/,
+ name, debugger_hooks, cache_capacity,
+ true /*are_loading_retries_enabled*/,
base::Bind(&loader::LoaderFactory::CreateTypefaceLoader,
base::Unretained(loader_factory))));
}
diff --git a/src/cobalt/loader/image/animated_webp_image.cc b/src/cobalt/loader/image/animated_webp_image.cc
index 9618b0b..0d604ab 100644
--- a/src/cobalt/loader/image/animated_webp_image.cc
+++ b/src/cobalt/loader/image/animated_webp_image.cc
@@ -41,7 +41,8 @@
AnimatedWebPImage::AnimatedWebPImage(
const math::Size& size, bool is_opaque,
- render_tree::ResourceProvider* resource_provider)
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
: size_(size),
is_opaque_(is_opaque),
demux_(NULL),
@@ -53,6 +54,7 @@
current_frame_index_(0),
should_dispose_previous_frame_to_background_(false),
resource_provider_(resource_provider),
+ debugger_hooks_(debugger_hooks),
frame_provider_(new FrameProvider()) {
TRACE_EVENT0("cobalt::loader::image",
"AnimatedWebPImage::AnimatedWebPImage()");
@@ -201,9 +203,8 @@
DCHECK(task_runner_->BelongsToCurrentThread());
if (decode_closure_.callback().is_null()) {
- decode_closure_.Reset(
- base::Bind(&AnimatedWebPImage::LockAndDecodeFrames,
- base::Unretained(this)));
+ decode_closure_.Reset(base::Bind(&AnimatedWebPImage::LockAndDecodeFrames,
+ base::Unretained(this)));
}
if (AdvanceFrame()) {
@@ -263,9 +264,10 @@
return false;
}
- ImageDecoder image_decoder(
- resource_provider_, base::Bind(&RecordImage, &next_frame_image),
- ImageDecoder::kImageTypeWebP, base::Bind(&DecodeError));
+ ImageDecoder image_decoder(resource_provider_, debugger_hooks_,
+ base::Bind(&RecordImage, &next_frame_image),
+ ImageDecoder::kImageTypeWebP,
+ base::Bind(&DecodeError));
image_decoder.DecodeChunk(
reinterpret_cast<const char*>(webp_iterator.fragment.bytes),
webp_iterator.fragment.size);
diff --git a/src/cobalt/loader/image/animated_webp_image.h b/src/cobalt/loader/image/animated_webp_image.h
index 34cf56b..c0fd222 100644
--- a/src/cobalt/loader/image/animated_webp_image.h
+++ b/src/cobalt/loader/image/animated_webp_image.h
@@ -27,6 +27,7 @@
#include "base/threading/thread.h"
#include "base/time/time.h"
#include "base/trace_event/trace_event.h"
+#include "cobalt/base/debugger_hooks.h"
#include "cobalt/loader/image/image.h"
#include "cobalt/render_tree/color_rgba.h"
#include "cobalt/render_tree/resource_provider.h"
@@ -39,7 +40,8 @@
class AnimatedWebPImage : public AnimatedImage {
public:
AnimatedWebPImage(const math::Size& size, bool is_opaque,
- render_tree::ResourceProvider* resource_provider);
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks);
const math::Size& GetSize() const override { return size_; }
@@ -106,6 +108,7 @@
int current_frame_index_;
bool should_dispose_previous_frame_to_background_;
render_tree::ResourceProvider* resource_provider_;
+ const base::DebuggerHooks& debugger_hooks_;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
render_tree::ColorRGBA background_color_;
diff --git a/src/cobalt/loader/image/dummy_gif_image_decoder.cc b/src/cobalt/loader/image/dummy_gif_image_decoder.cc
index 5b4b125..38f54fd 100644
--- a/src/cobalt/loader/image/dummy_gif_image_decoder.cc
+++ b/src/cobalt/loader/image/dummy_gif_image_decoder.cc
@@ -26,8 +26,9 @@
'\x00', '\x02', '\x01', '\x44', '\x00', '\x3B'};
DummyGIFImageDecoder::DummyGIFImageDecoder(
- render_tree::ResourceProvider* resource_provider)
- : ImageDataDecoder(resource_provider) {}
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
+ : ImageDataDecoder(resource_provider, debugger_hooks) {}
size_t DummyGIFImageDecoder::DecodeChunkInternal(const uint8* data,
size_t input_byte) {
diff --git a/src/cobalt/loader/image/dummy_gif_image_decoder.h b/src/cobalt/loader/image/dummy_gif_image_decoder.h
index 79941e2..1248a9f 100644
--- a/src/cobalt/loader/image/dummy_gif_image_decoder.h
+++ b/src/cobalt/loader/image/dummy_gif_image_decoder.h
@@ -30,7 +30,8 @@
class DummyGIFImageDecoder : public ImageDataDecoder {
public:
explicit DummyGIFImageDecoder(
- render_tree::ResourceProvider* resource_provider);
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks);
~DummyGIFImageDecoder() override {}
// From ImageDataDecoder
diff --git a/src/cobalt/loader/image/image_cache.h b/src/cobalt/loader/image/image_cache.h
index 6c75ba9..ca1e514 100644
--- a/src/cobalt/loader/image/image_cache.h
+++ b/src/cobalt/loader/image/image_cache.h
@@ -47,14 +47,15 @@
// CreateImageCache() provides a mechanism for creating an |ImageCache|.
inline static std::unique_ptr<ImageCache> CreateImageCache(
- const std::string& name, uint32 cache_capacity,
- loader::LoaderFactory* loader_factory) {
- return std::unique_ptr<ImageCache>(new ImageCache(
- name, cache_capacity, false /*are_loading_retries_enabled*/,
- base::Bind(&loader::LoaderFactory::CreateImageLoader,
- base::Unretained(loader_factory)),
- base::Bind(&loader::LoaderFactory::NotifyResourceRequested,
- base::Unretained(loader_factory))));
+ const std::string& name, const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, loader::LoaderFactory* loader_factory) {
+ return std::unique_ptr<ImageCache>(
+ new ImageCache(name, debugger_hooks, cache_capacity,
+ false /*are_loading_retries_enabled*/,
+ base::Bind(&loader::LoaderFactory::CreateImageLoader,
+ base::Unretained(loader_factory)),
+ base::Bind(&loader::LoaderFactory::NotifyResourceRequested,
+ base::Unretained(loader_factory))));
}
// The ReducedCacheCapacityManager is a helper class that manages state which
diff --git a/src/cobalt/loader/image/image_data_decoder.cc b/src/cobalt/loader/image/image_data_decoder.cc
index 7ca65ca..0a19fdf 100644
--- a/src/cobalt/loader/image/image_data_decoder.cc
+++ b/src/cobalt/loader/image/image_data_decoder.cc
@@ -29,8 +29,11 @@
} // namespace
ImageDataDecoder::ImageDataDecoder(
- render_tree::ResourceProvider* resource_provider)
- : resource_provider_(resource_provider), state_(kWaitingForHeader) {
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
+ : resource_provider_(resource_provider),
+ debugger_hooks_(debugger_hooks),
+ state_(kWaitingForHeader) {
CalculatePixelFormat();
}
diff --git a/src/cobalt/loader/image/image_data_decoder.h b/src/cobalt/loader/image/image_data_decoder.h
index eab7b67..04bf063 100644
--- a/src/cobalt/loader/image/image_data_decoder.h
+++ b/src/cobalt/loader/image/image_data_decoder.h
@@ -19,6 +19,7 @@
#include <string>
#include <vector>
+#include "cobalt/base/debugger_hooks.h"
#include "cobalt/loader/image/image.h"
#include "cobalt/render_tree/resource_provider.h"
#if defined(STARBOARD)
@@ -36,7 +37,8 @@
// image to ImageDecoder.
class ImageDataDecoder {
public:
- explicit ImageDataDecoder(render_tree::ResourceProvider* resource_provider);
+ explicit ImageDataDecoder(render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks);
virtual ~ImageDataDecoder() {}
@@ -64,6 +66,8 @@
return resource_provider_;
}
+ const base::DebuggerHooks& debugger_hooks() { return debugger_hooks_; }
+
void set_state(State state) { state_ = state; }
State state() const { return state_; }
@@ -83,6 +87,8 @@
// |resource_provider_| is used to allocate render_tree::ImageData
render_tree::ResourceProvider* const resource_provider_;
+ // |debugger_hooks_| is used with CLOG to report errors to the WebDev.
+ const base::DebuggerHooks& debugger_hooks_;
// |data_buffer_| is used to cache the undecoded data.
std::vector<uint8> data_buffer_;
// Record the current decoding status.
diff --git a/src/cobalt/loader/image/image_decoder.cc b/src/cobalt/loader/image/image_decoder.cc
index 0debb82..f9bf6c8 100644
--- a/src/cobalt/loader/image/image_decoder.cc
+++ b/src/cobalt/loader/image/image_decoder.cc
@@ -75,9 +75,11 @@
ImageDecoder::ImageDecoder(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
const ImageAvailableCallback& image_available_callback,
const loader::Decoder::OnCompleteFunction& load_complete_callback)
: resource_provider_(resource_provider),
+ debugger_hooks_(debugger_hooks),
image_available_callback_(image_available_callback),
image_type_(kImageTypeInvalid),
load_complete_callback_(load_complete_callback),
@@ -88,10 +90,12 @@
ImageDecoder::ImageDecoder(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
const ImageAvailableCallback& image_available_callback,
ImageType image_type,
const loader::Decoder::OnCompleteFunction& load_complete_callback)
: resource_provider_(resource_provider),
+ debugger_hooks_(debugger_hooks),
image_available_callback_(image_available_callback),
image_type_(image_type),
load_complete_callback_(load_complete_callback),
@@ -281,7 +285,8 @@
// If |mime_type| is empty, |image_type| will be used to deduce the mime type.
std::unique_ptr<ImageDataDecoder> MaybeCreateStarboardDecoder(
const std::string& mime_type, ImageDecoder::ImageType image_type,
- render_tree::ResourceProvider* resource_provider) {
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks) {
// clang-format off
const SbDecodeTargetFormat kPreferredFormats[] = {
kSbDecodeTargetFormat1PlaneRGBA,
@@ -314,7 +319,7 @@
if (SbDecodeTargetIsFormatValid(format) &&
resource_provider->SupportsSbDecodeTarget()) {
return std::unique_ptr<ImageDataDecoder>(new ImageDecoderStarboard(
- resource_provider, mime_type_c_string, format));
+ resource_provider, debugger_hooks, mime_type_c_string, format));
}
}
return std::unique_ptr<ImageDataDecoder>();
@@ -322,26 +327,28 @@
std::unique_ptr<ImageDataDecoder> CreateImageDecoderFromImageType(
ImageDecoder::ImageType image_type,
- render_tree::ResourceProvider* resource_provider) {
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks) {
// Call different types of decoders by matching the image signature.
if (s_use_stub_image_decoder) {
return std::unique_ptr<ImageDataDecoder>(
- new StubImageDecoder(resource_provider));
+ new StubImageDecoder(resource_provider, debugger_hooks));
} else if (image_type == ImageDecoder::kImageTypeJPEG) {
- return std::unique_ptr<ImageDataDecoder>(new JPEGImageDecoder(
- resource_provider, ImageDecoder::AllowDecodingToMultiPlane()));
+ return std::unique_ptr<ImageDataDecoder>(
+ new JPEGImageDecoder(resource_provider, debugger_hooks,
+ ImageDecoder::AllowDecodingToMultiPlane()));
} else if (image_type == ImageDecoder::kImageTypePNG) {
return std::unique_ptr<ImageDataDecoder>(
- new PNGImageDecoder(resource_provider));
+ new PNGImageDecoder(resource_provider, debugger_hooks));
} else if (image_type == ImageDecoder::kImageTypeWebP) {
return std::unique_ptr<ImageDataDecoder>(
- new WEBPImageDecoder(resource_provider));
+ new WEBPImageDecoder(resource_provider, debugger_hooks));
} else if (image_type == ImageDecoder::kImageTypeGIF) {
return std::unique_ptr<ImageDataDecoder>(
- new DummyGIFImageDecoder(resource_provider));
+ new DummyGIFImageDecoder(resource_provider, debugger_hooks));
} else if (image_type == ImageDecoder::kImageTypeJSON) {
return std::unique_ptr<ImageDataDecoder>(
- new LottieAnimationDecoder(resource_provider));
+ new LottieAnimationDecoder(resource_provider, debugger_hooks));
} else {
return std::unique_ptr<ImageDataDecoder>();
}
@@ -367,11 +374,12 @@
image_type_ = DetermineImageType(signature_cache_.data);
}
- decoder_ =
- MaybeCreateStarboardDecoder(mime_type_, image_type_, resource_provider_);
+ decoder_ = MaybeCreateStarboardDecoder(mime_type_, image_type_,
+ resource_provider_, debugger_hooks_);
if (!decoder_) {
- decoder_ = CreateImageDecoderFromImageType(image_type_, resource_provider_);
+ decoder_ = CreateImageDecoderFromImageType(image_type_, resource_provider_,
+ debugger_hooks_);
}
if (!decoder_) {
diff --git a/src/cobalt/loader/image/image_decoder.h b/src/cobalt/loader/image/image_decoder.h
index 0e1c3dc..2f82867 100644
--- a/src/cobalt/loader/image/image_decoder.h
+++ b/src/cobalt/loader/image/image_decoder.h
@@ -51,10 +51,12 @@
ImageDecoder(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
const ImageAvailableCallback& image_available_callback,
const loader::Decoder::OnCompleteFunction& load_complete_callback);
ImageDecoder(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
const ImageAvailableCallback& image_available_callback,
ImageType image_type,
const loader::Decoder::OnCompleteFunction& load_complete_callback);
@@ -102,6 +104,7 @@
size_t* consumed_size);
render_tree::ResourceProvider* resource_provider_;
+ const base::DebuggerHooks& debugger_hooks_;
const ImageAvailableCallback image_available_callback_;
ImageType image_type_;
const loader::Decoder::OnCompleteFunction load_complete_callback_;
diff --git a/src/cobalt/loader/image/image_decoder_starboard.cc b/src/cobalt/loader/image/image_decoder_starboard.cc
index 754e211..4e5a27b 100644
--- a/src/cobalt/loader/image/image_decoder_starboard.cc
+++ b/src/cobalt/loader/image/image_decoder_starboard.cc
@@ -28,9 +28,10 @@
namespace image {
ImageDecoderStarboard::ImageDecoderStarboard(
- render_tree::ResourceProvider* resource_provider, const char* mime_type,
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks, const char* mime_type,
SbDecodeTargetFormat format)
- : ImageDataDecoder(resource_provider),
+ : ImageDataDecoder(resource_provider, debugger_hooks),
mime_type_(mime_type),
format_(format),
provider_(resource_provider->GetSbDecodeTargetGraphicsContextProvider()),
diff --git a/src/cobalt/loader/image/image_decoder_starboard.h b/src/cobalt/loader/image/image_decoder_starboard.h
index d1b43e1..3194db5 100644
--- a/src/cobalt/loader/image/image_decoder_starboard.h
+++ b/src/cobalt/loader/image/image_decoder_starboard.h
@@ -30,7 +30,8 @@
class ImageDecoderStarboard : public ImageDataDecoder {
public:
explicit ImageDecoderStarboard(
- render_tree::ResourceProvider* resource_provider, const char* mime_type,
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks, const char* mime_type,
SbDecodeTargetFormat format);
~ImageDecoderStarboard() override;
diff --git a/src/cobalt/loader/image/image_decoder_test.cc b/src/cobalt/loader/image/image_decoder_test.cc
index bf3beca..5aaf617 100644
--- a/src/cobalt/loader/image/image_decoder_test.cc
+++ b/src/cobalt/loader/image/image_decoder_test.cc
@@ -69,13 +69,14 @@
protected:
render_tree::ResourceProviderStub resource_provider_;
+ base::NullDebuggerHooks debugger_hooks_;
::testing::StrictMock<MockImageDecoderCallback> image_decoder_callback_;
std::unique_ptr<Decoder> image_decoder_;
};
MockImageDecoder::MockImageDecoder() {
image_decoder_.reset(new ImageDecoder(
- &resource_provider_,
+ &resource_provider_, debugger_hooks_,
base::Bind(&MockImageDecoderCallback::SuccessCallback,
base::Unretained(&image_decoder_callback_)),
base::Bind(&MockImageDecoderCallback::LoadCompleteCallback,
@@ -651,8 +652,9 @@
// output to be single plane.
TEST(ImageDecoderTest, DecodeProgressiveJPEGImageToSinglePlane) {
render_tree::ResourceProviderStub resource_provider;
+ base::NullDebuggerHooks debugger_hooks;
const bool kAllowImageDecodingToMultiPlane = false;
- JPEGImageDecoder jpeg_image_decoder(&resource_provider,
+ JPEGImageDecoder jpeg_image_decoder(&resource_provider, debugger_hooks,
kAllowImageDecodingToMultiPlane);
std::vector<uint8> image_data =
@@ -683,8 +685,9 @@
TEST(ImageDecoderTest,
DecodeProgressiveJPEGImageWithMultipleChunksToSinglePlane) {
render_tree::ResourceProviderStub resource_provider;
+ base::NullDebuggerHooks debugger_hooks;
const bool kAllowImageDecodingToMultiPlane = false;
- JPEGImageDecoder jpeg_image_decoder(&resource_provider,
+ JPEGImageDecoder jpeg_image_decoder(&resource_provider, debugger_hooks,
kAllowImageDecodingToMultiPlane);
std::vector<uint8> image_data =
diff --git a/src/cobalt/loader/image/jpeg_image_decoder.cc b/src/cobalt/loader/image/jpeg_image_decoder.cc
index 8f69809..feff4f7 100644
--- a/src/cobalt/loader/image/jpeg_image_decoder.cc
+++ b/src/cobalt/loader/image/jpeg_image_decoder.cc
@@ -18,6 +18,7 @@
#include "base/logging.h"
#include "base/trace_event/trace_event.h"
+#include "cobalt/base/console_log.h"
#include "nb/memory_scope.h"
#include "third_party/libjpeg/jpegint.h"
@@ -125,8 +126,9 @@
JPEGImageDecoder::JPEGImageDecoder(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
bool allow_image_decoding_to_multi_plane)
- : ImageDataDecoder(resource_provider),
+ : ImageDataDecoder(resource_provider, debugger_hooks),
allow_image_decoding_to_multi_plane_(
allow_image_decoding_to_multi_plane) {
TRACE_EVENT0("cobalt::loader::image", "JPEGImageDecoder::JPEGImageDecoder()");
diff --git a/src/cobalt/loader/image/jpeg_image_decoder.h b/src/cobalt/loader/image/jpeg_image_decoder.h
index ca18af9..afe61f5 100644
--- a/src/cobalt/loader/image/jpeg_image_decoder.h
+++ b/src/cobalt/loader/image/jpeg_image_decoder.h
@@ -16,6 +16,7 @@
#define COBALT_LOADER_IMAGE_JPEG_IMAGE_DECODER_H_
#include <setjmp.h>
+
#include <memory>
#include <string>
@@ -40,6 +41,7 @@
// multi plane images efficiently, and the output will always be produced in
// single plane RGBA or BGRA.
JPEGImageDecoder(render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
bool allow_image_decoding_to_multi_plane);
~JPEGImageDecoder() override;
diff --git a/src/cobalt/loader/image/lottie_animation_decoder.cc b/src/cobalt/loader/image/lottie_animation_decoder.cc
index 0408d8e..a5f9340 100644
--- a/src/cobalt/loader/image/lottie_animation_decoder.cc
+++ b/src/cobalt/loader/image/lottie_animation_decoder.cc
@@ -22,8 +22,9 @@
namespace image {
LottieAnimationDecoder::LottieAnimationDecoder(
- render_tree::ResourceProvider* resource_provider)
- : ImageDataDecoder(resource_provider) {
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
+ : ImageDataDecoder(resource_provider, debugger_hooks) {
TRACE_EVENT0("cobalt::loader::image",
"LottieAnimationDecoder::LottieAnimationDecoder()");
TRACK_MEMORY_SCOPE("Rendering");
diff --git a/src/cobalt/loader/image/lottie_animation_decoder.h b/src/cobalt/loader/image/lottie_animation_decoder.h
index 313be2c..e6d741f 100644
--- a/src/cobalt/loader/image/lottie_animation_decoder.h
+++ b/src/cobalt/loader/image/lottie_animation_decoder.h
@@ -27,7 +27,8 @@
class LottieAnimationDecoder : public ImageDataDecoder {
public:
explicit LottieAnimationDecoder(
- render_tree::ResourceProvider* resource_provider);
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks);
// From ImageDataDecoder
std::string GetTypeString() const override {
diff --git a/src/cobalt/loader/image/png_image_decoder.cc b/src/cobalt/loader/image/png_image_decoder.cc
index 7e5783f..5fd726a 100644
--- a/src/cobalt/loader/image/png_image_decoder.cc
+++ b/src/cobalt/loader/image/png_image_decoder.cc
@@ -16,6 +16,7 @@
#include "base/logging.h"
#include "base/trace_event/trace_event.h"
+#include "cobalt/base/console_log.h"
#include "nb/memory_scope.h"
namespace cobalt {
@@ -66,8 +67,9 @@
} // namespace
PNGImageDecoder::PNGImageDecoder(
- render_tree::ResourceProvider* resource_provider)
- : ImageDataDecoder(resource_provider),
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
+ : ImageDataDecoder(resource_provider, debugger_hooks),
png_(NULL),
info_(NULL),
has_alpha_(false),
@@ -234,8 +236,8 @@
if (interlace_type == PNG_INTERLACE_ADAM7) {
// Notify libpng to send us rows for interlaced pngs.
png_set_interlace_handling(png_);
- DLOG(WARNING) << "Interlaced PNGs are not displayed properly in older "
- "versions of Cobalt";
+ CLOG(WARNING, debugger_hooks()) << "Interlaced PNGs are not displayed "
+ "properly in older versions of Cobalt";
}
// Updates |info_| to reflect any transformations that have been requested.
diff --git a/src/cobalt/loader/image/png_image_decoder.h b/src/cobalt/loader/image/png_image_decoder.h
index fcead5b..696d814 100644
--- a/src/cobalt/loader/image/png_image_decoder.h
+++ b/src/cobalt/loader/image/png_image_decoder.h
@@ -29,7 +29,8 @@
class PNGImageDecoder : public ImageDataDecoder {
public:
- explicit PNGImageDecoder(render_tree::ResourceProvider* resource_provider);
+ explicit PNGImageDecoder(render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks);
~PNGImageDecoder() override;
// From ImageDataDecoder
diff --git a/src/cobalt/loader/image/sandbox/image_decoder_sandbox.cc b/src/cobalt/loader/image/sandbox/image_decoder_sandbox.cc
index 60eb3d9..6367305 100644
--- a/src/cobalt/loader/image/sandbox/image_decoder_sandbox.cc
+++ b/src/cobalt/loader/image/sandbox/image_decoder_sandbox.cc
@@ -36,10 +36,10 @@
const int kViewportWidth = 1920;
const int kViewportHeight = 1080;
-using renderer::RendererModule;
-using render_tree::ResourceProvider;
-using system_window::SystemWindow;
using base::FileEnumerator;
+using render_tree::ResourceProvider;
+using renderer::RendererModule;
+using system_window::SystemWindow;
struct ImageDecoderCallback {
void SuccessCallback(const scoped_refptr<loader::image::Image>& value) {
@@ -86,8 +86,8 @@
int num_of_bytes = base::ReadFile(
file_path, reinterpret_cast<char*>(&data[0]), static_cast<int>(size));
- CHECK_EQ(num_of_bytes, data.size()) << "Could not read '" << file_path.value()
- << "'.";
+ CHECK_EQ(num_of_bytes, data.size())
+ << "Could not read '" << file_path.value() << "'.";
return data;
}
@@ -97,12 +97,13 @@
size_t total_size = 0;
for (size_t i = 0; i < paths.size(); ++i) {
+ base::NullDebuggerHooks debugger_hooks;
ImageDecoderCallback image_decoder_result;
std::vector<uint8> image_data = GetFileContent(paths[i]);
base::Time start = base::Time::Now();
std::unique_ptr<Decoder> image_decoder(
- new ImageDecoder(resource_provider,
+ new ImageDecoder(resource_provider, debugger_hooks,
base::Bind(&ImageDecoderCallback::SuccessCallback,
base::Unretained(&image_decoder_result)),
base::Bind(&ImageDecoderCallback::LoadCompleteCallback,
diff --git a/src/cobalt/loader/image/stub_image_decoder.h b/src/cobalt/loader/image/stub_image_decoder.h
index d8b0dab..cc13068 100644
--- a/src/cobalt/loader/image/stub_image_decoder.h
+++ b/src/cobalt/loader/image/stub_image_decoder.h
@@ -30,8 +30,9 @@
// during tests or benchmarks to minimize the impact of image decoding.
class StubImageDecoder : public ImageDataDecoder {
public:
- explicit StubImageDecoder(render_tree::ResourceProvider* resource_provider)
- : ImageDataDecoder(resource_provider) {}
+ explicit StubImageDecoder(render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
+ : ImageDataDecoder(resource_provider, debugger_hooks) {}
// From ImageDataDecoder
std::string GetTypeString() const override { return "StubImageDecoder"; }
diff --git a/src/cobalt/loader/image/threaded_image_decoder_proxy.cc b/src/cobalt/loader/image/threaded_image_decoder_proxy.cc
index e9b0b81..43cc094 100644
--- a/src/cobalt/loader/image/threaded_image_decoder_proxy.cc
+++ b/src/cobalt/loader/image/threaded_image_decoder_proxy.cc
@@ -54,6 +54,7 @@
ThreadedImageDecoderProxy::ThreadedImageDecoderProxy(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks* debugger_hooks,
const ImageAvailableCallback& image_available_callback,
base::MessageLoop* load_message_loop,
const loader::Decoder::OnCompleteFunction& load_complete_callback)
@@ -63,7 +64,7 @@
load_message_loop_(load_message_loop),
result_message_loop_(base::MessageLoop::current()),
image_decoder_(new ImageDecoder(
- resource_provider,
+ resource_provider, *debugger_hooks,
base::Bind(&PostToMessageLoopChecked<ImageAvailableCallback,
scoped_refptr<Image>>,
weak_this_, image_available_callback,
diff --git a/src/cobalt/loader/image/threaded_image_decoder_proxy.h b/src/cobalt/loader/image/threaded_image_decoder_proxy.h
index f95f628..4555442 100644
--- a/src/cobalt/loader/image/threaded_image_decoder_proxy.h
+++ b/src/cobalt/loader/image/threaded_image_decoder_proxy.h
@@ -46,12 +46,13 @@
// ThreadedImageDecoderProxy.
static std::unique_ptr<Decoder> Create(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks* debugger_hooks,
const ImageAvailableCallback& image_available_callback,
base::MessageLoop* load_message_loop_,
const loader::Decoder::OnCompleteFunction& load_complete_callback) {
return std::unique_ptr<Decoder>(new ThreadedImageDecoderProxy(
- resource_provider, image_available_callback, load_message_loop_,
- load_complete_callback));
+ resource_provider, debugger_hooks, image_available_callback,
+ load_message_loop_, load_complete_callback));
}
// From the Decoder interface.
@@ -67,6 +68,7 @@
private:
ThreadedImageDecoderProxy(
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks* debugger_hooks,
const ImageAvailableCallback& image_available_callback,
base::MessageLoop* load_message_loop_,
const loader::Decoder::OnCompleteFunction& load_complete_callback);
diff --git a/src/cobalt/loader/image/webp_image_decoder.cc b/src/cobalt/loader/image/webp_image_decoder.cc
index aafddaf..6e0d378 100644
--- a/src/cobalt/loader/image/webp_image_decoder.cc
+++ b/src/cobalt/loader/image/webp_image_decoder.cc
@@ -26,8 +26,10 @@
namespace image {
WEBPImageDecoder::WEBPImageDecoder(
- render_tree::ResourceProvider* resource_provider)
- : ImageDataDecoder(resource_provider), internal_decoder_(NULL) {
+ render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks)
+ : ImageDataDecoder(resource_provider, debugger_hooks),
+ internal_decoder_(NULL) {
TRACK_MEMORY_SCOPE("Rendering");
TRACE_EVENT0("cobalt::loader::image", "WEBPImageDecoder::WEBPImageDecoder()");
// Initialize the configuration as empty.
@@ -59,7 +61,7 @@
if (config_.input.has_animation) {
animated_webp_image_ = new AnimatedWebPImage(
math::Size(config_.input.width, config_.input.height),
- !!config_.input.has_alpha, resource_provider());
+ !!config_.input.has_alpha, resource_provider(), debugger_hooks());
} else {
decoded_image_data_ = AllocateImageData(
math::Size(config_.input.width, config_.input.height),
diff --git a/src/cobalt/loader/image/webp_image_decoder.h b/src/cobalt/loader/image/webp_image_decoder.h
index 1ff4a0f..c7e3360 100644
--- a/src/cobalt/loader/image/webp_image_decoder.h
+++ b/src/cobalt/loader/image/webp_image_decoder.h
@@ -30,7 +30,8 @@
class WEBPImageDecoder : public ImageDataDecoder {
public:
- explicit WEBPImageDecoder(render_tree::ResourceProvider* resource_provider);
+ explicit WEBPImageDecoder(render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks);
~WEBPImageDecoder() override;
// From ImageDataDecoder
diff --git a/src/cobalt/loader/loader_factory.cc b/src/cobalt/loader/loader_factory.cc
index 7cb2789..e1f6a77 100644
--- a/src/cobalt/loader/loader_factory.cc
+++ b/src/cobalt/loader/loader_factory.cc
@@ -12,10 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include <memory>
-
#include "cobalt/loader/loader_factory.h"
+#include <memory>
+
#include "base/threading/platform_thread.h"
#include "cobalt/loader/image/threaded_image_decoder_proxy.h"
@@ -32,10 +32,12 @@
LoaderFactory::LoaderFactory(const char* name, FetcherFactory* fetcher_factory,
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
size_t encoded_image_cache_capacity,
base::ThreadPriority loader_thread_priority)
: fetcher_factory_(fetcher_factory),
resource_provider_(resource_provider),
+ debugger_hooks_(debugger_hooks),
load_thread_("ResourceLoader"),
is_suspended_(false) {
if (encoded_image_cache_capacity > 0) {
@@ -61,7 +63,8 @@
std::unique_ptr<Loader> loader(new Loader(
fetcher_creator,
base::Bind(&image::ThreadedImageDecoderProxy::Create, resource_provider_,
- image_available_callback, load_thread_.message_loop()),
+ &debugger_hooks_, image_available_callback,
+ load_thread_.message_loop()),
load_complete_callback,
base::Bind(&LoaderFactory::OnLoaderDestroyed, base::Unretained(this)),
is_suspended_));
diff --git a/src/cobalt/loader/loader_factory.h b/src/cobalt/loader/loader_factory.h
index 8ff1429..c6a456e 100644
--- a/src/cobalt/loader/loader_factory.h
+++ b/src/cobalt/loader/loader_factory.h
@@ -20,6 +20,7 @@
#include <string>
#include "base/threading/thread.h"
+#include "cobalt/base/debugger_hooks.h"
#include "cobalt/csp/content_security_policy.h"
#include "cobalt/loader/fetcher.h"
#include "cobalt/loader/fetcher_cache.h"
@@ -42,6 +43,7 @@
public:
LoaderFactory(const char* name, FetcherFactory* fetcher_factory,
render_tree::ResourceProvider* resource_provider,
+ const base::DebuggerHooks& debugger_hooks,
size_t encoded_image_cache_capacity,
base::ThreadPriority loader_thread_priority);
@@ -121,6 +123,9 @@
// Used to create render_tree resources.
render_tree::ResourceProvider* resource_provider_;
+ // Used with CLOG to report errors with the image source.
+ const base::DebuggerHooks& debugger_hooks_;
+
// Keeps track of all active loaders so that if a suspend event occurs they
// can be aborted.
typedef std::set<Loader*> LoaderSet;
diff --git a/src/cobalt/loader/mesh/mesh_cache.h b/src/cobalt/loader/mesh/mesh_cache.h
index a727c0e..8295bae 100644
--- a/src/cobalt/loader/mesh/mesh_cache.h
+++ b/src/cobalt/loader/mesh/mesh_cache.h
@@ -46,10 +46,11 @@
// CreateMeshCache() provides a mechanism for creating an |MeshCache|.
inline static std::unique_ptr<MeshCache> CreateMeshCache(
- const std::string& name, uint32 cache_capacity,
- loader::LoaderFactory* loader_factory) {
+ const std::string& name, const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, loader::LoaderFactory* loader_factory) {
return std::unique_ptr<MeshCache>(
- new MeshCache(name, cache_capacity, false /*are_loading_retries_enabled*/,
+ new MeshCache(name, debugger_hooks, cache_capacity,
+ false /*are_loading_retries_enabled*/,
base::Bind(&loader::LoaderFactory::CreateMeshLoader,
base::Unretained(loader_factory))));
}
diff --git a/src/cobalt/loader/resource_cache.cc b/src/cobalt/loader/resource_cache.cc
index ca42c8a..e14e7bb 100644
--- a/src/cobalt/loader/resource_cache.cc
+++ b/src/cobalt/loader/resource_cache.cc
@@ -18,6 +18,7 @@
#include <memory>
#include "base/strings/stringprintf.h"
+#include "cobalt/base/console_log.h"
namespace cobalt {
namespace loader {
@@ -145,7 +146,8 @@
}
// Error
} else {
- LOG(WARNING) << " Error while loading '" << url_ << "': " << *error;
+ CLOG(WARNING, owner_->debugger_hooks())
+ << " Error while loading '" << url_ << "': " << *error;
if (has_resource_func_.Run()) {
LOG(WARNING) << "A resource was produced but there was still an error.";
@@ -215,10 +217,11 @@
}
ResourceCacheBase::ResourceCacheBase(
- const std::string& name, uint32 cache_capacity,
- bool are_loading_retries_enabled,
+ const std::string& name, const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, bool are_loading_retries_enabled,
const ReclaimMemoryFunc& reclaim_memory_func)
: name_(name),
+ debugger_hooks_(debugger_hooks),
are_loading_retries_enabled_(are_loading_retries_enabled),
cache_capacity_(cache_capacity),
reclaim_memory_func_(reclaim_memory_func),
diff --git a/src/cobalt/loader/resource_cache.h b/src/cobalt/loader/resource_cache.h
index 7ed5dfb..7833762 100644
--- a/src/cobalt/loader/resource_cache.h
+++ b/src/cobalt/loader/resource_cache.h
@@ -27,6 +27,7 @@
#include "base/threading/thread_checker.h"
#include "base/timer/timer.h"
#include "cobalt/base/c_val.h"
+#include "cobalt/base/debugger_hooks.h"
#include "cobalt/csp/content_security_policy.h"
#include "cobalt/loader/decoder.h"
#include "cobalt/loader/fetcher_factory.h"
@@ -45,6 +46,8 @@
template <typename CacheType>
class ResourceCache;
+class ResourceCacheBase;
+
enum CallbackType {
kOnLoadingSuccessCallbackType,
kOnLoadingErrorCallbackType,
@@ -96,13 +99,15 @@
typedef base::Callback<std::unique_ptr<Loader>()> StartLoadingFunc;
CachedResourceBase(
- const GURL& url, const StartLoadingFunc& start_loading_func,
+ const ResourceCacheBase* owner, const GURL& url,
+ const StartLoadingFunc& start_loading_func,
const base::Closure& on_retry_loading,
const base::Callback<bool()>& has_resource_func,
const base::Callback<void()>& reset_resource_func,
const base::Callback<bool()>& are_loading_retries_enabled_func,
const base::Callback<void(CallbackType)>& on_resource_loaded)
- : url_(url),
+ : owner_(owner),
+ url_(url),
start_loading_func_(start_loading_func),
on_retry_loading_(on_retry_loading),
has_resource_func_(has_resource_func),
@@ -113,14 +118,15 @@
}
CachedResourceBase(
- const GURL& url, const Origin& origin,
+ const ResourceCacheBase* owner, const GURL& url, const Origin& origin,
const StartLoadingFunc& start_loading_func,
const base::Closure& on_retry_loading,
const base::Callback<bool()>& has_resource_func,
const base::Callback<void()>& reset_resource_func,
const base::Callback<bool()>& are_loading_retries_enabled_func,
const base::Callback<void(CallbackType)>& on_resource_loaded)
- : url_(url),
+ : owner_(owner),
+ url_(url),
origin_(origin),
start_loading_func_(start_loading_func),
on_retry_loading_(on_retry_loading),
@@ -157,6 +163,7 @@
THREAD_CHECKER(cached_resource_thread_checker_);
+ const ResourceCacheBase* owner_;
const GURL url_;
const Origin origin_;
const StartLoadingFunc start_loading_func_;
@@ -194,7 +201,8 @@
// Request fetching and decoding a single resource based on the url.
CachedResource(
- const GURL& url, const Origin& origin,
+ const ResourceCache<CacheType>* owner, const GURL& url,
+ const Origin& origin,
const base::Callback<std::unique_ptr<Loader>(CachedResource*)>&
start_loading_func,
const base::Callback<void(CachedResourceBase*)>& on_retry_loading,
@@ -207,7 +215,8 @@
// and there is no need to fetch or load this resource again. |loader_|
// is NULL in this case.
CachedResource(
- const GURL& url, ResourceType* resource,
+ const ResourceCache<CacheType>* owner, const GURL& url,
+ ResourceType* resource,
const base::Callback<std::unique_ptr<Loader>(CachedResource*)>&
start_loading_func,
const base::Callback<void(CachedResourceBase*)>& on_retry_loading,
@@ -261,7 +270,8 @@
template <typename CacheType>
CachedResource<CacheType>::CachedResource(
- const GURL& url, const Origin& origin,
+ const ResourceCache<CacheType>* owner, const GURL& url,
+ const Origin& origin,
const base::Callback<std::unique_ptr<Loader>(CachedResource*)>&
start_loading_func,
const base::Callback<void(CachedResourceBase*)>& on_retry_loading,
@@ -270,7 +280,8 @@
const base::Callback<void(CachedResource*, CallbackType)>&
on_resource_loaded)
: CachedResourceBase(
- url, origin, base::Bind(start_loading_func, base::Unretained(this)),
+ owner, url, origin,
+ base::Bind(start_loading_func, base::Unretained(this)),
base::Bind(on_retry_loading, base::Unretained(this)),
base::Bind(&CachedResource::HasResource, base::Unretained(this)),
base::Bind(&CachedResource::ResetResource, base::Unretained(this)),
@@ -282,7 +293,8 @@
template <typename CacheType>
CachedResource<CacheType>::CachedResource(
- const GURL& url, ResourceType* resource,
+ const ResourceCache<CacheType>* owner, const GURL& url,
+ ResourceType* resource,
const base::Callback<std::unique_ptr<Loader>(CachedResource*)>&
start_loading_func,
const base::Callback<void(CachedResourceBase*)>& on_retry_loading,
@@ -291,7 +303,7 @@
const base::Callback<void(CachedResource*, CallbackType)>&
on_resource_loaded)
: CachedResourceBase(
- url, base::Bind(start_loading_func, base::Unretained(this)),
+ owner, url, base::Bind(start_loading_func, base::Unretained(this)),
base::Bind(on_retry_loading, base::Unretained(this)),
base::Bind(&CachedResource::HasResource, base::Unretained(this)),
base::Bind(&CachedResource::ResetResource, base::Unretained(this)),
@@ -377,6 +389,8 @@
return security_callback_;
}
+ const base::DebuggerHooks& debugger_hooks() const { return debugger_hooks_; }
+
uint32 capacity() const { return cache_capacity_; }
void SetCapacity(uint32 capacity);
@@ -402,8 +416,9 @@
typedef net::linked_hash_map<std::string, ResourceCallbackInfo>
ResourceCallbackMap;
- ResourceCacheBase(const std::string& name, uint32 cache_capacity,
- bool are_loading_retries_enabled,
+ ResourceCacheBase(const std::string& name,
+ const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, bool are_loading_retries_enabled,
const ReclaimMemoryFunc& reclaim_memory_func);
// Called by CachedResource objects when they fail to load as a result of a
@@ -431,6 +446,8 @@
// The name of this resource cache object, useful while debugging.
const std::string name_;
+ const base::DebuggerHooks& debugger_hooks_;
+
bool are_loading_retries_enabled_;
uint32 cache_capacity_;
@@ -502,8 +519,9 @@
typedef base::Callback<void(const std::string&)>
NotifyResourceRequestedFunction;
- ResourceCache(const std::string& name, uint32 cache_capacity,
- bool are_loading_retries_enabled,
+ ResourceCache(const std::string& name,
+ const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, bool are_loading_retries_enabled,
const CreateLoaderFunction& create_loader_function,
const NotifyResourceRequestedFunction&
notify_resource_requested_function =
@@ -586,12 +604,12 @@
template <typename CacheType>
ResourceCache<CacheType>::ResourceCache(
- const std::string& name, uint32 cache_capacity,
- bool are_loading_retries_enabled,
+ const std::string& name, const base::DebuggerHooks& debugger_hooks,
+ uint32 cache_capacity, bool are_loading_retries_enabled,
const CreateLoaderFunction& create_loader_function,
const NotifyResourceRequestedFunction& notify_resource_requested_function)
: ResourceCacheBase(
- name, cache_capacity, are_loading_retries_enabled,
+ name, debugger_hooks, cache_capacity, are_loading_retries_enabled,
base::Bind(&ResourceCache::ReclaimMemory, base::Unretained(this))),
create_loader_function_(create_loader_function),
notify_resource_requested_function_(notify_resource_requested_function) {
@@ -622,7 +640,7 @@
auto resource_iterator = unreferenced_cached_resource_map_.find(url.spec());
if (resource_iterator != unreferenced_cached_resource_map_.end()) {
scoped_refptr<CachedResourceType> cached_resource(new CachedResourceType(
- url, resource_iterator->second.get(),
+ this, url, resource_iterator->second.get(),
base::Bind(&ResourceCache::StartLoadingResource,
base::Unretained(this)),
base::Bind(&ResourceCache::NotifyResourceLoadingRetryScheduled,
@@ -643,7 +661,7 @@
resource_iterator = weak_referenced_cached_resource_map_.find(url.spec());
if (resource_iterator != weak_referenced_cached_resource_map_.end()) {
scoped_refptr<CachedResourceType> cached_resource(new CachedResourceType(
- url, resource_iterator->second.get(),
+ this, url, resource_iterator->second.get(),
base::Bind(&ResourceCache::StartLoadingResource,
base::Unretained(this)),
base::Bind(&ResourceCache::NotifyResourceLoadingRetryScheduled,
@@ -665,7 +683,7 @@
// Create the cached resource and fetch its resource based on the url.
scoped_refptr<CachedResourceType> cached_resource(new CachedResourceType(
- url, origin,
+ this, url, origin,
base::Bind(&ResourceCache::StartLoadingResource, base::Unretained(this)),
base::Bind(&ResourceCache::NotifyResourceLoadingRetryScheduled,
base::Unretained(this)),
diff --git a/src/cobalt/media/base/playback_statistics.cc b/src/cobalt/media/base/playback_statistics.cc
index 00832ca..9559724 100644
--- a/src/cobalt/media/base/playback_statistics.cc
+++ b/src/cobalt/media/base/playback_statistics.cc
@@ -15,7 +15,7 @@
#include "cobalt/media/base/playback_statistics.h"
#include "starboard/atomic.h"
-#include "starboard/common/format_string.h"
+#include "starboard/common/string.h"
namespace cobalt {
namespace media {
diff --git a/src/cobalt/network/network_module.cc b/src/cobalt/network/network_module.cc
index 65c15ed..42032dd 100644
--- a/src/cobalt/network/network_module.cc
+++ b/src/cobalt/network/network_module.cc
@@ -90,10 +90,11 @@
custom_proxy_rules));
}
-void NetworkModule::DisableQuic() {
+void NetworkModule::SetEnableQuic(bool enable_quic) {
task_runner()->PostTask(
- FROM_HERE, base::Bind(&URLRequestContext::DisableQuic,
- base::Unretained(url_request_context_.get())));
+ FROM_HERE, base::Bind(&URLRequestContext::SetEnableQuic,
+ base::Unretained(url_request_context_.get()),
+ enable_quic));
}
void NetworkModule::Initialize(const std::string& user_agent_string,
@@ -141,16 +142,7 @@
base::Thread::Options thread_options;
thread_options.message_loop_type = base::MessageLoop::TYPE_IO;
thread_options.stack_size = 256 * 1024;
- // Thread priority is set to LOW (background) due to the following
- // constraints:
- // (1) Setting to high could result in an increase in unresponsiveness
- // and input latency on single-core devices.
- // (2) Setting to normal results in choppy video playback performance
- // on lower-end devices.
- // It was found with some testing that BACKGROUND priority gives the
- // desired performance on low-end devices without impacting the more
- // capable devices.
- thread_options.priority = base::ThreadPriority::BACKGROUND;
+ thread_options.priority = base::ThreadPriority::NORMAL;
thread_->StartWithOptions(thread_options);
base::WaitableEvent creation_event(
diff --git a/src/cobalt/network/network_module.h b/src/cobalt/network/network_module.h
index 7d29dca..b463e22 100644
--- a/src/cobalt/network/network_module.h
+++ b/src/cobalt/network/network_module.h
@@ -103,7 +103,7 @@
#endif
void SetProxy(const std::string& custom_proxy_rules);
- void DisableQuic();
+ void SetEnableQuic(bool enable_quic);
private:
void Initialize(const std::string& user_agent_string,
diff --git a/src/cobalt/network/url_request_context.cc b/src/cobalt/network/url_request_context.cc
index 1b73243..681f1fc 100644
--- a/src/cobalt/network/url_request_context.cc
+++ b/src/cobalt/network/url_request_context.cc
@@ -189,9 +189,9 @@
std::make_unique<ProxyConfigService>(proxy_config));
}
-void URLRequestContext::DisableQuic() {
+void URLRequestContext::SetEnableQuic(bool enable_quic) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
- storage_.http_network_session()->DisableQuic();
+ storage_.http_network_session()->SetEnableQuic(enable_quic);
}
#if defined(ENABLE_DEBUGGER)
diff --git a/src/cobalt/network/url_request_context.h b/src/cobalt/network/url_request_context.h
index 614d1f8..35d9a5d 100644
--- a/src/cobalt/network/url_request_context.h
+++ b/src/cobalt/network/url_request_context.h
@@ -47,7 +47,7 @@
void SetProxy(const std::string& custom_proxy_rules);
- void DisableQuic();
+ void SetEnableQuic(bool enable_quic);
private:
THREAD_CHECKER(thread_checker_);
diff --git a/src/cobalt/render_tree/lottie_animation.h b/src/cobalt/render_tree/lottie_animation.h
index 9cab513..37bc7ce 100644
--- a/src/cobalt/render_tree/lottie_animation.h
+++ b/src/cobalt/render_tree/lottie_animation.h
@@ -30,7 +30,7 @@
// LottieAnimation object.
class LottieAnimation : public Image {
public:
- enum class LottieState { kPlaying, kPaused, kStopped };
+ enum class LottieState { kPlaying, kPaused, kStopped, kFrozen };
enum class LottieMode { kNormal, kBounce };
@@ -48,7 +48,7 @@
LottieProperties() = default;
// Return true if |state| is updated to a new & valid LottieState.
- bool UpdateState(LottieState new_state) {
+ bool UpdateState(const LottieState& new_state) {
// Regardless of whether the state actually changes, per the web spec, we
// need to dispatch an event signaling that a particular playback state
// was requested.
@@ -69,6 +69,26 @@
return true;
}
+ // Return true if we can freeze the animation, i.e. the animation is
+ // currently playing.
+ bool FreezeAnimationState() {
+ if (state == LottieState::kPlaying) {
+ state = LottieState::kFrozen;
+ return true;
+ }
+ return false;
+ }
+
+ // Return true if we can unfreeze the animation, i.e. the animation is
+ // currently frozen.
+ bool UnfreezeAnimationState() {
+ if (state == LottieState::kFrozen) {
+ state = LottieState::kPlaying;
+ return true;
+ }
+ return false;
+ }
+
// Return true if |count| is updated to a new & valid number.
bool UpdateCount(int new_count) {
// |count| must be positive.
@@ -199,17 +219,44 @@
base::Closure oncomplete_callback;
base::Closure onloop_callback;
base::Callback<void(double, double)> onenterframe_callback;
+ base::Closure onfreeze_callback;
+ base::Closure onunfreeze_callback;
};
- virtual void SetProperties(LottieProperties properties) = 0;
+ void BeginRenderFrame(const LottieProperties& properties) {
+ // Trigger callback if playback state changed.
+ if (played_this_frame_ && properties.state == LottieState::kFrozen &&
+ !properties_.onunfreeze_callback.is_null()) {
+ properties_.onunfreeze_callback.Run();
+ }
+ if (!played_this_frame_ && properties.state == LottieState::kPlaying &&
+ !properties_.onfreeze_callback.is_null()) {
+ properties_.onfreeze_callback.Run();
+ }
+ played_this_frame_ = false;
+ properties_ = properties;
+ }
- virtual void SetAnimationTime(base::TimeDelta animate_function_time) = 0;
+ void SetAnimationTime(base::TimeDelta animate_function_time) {
+ played_this_frame_ = true;
+ SetAnimationTimeInternal(animate_function_time);
+ }
protected:
virtual ~LottieAnimation() {}
// Allow the reference counting system access to our destructor.
friend class base::RefCountedThreadSafe<LottieAnimation>;
+
+ virtual void SetAnimationTimeInternal(
+ base::TimeDelta animate_function_time) = 0;
+
+ LottieProperties properties_;
+
+ private:
+ // A flag that will be set to true only if the animation is visible onscreen
+ // and is rendered.
+ bool played_this_frame_ = false;
};
} // namespace render_tree
diff --git a/src/cobalt/renderer/rasterizer/egl/render_tree_node_visitor.cc b/src/cobalt/renderer/rasterizer/egl/render_tree_node_visitor.cc
index 07b7cea..3301a4b 100644
--- a/src/cobalt/renderer/rasterizer/egl/render_tree_node_visitor.cc
+++ b/src/cobalt/renderer/rasterizer/egl/render_tree_node_visitor.cc
@@ -613,6 +613,10 @@
}
void RenderTreeNodeVisitor::Visit(render_tree::LottieNode* lottie_node) {
+ if (!IsVisible(lottie_node->GetBounds())) {
+ return;
+ }
+
// Use Skottie to render Lottie animations.
FallbackRasterize(lottie_node);
}
diff --git a/src/cobalt/renderer/rasterizer/pixel_test.cc b/src/cobalt/renderer/rasterizer/pixel_test.cc
index 55ab832..ae27062 100644
--- a/src/cobalt/renderer/rasterizer/pixel_test.cc
+++ b/src/cobalt/renderer/rasterizer/pixel_test.cc
@@ -4137,7 +4137,7 @@
reinterpret_cast<char*>(&animation_data[0]), animation_data.size());
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4154,7 +4154,7 @@
reinterpret_cast<char*>(&animation_data[0]), animation_data.size());
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4171,7 +4171,7 @@
reinterpret_cast<char*>(&animation_data[0]), animation_data.size());
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4190,7 +4190,7 @@
// An animation must start playing before it can be paused.
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateState(LottieAnimation::LottieState::kPaused);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4207,7 +4207,7 @@
reinterpret_cast<char*>(&animation_data[0]), animation_data.size());
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kStopped);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4224,7 +4224,7 @@
reinterpret_cast<char*>(&animation_data[0]), animation_data.size());
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.SeekFrame(10);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4241,7 +4241,7 @@
reinterpret_cast<char*>(&animation_data[0]), animation_data.size());
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.SeekPercent(50);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4259,7 +4259,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateDirection(-1);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4277,7 +4277,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4297,7 +4297,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(false);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4318,7 +4318,7 @@
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
lottie_properties.UpdateCount(2);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4339,7 +4339,7 @@
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
lottie_properties.UpdateCount(2);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4360,7 +4360,7 @@
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
lottie_properties.UpdateMode(LottieAnimation::LottieMode::kBounce);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4380,7 +4380,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateSpeed(2);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4399,7 +4399,7 @@
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(false);
lottie_properties.ToggleLooping();
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4420,7 +4420,7 @@
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
lottie_properties.ToggleLooping();
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4440,7 +4440,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kStopped);
lottie_properties.TogglePlay();
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4459,7 +4459,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPaused);
lottie_properties.TogglePlay();
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4478,7 +4478,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.TogglePlay();
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4497,7 +4497,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
@@ -4515,7 +4515,7 @@
LottieAnimation::LottieProperties lottie_properties;
lottie_properties.UpdateState(LottieAnimation::LottieState::kPlaying);
lottie_properties.UpdateLoop(true);
- animation->SetProperties(lottie_properties);
+ animation->BeginRenderFrame(lottie_properties);
LottieNode::Builder node_builder =
LottieNode::Builder(animation, RectF(output_surface_size()));
diff --git a/src/cobalt/renderer/rasterizer/skia/skottie_animation.cc b/src/cobalt/renderer/rasterizer/skia/skottie_animation.cc
index 71af29e..4fae87f 100644
--- a/src/cobalt/renderer/rasterizer/skia/skottie_animation.cc
+++ b/src/cobalt/renderer/rasterizer/skia/skottie_animation.cc
@@ -30,11 +30,8 @@
json_size_in_bytes_ = builder.getStats().fJsonSize;
}
-void SkottieAnimation::SetProperties(LottieProperties properties) {
- properties_ = properties;
-}
-
-void SkottieAnimation::SetAnimationTime(base::TimeDelta animate_function_time) {
+void SkottieAnimation::SetAnimationTimeInternal(
+ base::TimeDelta animate_function_time) {
// Seeking to a particular frame takes precedence over normal playback.
// Check whether "seek()" has been called but has yet to occur.
if (seek_counter_ != properties_.seek_counter) {
@@ -75,7 +72,6 @@
return;
}
- DCHECK(properties_.state == LottieState::kPlaying);
base::TimeDelta current_animation_time = last_updated_animation_time_;
base::TimeDelta time_elapsed =
animate_function_time - last_updated_animate_function_time_;
@@ -131,6 +127,8 @@
void SkottieAnimation::UpdateAnimationFrameAndAnimateFunctionTimes(
base::TimeDelta current_animation_time,
base::TimeDelta current_animate_function_time) {
+ last_updated_animate_function_time_ = current_animate_function_time;
+
if (current_animation_time == last_updated_animation_time_) {
return;
}
@@ -146,7 +144,6 @@
}
last_updated_animation_time_ = current_animation_time;
- last_updated_animate_function_time_ = current_animate_function_time;
}
} // namespace skia
diff --git a/src/cobalt/renderer/rasterizer/skia/skottie_animation.h b/src/cobalt/renderer/rasterizer/skia/skottie_animation.h
index f6cd6eb..3d5531c 100644
--- a/src/cobalt/renderer/rasterizer/skia/skottie_animation.h
+++ b/src/cobalt/renderer/rasterizer/skia/skottie_animation.h
@@ -37,9 +37,7 @@
bool IsOpaque() const override { return false; }
- void SetProperties(LottieProperties properties) override;
-
- void SetAnimationTime(base::TimeDelta animate_function_time) override;
+ void SetAnimationTimeInternal(base::TimeDelta animate_function_time) override;
sk_sp<skottie::Animation> GetSkottieAnimation() { return skottie_animation_; }
@@ -52,7 +50,6 @@
math::Size animation_size_;
uint32 json_size_in_bytes_;
- LottieProperties properties_;
// |seek_counter_| is used to indicate whether a particular seek has already
// been processed. When |LottieProperties::seek_counter| is different, then
// the requested seek should be performed and |seek_counter_| updated to match
diff --git a/src/cobalt/script/v8c/isolate_fellowship.cc b/src/cobalt/script/v8c/isolate_fellowship.cc
index 8bb2a29..541278e 100644
--- a/src/cobalt/script/v8c/isolate_fellowship.cc
+++ b/src/cobalt/script/v8c/isolate_fellowship.cc
@@ -97,9 +97,6 @@
// to write the snapshot data. We need to make sure all global command line
// flags are set before that.
V8FlagsInit();
-#if !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
- InitializeStartupData();
-#endif // !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
}
IsolateFellowship::~IsolateFellowship() {
@@ -111,156 +108,8 @@
delete array_buffer_allocator;
array_buffer_allocator = nullptr;
-#if !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
- // Note that both us and V8 will have created this with new[], see
- // "snapshot-common.cc". Also note that both startup data creation failure
- // from V8 is possible, and deleting a null pointer is safe, so there is no
- // DCHECK here.
- delete[] startup_data.data;
- startup_data = {nullptr, 0};
-#endif // !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
}
-#if !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
-void IsolateFellowship::InitializeStartupData() {
- TRACE_EVENT0("cobalt::script", "IsolateFellowship::InitializeStartupData");
- DCHECK(startup_data.data == nullptr);
-
- std::vector<char> cache_path(kSbFileMaxPath);
- if (!SbSystemGetPath(kSbSystemPathCacheDirectory, cache_path.data(),
- cache_path.size())) {
- // If there is no cache directory, then just save the startup data in
- // memory.
- LOG(WARNING) << "Unable to read/write V8 startup snapshot data to file.";
- startup_data = v8::SnapshotCreator().CreateBlob(
- v8::SnapshotCreator::FunctionCodeHandling::kKeep);
- return;
- }
-
- // Whether or not we should attempt to remove the existing cache file due to
- // it being in an invalid state. We will do so in the case that it either
- // was of size 0 (but existed), or we failed to write it.
- bool should_remove_cache_file = false;
-
- // Attempt to read the cache file.
- std::string snapshot_file_full_path =
- std::string(cache_path.data()) + kSbFileSepString +
- V8C_INTERNAL_STARTUP_DATA_CACHE_FILE_NAME;
- bool read_file = ([&]() {
- starboard::ScopedFile scoped_file(snapshot_file_full_path.c_str(),
- kSbFileOpenOnly | kSbFileRead);
- if (!scoped_file.IsValid()) {
- LOG(INFO) << "Can not open snapshot file";
- return false;
- }
-
- int64_t size = scoped_file.GetSize();
- if (size == -1) {
- LOG(ERROR) << "Received size of -1 for file that was valid.";
- return false;
- }
-
- if (size == 0) {
- LOG(ERROR) << "Read V8 snapshot file of size 0.";
- should_remove_cache_file = true;
- return false;
- }
- int64_t data_size = size - sizeof(kIsolateFellowshipBuildTime);
-
- char snapshot_time[sizeof(kIsolateFellowshipBuildTime)];
- int read =
- scoped_file.ReadAll(snapshot_time, sizeof(kIsolateFellowshipBuildTime));
- // Logically, this could be collapsed to just "read != data_size", but this
- // should be read as "if the platform explicitly told us reading failed,
- // or the platform told us we read less than we expected".
- if (read == -1 || read != sizeof(kIsolateFellowshipBuildTime)) {
- LOG(ERROR) << "Reading V8 startup snapshot time failed.";
- should_remove_cache_file = true;
- return false;
- }
-
- // kIsolateFellowshipBuildTime is an auto-generated/updated time stamp when
- // v8 target is compiled to update snapshot data after any v8 change.
- if (SbMemoryCompare(snapshot_time, kIsolateFellowshipBuildTime,
- sizeof(kIsolateFellowshipBuildTime)) != 0) {
- LOG(INFO) << "V8 code was modified since last V8 startup snapshot cache "
- "file was generated, creating a new one.";
- should_remove_cache_file = true;
- return false;
- }
-
- std::unique_ptr<char[]> data(new char[data_size]);
- read = scoped_file.ReadAll(data.get(), data_size);
- if (read == -1 || read != data_size) {
- LOG(ERROR) << "Reading V8 startup snapshot cache file failed for some "
- "unknown reason.";
- should_remove_cache_file = true;
- return false;
- }
-
- LOG(INFO) << "Successfully read V8 startup snapshot cache file.";
- startup_data.data = data.release();
- startup_data.raw_size = data_size;
- return true;
- })();
-
- auto maybe_remove_cache_file = [&]() {
- if (should_remove_cache_file) {
- if (!SbFileDelete(snapshot_file_full_path.c_str())) {
- LOG(ERROR) << "Failed to delete V8 startup snapshot cache file.";
- }
- should_remove_cache_file = false;
- }
- };
- maybe_remove_cache_file();
-
- // If we failed to read the file, then create the snapshot data and attempt
- // to write it.
- if (!read_file) {
- ([&]() {
- startup_data = v8::SnapshotCreator().CreateBlob(
- v8::SnapshotCreator::FunctionCodeHandling::kKeep);
- if (startup_data.data == nullptr) {
- // Trust the V8 API, but verify. |raw_size| should also be 0.
- DCHECK_EQ(startup_data.raw_size, 0);
- // This is technically legal w.r.t. to the API documentation, but
- // *probably* indicates a serious problem (are you hacking V8
- // internals or something?).
- LOG(WARNING) << "Failed to create V8 startup snapshot.";
- return;
- }
-
- starboard::ScopedFile scoped_file(snapshot_file_full_path.c_str(),
- kSbFileCreateOnly | kSbFileWrite);
- if (!scoped_file.IsValid()) {
- LOG(ERROR)
- << "Failed to open V8 startup snapshot cache file for writing.";
- return;
- }
-
- int written = scoped_file.WriteAll(kIsolateFellowshipBuildTime,
- sizeof(kIsolateFellowshipBuildTime));
- if (written < sizeof(kIsolateFellowshipBuildTime)) {
- LOG(ERROR) << "Failed to write V8 startup snapshot time.";
- should_remove_cache_file = true;
- return;
- }
-
- written = scoped_file.WriteAll(startup_data.data, startup_data.raw_size);
- if (written < startup_data.raw_size) {
- LOG(ERROR) << "Failed to write entire V8 startup snapshot.";
- should_remove_cache_file = true;
- return;
- }
-
- LOG(INFO) << "Successfully wrote V8 startup snapshot cache file.";
- })();
- }
-
- maybe_remove_cache_file();
-}
-#endif // !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
-
} // namespace v8c
} // namespace script
} // namespace cobalt
diff --git a/src/cobalt/script/v8c/isolate_fellowship.h b/src/cobalt/script/v8c/isolate_fellowship.h
index 5f36845..e90267c 100644
--- a/src/cobalt/script/v8c/isolate_fellowship.h
+++ b/src/cobalt/script/v8c/isolate_fellowship.h
@@ -40,9 +40,6 @@
std::unique_ptr<CobaltPlatform> platform;
v8::ArrayBuffer::Allocator* array_buffer_allocator = nullptr;
-#if !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
- v8::StartupData startup_data = {nullptr, 0};
-#endif // !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
friend struct base::StaticMemorySingletonTraits<IsolateFellowship>;
@@ -50,13 +47,6 @@
IsolateFellowship();
~IsolateFellowship();
-#if !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
- // Initialize |startup_data| by either reading it from a cache file or
- // creating it. If creating it for the first time, then when appropriate
- // (i.e. the platform has a suitable directory) attempt to write it to a cache
- // file.
- void InitializeStartupData();
-#endif // !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
};
} // namespace v8c
diff --git a/src/cobalt/script/v8c/v8c_engine.cc b/src/cobalt/script/v8c/v8c_engine.cc
index 90fe4cf..d3b8285 100644
--- a/src/cobalt/script/v8c/v8c_engine.cc
+++ b/src/cobalt/script/v8c/v8c_engine.cc
@@ -121,17 +121,6 @@
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator =
isolate_fellowship->array_buffer_allocator;
-#if !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
- auto* startup_data = &isolate_fellowship->startup_data;
- if (startup_data->data != nullptr) {
- create_params.snapshot_blob = startup_data;
- } else {
- // Technically possible to attempt to recover here, but hitting this
- // indicates that something is probably seriously wrong.
- LOG(WARNING) << "Isolate fellowship startup data was null, this will "
- "significantly slow down startup time.";
- }
-#endif // !defined(COBALT_V8_BUILDTIME_SNAPSHOT)
isolate_ = v8::Isolate::New(create_params);
CHECK(isolate_);
diff --git a/src/cobalt/site/docs/reference/starboard/configuration-public.md b/src/cobalt/site/docs/reference/starboard/configuration-public.md
index c3cbb64..3b30513 100644
--- a/src/cobalt/site/docs/reference/starboard/configuration-public.md
+++ b/src/cobalt/site/docs/reference/starboard/configuration-public.md
@@ -69,7 +69,7 @@
| Properties |
| :--- |
-| **`SB_HAS_QUIRK_SEEK_TO_KEYFRAME`**<br><br>After a seek is triggered, the default behavior is to append video frames from the last keyframe before the seek time and append audio frames from the seek time because usually all audio frames are keyframes. On platforms that cannot decode video frames without displaying them, this will cause the video being played without audio for several seconds after seeking. When the following macro is defined, the app will append audio frames start from the timestamp that is before the timestamp of the video keyframe being appended.<br><br>By default, this property is undefined.<br><br>This quirk is **deprecated in Starboard version 12 or later**. On platforms in Starboard version 12 or later that require this feature, the implementation should skip all video frames before the second video keyframe, and skip all audio access units whose timestamps are before the timestamp of the second video frame.<br><br>It is worth noting that after a seek the H5 player only needs to append audio access units right before the seek time, instead of before the first video keyframe. The H5 player used to have a special workaround to append audio access units before the first video keyframe after a seek to make this quirk possible, and the special workaround is no longer supported. To skip all audio and video access units before the second video frame as mentioned above allows the Starboard implementation to no longer depend on any special workaround of the H5 player.||
+| **`SB_HAS_QUIRK_SEEK_TO_KEYFRAME`**<br><br>After a seek is triggerred, the default behavior is to append video frames from the last key frame before the seek time and append audio frames from the seek time because usually all audio frames are key frames. On platforms that cannot decode video frames without displaying them, this will cause the video being played without audio for several seconds after seeking. When the following macro is defined, the app will append audio frames start from the timestamp that is before the timestamp of the video key frame being appended. This quirk has been deprecated in Starboard version 12 or later. Please see `configuration_public.md` for more details.<br><br>By default, this property is undefined. |
| **`SB_HAS_QUIRK_SUPPORT_INT16_AUDIO_SAMPLES`**<br><br>The implementation is allowed to support kSbMediaAudioSampleTypeInt16 only when this macro is defined.<br><br>By default, this property is undefined. |
| **`SB_HAS_QUIRK_NO_FFS`**<br><br>dlmalloc will use the ffs intrinsic if available. Platforms on which this is not available should define the following quirk.<br><br>By default, this property is undefined. |
diff --git a/src/cobalt/site/docs/reference/starboard/gyp-configuration.md b/src/cobalt/site/docs/reference/starboard/gyp-configuration.md
index dafe5e9..5ae384b 100644
--- a/src/cobalt/site/docs/reference/starboard/gyp-configuration.md
+++ b/src/cobalt/site/docs/reference/starboard/gyp-configuration.md
@@ -41,7 +41,6 @@
| **`cobalt_platform_dependencies`**<br><br> List of platform-specific targets that get compiled into cobalt.<br><br>The default value is `[]`. |
| **`cobalt_splash_screen_file`**<br><br> The path to a splash screen to copy into content/data/web which can be accessed via a file URL starting with "file:///cobalt/browser/splash_screen/". If '', no file is copied.<br><br>The default value is `''`. |
| **`cobalt_user_on_exit_strategy`**<br><br> Deprecated. Implement the CobaltExtensionConfigurationApi function CobaltUserOnExitStrategy instead. This variable defines what Cobalt's preferred strategy should be for handling internally triggered application exit requests (e.g. the user chooses to back out of the application).<ul><li><code>stop</code> - The application should call SbSystemRequestStop() on exit, resulting in a complete shutdown of the application.<li><code>suspend</code> - The application should call SbSystemRequestSuspend() on exit, resulting in the application being "minimized".<li><code>noexit</code> - The application should never allow the user to trigger an exit, this will be managed by the system.<br><br>The default value is `''`. |
-| **`cobalt_v8_buildtime_snapshot`**<br><br> Set to "true" to enable v8 snapshot generation at Cobalt build time.<br><br>The default value is `'<(cobalt_v8_buildtime_snapshot)'`. |
| **`cobalt_v8_emit_builtins_as_inline_asm`**<br><br> Some compiler can not compile with raw assembly(.S files) and v8 converts asm to inline assembly for these platforms.<br><br>The default value is `1`. |
| **`cobalt_v8_enable_embedded_builtins`**<br><br> We need to define some variables inside of an inner 'variables' scope so that they can be referenced by other outer variables here. Also, it allows for the specification of default values that get referenced by a top level scope.<br><br>The default value is `1`. |
| **`cobalt_version`**<br><br> Build version number.<br><br>The default value is `'<(BUILD_NUMBER)'`. |
@@ -57,7 +56,7 @@
| **`defines_qa`**<br><br> For qa and gold configs, different compiler flags may be specified for gyp targets that should be built for size than for speed. Targets which specify 'optimize_target_for_speed == 1', will compile with flags: ['compiler_flags_*<config>', 'compiler_flags_*<config>_speed']. Otherwise, targets will use compiler flags: ['compiler_flags_*<config>', 'compiler_flags_*<config>_size']. Platforms may decide to use the same optimization flags for both target types by leaving the '*_size' and '*_speed' variables empty.<br><br>The default value is `[]`. |
| **`enable_account_manager`**<br><br> Set to 1 to enable H5vccAccountManager.<br><br>The default value is `0`. |
| **`enable_configure_request_job_factory`**<br><br> Set to 1 to enable setting Interceptors on the URLRequestJobFactory<br><br>The default value is `0`. |
-| **`enable_crash_log`**<br><br> Set to 1 to enable H5vccCrashLog.<br><br>The default value is `0`. |
+| **`enable_crash_log`**<br><br> Set to 1 to enable H5vccCrashLog.<br><br>The default value is `1`. |
| **`enable_map_to_mesh`**<br><br> Enable support for the map to mesh filter, which is primarily used to implement spherical video playback. This setting is deprecated in favor of the cobalt graphics extension (CobaltGraphicsExtensionApi) function `IsMapToMeshEnabled()`. If the CobaltGraphicsExtensionApi is not implemented, then Cobalt will fall back onto a default. For starboard API versions 12 and later, the default is true (i.e. Cobalt will assume map to mesh is supported). For earlier starboard API versions, if this gyp variable is redefined to a value other than -1, it will use the new value as the default. If it is not redefined, the default is false.<br><br>The default value is `-1`. |
| **`enable_sso`**<br><br> Set to 1 to enable H5vccSSO (Single Sign On).<br><br>The default value is `0`. |
| **`enable_xhr_header_filtering`**<br><br> Set to 1 to enable filtering of HTTP headers before sending.<br><br>The default value is `0`. |
@@ -87,6 +86,7 @@
| **`render_dirty_region_only`**<br><br> Deprecated. Implement the CobaltExtensionConfigurationApi function CobaltRenderDirtyRegionOnly instead. If set to 1, will enable support for rendering only the regions of the display that are modified due to animations, instead of re-rendering the entire scene each frame. This feature can reduce startup time where usually there is a small loading spinner animating on the screen. On GLES renderers, Cobalt will attempt to implement this support by using eglSurfaceAttrib(..., EGL_SWAP_BEHAVIOR, EGL_BUFFER_PRESERVED), otherwise the dirty region will be silently disabled. On Blitter API platforms, if this is enabled, we explicitly create an extra offscreen full-size intermediate surface to render into. Note that some GLES driver implementations may internally allocate an extra full screen surface to support this feature, and many have been noticed to not properly support this functionality (but they report that they do), and for these reasons this value is defaulted to 0.<br><br>The default value is `-1`. |
| **`sb_api_version`**<br><br> The Starboard API version of the current build configuration. The default value is meant to be overridden by a Starboard ABI file.<br><br>The default value is `0`. |
| **`sb_deploy_output_dir`**<br><br> Top-level directory for staging deploy build output. Platform deploy actions should use <(target_deploy_dir) defined in deploy.gypi to place artifacts for each deploy target in its own subdirectoy.<br><br>The default value is `'<(sb_deploy_output_dir)'`. |
+| **`sb_disable_cpp14_audit`**<br><br> Disables an NPLB audit of C++14 support.<br><br>The default value is `0`. |
| **`sb_disable_microphone_idl`**<br><br> When this is set to true, the web bindings for the microphone are disabled<br><br>The default value is `0`. |
| **`sb_enable_benchmark`**<br><br> Used to enable benchmarks.<br><br>The default value is `0`. |
| **`sb_enable_lib`**<br><br> Enables embedding Cobalt as a shared library within another app. This requires a 'lib' starboard implementation for the corresponding platform.<br><br>The default value is `'<(sb_enable_lib)'`. |
diff --git a/src/cobalt/site/docs/reference/starboard/modules/12/media.md b/src/cobalt/site/docs/reference/starboard/modules/12/media.md
index 8d94612..5a50b33 100644
--- a/src/cobalt/site/docs/reference/starboard/modules/12/media.md
+++ b/src/cobalt/site/docs/reference/starboard/modules/12/media.md
@@ -653,18 +653,6 @@
bool SbMediaIsBufferUsingMemoryPool()
```
-### SbMediaIsOutputProtected ###
-
-Indicates whether output copy protection is currently enabled on all capable
-outputs. If `true`, then non-protection-capable outputs are expected to be
-blanked.
-
-#### Declaration ####
-
-```
-bool SbMediaIsOutputProtected()
-```
-
### SbMediaIsSupported ###
Indicates whether this platform supports decoding `video_codec` and
@@ -701,20 +689,3 @@
void SbMediaSetAudioWriteDuration(SbTime duration)
```
-### SbMediaSetOutputProtection ###
-
-Enables or disables output copy protection on all capable outputs. If enabled,
-then non-protection-capable outputs are expected to be blanked.
-
-The return value indicates whether the operation was successful, and the
-function returns a success even if the call is redundant in that it doesn't
-change the current value.
-
-`enabled`: Indicates whether output protection is enabled (`true`) or disabled.
-
-#### Declaration ####
-
-```
-bool SbMediaSetOutputProtection(bool enabled)
-```
-
diff --git a/src/cobalt/site/docs/reference/starboard/modules/media.md b/src/cobalt/site/docs/reference/starboard/modules/media.md
index 8d94612..5a50b33 100644
--- a/src/cobalt/site/docs/reference/starboard/modules/media.md
+++ b/src/cobalt/site/docs/reference/starboard/modules/media.md
@@ -653,18 +653,6 @@
bool SbMediaIsBufferUsingMemoryPool()
```
-### SbMediaIsOutputProtected ###
-
-Indicates whether output copy protection is currently enabled on all capable
-outputs. If `true`, then non-protection-capable outputs are expected to be
-blanked.
-
-#### Declaration ####
-
-```
-bool SbMediaIsOutputProtected()
-```
-
### SbMediaIsSupported ###
Indicates whether this platform supports decoding `video_codec` and
@@ -701,20 +689,3 @@
void SbMediaSetAudioWriteDuration(SbTime duration)
```
-### SbMediaSetOutputProtection ###
-
-Enables or disables output copy protection on all capable outputs. If enabled,
-then non-protection-capable outputs are expected to be blanked.
-
-The return value indicates whether the operation was successful, and the
-function returns a success even if the call is redundant in that it doesn't
-change the current value.
-
-`enabled`: Indicates whether output protection is enabled (`true`) or disabled.
-
-#### Declaration ####
-
-```
-bool SbMediaSetOutputProtection(bool enabled)
-```
-
diff --git a/src/cobalt/subtlecrypto/subtle_crypto.cc b/src/cobalt/subtlecrypto/subtle_crypto.cc
index 0634745..28bdce6 100644
--- a/src/cobalt/subtlecrypto/subtle_crypto.cc
+++ b/src/cobalt/subtlecrypto/subtle_crypto.cc
@@ -27,8 +27,6 @@
namespace {
-// TODO: Test performance for large input data, and evaluate
-// removing copies of inputs to a vector.
const ByteVector to_vector(const dom::BufferSource &data) {
const uint8_t *buff;
int buf_len;
@@ -40,18 +38,21 @@
return algo.has_name() ? algo.name() : "";
}
-std::string to_string(SubtleCrypto::AlgorithmIdentifier algorithm) {
- return algorithm.IsType<std::string>()
- ? algorithm.AsType<std::string>()
- : algo_name(algorithm.AsType<Algorithm>());
-}
-
template <typename T, typename W>
-std::string getName(const W &algorithm) {
+std::string get_name(const W &algorithm) {
if (algorithm.template IsType<T>()) {
return algo_name(algorithm.template AsType<T>());
}
- return "";
+ return std::is_same<T, Algorithm>::value ? ""
+ : get_name<Algorithm>(algorithm);
+}
+
+template <typename T = Algorithm, typename W>
+std::string get_name_or_string(const W &algorithm) {
+ if (algorithm.template IsType<T>()) {
+ return algo_name(algorithm.template AsType<T>());
+ }
+ return algorithm.template AsType<std::string>();
}
template <typename Promise>
@@ -108,9 +109,7 @@
// parameter passed to the decrypt method.
// 3. Let normalizedAlgorithm be the result of normalizing an algorithm, with
// alg set to algorithm and op set to "decrypt".
- std::string normalizedAlgorithm = getName<AesCtrParams>(algorithm);
- if (normalizedAlgorithm.empty())
- normalizedAlgorithm = getName<Algorithm>(algorithm);
+ std::string normalizedAlgorithm = get_name<AesCtrParams>(algorithm);
// 5. Let promise be a new Promise.
auto promise = CreatePromise();
// 4. If an error occurred, return a Promise rejected with
@@ -169,9 +168,7 @@
// parameter passed to the encrypt method.
// 3. Let normalizedAlgorithm be the result of normalizing an algorithm, with
// alg set to algorithm and op set to "encrypt".
- std::string normalizedAlgorithm = getName<AesCtrParams>(algorithm);
- if (normalizedAlgorithm.empty())
- normalizedAlgorithm = getName<Algorithm>(algorithm);
+ std::string normalizedAlgorithm = get_name<AesCtrParams>(algorithm);
// 5. Let promise be a new Promise.
auto promise = CreatePromise();
// 4. If an error occurred, return a Promise rejected with
@@ -228,7 +225,7 @@
// parameter passed to the sign method.
// 3. Let normalizedAlgorithm be the result of normalizing an algorithm, with
// alg set to algorithm and op set to "sign".
- std::string normalizedAlgorithm = getName<Algorithm>(algorithm);
+ std::string normalizedAlgorithm = get_name_or_string(algorithm);
// 5. Let promise be a new Promise.
auto promise = CreatePromise();
if (normalizedAlgorithm == "HMAC") {
@@ -264,7 +261,7 @@
// parameter passed to the verify method.
// 4. Let normalizedAlgorithm be the result of normalizing an algorithm, with
// alg set to algorithm and op set to "verify".
- std::string normalizedAlgorithm = getName<Algorithm>(algorithm);
+ std::string normalizedAlgorithm = get_name_or_string(algorithm);
// 6. Let promise be a new Promise.
auto promise = CreatePromise<PromiseBool, bool>();
if (normalizedAlgorithm == "HMAC") {
@@ -297,7 +294,7 @@
// parameter passed to the digest method.
// 3. Let normalizedAlgorithm be the result of normalizing an algorithm, with
// alg set to algorithm and op set to "digest".
- auto normalizedAlgorithm = to_string(algorithm);
+ auto normalizedAlgorithm = get_name_or_string(algorithm);
// 5. Let promise be a new Promise.
auto promise = CreatePromise();
auto hash = Hash::CreateByName(normalizedAlgorithm);
@@ -351,7 +348,7 @@
// 3. Let normalizedAlgorithm be the result of normalizing an algorithm, with
// alg set to algorithm and op set to "importKey".
std::string normalizedAlgorithm =
- getName<ImportKeyAlgorithmParams>(algorithm);
+ get_name_or_string<ImportKeyAlgorithmParams>(algorithm);
// 5. Let promise be a new Promise.
auto promise = CreateKeyPromise();
diff --git a/src/cobalt/test/document_loader.h b/src/cobalt/test/document_loader.h
index 0e2730b..83aa262 100644
--- a/src/cobalt/test/document_loader.h
+++ b/src/cobalt/test/document_loader.h
@@ -54,10 +54,11 @@
resource_provider_stub_(new render_tree::ResourceProviderStub()),
loader_factory_(new loader::LoaderFactory(
"Test" /* name */, &fetcher_factory_, resource_provider_stub_.get(),
- 0 /* encoded_image_cache_capacity */,
+ debugger_hooks_, 0 /* encoded_image_cache_capacity */,
base::ThreadPriority::BACKGROUND)),
image_cache_(loader::image::CreateImageCache(
- "Test.ImageCache", 32U * 1024 * 1024, loader_factory_.get())),
+ "Test.ImageCache", debugger_hooks_, 32U * 1024 * 1024,
+ loader_factory_.get())),
dom_stat_tracker_(new dom::DomStatTracker("IsDisplayedTest")),
resource_provider_(resource_provider_stub_.get()),
html_element_context_(
@@ -108,6 +109,7 @@
base::RunLoop nested_loop_;
dom::testing::StubEnvironmentSettings environment_settings_;
+ base::NullDebuggerHooks debugger_hooks_;
script::FakeScriptRunner script_runner_;
loader::FetcherFactory fetcher_factory_;
std::unique_ptr<css_parser::Parser> css_parser_;
diff --git a/src/cobalt/updater/crash_client.cc b/src/cobalt/updater/crash_client.cc
index d989e2a..25029db 100644
--- a/src/cobalt/updater/crash_client.cc
+++ b/src/cobalt/updater/crash_client.cc
@@ -13,7 +13,7 @@
#include "base/path_service.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
-#include "cobalt/updater/util.h"
+#include "cobalt/updater/utils.h"
#include "third_party/crashpad/crashpad/client/crash_report_database.h"
#include "third_party/crashpad/crashpad/client/crashpad_client.h"
#include "third_party/crashpad/crashpad/client/prune_crash_reports.h"
diff --git a/src/cobalt/updater/crash_reporter.cc b/src/cobalt/updater/crash_reporter.cc
index 611f39a..54bfece 100644
--- a/src/cobalt/updater/crash_reporter.cc
+++ b/src/cobalt/updater/crash_reporter.cc
@@ -19,7 +19,7 @@
#include "base/strings/utf_string_conversions.h"
#include "cobalt/updater/updater_constants.h"
// #include "cobalt/updater/updater_version.h"
-#include "cobalt/updater/util.h"
+#include "cobalt/updater/utils.h"
// #include "third_party/crashpad/crashpad/client/crashpad_client.h"
// #include "third_party/crashpad/crashpad/handler/handler_main.h"
diff --git a/src/cobalt/updater/prefs.cc b/src/cobalt/updater/prefs.cc
index 2849292..0f3aed1 100644
--- a/src/cobalt/updater/prefs.cc
+++ b/src/cobalt/updater/prefs.cc
@@ -4,9 +4,12 @@
#include "cobalt/updater/prefs.h"
+#include <string>
+
#include "base/files/file_path.h"
#include "base/memory/scoped_refptr.h"
-#include "cobalt/updater/util.h"
+#include "cobalt/extension/installation_manager.h"
+#include "cobalt/updater/utils.h"
#include "components/prefs/json_pref_store.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/pref_service.h"
@@ -20,9 +23,27 @@
base::FilePath product_data_dir;
if (!GetProductDirectory(&product_data_dir)) return nullptr;
+ const CobaltExtensionInstallationManagerApi* installation_api =
+ static_cast<const CobaltExtensionInstallationManagerApi*>(
+ SbSystemGetExtension(kCobaltExtensionInstallationManagerName));
+ if (!installation_api) {
+ SB_LOG(ERROR) << "Failed to get installation manager api.";
+ return nullptr;
+ }
+ char app_key[IM_EXT_MAX_APP_KEY_LENGTH];
+ if (installation_api->GetAppKey(app_key, IM_EXT_MAX_APP_KEY_LENGTH) ==
+ IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "Failed to get app key.";
+ return nullptr;
+ }
+
+ SB_LOG(INFO) << "Updater: prefs app_key=" << app_key;
PrefServiceFactory pref_service_factory;
+ std::string file_name = "prefs_";
+ file_name += app_key;
+ file_name += ".json";
pref_service_factory.set_user_prefs(base::MakeRefCounted<JsonPrefStore>(
- product_data_dir.Append(FILE_PATH_LITERAL("prefs.json"))));
+ product_data_dir.Append(FILE_PATH_LITERAL(file_name))));
auto pref_registry = base::MakeRefCounted<PrefRegistrySimple>();
update_client::RegisterPrefs(pref_registry.get());
diff --git a/src/cobalt/updater/updater.cc b/src/cobalt/updater/updater.cc
index 1237e18..8f77701 100644
--- a/src/cobalt/updater/updater.cc
+++ b/src/cobalt/updater/updater.cc
@@ -38,8 +38,6 @@
#include "base/time/time.h"
#include "cobalt/network/network_module.h"
#include "cobalt/updater/configurator.h"
-#include "cobalt/updater/crash_client.h"
-#include "cobalt/updater/crash_reporter.h"
#include "cobalt/updater/updater_module.h"
#include "components/crx_file/crx_verifier.h"
#include "components/prefs/pref_service.h"
diff --git a/src/cobalt/updater/updater.gyp b/src/cobalt/updater/updater.gyp
index eed5845..e603703 100644
--- a/src/cobalt/updater/updater.gyp
+++ b/src/cobalt/updater/updater.gyp
@@ -22,11 +22,6 @@
'configurator.h',
'network_fetcher.cc',
'network_fetcher.h',
- # TODO: enable crash report later with crashpad dependency
- #'crash_client.cc',
- #'crash_client.h',
- #'crash_reporter.cc',
- #'crash_reporter.h',
'patcher.cc',
'patcher.h',
'prefs.cc',
@@ -37,8 +32,8 @@
'updater_module.h',
'updater_constants.cc',
'updater_constants.h',
- 'util.cc',
- 'util.h',
+ 'utils.cc',
+ 'utils.h',
],
'dependencies': [
'<(DEPTH)/base/base.gyp:base',
@@ -49,6 +44,8 @@
'<(DEPTH)/cobalt/script/script.gyp:script',
'<(DEPTH)/components/prefs/prefs.gyp:prefs',
'<(DEPTH)/components/update_client/update_client.gyp:update_client',
+ '<(DEPTH)/starboard/loader_app/app_key_files.gyp:app_key_files',
+ '<(DEPTH)/starboard/loader_app/drain_file.gyp:drain_file',
'<(DEPTH)/third_party/zlib/zlib.gyp:zip',
'<(DEPTH)/url/url.gyp:url',
],
diff --git a/src/cobalt/updater/updater_module.cc b/src/cobalt/updater/updater_module.cc
index c906141..2f00c8a 100644
--- a/src/cobalt/updater/updater_module.cc
+++ b/src/cobalt/updater/updater_module.cc
@@ -34,7 +34,7 @@
#include "cobalt/extension/installation_manager.h"
#include "cobalt/updater/crash_client.h"
#include "cobalt/updater/crash_reporter.h"
-#include "cobalt/updater/util.h"
+#include "cobalt/updater/utils.h"
#include "components/crx_file/crx_verifier.h"
#include "components/update_client/utils.h"
#include "starboard/configuration_constants.h"
@@ -136,19 +136,6 @@
void UpdaterModule::Initialize() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
- // TODO: enable crash report with dependency on CrashPad
- // updater::crash_reporter::InitializeCrashKeys();
-
- // static crash_reporter::CrashKeyString<16> crash_key_process_type(
- // "process_type");
- // crash_key_process_type.Set("updater");
-
- // if (CrashClient::GetInstance()->InitializeCrashReporting())
- // VLOG(1) << "Crash reporting initialized.";
- // else
- // VLOG(1) << "Crash reporting is not available.";
-
- // StartCrashReporter(UPDATER_VERSION_STRING);
updater_configurator_ = base::MakeRefCounted<Configurator>(network_module_);
update_client_ = update_client::UpdateClientFactory(updater_configurator_);
@@ -204,7 +191,7 @@
const std::vector<std::string> app_ids = {
updater_configurator_->GetAppGuid()};
- const base::Version manifest_version(GetEvergreenVersion());
+ const base::Version manifest_version(GetCurrentEvergreenVersion());
if (!manifest_version.IsValid()) {
SB_LOG(ERROR) << "Updater failed to get the current update version.";
return;
diff --git a/src/cobalt/updater/util.h b/src/cobalt/updater/util.h
deleted file mode 100644
index f3d2db6..0000000
--- a/src/cobalt/updater/util.h
+++ /dev/null
@@ -1,26 +0,0 @@
-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COBALT_UPDATER_UTIL_H_
-#define COBALT_UPDATER_UTIL_H_
-
-#include <string>
-
-namespace base {
-class FilePath;
-}
-
-namespace cobalt {
-namespace updater {
-
-// Returns a directory where updater files or its data is stored.
-bool GetProductDirectory(base::FilePath* path);
-
-// Returns the Evergreen version of the running installation.
-const std::string GetEvergreenVersion();
-
-} // namespace updater
-} // namespace cobalt
-
-#endif // COBALT_UPDATER_UTIL_H_
diff --git a/src/cobalt/updater/util.cc b/src/cobalt/updater/utils.cc
similarity index 83%
rename from src/cobalt/updater/util.cc
rename to src/cobalt/updater/utils.cc
index 6dc16d4..dbd2f79 100644
--- a/src/cobalt/updater/util.cc
+++ b/src/cobalt/updater/utils.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "cobalt/updater/util.h"
+#include "cobalt/updater/utils.h"
#include <vector>
@@ -65,7 +65,20 @@
return true;
}
-const std::string GetEvergreenVersion() {
+base::Version ReadEvergreenVersion(base::FilePath installation_dir) {
+ auto manifest = update_client::ReadManifest(installation_dir);
+ if (!manifest) {
+ return base::Version();
+ }
+
+ auto version = manifest->FindKey("version");
+ if (version) {
+ return base::Version(version->GetString());
+ }
+ return base::Version();
+}
+
+const std::string GetCurrentEvergreenVersion() {
auto installation_manager =
static_cast<const CobaltExtensionInstallationManagerApi*>(
SbSystemGetExtension(kCobaltExtensionInstallationManagerName));
@@ -87,19 +100,14 @@
SB_LOG(ERROR) << "Failed to get installation path.";
return "";
}
- auto manifest = update_client::ReadManifest(base::FilePath(
+ base::Version version = ReadEvergreenVersion(base::FilePath(
std::string(installation_path.begin(), installation_path.end())));
- if (!manifest) {
- SB_LOG(ERROR) << "Failed to read the manifest file of the current "
- "installation.";
+
+ if (!version.IsValid()) {
+ SB_LOG(ERROR) << "Failed to get the Everegreen version.";
return "";
}
- auto* version_path = manifest->FindKey("version");
- if (!version_path) {
- SB_LOG(ERROR) << "Failed to find the version in the manifest.";
- return "";
- }
- return version_path->GetString();
+ return version.GetString();
}
} // namespace updater
diff --git a/src/cobalt/updater/utils.h b/src/cobalt/updater/utils.h
new file mode 100644
index 0000000..2a71b5c
--- /dev/null
+++ b/src/cobalt/updater/utils.h
@@ -0,0 +1,31 @@
+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COBALT_UPDATER_UTILS_H_
+#define COBALT_UPDATER_UTILS_H_
+
+#include <string>
+
+#include "base/version.h"
+
+namespace base {
+class FilePath;
+}
+
+namespace cobalt {
+namespace updater {
+
+// Returns a directory where updater files or its data is stored.
+bool GetProductDirectory(base::FilePath* path);
+
+// Returns the Evergreen version of the current installation.
+const std::string GetCurrentEvergreenVersion();
+
+// Read the Evergreen version of the installation dir.
+base::Version ReadEvergreenVersion(base::FilePath installation_dir);
+
+} // namespace updater
+} // namespace cobalt
+
+#endif // COBALT_UPDATER_UTILS_H_
diff --git a/src/cobalt/webdriver/dispatcher.h b/src/cobalt/webdriver/dispatcher.h
index 92f7270..33e812f 100644
--- a/src/cobalt/webdriver/dispatcher.h
+++ b/src/cobalt/webdriver/dispatcher.h
@@ -76,8 +76,8 @@
};
// Send the result of the execution of a registered WebDriver command to be
// sent as a response as described in the spec:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Responses
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Failed_Commands
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Responses
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Failed-Commands
virtual void SendResult(
const base::Optional<protocol::SessionId>& session_id,
protocol::Response::StatusCode status_code,
@@ -95,7 +95,7 @@
// Some forms of Invalid Requests are detected in the CommandCallback by
// checking the path variables and command parameters. Invalid requests are
// described here:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Invalid_Requests
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Invalid-Requests
//
// TODO: Invalid requests should be handled before calling the
// CommandCallback.
diff --git a/src/cobalt/webdriver/protocol/capabilities.h b/src/cobalt/webdriver/protocol/capabilities.h
index 105653a..54ca1b0 100644
--- a/src/cobalt/webdriver/protocol/capabilities.h
+++ b/src/cobalt/webdriver/protocol/capabilities.h
@@ -45,7 +45,7 @@
private:
Capabilities() {}
// The capabilities listed here:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Capabilities_JSON_Object
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Capabilities-JSON-Object
base::Optional<std::string> browser_name_;
base::Optional<std::string> version_;
diff --git a/src/cobalt/webdriver/protocol/element_id.h b/src/cobalt/webdriver/protocol/element_id.h
index dbf8ad7..94b75c3 100644
--- a/src/cobalt/webdriver/protocol/element_id.h
+++ b/src/cobalt/webdriver/protocol/element_id.h
@@ -31,7 +31,7 @@
static const char kElementKey[];
// Convert the ElementId to a WebElement JSON object:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#WebElement_JSON_Object
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#WebElement-JSON-Object
static std::unique_ptr<base::Value> ToValue(const ElementId& element_id);
static base::Optional<ElementId> FromValue(const base::Value* value);
diff --git a/src/cobalt/webdriver/protocol/frame_id.h b/src/cobalt/webdriver/protocol/frame_id.h
index 402061d..4e2e7ce 100644
--- a/src/cobalt/webdriver/protocol/frame_id.h
+++ b/src/cobalt/webdriver/protocol/frame_id.h
@@ -22,7 +22,7 @@
namespace webdriver {
namespace protocol {
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/frame
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidframe
// Since Cobalt doesn't support multiple frames, the only valid value for this
// command is to request switching to the top-level browsing context, which
// is always active.
diff --git a/src/cobalt/webdriver/protocol/log_entry.cc b/src/cobalt/webdriver/protocol/log_entry.cc
index acc4bd2..297c084 100644
--- a/src/cobalt/webdriver/protocol/log_entry.cc
+++ b/src/cobalt/webdriver/protocol/log_entry.cc
@@ -48,7 +48,7 @@
std::unique_ptr<base::DictionaryValue> log_entry_value(
new base::DictionaryValue());
// Format of the Log Entry object can be found here:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Log_Entry_JSON_Object
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Log-Entry-JSON-Object
// timestamp is in milliseconds since the Unix Epoch.
log_entry_value->SetInteger("timestamp",
log_entry.timestamp_.InMilliseconds());
diff --git a/src/cobalt/webdriver/protocol/log_entry.h b/src/cobalt/webdriver/protocol/log_entry.h
index f06a95c..94d01bd 100644
--- a/src/cobalt/webdriver/protocol/log_entry.h
+++ b/src/cobalt/webdriver/protocol/log_entry.h
@@ -26,7 +26,7 @@
namespace protocol {
// Log entry object:
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#Log_Entry_JSON_Object
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Log-Entry-JSON-Object
class LogEntry {
public:
enum LogLevel {
diff --git a/src/cobalt/webdriver/protocol/response.h b/src/cobalt/webdriver/protocol/response.h
index 9ab38b5..0244c14 100644
--- a/src/cobalt/webdriver/protocol/response.h
+++ b/src/cobalt/webdriver/protocol/response.h
@@ -29,7 +29,7 @@
class Response {
public:
// WebDriver Response Status Codes:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Response_Status_Codes
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Response-Status-Codes
enum StatusCode {
// The command executed successfully.
kSuccess = 0,
@@ -79,13 +79,13 @@
// Create a JSON object that will be used as the response body for a failed
// command:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Failed_Commands
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Failed-Commands
// TODO: Add support for screenshot, stack trace, etc.
static std::unique_ptr<base::Value> CreateErrorResponse(
const std::string& message);
// Create a JSON object that will be used as the response body for a command:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Responses
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Responses
static std::unique_ptr<base::Value> CreateResponse(
const base::Optional<protocol::SessionId>& session_id,
StatusCode status_code,
diff --git a/src/cobalt/webdriver/protocol/script.h b/src/cobalt/webdriver/protocol/script.h
index 7f75af1..78256fc 100644
--- a/src/cobalt/webdriver/protocol/script.h
+++ b/src/cobalt/webdriver/protocol/script.h
@@ -27,8 +27,8 @@
// Represents the JSON parameters passed to the execute and execute_async
// WebDriver commands.
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/execute
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/execute_async
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidexecute
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidexecute-async
class Script {
public:
static base::Optional<Script> FromValue(const base::Value* script);
diff --git a/src/cobalt/webdriver/protocol/server_status.h b/src/cobalt/webdriver/protocol/server_status.h
index 75043fc..f100f41 100644
--- a/src/cobalt/webdriver/protocol/server_status.h
+++ b/src/cobalt/webdriver/protocol/server_status.h
@@ -27,7 +27,7 @@
// Represents the JSON object that describes the WebDriver server's current
// status in response to the /status command:
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/status
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#status
class ServerStatus {
public:
ServerStatus();
diff --git a/src/cobalt/webdriver/protocol/session_id.h b/src/cobalt/webdriver/protocol/session_id.h
index 4aeacee..8fc7f45 100644
--- a/src/cobalt/webdriver/protocol/session_id.h
+++ b/src/cobalt/webdriver/protocol/session_id.h
@@ -25,7 +25,7 @@
namespace protocol {
// sessionId is mentioned in the spec describing WebDriver responses:
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#Responses
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Responses
//
class SessionId {
public:
diff --git a/src/cobalt/webdriver/server.cc b/src/cobalt/webdriver/server.cc
index 18ec451..f7bff66 100644
--- a/src/cobalt/webdriver/server.cc
+++ b/src/cobalt/webdriver/server.cc
@@ -76,7 +76,7 @@
server_(server),
connection_id_(connection_id) {}
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Responses
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Responses
void Success(std::unique_ptr<base::Value> value) override {
DCHECK(value);
std::string data;
@@ -94,7 +94,7 @@
// Failed commands map to a valid WebDriver command and contain the expected
// parameters, but otherwise failed to execute for some reason. This should
// send a 500 Internal Server Error.
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Error_Handling
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Error-Handling
void FailedCommand(std::unique_ptr<base::Value> value) override {
DCHECK(value);
std::string data;
@@ -103,7 +103,7 @@
}
// A number of cases for invalid requests are explained here:
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Invalid_Requests
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Invalid-Requests
// The response type should be text/plain and the message body is an error
// message
diff --git a/src/cobalt/webdriver/server.h b/src/cobalt/webdriver/server.h
index 92200cd..ffc9372 100644
--- a/src/cobalt/webdriver/server.h
+++ b/src/cobalt/webdriver/server.h
@@ -54,18 +54,18 @@
class ResponseHandler {
public:
// Called after a successful WebDriver command.
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Responses
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Responses
virtual void Success(std::unique_ptr<base::Value>) = 0;
// |content_type| specifies the type of the data using HTTP mime types.
virtual void SuccessData(const std::string& content_type, const char* data,
int len) = 0;
// Called after a failed WebDriver command
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Failed_Commands
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Failed-Commands
virtual void FailedCommand(std::unique_ptr<base::Value>) = 0;
// Called after an invalid request.
- // https://code.google.com/p/selenium/wiki/JsonWireProtocol#Invalid_Requests
+ // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Invalid-Requests
virtual void UnknownCommand(const std::string& path) = 0;
virtual void UnimplementedCommand(const std::string& path) = 0;
virtual void VariableResourceNotFound(const std::string& variable_name) = 0;
diff --git a/src/cobalt/webdriver/web_driver_module.cc b/src/cobalt/webdriver/web_driver_module.cc
index 09656cf..b34860d 100644
--- a/src/cobalt/webdriver/web_driver_module.cc
+++ b/src/cobalt/webdriver/web_driver_module.cc
@@ -513,7 +513,7 @@
return NULL;
}
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/status
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#status
void WebDriverModule::GetServerStatus(
const base::Value* parameters,
const WebDriverDispatcher::PathVariableMap* path_variables,
@@ -523,7 +523,7 @@
protocol::ServerStatus::ToValue(status_));
}
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/sessions
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessions
void WebDriverModule::GetActiveSessions(
const base::Value* parameters,
const WebDriverDispatcher::PathVariableMap* path_variables,
@@ -537,7 +537,7 @@
util::internal::ToValue(sessions));
}
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#GET_/session/:sessionId
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#get-sessionsessionid
void WebDriverModule::CreateSession(
const base::Value* parameters,
const WebDriverDispatcher::PathVariableMap* path_variables,
@@ -563,7 +563,7 @@
result_handler.get());
}
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#DELETE_/session/:sessionId
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#delete-sessionsessionid
void WebDriverModule::DeleteSession(
const base::Value* parameters,
const WebDriverDispatcher::PathVariableMap* path_variables,
@@ -626,7 +626,7 @@
}
}
-// https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/screenshot
+// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidscreenshot
void WebDriverModule::RequestScreenshot(
const base::Value* parameters,
const WebDriverDispatcher::PathVariableMap* path_variables,
diff --git a/src/components/prefs/prefs.gyp b/src/components/prefs/prefs.gyp
index c17c711..62df19c 100644
--- a/src/components/prefs/prefs.gyp
+++ b/src/components/prefs/prefs.gyp
@@ -68,6 +68,26 @@
'defines': [
'COMPONENTS_PREFS_IMPLEMENTATION',
],
- }
+ },
+ {
+ 'target_name': 'test_support',
+ 'type': 'static_library',
+ 'sources': [
+ 'mock_pref_change_callback.cc',
+ 'mock_pref_change_callback.h',
+ 'pref_store_observer_mock.cc',
+ 'pref_store_observer_mock.h',
+ 'testing_pref_service.cc',
+ 'testing_pref_service.h',
+ 'testing_pref_store.cc',
+ 'testing_pref_store.h',
+ ],
+ 'dependencies': [
+ 'prefs',
+ '<(DEPTH)/base/base.gyp:base',
+ '<(DEPTH)/testing/gmock.gyp:gmock',
+ '<(DEPTH)/testing/gtest.gyp:gtest',
+ ],
+ },
]
}
diff --git a/src/components/update_client/component.cc b/src/components/update_client/component.cc
index 1755805..6613a93 100644
--- a/src/components/update_client/component.cc
+++ b/src/components/update_client/component.cc
@@ -32,6 +32,11 @@
#include "components/update_client/update_engine.h"
#include "components/update_client/utils.h"
+#if defined(OS_STARBOARD)
+#include "starboard/loader_app/app_key_files.h"
+#include "starboard/loader_app/drain_file.h"
+#endif
+
// The state machine representing how a CRX component changes during an update.
//
// +------------------------- kNew
@@ -144,12 +149,27 @@
// TODO: add correct error code.
install_error = InstallError::GENERIC_ERROR;
} else {
- int ret =
- installation_api->RequestRollForwardToInstallation(installation_index);
- if (ret == IM_EXT_ERROR) {
- SB_LOG(ERROR) << "Failed to request roll forward.";
+ char app_key[IM_EXT_MAX_APP_KEY_LENGTH];
+ if (installation_api->GetAppKey(app_key, IM_EXT_MAX_APP_KEY_LENGTH) ==
+ IM_EXT_ERROR) {
// TODO: add correct error code.
install_error = InstallError::GENERIC_ERROR;
+ } else {
+ std::string good_app_key_file_path =
+ starboard::loader_app::GetGoodAppKeyFilePath(unpack_path.value(),
+ app_key);
+ SB_CHECK(!good_app_key_file_path.empty());
+ if (!starboard::loader_app::CreateAppKeyFile(good_app_key_file_path)) {
+ SB_LOG(WARNING) << "Failed to create good app key file";
+ }
+ DrainFileRemove(unpack_path.value().c_str(), app_key);
+ int ret = installation_api->RequestRollForwardToInstallation(
+ installation_index);
+ if (ret == IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "Failed to request roll forward.";
+ // TODO: add correct error code.
+ install_error = InstallError::GENERIC_ERROR;
+ }
}
}
diff --git a/src/components/update_client/crx_downloader.cc b/src/components/update_client/crx_downloader.cc
index 35cac8e..15d1f2a 100644
--- a/src/components/update_client/crx_downloader.cc
+++ b/src/components/update_client/crx_downloader.cc
@@ -184,29 +184,37 @@
download_metrics_.push_back(download_metrics);
- // If an error has occured, try the next url if there is any,
- // or try the successor in the chain if there is any successor.
- // If this downloader has received a 5xx error for the current url,
- // as indicated by the |is_handled| flag, remove that url from the list of
- // urls so the url is never tried again down the chain.
- if (is_handled) {
- current_url_ = urls_.erase(current_url_);
- } else {
- ++current_url_;
- }
+#if defined(OS_STARBOARD)
+ if (result.error != Error::CRX_DOWNLOADER_ABORT) {
+#endif
- // Try downloading from another url from the list.
- if (current_url_ != urls_.end()) {
- DoStartDownload(*current_url_);
- return;
- }
+ // If an error has occured, try the next url if there is any,
+ // or try the successor in the chain if there is any successor.
+ // If this downloader has received a 5xx error for the current url,
+ // as indicated by the |is_handled| flag, remove that url from the list of
+ // urls so the url is never tried again down the chain.
+ if (is_handled) {
+ current_url_ = urls_.erase(current_url_);
+ } else {
+ ++current_url_;
+ }
- // Try downloading using the next downloader.
- if (successor_ && !urls_.empty()) {
- successor_->StartDownload(urls_, expected_hash_,
- std::move(download_callback_));
- return;
+ // Try downloading from another url from the list.
+ if (current_url_ != urls_.end()) {
+ DoStartDownload(*current_url_);
+ return;
+ }
+
+ // Try downloading using the next downloader.
+ if (successor_ && !urls_.empty()) {
+ successor_->StartDownload(urls_, expected_hash_,
+ std::move(download_callback_));
+ return;
+ }
+
+#if defined(OS_STARBOARD)
}
+#endif
// The download ends here since there is no url nor downloader to handle this
// download request further.
diff --git a/src/components/update_client/crx_downloader.h b/src/components/update_client/crx_downloader.h
index 966ee82..621766f 100644
--- a/src/components/update_client/crx_downloader.h
+++ b/src/components/update_client/crx_downloader.h
@@ -39,6 +39,19 @@
// The members of this class expect to be called from the main thread only.
class CrxDownloader {
public:
+#if defined(OS_STARBOARD)
+ enum Error {
+ // The download succeeded.
+ CRX_DOWNLOADER_OK = 0,
+
+ // The download failed and should be retried.
+ CRX_DOWNLOADER_RETRY = -1,
+
+ // The download failed and should be aborted.
+ CRX_DOWNLOADER_ABORT = -2,
+ };
+#endif
+
struct DownloadMetrics {
enum Downloader { kNone = 0, kUrlFetcher, kBits };
diff --git a/src/components/update_client/crx_downloader_unittest.cc b/src/components/update_client/crx_downloader_unittest.cc
index 03c9002..e0cb5f9 100644
--- a/src/components/update_client/crx_downloader_unittest.cc
+++ b/src/components/update_client/crx_downloader_unittest.cc
@@ -21,8 +21,13 @@
#include "components/update_client/update_client_errors.h"
#include "components/update_client/utils.h"
#include "net/base/net_errors.h"
+#if defined(STARBOARD)
+#include "net/url_request/test_url_request_interceptor.h"
+#include "net/url_request/url_request_test_util.h"
+#else
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/test/test_url_loader_factory.h"
+#endif
#include "testing/gtest/include/gtest/gtest.h"
using base::ContentsEqual;
@@ -31,6 +36,11 @@
namespace {
+#if defined(STARBOARD)
+// Intercepts HTTP GET requests sent to "localhost".
+typedef net::LocalHostTestURLRequestInterceptor GetInterceptor;
+#endif
+
const char kTestFileName[] = "jebgalgnebhfojomionfpkfelancnnkf.crx";
const char hash_jebg[] =
diff --git a/src/components/update_client/net/network_cobalt.h b/src/components/update_client/net/network_cobalt.h
new file mode 100644
index 0000000..be55d65
--- /dev/null
+++ b/src/components/update_client/net/network_cobalt.h
@@ -0,0 +1,34 @@
+// Copyright 2019 The Cobalt Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_UPDATE_CLIENT_NET_NETWORK_COBALT_H_
+#define COMPONENTS_UPDATE_CLIENT_NET_NETWORK_COBALT_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "cobalt/network/network_module.h"
+#include "components/update_client/network.h"
+
+namespace update_client {
+
+class NetworkFetcherCobaltFactory : public NetworkFetcherFactory {
+ public:
+ explicit NetworkFetcherCobaltFactory(
+ cobalt::network::NetworkModule* network_module);
+
+ std::unique_ptr<NetworkFetcher> Create() const override;
+
+ protected:
+ ~NetworkFetcherCobaltFactory() override;
+
+ private:
+ cobalt::network::NetworkModule* network_module_;
+ DISALLOW_COPY_AND_ASSIGN(NetworkFetcherCobaltFactory);
+};
+
+} // namespace update_client
+
+#endif // COMPONENTS_UPDATE_CLIENT_NET_NETWORK_COBALT_H_
diff --git a/src/components/update_client/net/network_impl_cobalt.cc b/src/components/update_client/net/network_impl_cobalt.cc
new file mode 100644
index 0000000..02acd0f
--- /dev/null
+++ b/src/components/update_client/net/network_impl_cobalt.cc
@@ -0,0 +1,257 @@
+// Copyright 2019 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "components/update_client/net/network_impl_cobalt.h"
+
+#include <memory>
+#include <utility>
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/callback_helpers.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "cobalt/base/polymorphic_downcast.h"
+#include "cobalt/loader/url_fetcher_string_writer.h"
+#include "components/update_client/net/network_cobalt.h"
+
+namespace {
+
+bool IsResponseCodeSuccess(int response_code) {
+ // NetworkFetcher only considers success to be if the network request
+ // was successful *and* we get a 2xx response back.
+ return response_code / 100 == 2;
+}
+
+constexpr net::NetworkTrafficAnnotationTag kNetworkTrafficAnnotation =
+ net::DefineNetworkTrafficAnnotation("cobalt_updater_network_fetcher",
+ "cobalt_updater_network_fetcher");
+
+// Returns the string value of a header of the server response or an empty
+// string if the header is not available. Only the first header is returned
+// if multiple instances of the same header are present.
+std::string GetStringHeader(const net::HttpResponseHeaders* headers,
+ const char* header_name) {
+ if (!headers) {
+ return {};
+ }
+
+ std::string header_value;
+ return headers->EnumerateHeader(nullptr, header_name, &header_value)
+ ? header_value
+ : std::string{};
+}
+
+// Returns the integral value of a header of the server response or -1 if
+// if the header is not available or a conversion error has occured.
+int64_t GetInt64Header(const net::HttpResponseHeaders* headers,
+ const char* header_name) {
+ if (!headers) {
+ return -1;
+ }
+
+ return headers->GetInt64HeaderValue(header_name);
+}
+
+} // namespace
+
+namespace update_client {
+
+NetworkFetcherCobaltImpl::NetworkFetcherCobaltImpl(
+ const cobalt::network::NetworkModule* network_module)
+ : network_module_(network_module) {}
+
+NetworkFetcherCobaltImpl::~NetworkFetcherCobaltImpl() {}
+
+void NetworkFetcherCobaltImpl::PostRequest(
+ const GURL& url,
+ const std::string& post_data,
+ const base::flat_map<std::string, std::string>& post_additional_headers,
+ ResponseStartedCallback response_started_callback,
+ ProgressCallback progress_callback,
+ PostRequestCompleteCallback post_request_complete_callback) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+
+ SB_LOG(INFO) << "PostRequest url = " << url;
+ SB_LOG(INFO) << "PostRequest post_data = " << post_data;
+
+ response_started_callback_ = std::move(response_started_callback);
+ progress_callback_ = std::move(progress_callback);
+ post_request_complete_callback_ = std::move(post_request_complete_callback);
+
+ CreateUrlFetcher(url, net::URLFetcher::POST);
+
+ std::unique_ptr<cobalt::loader::URLFetcherStringWriter> download_data_writer(
+ new cobalt::loader::URLFetcherStringWriter());
+ url_fetcher_->SaveResponseWithWriter(std::move(download_data_writer));
+
+ for (const auto& header : post_additional_headers) {
+ url_fetcher_->AddExtraRequestHeader(header.first + ": " + header.second);
+ }
+
+ url_fetcher_->SetUploadData("application/json", post_data);
+
+ url_fetcher_type_ = kUrlFetcherTypePostRequest;
+
+ url_fetcher_->Start();
+}
+
+void NetworkFetcherCobaltImpl::DownloadToFile(
+ const GURL& url,
+ const base::FilePath& file_path,
+ ResponseStartedCallback response_started_callback,
+ ProgressCallback progress_callback,
+ DownloadToFileCompleteCallback download_to_file_complete_callback) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+
+ SB_LOG(INFO) << "DownloadToFile url = " << url;
+ SB_LOG(INFO) << "DownloadToFile file_path = " << file_path;
+
+ response_started_callback_ = std::move(response_started_callback);
+ progress_callback_ = std::move(progress_callback);
+ download_to_file_complete_callback_ =
+ std::move(download_to_file_complete_callback);
+
+ CreateUrlFetcher(url, net::URLFetcher::GET);
+
+ url_fetcher_->SaveResponseToFileAtPath(
+ file_path, base::SequencedTaskRunnerHandle::Get());
+
+ url_fetcher_type_ = kUrlFetcherTypeDownloadToFile;
+
+ url_fetcher_->Start();
+}
+
+void NetworkFetcherCobaltImpl::OnURLFetchResponseStarted(
+ const net::URLFetcher* source) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ std::move(response_started_callback_)
+ .Run(source->GetURL(), source->GetResponseCode(),
+ source->GetResponseHeaders()
+ ? source->GetResponseHeaders()->GetContentLength()
+ : -1);
+}
+
+void NetworkFetcherCobaltImpl::OnURLFetchComplete(
+ const net::URLFetcher* source) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ const net::URLRequestStatus& status = source->GetStatus();
+ const int response_code = source->GetResponseCode();
+ if (url_fetcher_type_ == kUrlFetcherTypePostRequest) {
+ OnPostRequestComplete(source, status.error());
+ } else if (url_fetcher_type_ == kUrlFetcherTypeDownloadToFile) {
+ OnDownloadToFileComplete(source, status.error());
+ }
+
+ if (!status.is_success() || !IsResponseCodeSuccess(response_code)) {
+ std::string msg(base::StringPrintf(
+ "NetworkFetcher error on %s : %s, response code %d",
+ source->GetURL().spec().c_str(),
+ net::ErrorToString(status.error()).c_str(), response_code));
+ return HandleError(msg).InvalidateThis();
+ }
+ url_fetcher_.reset();
+}
+
+void NetworkFetcherCobaltImpl::OnURLFetchDownloadProgress(
+ const net::URLFetcher* source,
+ int64_t current,
+ int64_t /*total*/,
+ int64_t /*current_network_bytes*/) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+
+ progress_callback_.Run(current);
+}
+
+void NetworkFetcherCobaltImpl::CreateUrlFetcher(
+ const GURL& url,
+ const net::URLFetcher::RequestType request_type) {
+ DCHECK(url.SchemeIsHTTPOrHTTPS());
+ url_fetcher_ = net::URLFetcher::Create(url, request_type, this,
+ kNetworkTrafficAnnotation);
+
+ url_fetcher_->SetRequestContext(
+ network_module_->url_request_context_getter().get());
+
+ // Request mode is kCORSModeOmitCredentials.
+ const uint32 kDisableCookiesAndCacheLoadFlags =
+ net::LOAD_NORMAL | net::LOAD_DO_NOT_SAVE_COOKIES |
+ net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SEND_AUTH_DATA |
+ net::LOAD_DISABLE_CACHE;
+ url_fetcher_->SetLoadFlags(kDisableCookiesAndCacheLoadFlags);
+
+ url_fetcher_->SetAutomaticallyRetryOnNetworkChanges(
+ kMaxRetriesOnNetworkChange);
+}
+
+void NetworkFetcherCobaltImpl::OnPostRequestComplete(
+ const net::URLFetcher* source,
+ const int status_error) {
+ std::unique_ptr<std::string> response_body(new std::string);
+ auto* download_data_writer =
+ base::polymorphic_downcast<cobalt::loader::URLFetcherStringWriter*>(
+ source->GetResponseWriter());
+ if (download_data_writer) {
+ download_data_writer->GetAndResetData(response_body.get());
+ }
+
+ if (response_body->empty()) {
+ SB_LOG(ERROR) << "PostRequest got empty response.";
+ }
+
+ SB_LOG(INFO) << "OnPostRequestComplete response_body = "
+ << *response_body.get();
+
+ net::HttpResponseHeaders* response_headers = source->GetResponseHeaders();
+ std::move(post_request_complete_callback_)
+ .Run(std::move(response_body), status_error,
+ GetStringHeader(response_headers,
+ update_client::NetworkFetcher::kHeaderEtag),
+ GetInt64Header(response_headers,
+ update_client::NetworkFetcher::kHeaderXRetryAfter));
+}
+
+void NetworkFetcherCobaltImpl::OnDownloadToFileComplete(
+ const net::URLFetcher* source,
+ const int status_error) {
+ base::FilePath response_file;
+ if (!source->GetResponseAsFilePath(true, &response_file)) {
+ SB_LOG(ERROR) << "DownloadToFile failed to get response from a file";
+ }
+ SB_LOG(INFO) << "OnDownloadToFileComplete response_file = " << response_file;
+
+ std::move(download_to_file_complete_callback_)
+ .Run(response_file, status_error,
+ source->GetResponseHeaders()
+ ? source->GetResponseHeaders()->GetContentLength()
+ : -1);
+}
+
+NetworkFetcherCobaltImpl::ReturnWrapper NetworkFetcherCobaltImpl::HandleError(
+ const std::string& message) {
+ url_fetcher_.reset();
+ SB_LOG(ERROR) << message;
+ return ReturnWrapper();
+}
+
+NetworkFetcherCobaltFactory::NetworkFetcherCobaltFactory(
+ cobalt::network::NetworkModule* network_module)
+ : network_module_(network_module) {}
+
+NetworkFetcherCobaltFactory::~NetworkFetcherCobaltFactory() = default;
+
+std::unique_ptr<NetworkFetcher> NetworkFetcherCobaltFactory::Create() const {
+ return std::make_unique<NetworkFetcherCobaltImpl>(network_module_);
+}
+
+} // namespace update_client
diff --git a/src/components/update_client/net/network_impl_cobalt.h b/src/components/update_client/net/network_impl_cobalt.h
new file mode 100644
index 0000000..c30f3ad
--- /dev/null
+++ b/src/components/update_client/net/network_impl_cobalt.h
@@ -0,0 +1,125 @@
+// Copyright 2019 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef COMPONENTS_UPDATE_CLIENT_NET_NETWORK_IMPL_COBALT_H_
+#define COMPONENTS_UPDATE_CLIENT_NET_NETWORK_IMPL_COBALT_H_
+
+#include <stdint.h>
+
+#include <memory>
+#include <string>
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/threading/thread_checker.h"
+#include "cobalt/network/network_module.h"
+#include "components/update_client/network.h"
+#include "net/url_request/url_fetcher_delegate.h"
+
+namespace base {
+
+class FilePath;
+class SingleThreadTaskRunner;
+
+} // namespace base
+
+namespace update_client {
+
+typedef enum UrlFetcherType {
+ kUrlFetcherTypePostRequest,
+ kUrlFetcherTypeDownloadToFile,
+} UrlFetcherType;
+
+class NetworkFetcherCobaltImpl : public NetworkFetcher,
+ public net::URLFetcherDelegate {
+ public:
+ using ResponseStartedCallback =
+ update_client::NetworkFetcher::ResponseStartedCallback;
+ using ProgressCallback = update_client::NetworkFetcher::ProgressCallback;
+ using PostRequestCompleteCallback =
+ update_client::NetworkFetcher::PostRequestCompleteCallback;
+ using DownloadToFileCompleteCallback =
+ update_client::NetworkFetcher::DownloadToFileCompleteCallback;
+
+ explicit NetworkFetcherCobaltImpl(
+ const cobalt::network::NetworkModule* network_module);
+ ~NetworkFetcherCobaltImpl() override;
+
+ // update_client::NetworkFetcher interface.
+ void PostRequest(
+ const GURL& url,
+ const std::string& post_data,
+ const base::flat_map<std::string, std::string>& post_additional_headers,
+ ResponseStartedCallback response_started_callback,
+ ProgressCallback progress_callback,
+ PostRequestCompleteCallback post_request_complete_callback) override;
+ void DownloadToFile(const GURL& url,
+ const base::FilePath& file_path,
+ ResponseStartedCallback response_started_callback,
+ ProgressCallback progress_callback,
+ DownloadToFileCompleteCallback
+ download_to_file_complete_callback) override;
+
+ // net::URLFetcherDelegate interface.
+ void OnURLFetchResponseStarted(const net::URLFetcher* source) override;
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
+ void OnURLFetchDownloadProgress(const net::URLFetcher* source,
+ int64_t current,
+ int64_t total,
+ int64_t current_network_bytes) override;
+
+ private:
+ // Thread checker ensures all calls to the NetworkFetcher are made from the
+ // same thread that it is created in.
+ THREAD_CHECKER(thread_checker_);
+
+ // Empty struct to ensure the caller of |HandleError()| knows that |this|
+ // may have been destroyed and handles it appropriately.
+ struct ReturnWrapper {
+ void InvalidateThis() {}
+ };
+
+ ReturnWrapper HandleError(const std::string& error_message)
+ WARN_UNUSED_RESULT;
+
+ void CreateUrlFetcher(const GURL& url,
+ const net::URLFetcher::RequestType request_type);
+
+ void OnPostRequestComplete(const net::URLFetcher* source,
+ const int status_error);
+ void OnDownloadToFileComplete(const net::URLFetcher* source,
+ const int status_error);
+
+ static constexpr int kMaxRetriesOnNetworkChange = 3;
+
+ scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
+
+ std::unique_ptr<net::URLFetcher> url_fetcher_;
+
+ UrlFetcherType url_fetcher_type_;
+
+ ResponseStartedCallback response_started_callback_;
+ ProgressCallback progress_callback_;
+ PostRequestCompleteCallback post_request_complete_callback_;
+ DownloadToFileCompleteCallback download_to_file_complete_callback_;
+
+ const cobalt::network::NetworkModule* network_module_;
+
+ DISALLOW_COPY_AND_ASSIGN(NetworkFetcherCobaltImpl);
+};
+
+} // namespace update_client
+
+#endif // COMPONENTS_UPDATE_CLIENT_NET_NETWORK_IMPL_COBALT_H_
diff --git a/src/components/update_client/net/url_request_post_interceptor.cc b/src/components/update_client/net/url_request_post_interceptor.cc
new file mode 100644
index 0000000..e5a539f
--- /dev/null
+++ b/src/components/update_client/net/url_request_post_interceptor.cc
@@ -0,0 +1,339 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/update_client/net/url_request_post_interceptor.h"
+
+#include <memory>
+
+#include "base/bind.h"
+#include "base/files/file_util.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/sequenced_task_runner.h"
+#include "base/strings/stringprintf.h"
+#include "components/update_client/test_configurator.h"
+#include "net/base/upload_bytes_element_reader.h"
+#include "net/base/upload_data_stream.h"
+#include "net/http/http_response_headers.h"
+#include "net/http/http_util.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_filter.h"
+#include "net/url_request/url_request_interceptor.h"
+#include "net/url_request/url_request_simple_job.h"
+#include "net/url_request/url_request_test_util.h"
+
+namespace update_client {
+
+// Returns a canned response.
+class URLRequestPostInterceptor::URLRequestMockJob
+ : public net::URLRequestSimpleJob {
+ public:
+ URLRequestMockJob(scoped_refptr<URLRequestPostInterceptor> interceptor,
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ int response_code,
+ const std::string& response_body)
+ : net::URLRequestSimpleJob(request, network_delegate),
+ interceptor_(interceptor),
+ response_code_(response_code),
+ response_body_(response_body) {}
+
+ void Start() override {
+ if (interceptor_->is_paused_)
+ return;
+ net::URLRequestSimpleJob::Start();
+ }
+
+ protected:
+ void GetResponseInfo(net::HttpResponseInfo* info) override {
+ const std::string headers =
+ base::StringPrintf("HTTP/1.1 %i OK\r\n\r\n", response_code_);
+ info->headers = base::MakeRefCounted<net::HttpResponseHeaders>(
+ net::HttpUtil::AssembleRawHeaders(headers.c_str(), headers.length()));
+ }
+
+ int GetData(std::string* mime_type,
+ std::string* charset,
+ std::string* data,
+ const net::CompletionOnceCallback callback) const override {
+ mime_type->assign("text/plain");
+ charset->assign("US-ASCII");
+ data->assign(response_body_);
+ return net::OK;
+ }
+
+ private:
+ ~URLRequestMockJob() override {}
+
+ scoped_refptr<URLRequestPostInterceptor> interceptor_;
+
+ int response_code_;
+ std::string response_body_;
+ DISALLOW_COPY_AND_ASSIGN(URLRequestMockJob);
+};
+
+URLRequestPostInterceptor::URLRequestPostInterceptor(
+ const GURL& url,
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner)
+ : url_(url), io_task_runner_(io_task_runner), hit_count_(0) {}
+
+URLRequestPostInterceptor::~URLRequestPostInterceptor() {
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
+}
+
+GURL URLRequestPostInterceptor::GetUrl() const {
+ return url_;
+}
+
+bool URLRequestPostInterceptor::ExpectRequest(
+ std::unique_ptr<RequestMatcher> request_matcher) {
+ return ExpectRequest(std::move(request_matcher), kResponseCode200);
+}
+
+bool URLRequestPostInterceptor::ExpectRequest(
+ std::unique_ptr<RequestMatcher> request_matcher,
+ int response_code) {
+ expectations_.push(
+ {std::move(request_matcher), ExpectationResponse(response_code, "")});
+ return true;
+}
+
+bool URLRequestPostInterceptor::ExpectRequest(
+ std::unique_ptr<RequestMatcher> request_matcher,
+ const base::FilePath& filepath) {
+ std::string response;
+ if (filepath.empty() || !base::ReadFileToString(filepath, &response))
+ return false;
+
+ expectations_.push({std::move(request_matcher),
+ ExpectationResponse(kResponseCode200, response)});
+ return true;
+}
+
+int URLRequestPostInterceptor::GetHitCount() const {
+ base::AutoLock auto_lock(interceptor_lock_);
+ return hit_count_;
+}
+
+int URLRequestPostInterceptor::GetCount() const {
+ base::AutoLock auto_lock(interceptor_lock_);
+ return static_cast<int>(requests_.size());
+}
+
+std::vector<URLRequestPostInterceptor::InterceptedRequest>
+URLRequestPostInterceptor::GetRequests() const {
+ base::AutoLock auto_lock(interceptor_lock_);
+ return requests_;
+}
+
+std::string URLRequestPostInterceptor::GetRequestBody(size_t n) const {
+ base::AutoLock auto_lock(interceptor_lock_);
+ return requests_[n].first;
+}
+
+std::string URLRequestPostInterceptor::GetRequestsAsString() const {
+ const std::vector<InterceptedRequest> requests = GetRequests();
+
+ std::string s = "Requests are:";
+
+ int i = 0;
+ for (auto it = requests.cbegin(); it != requests.cend(); ++it)
+ s.append(base::StringPrintf("\n [%d]: %s", ++i, it->first.c_str()));
+
+ return s;
+}
+
+void URLRequestPostInterceptor::Reset() {
+ base::AutoLock auto_lock(interceptor_lock_);
+ hit_count_ = 0;
+ requests_.clear();
+ base::queue<Expectation>().swap(expectations_);
+}
+
+void URLRequestPostInterceptor::Pause() {
+ base::AutoLock auto_lock(interceptor_lock_);
+ is_paused_ = true;
+}
+
+void URLRequestPostInterceptor::Resume() {
+ base::AutoLock auto_lock(interceptor_lock_);
+ is_paused_ = false;
+ io_task_runner_->PostTask(FROM_HERE,
+ base::BindOnce(&URLRequestMockJob::Start,
+ base::Unretained(request_job_)));
+}
+
+void URLRequestPostInterceptor::url_job_request_ready_callback(
+ UrlJobRequestReadyCallback url_job_request_ready_callback) {
+ base::AutoLock auto_lock(interceptor_lock_);
+ url_job_request_ready_callback_ = std::move(url_job_request_ready_callback);
+}
+
+class URLRequestPostInterceptor::Delegate : public net::URLRequestInterceptor {
+ public:
+ Delegate(const std::string& scheme,
+ const std::string& hostname,
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner)
+ : scheme_(scheme), hostname_(hostname), io_task_runner_(io_task_runner) {}
+
+ void Register() {
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
+ net::URLRequestFilter::GetInstance()->AddHostnameInterceptor(
+ scheme_, hostname_, std::unique_ptr<net::URLRequestInterceptor>(this));
+ }
+
+ void Unregister() {
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
+ interceptors_.clear();
+ net::URLRequestFilter::GetInstance()->RemoveHostnameHandler(scheme_,
+ hostname_);
+ }
+
+ void OnCreateInterceptor(
+ scoped_refptr<URLRequestPostInterceptor> interceptor) {
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
+ DCHECK_EQ(0u, interceptors_.count(interceptor->GetUrl()));
+
+ interceptors_.insert(std::make_pair(interceptor->GetUrl(), interceptor));
+ }
+
+ private:
+ ~Delegate() override {}
+
+ net::URLRequestJob* MaybeInterceptRequest(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate) const override {
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
+
+ // Only intercepts POST.
+ if (!request->has_upload())
+ return nullptr;
+
+ GURL url = request->url();
+ if (url.has_query()) {
+ GURL::Replacements replacements;
+ replacements.ClearQuery();
+ url = url.ReplaceComponents(replacements);
+ }
+
+ const auto it = interceptors_.find(url);
+ if (it == interceptors_.end())
+ return nullptr;
+
+ // There is an interceptor hooked up for this url. Read the request body,
+ // check the existing expectations, and handle the matching case by
+ // popping the expectation off the queue, counting the match, and
+ // returning a mock object to serve the canned response.
+ auto interceptor = it->second;
+
+ const net::UploadDataStream* stream = request->get_upload();
+ const net::UploadBytesElementReader* reader =
+ (*stream->GetElementReaders())[0]->AsBytesReader();
+ const int size = reader->length();
+ scoped_refptr<net::IOBuffer> buffer(new net::IOBuffer(size));
+ const std::string request_body(reader->bytes());
+
+ {
+ base::AutoLock auto_lock(interceptor->interceptor_lock_);
+ interceptor->requests_.push_back(
+ {request_body, request->extra_request_headers()});
+ if (interceptor->expectations_.empty())
+ return nullptr;
+ const auto& expectation = interceptor->expectations_.front();
+ if (expectation.first->Match(request_body)) {
+ const int response_code(expectation.second.response_code);
+ const std::string response_body(expectation.second.response_body);
+ interceptor->expectations_.pop();
+ ++interceptor->hit_count_;
+ interceptor->request_job_ =
+ new URLRequestMockJob(interceptor, request, network_delegate,
+ response_code, response_body);
+ if (interceptor->url_job_request_ready_callback_) {
+ io_task_runner_->PostTask(
+ FROM_HERE,
+ std::move(interceptor->url_job_request_ready_callback_));
+ }
+ return interceptor->request_job_;
+ }
+ }
+
+ return nullptr;
+ }
+
+ using InterceptorMap =
+ std::map<GURL, scoped_refptr<URLRequestPostInterceptor>>;
+ InterceptorMap interceptors_;
+
+ const std::string scheme_;
+ const std::string hostname_;
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner_;
+
+ DISALLOW_COPY_AND_ASSIGN(Delegate);
+};
+
+URLRequestPostInterceptorFactory::URLRequestPostInterceptorFactory(
+ const std::string& scheme,
+ const std::string& hostname,
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner)
+ : scheme_(scheme),
+ hostname_(hostname),
+ io_task_runner_(io_task_runner),
+ delegate_(new URLRequestPostInterceptor::Delegate(scheme,
+ hostname,
+ io_task_runner)) {
+ io_task_runner_->PostTask(
+ FROM_HERE, base::BindOnce(&URLRequestPostInterceptor::Delegate::Register,
+ base::Unretained(delegate_)));
+}
+
+URLRequestPostInterceptorFactory::~URLRequestPostInterceptorFactory() {
+ io_task_runner_->PostTask(
+ FROM_HERE,
+ base::BindOnce(&URLRequestPostInterceptor::Delegate::Unregister,
+ base::Unretained(delegate_)));
+}
+
+scoped_refptr<URLRequestPostInterceptor>
+URLRequestPostInterceptorFactory::CreateInterceptor(
+ const base::FilePath& filepath) {
+ const GURL base_url(
+ base::StringPrintf("%s://%s", scheme_.c_str(), hostname_.c_str()));
+ GURL absolute_url(base_url.Resolve(filepath.MaybeAsASCII()));
+ auto interceptor = scoped_refptr<URLRequestPostInterceptor>(
+ new URLRequestPostInterceptor(absolute_url, io_task_runner_));
+ bool res = io_task_runner_->PostTask(
+ FROM_HERE,
+ base::BindOnce(&URLRequestPostInterceptor::Delegate::OnCreateInterceptor,
+ base::Unretained(delegate_), interceptor));
+ return res ? interceptor : nullptr;
+}
+
+bool PartialMatch::Match(const std::string& actual) const {
+ return actual.find(expected_) != std::string::npos;
+}
+
+bool AnyMatch::Match(const std::string&) const {
+ return true;
+}
+
+InterceptorFactory::InterceptorFactory(
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner)
+ : URLRequestPostInterceptorFactory(POST_INTERCEPT_SCHEME,
+ POST_INTERCEPT_HOSTNAME,
+ io_task_runner) {}
+
+InterceptorFactory::~InterceptorFactory() {}
+
+scoped_refptr<URLRequestPostInterceptor>
+InterceptorFactory::CreateInterceptor() {
+ return CreateInterceptorForPath(POST_INTERCEPT_PATH);
+}
+
+scoped_refptr<URLRequestPostInterceptor>
+InterceptorFactory::CreateInterceptorForPath(const char* url_path) {
+ return URLRequestPostInterceptorFactory::CreateInterceptor(
+ base::FilePath::FromUTF8Unsafe(url_path));
+}
+
+} // namespace update_client
diff --git a/src/components/update_client/net/url_request_post_interceptor.h b/src/components/update_client/net/url_request_post_interceptor.h
new file mode 100644
index 0000000..07a8ae2
--- /dev/null
+++ b/src/components/update_client/net/url_request_post_interceptor.h
@@ -0,0 +1,220 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_UPDATE_CLIENT_URL_REQUEST_POST_INTERCEPTOR_H_
+#define COMPONENTS_UPDATE_CLIENT_URL_REQUEST_POST_INTERCEPTOR_H_
+
+#include <stdint.h>
+#include <map>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
+#include "base/callback.h"
+#include "base/containers/queue.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/synchronization/lock.h"
+#include "url/gurl.h"
+
+namespace base {
+class FilePath;
+class SequencedTaskRunner;
+} // namespace base
+
+namespace net {
+class HttpRequestHeaders;
+}
+
+namespace update_client {
+
+class URLRequestMockJob;
+
+// Intercepts requests to a file path, counts them, and captures the body of
+// the requests. Optionally, for each request, it can return a canned response
+// from a given file. The class maintains a queue of expectations, and returns
+// one and only one response for each request that matches the expectation.
+// Then, the expectation is removed from the queue.
+class URLRequestPostInterceptor
+ : public base::RefCountedThreadSafe<URLRequestPostInterceptor> {
+ public:
+ using InterceptedRequest = std::pair<std::string, net::HttpRequestHeaders>;
+
+ // Called when the job associated with the url request which is intercepted
+ // by this object has been created.
+ using UrlJobRequestReadyCallback = base::OnceCallback<void()>;
+
+ // Allows a generic string maching interface when setting up expectations.
+ class RequestMatcher {
+ public:
+ virtual bool Match(const std::string& actual) const = 0;
+ virtual ~RequestMatcher() {}
+ };
+
+ // Returns the url that is intercepted.
+ GURL GetUrl() const;
+
+ // Sets an expection for the body of the POST request and optionally,
+ // provides a canned response identified by a |file_path| to be returned when
+ // the expectation is met. If no |file_path| is provided, then an empty
+ // response body is served. If |response_code| is provided, then an empty
+ // response body with that response code is returned.
+ // Returns |true| if the expectation was set.
+ bool ExpectRequest(std::unique_ptr<RequestMatcher> request_matcher);
+ bool ExpectRequest(std::unique_ptr<RequestMatcher> request_matcher,
+ int response_code);
+ bool ExpectRequest(std::unique_ptr<RequestMatcher> request_matcher,
+ const base::FilePath& filepath);
+
+ // Returns how many requests have been intercepted and matched by
+ // an expectation. One expectation can only be matched by one request.
+ int GetHitCount() const;
+
+ // Returns how many requests in total have been captured by the interceptor.
+ int GetCount() const;
+
+ // Returns all requests that have been intercepted, matched or not.
+ std::vector<InterceptedRequest> GetRequests() const;
+
+ // Return the body of the n-th request, zero-based.
+ std::string GetRequestBody(size_t n) const;
+
+ // Returns the joined bodies of all requests for debugging purposes.
+ std::string GetRequestsAsString() const;
+
+ // Resets the state of the interceptor so that new expectations can be set.
+ void Reset();
+
+ // Prevents the intercepted request from starting, as a way to simulate
+ // the effects of a very slow network. Call this function before the actual
+ // network request occurs.
+ void Pause();
+
+ // Allows a previously paused request to continue.
+ void Resume();
+
+ // Sets a callback to be invoked when the request job associated with
+ // an intercepted request is created. This allows the test execution to
+ // synchronize with network tasks running on the IO thread and avoid polling
+ // using idle run loops. A paused request can be resumed after this callback
+ // has been invoked.
+ void url_job_request_ready_callback(
+ UrlJobRequestReadyCallback url_job_request_ready_callback);
+
+ private:
+ class Delegate;
+ class URLRequestMockJob;
+
+ friend class URLRequestPostInterceptorFactory;
+ friend class base::RefCountedThreadSafe<URLRequestPostInterceptor>;
+
+ static const int kResponseCode200 = 200;
+
+ struct ExpectationResponse {
+ ExpectationResponse(int code, const std::string& body)
+ : response_code(code), response_body(body) {}
+ const int response_code;
+ const std::string response_body;
+ };
+ using Expectation =
+ std::pair<std::unique_ptr<RequestMatcher>, ExpectationResponse>;
+
+ URLRequestPostInterceptor(
+ const GURL& url,
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner);
+ ~URLRequestPostInterceptor();
+
+ void ClearExpectations();
+
+ const GURL url_;
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner_;
+
+ mutable base::Lock interceptor_lock_;
+
+ // Contains the count of the request matching expectations.
+ int hit_count_;
+
+ // Contains the request body and the extra headers of the intercepted
+ // requests.
+ std::vector<InterceptedRequest> requests_;
+
+ // Contains the expectations which this interceptor tries to match.
+ base::queue<Expectation> expectations_;
+
+ URLRequestMockJob* request_job_ = nullptr;
+
+ bool is_paused_ = false;
+
+ UrlJobRequestReadyCallback url_job_request_ready_callback_;
+
+ DISALLOW_COPY_AND_ASSIGN(URLRequestPostInterceptor);
+};
+
+class URLRequestPostInterceptorFactory {
+ public:
+ URLRequestPostInterceptorFactory(
+ const std::string& scheme,
+ const std::string& hostname,
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner);
+ ~URLRequestPostInterceptorFactory();
+
+ // Creates an interceptor object for the specified url path.
+ scoped_refptr<URLRequestPostInterceptor> CreateInterceptor(
+ const base::FilePath& filepath);
+
+ private:
+ const std::string scheme_;
+ const std::string hostname_;
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner_;
+
+ // After creation, |delegate_| lives on the IO thread and it is owned by
+ // a URLRequestFilter after registration. A task to unregister it and
+ // implicitly destroy it is posted from ~URLRequestPostInterceptorFactory().
+ URLRequestPostInterceptor::Delegate* delegate_;
+
+ DISALLOW_COPY_AND_ASSIGN(URLRequestPostInterceptorFactory);
+};
+
+// Intercepts HTTP POST requests sent to "localhost2".
+class InterceptorFactory : public URLRequestPostInterceptorFactory {
+ public:
+ explicit InterceptorFactory(
+ scoped_refptr<base::SequencedTaskRunner> io_task_runner);
+ ~InterceptorFactory();
+
+ // Creates an interceptor for the url path defined by POST_INTERCEPT_PATH.
+ scoped_refptr<URLRequestPostInterceptor> CreateInterceptor();
+
+ // Creates an interceptor for the given url path.
+ scoped_refptr<URLRequestPostInterceptor> CreateInterceptorForPath(
+ const char* url_path);
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(InterceptorFactory);
+};
+
+class PartialMatch : public URLRequestPostInterceptor::RequestMatcher {
+ public:
+ explicit PartialMatch(const std::string& expected) : expected_(expected) {}
+ bool Match(const std::string& actual) const override;
+
+ private:
+ const std::string expected_;
+
+ DISALLOW_COPY_AND_ASSIGN(PartialMatch);
+};
+
+class AnyMatch : public URLRequestPostInterceptor::RequestMatcher {
+ public:
+ AnyMatch() = default;
+ bool Match(const std::string& actual) const override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(AnyMatch);
+};
+
+} // namespace update_client
+
+#endif // COMPONENTS_UPDATE_CLIENT_URL_REQUEST_POST_INTERCEPTOR_H_
diff --git a/src/components/update_client/patch/patch_impl_cobalt.cc b/src/components/update_client/patch/patch_impl_cobalt.cc
new file mode 100644
index 0000000..9c09a02
--- /dev/null
+++ b/src/components/update_client/patch/patch_impl_cobalt.cc
@@ -0,0 +1,55 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "components/update_client/patch/patch_impl_cobalt.h"
+
+#include "components/update_client/component_patcher_operation.h"
+
+namespace update_client {
+
+namespace {
+
+class PatcherImplCobalt : public Patcher {
+ public:
+ PatcherImplCobalt() {}
+
+ void PatchBsdiff(const base::FilePath& old_file,
+ const base::FilePath& patch_file,
+ const base::FilePath& destination,
+ PatchCompleteCallback callback) const override {
+ // TODO: implement when Evergreen supports patcher.
+ }
+
+ void PatchCourgette(const base::FilePath& old_file,
+ const base::FilePath& patch_file,
+ const base::FilePath& destination,
+ PatchCompleteCallback callback) const override {
+ // TODO: implement when Evergreen supports patcher.
+ }
+
+ protected:
+ ~PatcherImplCobalt() override = default;
+};
+
+} // namespace
+
+PatchCobaltFactory::PatchCobaltFactory() {}
+
+scoped_refptr<Patcher> PatchCobaltFactory::Create() const {
+ return base::MakeRefCounted<PatcherImplCobalt>();
+}
+
+PatchCobaltFactory::~PatchCobaltFactory() = default;
+
+} // namespace update_client
diff --git a/src/components/update_client/patch/patch_impl_cobalt.h b/src/components/update_client/patch/patch_impl_cobalt.h
new file mode 100644
index 0000000..c41739f
--- /dev/null
+++ b/src/components/update_client/patch/patch_impl_cobalt.h
@@ -0,0 +1,41 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef COMPONENTS_UPDATE_CLIENT_PATCH_PATCH_IMPL_COBALT_H_
+#define COMPONENTS_UPDATE_CLIENT_PATCH_PATCH_IMPL_COBALT_H_
+
+#include <memory>
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "components/update_client/patcher.h"
+
+namespace update_client {
+
+class PatchCobaltFactory : public PatcherFactory {
+ public:
+ PatchCobaltFactory();
+
+ scoped_refptr<Patcher> Create() const override;
+
+ protected:
+ ~PatchCobaltFactory() override;
+
+ DISALLOW_COPY_AND_ASSIGN(PatchCobaltFactory);
+};
+
+} // namespace update_client
+
+#endif // COMPONENTS_UPDATE_CLIENT_PATCH_PATCH_IMPL_COBALT_H_
diff --git a/src/components/update_client/ping_manager_unittest.cc b/src/components/update_client/ping_manager_unittest.cc
index 34583d7..91fb95f 100644
--- a/src/components/update_client/ping_manager_unittest.cc
+++ b/src/components/update_client/ping_manager_unittest.cc
@@ -20,13 +20,17 @@
#include "base/threading/thread_task_runner_handle.h"
#include "base/version.h"
#include "components/update_client/component.h"
-#include "components/update_client/net/url_loader_post_interceptor.h"
#include "components/update_client/protocol_definition.h"
#include "components/update_client/protocol_serializer.h"
#include "components/update_client/test_configurator.h"
#include "components/update_client/update_engine.h"
#include "testing/gtest/include/gtest/gtest.h"
+#if !defined(STARBOARD)
+#include "components/update_client/net/url_loader_post_interceptor.h"
#include "third_party/re2/src/re2/re2.h"
+#else
+#include "components/update_client/net/url_request_post_interceptor.h"
+#endif
using std::string;
@@ -113,8 +117,14 @@
INSTANTIATE_TEST_SUITE_P(Parameterized, PingManagerTest, testing::Bool());
TEST_P(PingManagerTest, SendPing) {
+#if defined(STARBOARD)
+ auto interceptor_factory =
+ std::make_unique<InterceptorFactory>(base::ThreadTaskRunnerHandle::Get());
+ auto interceptor = interceptor_factory->CreateInterceptor();
+#else
auto interceptor = std::make_unique<URLLoaderPostInterceptor>(
config_->test_url_loader_factory());
+#endif
EXPECT_TRUE(interceptor);
const auto update_context = MakeMockUpdateContext();
diff --git a/src/components/update_client/protocol_serializer_json_unittest.cc b/src/components/update_client/protocol_serializer_json_unittest.cc
index 1f4ce4a..5a928ff 100644
--- a/src/components/update_client/protocol_serializer_json_unittest.cc
+++ b/src/components/update_client/protocol_serializer_json_unittest.cc
@@ -18,7 +18,9 @@
#include "components/update_client/protocol_serializer_json.h"
#include "components/update_client/updater_state.h"
#include "testing/gtest/include/gtest/gtest.h"
+#if !defined(STARBOARD)
#include "third_party/re2/src/re2/re2.h"
+#endif
using base::Value;
using std::string;
diff --git a/src/components/update_client/request_sender_unittest.cc b/src/components/update_client/request_sender_unittest.cc
index e1e16d8..9bca3d0 100644
--- a/src/components/update_client/request_sender_unittest.cc
+++ b/src/components/update_client/request_sender_unittest.cc
@@ -15,7 +15,12 @@
#include "base/strings/string_util.h"
#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
+#if defined(STARBOARD)
+#include "components/update_client/net/url_request_post_interceptor.h"
+#include "net/url_request/url_fetcher.h"
+#else
#include "components/update_client/net/url_loader_post_interceptor.h"
+#endif
#include "components/update_client/test_configurator.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -26,6 +31,11 @@
const char kUrl1[] = "https://localhost2/path1";
const char kUrl2[] = "https://localhost2/path2";
+#if defined(STARBOARD)
+const char kUrlPath1[] = "path1";
+const char kUrlPath2[] = "path2";
+#endif
+
// TODO(sorin): refactor as a utility function for unit tests.
base::FilePath test_file(const char* file) {
base::FilePath path;
@@ -62,7 +72,14 @@
scoped_refptr<TestConfigurator> config_;
std::unique_ptr<RequestSender> request_sender_;
+#if defined(STARBOARD)
+ std::unique_ptr<InterceptorFactory> interceptor_factory_;
+
+ scoped_refptr<URLRequestPostInterceptor> post_interceptor_1_;
+ scoped_refptr<URLRequestPostInterceptor> post_interceptor_2_;
+#else
std::unique_ptr<URLLoaderPostInterceptor> post_interceptor_;
+#endif
int error_ = 0;
std::string response_;
@@ -85,6 +102,16 @@
config_ = base::MakeRefCounted<TestConfigurator>();
request_sender_ = std::make_unique<RequestSender>(config_);
+#if defined(STARBOARD)
+ interceptor_factory_ =
+ std::make_unique<InterceptorFactory>(base::ThreadTaskRunnerHandle::Get());
+ post_interceptor_1_ =
+ interceptor_factory_->CreateInterceptorForPath(kUrlPath1);
+ post_interceptor_2_ =
+ interceptor_factory_->CreateInterceptorForPath(kUrlPath2);
+ EXPECT_TRUE(post_interceptor_1_);
+ EXPECT_TRUE(post_interceptor_2_);
+#else
std::vector<GURL> urls;
urls.push_back(GURL(kUrl1));
urls.push_back(GURL(kUrl2));
@@ -92,12 +119,20 @@
post_interceptor_ = std::make_unique<URLLoaderPostInterceptor>(
urls, config_->test_url_loader_factory());
EXPECT_TRUE(post_interceptor_);
+#endif
}
void RequestSenderTest::TearDown() {
request_sender_ = nullptr;
+#if defined(STARBOARD)
+ post_interceptor_1_ = nullptr;
+ post_interceptor_2_ = nullptr;
+
+ interceptor_factory_ = nullptr;
+#else
post_interceptor_.reset();
+#endif
// Run the threads until they are idle to allow the clean up
// of the network interceptors on the IO thread.
@@ -128,9 +163,15 @@
// Tests that when a request to the first url succeeds, the subsequent urls are
// not tried.
TEST_P(RequestSenderTest, RequestSendSuccess) {
+#if defined(STARBOARD)
+ EXPECT_TRUE(post_interceptor_1_->ExpectRequest(
+ std::make_unique<PartialMatch>("test"),
+ test_file("updatecheck_reply_1.json")));
+#else
EXPECT_TRUE(
post_interceptor_->ExpectRequest(std::make_unique<PartialMatch>("test"),
test_file("updatecheck_reply_1.json")));
+#endif
const bool is_foreground = GetParam();
request_sender_->Send(
@@ -141,6 +182,20 @@
base::Unretained(this)));
RunThreads();
+#if defined(STARBOARD)
+ EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
+ << post_interceptor_1_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_1_->GetCount())
+ << post_interceptor_1_->GetRequestsAsString();
+
+ EXPECT_EQ(0, post_interceptor_2_->GetHitCount())
+ << post_interceptor_2_->GetRequestsAsString();
+ EXPECT_EQ(0, post_interceptor_2_->GetCount())
+ << post_interceptor_2_->GetRequestsAsString();
+
+ // Sanity check the request.
+ EXPECT_STREQ("test", post_interceptor_1_->GetRequestBody(0).c_str());
+#else
EXPECT_EQ(1, post_interceptor_->GetHitCount())
<< post_interceptor_->GetRequestsAsString();
EXPECT_EQ(1, post_interceptor_->GetCount())
@@ -151,14 +206,20 @@
// Sanity check the request.
EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
+#endif
// Check the response post conditions.
EXPECT_EQ(0, error_);
EXPECT_EQ(419ul, response_.size());
// Check the interactivity header value.
+#if defined(STARBOARD)
+ const auto extra_request_headers =
+ post_interceptor_1_->GetRequests()[0].second;
+#else
const auto extra_request_headers =
std::get<1>(post_interceptor_->GetRequests()[0]);
+#endif
EXPECT_TRUE(extra_request_headers.HasHeader("X-Goog-Update-Interactivity"));
std::string header;
extra_request_headers.GetHeader("X-Goog-Update-Interactivity", &header);
@@ -168,10 +229,17 @@
// Tests that the request succeeds using the second url after the first url
// has failed.
TEST_F(RequestSenderTest, RequestSendSuccessWithFallback) {
+#if defined(STARBOARD)
+ EXPECT_TRUE(post_interceptor_1_->ExpectRequest(
+ std::make_unique<PartialMatch>("test"), 403));
+ EXPECT_TRUE(post_interceptor_2_->ExpectRequest(
+ std::make_unique<PartialMatch>("test")));
+#else
EXPECT_TRUE(post_interceptor_->ExpectRequest(
std::make_unique<PartialMatch>("test"), net::HTTP_FORBIDDEN));
EXPECT_TRUE(
post_interceptor_->ExpectRequest(std::make_unique<PartialMatch>("test")));
+#endif
request_sender_->Send(
{GURL(kUrl1), GURL(kUrl2)}, {}, "test", false,
@@ -179,6 +247,19 @@
base::Unretained(this)));
RunThreads();
+#if defined(STARBOARD)
+ EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
+ << post_interceptor_1_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_1_->GetCount())
+ << post_interceptor_1_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_2_->GetHitCount())
+ << post_interceptor_2_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_2_->GetCount())
+ << post_interceptor_2_->GetRequestsAsString();
+
+ EXPECT_STREQ("test", post_interceptor_1_->GetRequestBody(0).c_str());
+ EXPECT_STREQ("test", post_interceptor_2_->GetRequestBody(0).c_str());
+#else
EXPECT_EQ(2, post_interceptor_->GetHitCount())
<< post_interceptor_->GetRequestsAsString();
EXPECT_EQ(2, post_interceptor_->GetCount())
@@ -190,15 +271,23 @@
EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
EXPECT_STREQ("test", post_interceptor_->GetRequestBody(1).c_str());
+#endif
EXPECT_EQ(0, error_);
}
// Tests that the request fails when both urls have failed.
TEST_F(RequestSenderTest, RequestSendFailed) {
+#if defined(STARBOARD)
+ EXPECT_TRUE(post_interceptor_1_->ExpectRequest(
+ std::make_unique<PartialMatch>("test"), 403));
+ EXPECT_TRUE(post_interceptor_2_->ExpectRequest(
+ std::make_unique<PartialMatch>("test"), 403));
+#else
EXPECT_TRUE(post_interceptor_->ExpectRequest(
std::make_unique<PartialMatch>("test"), net::HTTP_FORBIDDEN));
EXPECT_TRUE(post_interceptor_->ExpectRequest(
std::make_unique<PartialMatch>("test"), net::HTTP_FORBIDDEN));
+#endif
const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)};
request_sender_ = std::make_unique<RequestSender>(config_);
@@ -208,6 +297,19 @@
base::Unretained(this)));
RunThreads();
+#if defined(STARBOARD)
+ EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
+ << post_interceptor_1_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_1_->GetCount())
+ << post_interceptor_1_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_2_->GetHitCount())
+ << post_interceptor_2_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_2_->GetCount())
+ << post_interceptor_2_->GetRequestsAsString();
+
+ EXPECT_STREQ("test", post_interceptor_1_->GetRequestBody(0).c_str());
+ EXPECT_STREQ("test", post_interceptor_2_->GetRequestBody(0).c_str());
+#else
EXPECT_EQ(2, post_interceptor_->GetHitCount())
<< post_interceptor_->GetRequestsAsString();
EXPECT_EQ(2, post_interceptor_->GetCount())
@@ -219,6 +321,7 @@
EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
EXPECT_STREQ("test", post_interceptor_->GetRequestBody(1).c_str());
+#endif
EXPECT_EQ(403, error_);
}
@@ -237,9 +340,15 @@
// Tests that a CUP request fails if the response is not signed.
TEST_F(RequestSenderTest, RequestSendCupError) {
+#if defined(STARBOARD)
+ EXPECT_TRUE(post_interceptor_1_->ExpectRequest(
+ std::make_unique<PartialMatch>("test"),
+ test_file("updatecheck_reply_1.json")));
+#else
EXPECT_TRUE(
post_interceptor_->ExpectRequest(std::make_unique<PartialMatch>("test"),
test_file("updatecheck_reply_1.json")));
+#endif
const std::vector<GURL> urls = {GURL(kUrl1)};
request_sender_ = std::make_unique<RequestSender>(config_);
@@ -249,12 +358,21 @@
base::Unretained(this)));
RunThreads();
+#if defined(STARBOARD)
+ EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
+ << post_interceptor_1_->GetRequestsAsString();
+ EXPECT_EQ(1, post_interceptor_1_->GetCount())
+ << post_interceptor_1_->GetRequestsAsString();
+
+ EXPECT_STREQ("test", post_interceptor_1_->GetRequestBody(0).c_str());
+#else
EXPECT_EQ(1, post_interceptor_->GetHitCount())
<< post_interceptor_->GetRequestsAsString();
EXPECT_EQ(1, post_interceptor_->GetCount())
<< post_interceptor_->GetRequestsAsString();
EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
+#endif
EXPECT_EQ(-10000, error_);
EXPECT_TRUE(response_.empty());
}
diff --git a/src/components/update_client/test_configurator.cc b/src/components/update_client/test_configurator.cc
index 515be05..3bd3911 100644
--- a/src/components/update_client/test_configurator.cc
+++ b/src/components/update_client/test_configurator.cc
@@ -9,16 +9,21 @@
#include "base/threading/thread_task_runner_handle.h"
#include "base/version.h"
#include "components/prefs/pref_service.h"
+#if !defined(STARBOARD)
#include "components/services/patch/in_process_file_patcher.h"
#include "components/services/unzip/in_process_unzipper.h"
-#include "components/update_client/activity_data_service.h"
#include "components/update_client/net/network_chromium.h"
#include "components/update_client/patch/patch_impl.h"
+#include "components/update_client/unzip/unzip_impl.h"
+#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
+#else
+#include "components/update_client/patch/patch_impl_cobalt.h"
+#include "components/update_client/unzip/unzip_impl_cobalt.h"
+#endif
+#include "components/update_client/activity_data_service.h"
#include "components/update_client/patcher.h"
#include "components/update_client/protocol_handler.h"
-#include "components/update_client/unzip/unzip_impl.h"
#include "components/update_client/unzipper.h"
-#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "url/gurl.h"
namespace update_client {
@@ -34,6 +39,7 @@
} // namespace
+#if !defined(STARBOARD)
TestConfigurator::TestConfigurator()
: brand_("TEST"),
initial_time_(0),
@@ -50,8 +56,28 @@
network_fetcher_factory_(
base::MakeRefCounted<NetworkFetcherChromiumFactory>(
test_shared_loader_factory_)) {}
+#else
+TestConfigurator::TestConfigurator()
+ : brand_("TEST"),
+ initial_time_(0),
+ ondemand_time_(0),
+ enabled_cup_signing_(false),
+ enabled_component_updates_(true),
+ unzip_factory_(base::MakeRefCounted<update_client::UnzipCobaltFactory>()),
+ patch_factory_(
+ base::MakeRefCounted<update_client::PatchCobaltFactory>()) {
+ cobalt::network::NetworkModule::Options network_options;
+ network_module_.reset(new cobalt::network::NetworkModule(network_options));
+ network_fetcher_factory_ =
+ base::MakeRefCounted<NetworkFetcherCobaltFactory>(network_module_.get());
+}
+#endif
-TestConfigurator::~TestConfigurator() {}
+TestConfigurator::~TestConfigurator() {
+#if defined(STARBOARD)
+ network_module_.reset();
+#endif
+}
int TestConfigurator::InitialDelay() const {
return initial_time_;
diff --git a/src/components/update_client/test_configurator.h b/src/components/update_client/test_configurator.h
index 6935347..f6ede80 100644
--- a/src/components/update_client/test_configurator.h
+++ b/src/components/update_client/test_configurator.h
@@ -16,22 +16,36 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "components/update_client/configurator.h"
-#include "services/network/test/test_url_loader_factory.h"
#include "url/gurl.h"
+#if defined(STARBOARD)
+#include "cobalt/network/network_module.h"
+#include "components/update_client/net/network_cobalt.h"
+#else
+#include "services/network/test/test_url_loader_factory.h"
+#endif
+
class PrefService;
+#if !defined(STARBOARD)
namespace network {
class SharedURLLoaderFactory;
} // namespace network
+#endif
namespace update_client {
class ActivityDataService;
+class ProtocolHandlerFactory;
+#if defined(STARBOARD)
+class NetworkFetcherCobaltFactory;
+class PatchCobaltFactory;
+class UnzipCobaltFactory;
+#else
class NetworkFetcherFactory;
class PatchChromiumFactory;
-class ProtocolHandlerFactory;
class UnzipChromiumFactory;
+#endif
#define POST_INTERCEPT_SCHEME "https"
#define POST_INTERCEPT_HOSTNAME "localhost2"
@@ -111,9 +125,15 @@
void SetUpdateCheckUrl(const GURL& url);
void SetPingUrl(const GURL& url);
void SetAppGuid(const std::string& app_guid);
+
+#if defined(STARBOARD)
+ void SetChannel(const std::string& channel) override {}
+ bool IsChannelChanged() const override { return false; }
+#else
network::TestURLLoaderFactory* test_url_loader_factory() {
return &test_url_loader_factory_;
}
+#endif
private:
friend class base::RefCountedThreadSafe<TestConfigurator>;
@@ -131,12 +151,20 @@
GURL ping_url_;
std::string app_guid_;
+#if defined(STARBOARD)
+ scoped_refptr<update_client::UnzipCobaltFactory> unzip_factory_;
+ scoped_refptr<update_client::PatchCobaltFactory> patch_factory_;
+
+ scoped_refptr<NetworkFetcherCobaltFactory> network_fetcher_factory_;
+ std::unique_ptr<cobalt::network::NetworkModule> network_module_;
+#else
scoped_refptr<update_client::UnzipChromiumFactory> unzip_factory_;
scoped_refptr<update_client::PatchChromiumFactory> patch_factory_;
scoped_refptr<network::SharedURLLoaderFactory> test_shared_loader_factory_;
network::TestURLLoaderFactory test_url_loader_factory_;
scoped_refptr<NetworkFetcherFactory> network_fetcher_factory_;
+#endif
DISALLOW_COPY_AND_ASSIGN(TestConfigurator);
};
diff --git a/src/components/update_client/unzip/unzip_impl_cobalt.cc b/src/components/update_client/unzip/unzip_impl_cobalt.cc
new file mode 100644
index 0000000..40882b5
--- /dev/null
+++ b/src/components/update_client/unzip/unzip_impl_cobalt.cc
@@ -0,0 +1,38 @@
+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/update_client/unzip/unzip_impl_cobalt.h"
+
+#include <utility>
+#include "base/callback.h"
+#include "base/files/file_path.h"
+#include "starboard/time.h"
+#include "third_party/zlib/google/zip.h"
+
+namespace update_client {
+
+namespace {
+
+class UnzipperImpl : public update_client::Unzipper {
+ public:
+ UnzipperImpl() = default;
+
+ void Unzip(const base::FilePath& zip_path,
+ const base::FilePath& output_path,
+ UnzipCompleteCallback callback) override {
+ std::move(callback).Run(zip::Unzip(zip_path, output_path));
+ }
+};
+
+} // namespace
+
+UnzipCobaltFactory::UnzipCobaltFactory() = default;
+
+std::unique_ptr<Unzipper> UnzipCobaltFactory::Create() const {
+ return std::make_unique<UnzipperImpl>();
+}
+
+UnzipCobaltFactory::~UnzipCobaltFactory() = default;
+
+} // namespace update_client
diff --git a/src/components/update_client/unzip/unzip_impl_cobalt.h b/src/components/update_client/unzip/unzip_impl_cobalt.h
new file mode 100644
index 0000000..d5a2d38
--- /dev/null
+++ b/src/components/update_client/unzip/unzip_impl_cobalt.h
@@ -0,0 +1,31 @@
+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_UPDATE_CLIENT_UNZIP_UNZIP_IMPL_COBALT_H_
+#define COMPONENTS_UPDATE_CLIENT_UNZIP_UNZIP_IMPL_COBALT_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "components/update_client/unzipper.h"
+
+namespace update_client {
+
+class UnzipCobaltFactory : public UnzipperFactory {
+ public:
+ UnzipCobaltFactory();
+
+ std::unique_ptr<Unzipper> Create() const override;
+
+ protected:
+ ~UnzipCobaltFactory() override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(UnzipCobaltFactory);
+};
+
+} // namespace update_client
+
+#endif // COMPONENTS_UPDATE_CLIENT_UNZIP_UNZIP_IMPL_COBALT_H_
diff --git a/src/components/update_client/update_checker.cc b/src/components/update_client/update_checker.cc
index da15867..a904a17 100644
--- a/src/components/update_client/update_checker.cc
+++ b/src/components/update_client/update_checker.cc
@@ -22,6 +22,13 @@
#include "base/threading/thread_checker.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
+#if defined(OS_STARBOARD)
+#include "cobalt/extension/installation_manager.h"
+#include "cobalt/updater/utils.h"
+#include "starboard/file.h"
+#include "starboard/loader_app/app_key_files.h"
+#include "starboard/loader_app/drain_file.h"
+#endif
#include "components/update_client/component.h"
#include "components/update_client/configurator.h"
#include "components/update_client/persisted_data.h"
@@ -63,6 +70,20 @@
return false;
}
+#if defined(OS_STARBOARD)
+
+bool CheckBadFileExists(const char* installation_path, const char* app_key) {
+ std::string bad_app_key_file_path =
+ starboard::loader_app::GetBadAppKeyFilePath(installation_path, app_key);
+ SB_DCHECK(!bad_app_key_file_path.empty());
+ SB_LOG(INFO) << "bad_app_key_file_path: " << bad_app_key_file_path;
+ SB_LOG(INFO) << "bad_app_key_file_path SbFileExists: "
+ << SbFileExists(bad_app_key_file_path.c_str());
+ return !bad_app_key_file_path.empty() &&
+ SbFileExists(bad_app_key_file_path.c_str());
+}
+#endif
+
// Filters invalid attributes from |installer_attributes|.
using InstallerAttributesFlatMap = base::flat_map<std::string, std::string>;
InstallerAttributesFlatMap SanitizeInstallerAttributes(
@@ -205,7 +226,7 @@
crx_component->supports_group_policy_enable_component_updates &&
!enabled_component_updates;
- base::Version version = crx_component->version;
+ base::Version current_version = crx_component->version;
#if defined(OS_STARBOARD)
std::string unpacked_version =
GetPersistedData()->GetLastUnpackedVersion(app_id);
@@ -213,13 +234,100 @@
// version of the running binary, use the former to indicate the current
// update version in the update check request.
if (!unpacked_version.empty() &&
- base::Version(unpacked_version).CompareTo(version) > 0) {
- version = base::Version(unpacked_version);
+ base::Version(unpacked_version).CompareTo(current_version) > 0) {
+ current_version = base::Version(unpacked_version);
}
+
+ // Check if there is an available update already for quick roll-forward
+ auto installation_api =
+ static_cast<const CobaltExtensionInstallationManagerApi*>(
+ SbSystemGetExtension(kCobaltExtensionInstallationManagerName));
+ if (!installation_api) {
+ SB_LOG(ERROR) << "Failed to get installation manager extension.";
+ return;
+ }
+
+ char app_key[IM_EXT_MAX_APP_KEY_LENGTH];
+ if (installation_api->GetAppKey(app_key, IM_EXT_MAX_APP_KEY_LENGTH) ==
+ IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "Failed to get app key.";
+ return;
+ }
+
+ int max_slots = installation_api->GetMaxNumberInstallations();
+ if (max_slots == IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "Failed to get max number of slots.";
+ return;
+ }
+
+ // We'll find the newest version of the installation that satisfies the
+ // requirements as the final candidate slot.
+ base::Version slot_candidate_version("1.0.1");
+ int slot_candidate = -1;
+
+ // Iterate over all writeable slots - index >= 1.
+ for (int i = 1; i < max_slots; i++) {
+ SB_LOG(INFO) << "UpdateCheckerImpl::CheckForUpdatesHelper iterating slot="
+ << i;
+ // Get the path to new installation.
+ std::vector<char> installation_path(kSbFileMaxPath);
+ if (installation_api->GetInstallationPath(i, installation_path.data(),
+ installation_path.size()) ==
+ IM_EXT_ERROR) {
+ SB_LOG(ERROR)
+ << "UpdateCheckerImpl::CheckForUpdatesHelper: Failed to get "
+ "installation path for slot="
+ << i;
+ continue;
+ }
+
+ SB_DLOG(INFO)
+ << "UpdateCheckerImpl::CheckForUpdatesHelper installation_path = "
+ << installation_path.data();
+
+ base::FilePath installation_dir = base::FilePath(
+ std::string(installation_path.begin(), installation_path.end()));
+
+ base::Version installed_version =
+ cobalt::updater::ReadEvergreenVersion(installation_dir);
+
+ if (!installed_version.IsValid()) {
+ continue;
+ } else if (slot_candidate_version < installed_version &&
+ current_version < installed_version &&
+ !DrainFileDraining(installation_dir.value().c_str(), "") &&
+ !CheckBadFileExists(installation_dir.value().c_str(),
+ app_key) &&
+ starboard::loader_app::AnyGoodAppKeyFile(
+ installation_dir.value().c_str())) {
+ // Found a slot with newer version than the current version that's not
+ // draining, and no bad file of current app exists, and a good file
+ // exists. The final candidate is the newest version of the valid
+ // candidates.
+ SB_LOG(INFO)
+ << "UpdateCheckerImpl::CheckForUpdatesHelper slot candidate: " << i;
+ slot_candidate_version = installed_version;
+ slot_candidate = i;
+ }
+ }
+
+ if (slot_candidate != -1) {
+ if (installation_api->RequestRollForwardToInstallation(slot_candidate) !=
+ IM_EXT_ERROR) {
+ SB_LOG(INFO) << "UpdateCheckerImpl::CheckForUpdatesHelper: quick "
+ "update succeeded.";
+ return;
+ }
+ SB_LOG(WARNING)
+ << "UpdateCheckerImpl::CheckForUpdatesHelper: quick update failed.";
+ }
+// If the quick roll forward update slot candidate doesn't exist, continue
+// with update check.
#endif
apps.push_back(MakeProtocolApp(
- app_id, version, SanitizeBrand(config_->GetBrand()), install_source,
- crx_component->install_location, crx_component->fingerprint,
+ app_id, current_version, SanitizeBrand(config_->GetBrand()),
+ install_source, crx_component->install_location,
+ crx_component->fingerprint,
SanitizeInstallerAttributes(crx_component->installer_attributes),
metadata_->GetCohort(app_id), metadata_->GetCohortName(app_id),
metadata_->GetCohortHint(app_id), crx_component->disabled_reasons,
diff --git a/src/components/update_client/update_checker_unittest.cc b/src/components/update_client/update_checker_unittest.cc
index 1554743..de84eb9 100644
--- a/src/components/update_client/update_checker_unittest.cc
+++ b/src/components/update_client/update_checker_unittest.cc
@@ -29,7 +29,11 @@
#include "components/prefs/testing_pref_service.h"
#include "components/update_client/activity_data_service.h"
#include "components/update_client/component.h"
+#if defined(STARBOARD)
+#include "components/update_client/net/url_request_post_interceptor.h"
+#else
#include "components/update_client/net/url_loader_post_interceptor.h"
+#endif
#include "components/update_client/persisted_data.h"
#include "components/update_client/test_configurator.h"
#include "components/update_client/update_engine.h"
@@ -137,7 +141,12 @@
std::unique_ptr<UpdateChecker> update_checker_;
+#if defined(STARBOARD)
+ std::unique_ptr<InterceptorFactory> interceptor_factory_;
+ scoped_refptr<URLRequestPostInterceptor> post_interceptor_;
+#else
std::unique_ptr<URLLoaderPostInterceptor> post_interceptor_;
+#endif
base::Optional<ProtocolParser::Results> results_;
ErrorCategory error_category_ = ErrorCategory::kNone;
@@ -176,9 +185,14 @@
PersistedData::RegisterPrefs(pref_->registry());
metadata_ = std::make_unique<PersistedData>(pref_.get(),
activity_data_service_.get());
-
+#if defined(STARBOARD)
+ interceptor_factory_ =
+ std::make_unique<InterceptorFactory>(base::ThreadTaskRunnerHandle::Get());
+ post_interceptor_ = interceptor_factory_->CreateInterceptor();
+#else
post_interceptor_ = std::make_unique<URLLoaderPostInterceptor>(
config_->test_url_loader_factory());
+#endif
EXPECT_TRUE(post_interceptor_);
update_checker_ = nullptr;
@@ -192,7 +206,12 @@
void UpdateCheckerTest::TearDown() {
update_checker_ = nullptr;
+#if defined(STARBOARD)
+ post_interceptor_ = nullptr;
+ interceptor_factory_ = nullptr;
+#else
post_interceptor_.reset();
+#endif
config_ = nullptr;
@@ -351,8 +370,13 @@
EXPECT_STREQ("this", result.action_run.c_str());
// Check the DDOS protection header values.
+#if defined(STARBOARD)
+ const auto extra_request_headers = post_interceptor_->GetRequests()[0].second;
+#else
const auto extra_request_headers =
std::get<1>(post_interceptor_->GetRequests()[0]);
+#endif
+
EXPECT_TRUE(extra_request_headers.HasHeader("X-Goog-Update-Interactivity"));
std::string header;
extra_request_headers.GetHeader("X-Goog-Update-Interactivity", &header);
@@ -445,8 +469,13 @@
// Simulates a 403 server response error.
TEST_P(UpdateCheckerTest, UpdateCheckError) {
+#if defined(STARBOARD)
+ EXPECT_TRUE(post_interceptor_->ExpectRequest(
+ std::make_unique<PartialMatch>("updatecheck"), 403));
+#else
EXPECT_TRUE(post_interceptor_->ExpectRequest(
std::make_unique<PartialMatch>("updatecheck"), net::HTTP_FORBIDDEN));
+#endif
update_checker_ = UpdateChecker::Create(config_, metadata_.get());
@@ -1092,11 +1121,19 @@
EXPECT_TRUE(post_interceptor_->ExpectRequest(
std::make_unique<PartialMatch>("updatecheck"),
test_file("updatecheck_reply_noupdate.json")));
+#if defined(STARBOARD)
+ post_interceptor_->url_job_request_ready_callback(base::BindOnce(
+ [](scoped_refptr<URLRequestPostInterceptor> post_interceptor) {
+ post_interceptor->Resume();
+ },
+ post_interceptor_));
+#else
post_interceptor_->url_job_request_ready_callback(base::BindOnce(
[](URLLoaderPostInterceptor* post_interceptor) {
post_interceptor->Resume();
},
post_interceptor_.get()));
+#endif
post_interceptor_->Pause();
update_checker_ = UpdateChecker::Create(config_, metadata_.get());
diff --git a/src/components/update_client/update_client.gyp b/src/components/update_client/update_client.gyp
index 45dc09d..c54c314 100644
--- a/src/components/update_client/update_client.gyp
+++ b/src/components/update_client/update_client.gyp
@@ -96,18 +96,90 @@
],
},
{
+ 'target_name': 'test_support',
+ 'type': 'static_library',
+ 'sources': [
+ 'net/network_impl_cobalt.cc',
+ 'net/network_impl_cobalt.h',
+ 'net/network_cobalt.h',
+ 'net/url_request_post_interceptor.cc',
+ 'net/url_request_post_interceptor.h',
+ 'patch/patch_impl_cobalt.cc',
+ 'patch/patch_impl_cobalt.h',
+ 'test_configurator.cc',
+ 'test_configurator.h',
+ 'unzip/unzip_impl_cobalt.cc',
+ 'unzip/unzip_impl_cobalt.h',
+ ],
+ 'dependencies': [
+ 'update_client',
+ '<(DEPTH)/base/base.gyp:base',
+ '<(DEPTH)/cobalt/loader/loader.gyp:loader',
+ '<(DEPTH)/cobalt/debug/debug.gyp:console_command_manager',
+ '<(DEPTH)/components/prefs/prefs.gyp:prefs',
+ '<(DEPTH)/net/net.gyp:net',
+ '<(DEPTH)/net/net.gyp:test_support',
+ '<(DEPTH)/cobalt/network/network.gyp:network',
+ '<(DEPTH)/testing/gmock.gyp:gmock',
+ '<(DEPTH)/testing/gtest.gyp:gtest',
+ '<(DEPTH)/third_party/zlib/zlib.gyp:zip',
+ '<(DEPTH)/url/url.gyp:url',
+ ],
+ },
+ {
+ 'target_name': 'update_client_test_data',
+ 'type': 'none',
+ 'variables': {
+ 'content_test_input_files': [
+ '<(DEPTH)/components/test/data/update_client',
+ ],
+ 'content_test_output_subdir' : 'components/test/data',
+ },
+ 'includes': ['<(DEPTH)/starboard/build/copy_test_data.gypi'],
+ },
+ {
'target_name': 'update_client_test',
'type': '<(gtest_target_type)',
'sources': [
+ 'component_unpacker_unittest.cc',
+ # TODO: enable the tests commented out
+ # 'crx_downloader_unittest.cc',
+ 'persisted_data_unittest.cc',
+ 'ping_manager_unittest.cc',
+ 'protocol_parser_json_unittest.cc',
+ # 'protocol_serializer_json_unittest.cc',
+ 'protocol_serializer_unittest.cc',
+ 'request_sender_unittest.cc',
+ # 'update_checker_unittest.cc',
+ # 'update_client_unittest.cc',
+ 'update_query_params_unittest.cc',
+ 'updater_state_unittest.cc',
'utils_unittest.cc',
],
'dependencies': [
- ':update_client',
+ 'update_client',
+ 'test_support',
+ 'update_client_test_data',
'<(DEPTH)/cobalt/base/base.gyp:base',
+ '<(DEPTH)/components/prefs/prefs.gyp:prefs',
+ '<(DEPTH)/components/prefs/prefs.gyp:test_support',
+ '<(DEPTH)/components/crx_file/crx_file.gyp:crx_file',
+ '<(DEPTH)/net/net.gyp:test_support',
'<(DEPTH)/testing/gmock.gyp:gmock',
'<(DEPTH)/testing/gtest.gyp:gtest',
],
'includes': [ '<(DEPTH)/cobalt/test/test.gypi' ],
},
+ {
+ 'target_name': 'update_client_test_deploy',
+ 'type': 'none',
+ 'dependencies': [
+ 'update_client_test',
+ ],
+ 'variables': {
+ 'executable_name': 'update_client_test',
+ },
+ 'includes': [ '<(DEPTH)/starboard/build/deploy.gypi' ],
+ },
]
}
diff --git a/src/components/update_client/update_client_unittest.cc b/src/components/update_client/update_client_unittest.cc
index ddee228..59de931 100644
--- a/src/components/update_client/update_client_unittest.cc
+++ b/src/components/update_client/update_client_unittest.cc
@@ -180,6 +180,10 @@
base::test::ScopedTaskEnvironment scoped_task_environment_;
base::RunLoop runloop_;
+#if defined(STARBOARD)
+ std::unique_ptr<cobalt::network::NetworkModule> network_module_;
+#endif
+
scoped_refptr<update_client::TestConfigurator> config_ =
base::MakeRefCounted<TestConfigurator>();
std::unique_ptr<TestingPrefServiceSimple> pref_ =
@@ -244,6 +248,9 @@
static std::unique_ptr<UpdateChecker> Create(
scoped_refptr<Configurator> config,
PersistedData* metadata) {
+#if defined(STARBOARD)
+ metadata_ = metadata;
+#endif
return std::make_unique<MockUpdateChecker>();
}
@@ -276,6 +283,12 @@
FROM_HERE, base::BindOnce(std::move(update_check_callback), results,
ErrorCategory::kNone, 0, 0));
}
+#if defined(STARBOARD)
+ PersistedData* GetPersistedData() override { return metadata_; }
+
+ private:
+ PersistedData* metadata_ = nullptr;
+#endif
};
class MockCrxDownloader : public CrxDownloader {
diff --git a/src/components/update_client/update_query_params_unittest.cc b/src/components/update_client/update_query_params_unittest.cc
index 0e5701a..6baab47 100644
--- a/src/components/update_client/update_query_params_unittest.cc
+++ b/src/components/update_client/update_query_params_unittest.cc
@@ -6,7 +6,9 @@
#include "base/strings/stringprintf.h"
#include "base/sys_info.h"
#include "components/update_client/update_query_params_delegate.h"
+#if !defined(STARBOARD)
#include "components/version_info/version_info.h"
+#endif
#include "testing/gtest/include/gtest/gtest.h"
using base::StringPrintf;
@@ -36,10 +38,15 @@
Contains(params, StringPrintf("os=%s", UpdateQueryParams::GetOS())));
EXPECT_TRUE(
Contains(params, StringPrintf("arch=%s", UpdateQueryParams::GetArch())));
+#if !defined(STARBOARD)
EXPECT_TRUE(Contains(
params,
StringPrintf("os_arch=%s",
base::SysInfo().OperatingSystemArchitecture().c_str())));
+#else
+ EXPECT_TRUE(Contains(params, StringPrintf("os_arch=")));
+#endif
+
EXPECT_TRUE(Contains(
params,
StringPrintf("prod=%s", UpdateQueryParams::GetProdIdString(prod_id))));
@@ -48,8 +55,10 @@
}
void TestProdVersion() {
+#if !defined(STARBOARD)
EXPECT_EQ(version_info::GetVersionNumber(),
UpdateQueryParams::GetProdVersion());
+#endif
}
TEST(UpdateQueryParamsTest, GetParams) {
diff --git a/src/components/update_client/url_fetcher_downloader.cc b/src/components/update_client/url_fetcher_downloader.cc
index 61530d7..5ad6863 100644
--- a/src/components/update_client/url_fetcher_downloader.cc
+++ b/src/components/update_client/url_fetcher_downloader.cc
@@ -17,9 +17,17 @@
#include "base/sequenced_task_runner.h"
#include "base/task/post_task.h"
#include "base/task/task_traits.h"
+#include "base/threading/sequenced_task_runner_handle.h"
+#include "base/values.h"
#include "components/update_client/network.h"
#include "components/update_client/utils.h"
+
+#if defined(OS_STARBOARD)
+#include "cobalt/updater/utils.h"
#include "starboard/configuration_constants.h"
+#include "starboard/loader_app/drain_file.h"
+#endif
+
#include "url/gurl.h"
namespace {
@@ -45,6 +53,7 @@
directories.pop();
}
}
+
#endif
const base::TaskTraits kTaskTraits = {
@@ -59,79 +68,229 @@
std::unique_ptr<CrxDownloader> successor,
scoped_refptr<NetworkFetcherFactory> network_fetcher_factory)
: CrxDownloader(std::move(successor)),
- network_fetcher_factory_(network_fetcher_factory) {}
+ network_fetcher_factory_(network_fetcher_factory) {
+#if defined(OS_STARBOARD)
+ installation_api_ = static_cast<const CobaltExtensionInstallationManagerApi*>(
+ SbSystemGetExtension(kCobaltExtensionInstallationManagerName));
+#endif
+}
UrlFetcherDownloader::~UrlFetcherDownloader() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
}
+#if defined(OS_STARBOARD)
+void UrlFetcherDownloader::ConfirmSlot(const GURL& url) {
+ SB_LOG(INFO) << "UrlFetcherDownloader::ConfirmSlot " << url;
+ if (!DrainFileRankAndCheck(download_dir_.value().c_str(), app_key_.c_str())) {
+ SB_LOG(INFO) << "UrlFetcherDownloader::ConfirmSlot: failed to lock slot ";
+ ReportDownloadFailure(url, CrxDownloader::Error::CRX_DOWNLOADER_ABORT);
+ return;
+ }
+
+ // TODO: Double check the installed_version.
+
+ // Use the installation slot
+ if (installation_api_->ResetInstallation(installation_index_) ==
+ IM_EXT_ERROR) {
+ SB_LOG(INFO) << "UrlFetcherDownloader::ConfirmSlot: failed to reset slot ";
+ ReportDownloadFailure(url);
+ return;
+ }
+ // Remove all files and directories except for our ranking drain file.
+ DrainFilePrepareDirectory(download_dir_.value().c_str(), app_key_.c_str());
+
+ base::SequencedTaskRunnerHandle::Get()->PostTask(
+ FROM_HERE, base::BindOnce(&UrlFetcherDownloader::StartURLFetch,
+ base::Unretained(this), url));
+}
+
+void UrlFetcherDownloader::SelectSlot(const GURL& url) {
+ SB_LOG(INFO) << "UrlFetcherDownloader::SelectSlot url=" << url;
+ int max_slots = installation_api_->GetMaxNumberInstallations();
+ if (max_slots == IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "Failed to get max number of slots";
+ ReportDownloadFailure(url);
+ return;
+ }
+
+ // default invalid version
+ base::Version slot_candidate_version;
+ int slot_candidate = -1;
+ base::FilePath slot_candidate_path;
+
+ // Iterate over all writeable slots - index >= 1.
+ for (int i = 1; i < max_slots; i++) {
+ SB_LOG(INFO) << "UrlFetcherDownloader::SelectSlot iterating slot=" << i;
+ std::vector<char> installation_path(kSbFileMaxPath);
+ if (installation_api_->GetInstallationPath(i, installation_path.data(),
+ installation_path.size()) ==
+ IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "UrlFetcherDownloader::SelectSlot: Failed to get "
+ "installation path for slot="
+ << i;
+ continue;
+ }
+
+ SB_DLOG(INFO) << "UrlFetcherDownloader::SelectSlot: installation_path = "
+ << installation_path.data();
+
+ base::FilePath installation_dir(
+ std::string(installation_path.begin(), installation_path.end()));
+
+ // Cleanup expired drain files.
+ DrainFileClear(installation_dir.value().c_str(), app_key_.c_str(), true);
+
+ // Cleanup all drain files from the current app.
+ DrainFileRemove(installation_dir.value().c_str(), app_key_.c_str());
+ base::Version version =
+ cobalt::updater::ReadEvergreenVersion(installation_dir);
+ if (!version.IsValid()) {
+ SB_LOG(INFO)
+ << "UrlFetcherDownloader::SelectSlot installed version invalid";
+ if (!DrainFileDraining(installation_dir.value().c_str(), "")) {
+ SB_LOG(INFO) << "UrlFetcherDownloader::SelectSlot not draining";
+ // found empty slot
+ slot_candidate = i;
+ slot_candidate_path = installation_dir;
+ break;
+ } else {
+ // There is active draining from another updater so bail out.
+ SB_LOG(ERROR) << "UrlFetcherDownloader::SelectSlot bailing out";
+ ReportDownloadFailure(url, CrxDownloader::Error::CRX_DOWNLOADER_ABORT);
+ return;
+ }
+ } else if ((!slot_candidate_version.IsValid() ||
+ slot_candidate_version > version)) {
+ if (!DrainFileDraining(installation_dir.value().c_str(), "")) {
+ // found a slot with older version that's not draining.
+ SB_LOG(INFO) << "UrlFetcherDownloader::SelectSlot slot candidate: "
+ << i;
+ slot_candidate_version = version;
+ slot_candidate = i;
+ slot_candidate_path = installation_dir;
+ } else {
+ SB_LOG(ERROR) << "UrlFetcherDownloader::SelectSlot bailing out";
+ // There is active draining from another updater so bail out.
+ ReportDownloadFailure(url, CrxDownloader::Error::CRX_DOWNLOADER_ABORT);
+ return;
+ }
+ }
+ }
+
+ installation_index_ = slot_candidate;
+ download_dir_ = slot_candidate_path;
+
+ if (installation_index_ == -1 ||
+ !DrainFileTryDrain(download_dir_.value().c_str(), app_key_.c_str())) {
+ SB_LOG(ERROR)
+ << "UrlFetcherDownloader::SelectSlot unable to find a slot, candidate="
+ << installation_index_;
+ ReportDownloadFailure(url);
+ return;
+ } else {
+ // Use 15 sec delay to allow for other updaters/loaders to settle down.
+ base::SequencedTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE,
+ base::BindOnce(&UrlFetcherDownloader::ConfirmSlot,
+ base::Unretained(this), url),
+ base::TimeDelta::FromSeconds(15));
+ }
+}
+#endif
+
void UrlFetcherDownloader::DoStartDownload(const GURL& url) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+
+#if defined(OS_STARBOARD)
+ SB_LOG(INFO) << "UrlFetcherDownloader::DoStartDownload url=" << url;
+ // Make sure the index is reset
+ installation_index_ = IM_EXT_INVALID_INDEX;
+ if (!installation_api_) {
+ SB_LOG(ERROR) << "Failed to get installation manager";
+ ReportDownloadFailure(url);
+ return;
+ }
+
+ char app_key[IM_EXT_MAX_APP_KEY_LENGTH];
+ if (installation_api_->GetAppKey(app_key, IM_EXT_MAX_APP_KEY_LENGTH) ==
+ IM_EXT_ERROR) {
+ SB_LOG(ERROR) << "Failed to get app key.";
+ ReportDownloadFailure(url);
+ return;
+ }
+ app_key_ = app_key;
+ base::SequencedTaskRunnerHandle::Get()->PostTask(
+ FROM_HERE, base::BindOnce(&UrlFetcherDownloader::SelectSlot,
+ base::Unretained(this), url));
+
+#else
base::PostTaskWithTraitsAndReply(
FROM_HERE, kTaskTraits,
base::BindOnce(&UrlFetcherDownloader::CreateDownloadDir,
base::Unretained(this)),
base::BindOnce(&UrlFetcherDownloader::StartURLFetch,
base::Unretained(this), url));
+#endif
}
void UrlFetcherDownloader::CreateDownloadDir() {
-#if !defined(OS_STARBOARD)
base::CreateNewTempDirectory(FILE_PATH_LITERAL("chrome_url_fetcher_"),
&download_dir_);
+}
+
+#if defined(OS_STARBOARD)
+void UrlFetcherDownloader::ReportDownloadFailure(const GURL& url) {
+ ReportDownloadFailure(url, CrxDownloader::Error::CRX_DOWNLOADER_RETRY);
+}
+
+void UrlFetcherDownloader::ReportDownloadFailure(const GURL& url,
+ CrxDownloader::Error error) {
#else
- const CobaltExtensionInstallationManagerApi* installation_api =
- static_cast<const CobaltExtensionInstallationManagerApi*>(
- SbSystemGetExtension(kCobaltExtensionInstallationManagerName));
- if (!installation_api) {
- SB_LOG(ERROR) << "Failed to get installation manager";
- return;
- }
- // Get new installation index.
- installation_index_ = installation_api->SelectNewInstallationIndex();
- SB_DLOG(INFO) << "installation_index = " << installation_index_;
- if (installation_index_ == IM_EXT_ERROR) {
- SB_LOG(ERROR) << "Failed to get installation index";
- return;
- }
-
- // Get the path to new installation.
- std::vector<char> installation_path(kSbFileMaxPath);
- if (installation_api->GetInstallationPath(
- installation_index_, installation_path.data(),
- installation_path.size()) == IM_EXT_ERROR) {
- SB_LOG(ERROR) << "Failed to get installation path";
- return;
- }
-
- SB_DLOG(INFO) << "installation_path = " << installation_path.data();
- download_dir_ = base::FilePath(
- std::string(installation_path.begin(), installation_path.end()));
-
- // Cleanup the download dir.
- CleanupDirectory(download_dir_);
+void UrlFetcherDownloader::ReportDownloadFailure(const GURL& url) {
#endif
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+#if defined(OS_STARBOARD)
+ if (!download_dir_.empty() && !app_key_.empty()) {
+ // Cleanup all drain files of the current app.
+ DrainFileRemove(download_dir_.value().c_str(), app_key_.c_str());
+ }
+#endif
+ Result result;
+#if defined(OS_STARBOARD)
+ result.error = error;
+#else
+ result.error = -1;
+#endif
+
+ DownloadMetrics download_metrics;
+ download_metrics.url = url;
+ download_metrics.downloader = DownloadMetrics::kUrlFetcher;
+ download_metrics.error = -1;
+ download_metrics.downloaded_bytes = -1;
+ download_metrics.total_bytes = -1;
+ download_metrics.download_time_ms = 0;
+
+ main_task_runner()->PostTask(
+ FROM_HERE,
+ base::BindOnce(&UrlFetcherDownloader::OnDownloadComplete,
+ base::Unretained(this), false, result, download_metrics));
}
void UrlFetcherDownloader::StartURLFetch(const GURL& url) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+#if defined(OS_STARBOARD)
+ SB_LOG(INFO) << "UrlFetcherDownloader::StartURLFetch: url" << url
+ << " download_dir=" << download_dir_;
+#endif
+
if (download_dir_.empty()) {
- Result result;
- result.error = -1;
-
- DownloadMetrics download_metrics;
- download_metrics.url = url;
- download_metrics.downloader = DownloadMetrics::kUrlFetcher;
- download_metrics.error = -1;
- download_metrics.downloaded_bytes = -1;
- download_metrics.total_bytes = -1;
- download_metrics.download_time_ms = 0;
-
- main_task_runner()->PostTask(
- FROM_HERE, base::BindOnce(&UrlFetcherDownloader::OnDownloadComplete,
- base::Unretained(this), false, result,
- download_metrics));
+#if defined(OS_STARBOARD)
+ SB_LOG(ERROR) << "UrlFetcherDownloader::StartURLFetch: failed with empty "
+ "download_dir";
+#endif
+ ReportDownloadFailure(url);
return;
}
diff --git a/src/components/update_client/url_fetcher_downloader.h b/src/components/update_client/url_fetcher_downloader.h
index 10b5503..6955711 100644
--- a/src/components/update_client/url_fetcher_downloader.h
+++ b/src/components/update_client/url_fetcher_downloader.h
@@ -39,6 +39,11 @@
void CreateDownloadDir();
void StartURLFetch(const GURL& url);
+
+#if defined(OS_STARBOARD)
+ void SelectSlot(const GURL& url);
+ void ConfirmSlot(const GURL& url);
+#endif
void OnNetworkFetcherComplete(base::FilePath file_path,
int net_error,
int64_t content_size);
@@ -46,6 +51,10 @@
int response_code,
int64_t content_length);
void OnDownloadProgress(int64_t content_length);
+ void ReportDownloadFailure(const GURL& url);
+#if defined(OS_STARBOARD)
+ void ReportDownloadFailure(const GURL& url, CrxDownloader::Error error);
+#endif
THREAD_CHECKER(thread_checker_);
@@ -63,6 +72,8 @@
#if defined(OS_STARBOARD)
int installation_index_ = IM_EXT_INVALID_INDEX;
+ const CobaltExtensionInstallationManagerApi* installation_api_;
+ std::string app_key_;
#endif
DISALLOW_COPY_AND_ASSIGN(UrlFetcherDownloader);
diff --git a/src/glimp/gles/context.cc b/src/glimp/gles/context.cc
index 616072c..aa11665 100644
--- a/src/glimp/gles/context.cc
+++ b/src/glimp/gles/context.cc
@@ -62,6 +62,7 @@
unpack_alignment_(4),
unpack_row_length_(0),
error_(GL_NO_ERROR) {
+ SbAtomicNoBarrier_Store(&has_swapped_buffers_, 0);
if (share_context != NULL) {
resource_manager_ = share_context->resource_manager_;
} else {
@@ -2317,6 +2318,9 @@
if (surface->impl()->IsWindowSurface()) {
Flush();
impl_->SwapBuffers(surface);
+ if (!has_swapped_buffers()) {
+ SbAtomicNoBarrier_Increment(&has_swapped_buffers_, 1);
+ }
}
}
@@ -2419,12 +2423,7 @@
void Context::MarkUsedProgramDirty() {
GLIMP_TRACE_EVENT0(__FUNCTION__);
- draw_state_dirty_flags_.used_program_dirty = true;
- // Switching programs marks all uniforms, samplers and vertex attributes
- // as being dirty as well, since they are all properties of the program.
- draw_state_dirty_flags_.vertex_attributes_dirty = true;
- draw_state_dirty_flags_.textures_dirty = true;
- draw_state_dirty_flags_.uniforms_dirty.MarkAll();
+ draw_state_dirty_flags_.MarkUsedProgram();
}
void Context::SetBoundDrawFramebufferToDefault() {
@@ -2468,5 +2467,7 @@
}
}
+SbAtomic32 Context::has_swapped_buffers_ = 0;
+
} // namespace gles
} // namespace glimp
diff --git a/src/glimp/gles/context.h b/src/glimp/gles/context.h
index 8af4425..b04cc53 100644
--- a/src/glimp/gles/context.h
+++ b/src/glimp/gles/context.h
@@ -33,6 +33,7 @@
#include "glimp/gles/vertex_attribute.h"
#include "nb/ref_counted.h"
#include "nb/scoped_ptr.h"
+#include "starboard/atomic.h"
#include "starboard/thread.h"
namespace glimp {
@@ -42,6 +43,8 @@
public:
Context(nb::scoped_ptr<ContextImpl> context_impl, Context* share_context);
+ ~Context() { SbAtomicNoBarrier_Store(&has_swapped_buffers_, 0); }
+
// Returns current thread's current context, or NULL if nothing is current.
static Context* GetTLSCurrentContext();
@@ -244,6 +247,10 @@
return &draw_state_dirty_flags_;
}
+ static bool has_swapped_buffers() {
+ return SbAtomicNoBarrier_Load(&has_swapped_buffers_) != 0;
+ }
+
private:
void MakeCurrent(egl::Surface* draw, egl::Surface* read);
void ReleaseContext();
@@ -378,6 +385,10 @@
// The last GL ES error raised.
GLenum error_;
+
+ // Track if SwapBuffers() has been called. Stores 0 if SwapBuffers() has not
+ // been called, and 1 if SwapBuffers() has been called.
+ static SbAtomic32 has_swapped_buffers_;
};
} // namespace gles
diff --git a/src/glimp/gles/draw_state.h b/src/glimp/gles/draw_state.h
index db9c2d9..99ddcb3 100644
--- a/src/glimp/gles/draw_state.h
+++ b/src/glimp/gles/draw_state.h
@@ -202,6 +202,15 @@
uniforms_dirty.MarkAll();
}
+ void MarkUsedProgram() {
+ used_program_dirty = true;
+ // Switching programs marks all uniforms, samplers and vertex attributes
+ // as being dirty as well, since they are all properties of the program.
+ vertex_attributes_dirty = true;
+ textures_dirty = true;
+ uniforms_dirty.MarkAll();
+ }
+
bool clear_color_dirty;
bool color_mask_dirty;
bool draw_surface_dirty;
diff --git a/src/net/http/http_network_session.cc b/src/net/http/http_network_session.cc
index 9b1b444..ff78b73 100644
--- a/src/net/http/http_network_session.cc
+++ b/src/net/http/http_network_session.cc
@@ -546,6 +546,10 @@
params_.enable_quic = !params_.enable_quic;
}
+void HttpNetworkSession::SetEnableQuic(bool enable_quic) {
+ params_.enable_quic = enable_quic;
+}
+
bool HttpNetworkSession::UseQuicForUnknownOrigin() const {
return params_.use_quic_for_unknown_origins;
}
diff --git a/src/net/http/http_network_session.h b/src/net/http/http_network_session.h
index 4c031da..234bb6c 100644
--- a/src/net/http/http_network_session.h
+++ b/src/net/http/http_network_session.h
@@ -406,6 +406,8 @@
// Toggle QUIC support for new streams.
void ToggleQuic();
+ void SetEnableQuic(bool enable_quic);
+
// Whether to try QUIC connection for origins without alt-svc on record.
bool UseQuicForUnknownOrigin() const;
#endif // defined(STARBOARD)
diff --git a/src/net/socket/udp_socket_starboard.cc b/src/net/socket/udp_socket_starboard.cc
index bc319af..3abdcef 100644
--- a/src/net/socket/udp_socket_starboard.cc
+++ b/src/net/socket/udp_socket_starboard.cc
@@ -827,10 +827,10 @@
}
void UDPSocketStarboard::StopWatchingSocket() {
- if (!read_buf_ && !write_buf_ && !write_async_watcher_->watching())
+ if (!write_async_watcher_->watching())
return;
- InternalStopWatchingSocket();
write_async_watcher_->set_watching(false);
+ InternalStopWatchingSocket();
}
bool UDPSocketStarboard::InternalWatchSocket() {
@@ -840,8 +840,10 @@
}
void UDPSocketStarboard::InternalStopWatchingSocket() {
- bool ok = socket_watcher_.StopWatchingSocket();
- DCHECK(ok);
+ if (!read_buf_ && !write_buf_ && !write_async_watcher_->watching()) {
+ bool ok = socket_watcher_.StopWatchingSocket();
+ DCHECK(ok);
+ }
}
void UDPSocketStarboard::SetMaxPacketSize(size_t max_packet_size) {
diff --git a/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltActivity.java b/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltActivity.java
index 93552ed..9a609c0 100644
--- a/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltActivity.java
+++ b/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltActivity.java
@@ -231,6 +231,16 @@
getStarboardBridge().onRequestPermissionsResult(requestCode, permissions, grantResults);
}
+ public void resetVideoSurface() {
+ runOnUiThread(
+ new Runnable() {
+ @Override
+ public void run() {
+ createNewSurfaceView();
+ }
+ });
+ }
+
public void setVideoSurfaceBounds(final int x, final int y, final int width, final int height) {
runOnUiThread(
new Runnable() {
diff --git a/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltTextToSpeechHelper.java b/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltTextToSpeechHelper.java
index f7809b0..5f15d69 100644
--- a/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltTextToSpeechHelper.java
+++ b/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/CobaltTextToSpeechHelper.java
@@ -38,7 +38,6 @@
AccessibilityManager.AccessibilityStateChangeListener,
AccessibilityManager.TouchExplorationStateChangeListener {
private final Context context;
- private final Runnable stopRequester;
private final HandlerThread thread;
private final Handler handler;
@@ -58,9 +57,8 @@
private long nextUtteranceId;
private final List<String> pendingUtterances = new ArrayList<>();
- CobaltTextToSpeechHelper(Context context, Runnable stopRequester) {
+ CobaltTextToSpeechHelper(Context context) {
this.context = context;
- this.stopRequester = stopRequester;
thread = new HandlerThread("CobaltTextToSpeechHelper");
thread.start();
@@ -200,7 +198,10 @@
*/
private void finishIfScreenReaderChanged() {
if (wasScreenReaderEnabled != isScreenReaderEnabled()) {
- stopRequester.run();
+ wasScreenReaderEnabled = isScreenReaderEnabled();
+ nativeSendTTSChangedEvent();
}
}
+
+ private native void nativeSendTTSChangedEvent();
}
diff --git a/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java b/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java
index 754f495..fe988bb 100644
--- a/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java
+++ b/src/starboard/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java
@@ -29,6 +29,7 @@
import android.net.NetworkCapabilities;
import android.os.Build;
import android.util.Size;
+import android.util.SizeF;
import android.view.Display;
import android.view.accessibility.AccessibilityManager;
import android.view.accessibility.CaptioningManager;
@@ -104,7 +105,7 @@
this.args = args;
this.startDeepLink = startDeepLink;
this.sysConfigChangeReceiver = new CobaltSystemConfigChangeReceiver(appContext, stopRequester);
- this.ttsHelper = new CobaltTextToSpeechHelper(appContext, stopRequester);
+ this.ttsHelper = new CobaltTextToSpeechHelper(appContext);
this.userAuthorizer = userAuthorizer;
this.audioOutputManager = new AudioOutputManager(appContext);
this.cobaltMediaSession =
@@ -298,6 +299,12 @@
@SuppressWarnings("unused")
@UsedByNative
+ SizeF getDisplayDpi() {
+ return DisplayUtil.getDisplayDpi(appContext);
+ }
+
+ @SuppressWarnings("unused")
+ @UsedByNative
Size getDisplaySize() {
return DisplayUtil.getSystemDisplaySize(appContext);
}
@@ -485,6 +492,15 @@
@SuppressWarnings("unused")
@UsedByNative
+ public void resetVideoSurface() {
+ Activity activity = activityHolder.get();
+ if (activity instanceof CobaltActivity) {
+ ((CobaltActivity) activity).resetVideoSurface();
+ }
+ }
+
+ @SuppressWarnings("unused")
+ @UsedByNative
public void setVideoSurfaceBounds(final int x, final int y, final int width, final int height) {
Activity activity = activityHolder.get();
if (activity instanceof CobaltActivity) {
@@ -510,8 +526,7 @@
return false;
}
- int[] supportedHdrTypes =
- defaultDisplay.getHdrCapabilities().getSupportedHdrTypes();
+ int[] supportedHdrTypes = defaultDisplay.getHdrCapabilities().getSupportedHdrTypes();
for (int supportedType : supportedHdrTypes) {
if (supportedType == hdrType) {
return true;
diff --git a/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecUtil.java b/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecUtil.java
index de35fb4..40fcde0 100644
--- a/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecUtil.java
+++ b/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecUtil.java
@@ -547,6 +547,21 @@
"Rejecting %s, reason: want secure decoder and !FEATURE_SecurePlayback", name));
continue;
}
+ if (codecCapabilities.isFeatureRequired(
+ MediaCodecInfo.CodecCapabilities.FEATURE_TunneledPlayback)) {
+ Log.v(
+ TAG,
+ String.format("Rejecting %s, reason: codec requires FEATURE_TunneledPlayback", name));
+ continue;
+ }
+ if (!secure
+ && codecCapabilities.isFeatureRequired(
+ MediaCodecInfo.CodecCapabilities.FEATURE_SecurePlayback)) {
+ Log.v(
+ TAG,
+ String.format("Rejecting %s, reason: code requires FEATURE_SecurePlayback", name));
+ continue;
+ }
// VideoCapabilties is not implemented correctly on this device.
if (Build.VERSION.SDK_INT < 23
diff --git a/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/VideoSurfaceView.java b/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/VideoSurfaceView.java
index 1367aa7..a4ef40e 100644
--- a/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/VideoSurfaceView.java
+++ b/src/starboard/android/apk/app/src/main/java/dev/cobalt/media/VideoSurfaceView.java
@@ -18,11 +18,14 @@
import android.content.Context;
import android.graphics.Color;
+import android.os.Build;
import android.util.AttributeSet;
import android.view.Surface;
import android.view.SurfaceHolder;
import android.view.SurfaceView;
import dev.cobalt.util.Log;
+import java.util.HashSet;
+import java.util.Set;
/**
* A Surface view to be used by the video decoder. It informs the Starboard application when the
@@ -32,6 +35,17 @@
private static Surface currentSurface = null;
+ private static final Set<String> needResetSurfaceList = new HashSet<>();
+
+ static {
+ needResetSurfaceList.add("Nexus Player");
+
+ // Reset video surface on nexus player to avoid b/159073388.
+ if (needResetSurfaceList.contains(Build.MODEL)) {
+ nativeSetNeedResetSurface();
+ }
+ }
+
public VideoSurfaceView(Context context) {
super(context);
initialize(context);
@@ -61,7 +75,9 @@
// punch-out video when the position / size is animated.
}
- private native void nativeOnVideoSurfaceChanged(Surface surface);
+ private static native void nativeOnVideoSurfaceChanged(Surface surface);
+
+ private static native void nativeSetNeedResetSurface();
private class SurfaceHolderCallback implements SurfaceHolder.Callback {
diff --git a/src/starboard/android/apk/app/src/main/java/dev/cobalt/util/DisplayUtil.java b/src/starboard/android/apk/app/src/main/java/dev/cobalt/util/DisplayUtil.java
index 6836656..c7c2208 100644
--- a/src/starboard/android/apk/app/src/main/java/dev/cobalt/util/DisplayUtil.java
+++ b/src/starboard/android/apk/app/src/main/java/dev/cobalt/util/DisplayUtil.java
@@ -18,6 +18,7 @@
import android.content.res.Resources;
import android.util.DisplayMetrics;
import android.util.Size;
+import android.util.SizeF;
import android.view.Display;
import android.view.WindowManager;
import androidx.annotation.Nullable;
@@ -57,6 +58,15 @@
}
/**
+ * Returns the physical pixels per inch of the screen in the X and Y
+ * dimensions.
+ */
+ public static SizeF getDisplayDpi(Context context) {
+ DisplayMetrics metrics = getDisplayMetrics(context);
+ return new SizeF(metrics.xdpi, metrics.ydpi);
+ }
+
+ /**
* Returns the size of the physical display size in pixels.
*
* <p>This differs from {@link #getSystemDisplaySize(Context)} because it only uses
diff --git a/src/starboard/android/shared/application_android.h b/src/starboard/android/shared/application_android.h
index 26ad0c1..3ad4820 100644
--- a/src/starboard/android/shared/application_android.h
+++ b/src/starboard/android/shared/application_android.h
@@ -69,6 +69,10 @@
bool DestroyWindow(SbWindow window);
bool OnSearchRequested();
void HandleDeepLink(const char* link_url);
+ void SendTTSChangedEvent() {
+ Inject(new Event(kSbEventTypeAccessiblityTextToSpeechSettingsChanged,
+ nullptr, nullptr));
+ }
void SendAndroidCommand(AndroidCommand::CommandType type, void* data);
void SendAndroidCommand(AndroidCommand::CommandType type) {
diff --git a/src/starboard/android/shared/configuration.cc b/src/starboard/android/shared/configuration.cc
index c52e26f..6f05a18 100644
--- a/src/starboard/android/shared/configuration.cc
+++ b/src/starboard/android/shared/configuration.cc
@@ -37,8 +37,8 @@
return 0;
}
-bool CobaltEnableJit() {
- return true;
+bool CobaltEnableQuic() {
+ return 0;
}
const CobaltExtensionConfigurationApi kConfigurationApi = {
@@ -48,7 +48,7 @@
&common::CobaltRenderDirtyRegionOnlyDefault,
&CobaltEglSwapInterval,
&common::CobaltFallbackSplashScreenUrlDefault,
- &common::CobaltEnableQuicDefault,
+ &CobaltEnableQuic,
&common::CobaltSkiaCacheSizeInBytesDefault,
&common::CobaltOffscreenTargetCacheSizeInBytesDefault,
&common::CobaltEncodedImageCacheSizeInBytesDefault,
@@ -65,7 +65,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&common::CobaltGcZealDefault,
&common::CobaltRasterizerTypeDefault,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/android/shared/media_codec_bridge.cc b/src/starboard/android/shared/media_codec_bridge.cc
index b47f43e..b39a61d 100644
--- a/src/starboard/android/shared/media_codec_bridge.cc
+++ b/src/starboard/android/shared/media_codec_bridge.cc
@@ -14,7 +14,7 @@
#include "starboard/android/shared/media_codec_bridge.h"
-#include "starboard/common/format_string.h"
+#include "starboard/common/string.h"
namespace starboard {
namespace android {
diff --git a/src/starboard/android/shared/media_decoder.cc b/src/starboard/android/shared/media_decoder.cc
index 9d3859d..d5668d0 100644
--- a/src/starboard/android/shared/media_decoder.cc
+++ b/src/starboard/android/shared/media_decoder.cc
@@ -18,7 +18,6 @@
#include "starboard/android/shared/jni_utils.h"
#include "starboard/android/shared/media_common.h"
#include "starboard/audio_sink.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/shared/pthread/thread_create_priority.h"
diff --git a/src/starboard/android/shared/speech_synthesis_internal.cc b/src/starboard/android/shared/speech_synthesis_internal.cc
new file mode 100644
index 0000000..8b22256
--- /dev/null
+++ b/src/starboard/android/shared/speech_synthesis_internal.cc
@@ -0,0 +1,34 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <android/native_activity.h>
+
+#include "starboard/android/shared/application_android.h"
+#include "starboard/android/shared/jni_env_ext.h"
+#include "starboard/android/shared/jni_utils.h"
+
+namespace starboard {
+namespace android {
+namespace shared {
+
+extern "C" SB_EXPORT_PLATFORM
+void Java_dev_cobalt_coat_CobaltTextToSpeechHelper_nativeSendTTSChangedEvent(
+ JniEnvExt* env,
+ jobject unused_this) {
+ ApplicationAndroid::Get()->SendTTSChangedEvent();
+}
+
+} // namespace shared
+} // namespace android
+} // namespace starboard
diff --git a/src/starboard/android/shared/starboard_platform.gypi b/src/starboard/android/shared/starboard_platform.gypi
index 80e51f8..8ec8f70 100644
--- a/src/starboard/android/shared/starboard_platform.gypi
+++ b/src/starboard/android/shared/starboard_platform.gypi
@@ -142,6 +142,7 @@
'sanitizer_options.cc',
'speech_recognizer_impl.cc',
'speech_synthesis_cancel.cc',
+ 'speech_synthesis_internal.cc',
'speech_synthesis_is_supported.cc',
'speech_synthesis_speak.cc',
'system_get_connection_type.cc',
@@ -168,6 +169,7 @@
'video_window.h',
'window_create.cc',
'window_destroy.cc',
+ 'window_get_diagonal_size_in_inches.cc',
'window_get_platform_handle.cc',
'window_get_size.cc',
'window_internal.h',
@@ -458,7 +460,6 @@
'<(DEPTH)/starboard/shared/stub/thread_sampler_is_supported.cc',
'<(DEPTH)/starboard/shared/stub/thread_sampler_thaw.cc',
'<(DEPTH)/starboard/shared/stub/ui_nav_get_interface.cc',
- '<(DEPTH)/starboard/shared/stub/window_get_diagonal_size_in_inches.cc',
],
'defines': [
# This must be defined when building Starboard, and must not when
diff --git a/src/starboard/android/shared/video_render_algorithm.cc b/src/starboard/android/shared/video_render_algorithm.cc
index 639ae01..1b7e9aa 100644
--- a/src/starboard/android/shared/video_render_algorithm.cc
+++ b/src/starboard/android/shared/video_render_algorithm.cc
@@ -55,8 +55,9 @@
bool is_audio_playing;
bool is_audio_eos_played;
bool is_underflow;
+ double playback_rate;
SbTime playback_time = media_time_provider->GetCurrentMediaTime(
- &is_audio_playing, &is_audio_eos_played, &is_underflow);
+ &is_audio_playing, &is_audio_eos_played, &is_underflow, &playback_rate);
if (!is_audio_playing) {
break;
}
diff --git a/src/starboard/android/shared/video_window.cc b/src/starboard/android/shared/video_window.cc
index 2216d08..8329a85 100644
--- a/src/starboard/android/shared/video_window.cc
+++ b/src/starboard/android/shared/video_window.cc
@@ -41,6 +41,9 @@
ANativeWindow* g_native_video_window = NULL;
// Global video surface pointer holder.
VideoSurfaceHolder* g_video_surface_holder = NULL;
+// Global boolean to indicate if we need to reset SurfaceView after playing
+// vertical video.
+bool g_reset_surface_on_clear_window = false;
} // namespace
@@ -68,6 +71,13 @@
}
}
+extern "C" SB_EXPORT_PLATFORM void
+Java_dev_cobalt_media_VideoSurfaceView_nativeSetNeedResetSurface(
+ JNIEnv* env,
+ jobject unused_this) {
+ g_reset_surface_on_clear_window = true;
+}
+
// static
bool VideoSurfaceHolder::IsVideoSurfaceAvailable() {
// We only consider video surface is available when there is a video
@@ -113,6 +123,16 @@
// during painting.
ScopedLock lock(*GetViewSurfaceMutex());
+ if (g_reset_surface_on_clear_window) {
+ int width = ANativeWindow_getWidth(g_native_video_window);
+ int height = ANativeWindow_getHeight(g_native_video_window);
+ if (width <= height) {
+ JniEnvExt::Get()->CallStarboardVoidMethodOrAbort("resetVideoSurface",
+ "()V");
+ return;
+ }
+ }
+
if (!g_native_video_window) {
SB_LOG(INFO) << "Tried to clear video window when it was null.";
return;
diff --git a/src/starboard/android/shared/window_get_diagonal_size_in_inches.cc b/src/starboard/android/shared/window_get_diagonal_size_in_inches.cc
new file mode 100644
index 0000000..3e8c2aa
--- /dev/null
+++ b/src/starboard/android/shared/window_get_diagonal_size_in_inches.cc
@@ -0,0 +1,47 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/android/shared/jni_env_ext.h"
+#include "starboard/android/shared/jni_utils.h"
+#include "starboard/android/shared/window_internal.h"
+
+using starboard::android::shared::JniEnvExt;
+using starboard::android::shared::ScopedLocalJavaRef;
+
+float SbWindowGetDiagonalSizeInInches(SbWindow window) {
+ if (!SbWindowIsValid(window)) {
+ SB_DLOG(ERROR) << __FUNCTION__ << ": Invalid window.";
+ return 0.0f;
+ }
+
+ int32_t width_pixels = ANativeWindow_getWidth(window->native_window);
+ int32_t height_pixels = ANativeWindow_getHeight(window->native_window);
+ JniEnvExt* env = JniEnvExt::Get();
+ ScopedLocalJavaRef<jobject> display_dpi(env->CallStarboardObjectMethodOrAbort(
+ "getDisplayDpi", "()Landroid/util/SizeF;"));
+ float xdpi =
+ env->CallFloatMethodOrAbort(display_dpi.Get(), "getWidth", "()F");
+ float ydpi =
+ env->CallFloatMethodOrAbort(display_dpi.Get(), "getHeight", "()F");
+
+ if (xdpi < 0.1f || ydpi < 0.1f) {
+ SB_DLOG(ERROR) << __FUNCTION__ << ": Invalid display values.";
+ return 0.0f;
+ }
+
+ float width_inches = width_pixels / xdpi;
+ float height_inches = height_pixels / ydpi;
+ float diagonal_inches = sqrt(pow(width_inches, 2) + pow(height_inches, 2));
+ return diagonal_inches;
+}
diff --git a/src/starboard/build/platform_configuration.py b/src/starboard/build/platform_configuration.py
index b41e4e6..44f7155 100644
--- a/src/starboard/build/platform_configuration.py
+++ b/src/starboard/build/platform_configuration.py
@@ -365,12 +365,15 @@
A list of strings of test target names.
"""
tests = [
+ 'app_key_files_test',
+ 'app_key_test',
+ 'drain_file_test',
'elf_loader_test',
'installation_manager_test',
'nplb',
'nplb_blitter_pixel_tests',
- 'nplb_evergreen_compat_tests',
'player_filter_tests',
+ 'slot_management_test',
'starboard_platform_tests',
]
tests.extend(get_optional_tests.GetOptionalTestTargets())
diff --git a/src/starboard/common/common.gyp b/src/starboard/common/common.gyp
index e381f4e..154dfa0 100644
--- a/src/starboard/common/common.gyp
+++ b/src/starboard/common/common.gyp
@@ -30,8 +30,9 @@
'condition_variable.h',
'configuration_defaults.cc',
'configuration_defaults.h',
+ 'file.cc',
+ 'file.h',
'flat_map.h',
- 'format_string.h',
'locked_ptr.h',
'log.cc',
'log.h',
diff --git a/src/starboard/common/configuration_defaults.cc b/src/starboard/common/configuration_defaults.cc
index 3cc0e1d..6dbeb7b 100644
--- a/src/starboard/common/configuration_defaults.cc
+++ b/src/starboard/common/configuration_defaults.cc
@@ -102,7 +102,7 @@
}
bool CobaltEnableJitDefault() {
- return false;
+ return true;
}
} // namespace common
diff --git a/src/starboard/common/file.cc b/src/starboard/common/file.cc
new file mode 100644
index 0000000..b44ede8
--- /dev/null
+++ b/src/starboard/common/file.cc
@@ -0,0 +1,96 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/common/file.h"
+
+#include <string>
+#include <vector>
+
+#include "starboard/common/log.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/directory.h"
+#include "starboard/file.h"
+#include "starboard/string.h"
+
+namespace starboard {
+namespace {
+
+bool DirectoryCloseLogFailure(const char* path, SbDirectory dir) {
+ if (!SbDirectoryClose(dir)) {
+ SB_LOG(ERROR) << "Failed to close directory: '" << path << "'";
+ return false;
+ }
+ return true;
+}
+
+} // namespace
+
+bool SbFileDeleteRecursive(const char* path, bool preserve_root) {
+ if (!SbFileExists(path)) {
+ SB_LOG(ERROR) << "Path does not exist: '" << path << "'";
+ return false;
+ }
+
+ SbFileError err = kSbFileOk;
+ SbDirectory dir = kSbDirectoryInvalid;
+
+ dir = SbDirectoryOpen(path, &err);
+
+ // The |path| points to a file. Remove it and return.
+ if (err != kSbFileOk) {
+ return SbFileDelete(path);
+ }
+
+ SbFileInfo info;
+
+#if SB_API_VERSION >= 12
+ std::vector<char> entry(kSbFileMaxName);
+
+ while (SbDirectoryGetNext(dir, entry.data(), kSbFileMaxName)) {
+ if (!SbStringCompareAll(entry.data(), ".") ||
+ !SbStringCompareAll(entry.data(), "..")) {
+ continue;
+ }
+
+ std::string abspath(path);
+ abspath.append(kSbFileSepString);
+ abspath.append(entry.data());
+#else
+ SbDirectoryEntry entry;
+
+ while (SbDirectoryGetNext(dir, &entry)) {
+ if (!SbStringCompareAll(entry.name, ".") ||
+ !SbStringCompareAll(entry.name, "..")) {
+ continue;
+ }
+
+ std::string abspath(path);
+ abspath.append(kSbFileSepString);
+ abspath.append(entry.name);
+#endif
+
+ if (!SbFileDeleteRecursive(abspath.data(), false)) {
+ DirectoryCloseLogFailure(path, dir);
+ return false;
+ }
+ }
+
+ // Don't forget to close and remove the directory before returning!
+ if (DirectoryCloseLogFailure(path, dir)) {
+ return preserve_root ? true : SbFileDelete(path);
+ }
+ return false;
+}
+
+} // namespace starboard
diff --git a/src/starboard/common/file.h b/src/starboard/common/file.h
new file mode 100644
index 0000000..a91c2fa
--- /dev/null
+++ b/src/starboard/common/file.h
@@ -0,0 +1,41 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Module Overview: Starboard File module
+//
+// Implements a set of convenience functions and macros built on top of the core
+// Starboard file API.
+
+#ifndef STARBOARD_COMMON_FILE_H_
+#define STARBOARD_COMMON_FILE_H_
+
+#include "starboard/file.h"
+
+namespace starboard {
+
+// Deletes the file, symlink or directory at |path|. When |path| is a directory,
+// the function will recursively delete the entire tree; however, when
+// |preserve_root| is |true| the root directory is not removed. On some
+// platforms, this function fails if a file to be deleted is being held open.
+//
+// Returns |true| if the file, symlink, or directory was able to be deleted, and
+// |false| if there was an error at any point.
+//
+// |path|: The absolute path of the file, symlink, or directory to be deleted.
+// |preserve_root|: Whether or not the root directory should be preserved.
+bool SbFileDeleteRecursive(const char* path, bool preserve_root);
+
+} // namespace starboard
+
+#endif // STARBOARD_COMMON_FILE_H_
diff --git a/src/starboard/common/format_string.h b/src/starboard/common/format_string.h
deleted file mode 100644
index bf99ea3..0000000
--- a/src/starboard/common/format_string.h
+++ /dev/null
@@ -1,57 +0,0 @@
-// Copyright 2019 The Cobalt Authors. All Rights Reserved.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// Module Overview: Starboard String module
-//
-// Move the definition of FormatString from string.h to this header to break
-// the dependency between string.h and standard header <string>.
-
-#ifndef STARBOARD_COMMON_FORMAT_STRING_H_
-#define STARBOARD_COMMON_FORMAT_STRING_H_
-
-#include "starboard/common/string.h"
-
-#if SB_API_VERSION >= 11
-
-#include <string>
-#include <vector>
-
-namespace starboard {
-
-SB_C_INLINE std::string FormatString(const char* format, ...)
- SB_PRINTF_FORMAT(1, 2);
-
-SB_C_INLINE std::string FormatString(const char* format, ...) {
- va_list arguments;
- va_start(arguments, format);
- int expected_size = ::SbStringFormat(NULL, 0, format, arguments);
- va_end(arguments);
-
- std::string result;
- if (expected_size <= 0) {
- return result;
- }
-
- std::vector<char> buffer(expected_size + 1);
- va_start(arguments, format);
- ::SbStringFormat(buffer.data(), buffer.size(), format, arguments);
- va_end(arguments);
- return std::string(buffer.data(), expected_size);
-}
-
-} // namespace starboard
-
-#endif // SB_API_VERSION >= 11
-
-#endif // STARBOARD_COMMON_FORMAT_STRING_H_
diff --git a/src/starboard/common/string.h b/src/starboard/common/string.h
index 2815cc4..9108517 100644
--- a/src/starboard/common/string.h
+++ b/src/starboard/common/string.h
@@ -21,14 +21,12 @@
#include <stdarg.h>
-#include "starboard/configuration.h"
-#include "starboard/string.h"
-
-#if SB_API_VERSION < 11
-
#include <string>
#include <vector>
+#include "starboard/configuration.h"
+#include "starboard/string.h"
+
namespace starboard {
SB_C_INLINE std::string FormatString(const char* format, ...)
@@ -54,6 +52,4 @@
} // namespace starboard
-#endif // SB_API_VERSION < 11
-
#endif // STARBOARD_COMMON_STRING_H_
diff --git a/src/starboard/doc/evergreen/cobalt_evergreen_overview.md b/src/starboard/doc/evergreen/cobalt_evergreen_overview.md
index ccf031e..50537e0 100644
--- a/src/starboard/doc/evergreen/cobalt_evergreen_overview.md
+++ b/src/starboard/doc/evergreen/cobalt_evergreen_overview.md
@@ -52,7 +52,7 @@
* Longer device lifetime due to more Cobalt updates
* Less engineering work/accelerated timeline for Cobalt integration/deployment
as Google builds the Cobalt components and partners are only responsible for
- the Starboard and `loader_app` portion
+ the Starboard, `loader_app`, and `crashpad_handler` portion
### New in Evergreen
@@ -60,7 +60,8 @@
store multiple Cobalt binaries
* Access permissions to download binaries onto a device platform from Google
servers
-* New `loader_app` component required to be built on platform toolchains
+* New `loader_app` and `crashpad_handler` components required to be built on
+ platform toolchains
* Additional testing/verification required to ensure new Cobalt releases work
properly
@@ -101,17 +102,36 @@
The partner port of Starboard is built with the partner’s toolchain and is
linked into the **`loader_app` which knows how to dynamically load
-`libcobalt.so`.
+`libcobalt.so`, and the `crashpad_handler` which handles crashes.
```
cobalt/build/gyp_cobalt <partner_port_name>
-ninja -C out/<partner_port_name>_qa loader_app
+ninja -C out/<partner_port_name>_qa loader_app crashpad_handler
```
Partners should set `sb_evergreen_compatible` to 1 in their gyp platform config.
DO NOT set the `sb_evergreen` to 1 in your platform-specific configuration as it
is used only by Cobalt when building with the Google toolchain.
+Partners should additionally ensure they install Crashpad's crash handlers by
+calling the `third_party::crashpad::wrapper::InstallCrashpadHandler()` hook
+directly after installing system crash handler. On linux, for example, this
+could look like:
+```
+#include "third_party/crashpad/wrapper/wrapper.h"
+
+int main(int argc, char** argv) {
+ ...
+ starboard::shared::signal::InstallCrashSignalHandlers();
+ starboard::shared::signal::InstallSuspendSignalHandlers();
+
+ third_party::crashpad::wrapper::InstallCrashpadHandler();
+
+ int result = application.Run(argc, argv);
+ ...
+}
+```
+
The following additional Starboard interfaces are necessary to implement for
Evergreen:
@@ -300,77 +320,121 @@
### Installation Slots
-Cobalt Evergreen provides support for maintaining multiple separate versions of
+Cobalt Evergreen provides support for maintaining multiple, separate versions of
the Cobalt binary on a platform. These versions are stored in installation
slots(i.e. known locations on disk), and are used to significantly improve the
resilience and reliability of Cobalt updates.
-The number of installation slots available will be determined by the platform
-owner. A minimum of 2 must be available with the limit being the storage
-available on the platform.
+All slot configurations assume the following:
+* 1 System Image Installation Slot (read-only)
+* 2+ Additional Installation Slot(s) (writable)
-It is worth noting that adding a third installation slot allows a factory image
-to be permanently installed as a fail-safe option.
+The number of installation slots available will be determined by the platform
+owner. **3 slots is the default configuration for Evergreen**. There can be `N`
+installation slots configured with the only limitation being available storage.
+
+#### Slot Configuration
+NOTE: 3-slots is the DEFAULT configuration.
The number of installation slots is directly controlled using
`kMaxNumInstallations`, defined in
[loader\_app.cc](https://cobalt.googlesource.com/cobalt/+/refs/heads/master/src/starboard/loader_app/loader_app.cc).
-There are subtle differences between using 2 installation slots and using 3 or
-more installation slots outlined below.
+It is worth noting that all slot configurations specify that the first
+installation slot (`SLOT_0`) will always be the read-only factory system image.
+This is permanently installed on the platform and is used as a fail-safe option.
+This is stored in the directory specified by `kSbSystemPathContentDirectory`
+under the `app/cobalt` subdirectory.
-#### 2 Slot Configuration
+All of the other installation slots are located within the storage directory
+specified by `kSbSystemPathStorageDirectory`. This will vary depending on the
+platform.
-Both of the installation slots are located in the directory specified by
-`kSbSystemPathStorageDirectory`. This will vary depending on the platform.
-
-On the Raspberry Pi this value will be `/home/pi/.cobalt_storage`. The paths to
-the installation slots will be as follows:
-
-`/home/pi/.cobalt_storage/installation_0` (initial installation slot)
+For example, on the Raspberry Pi the `kSbSystemPathStorageDirectory` directory
+is `/home/pi/.cobalt_storage`, and the paths to all existing installation slots
+will be as follows:
```
-/home/pi/.cobalt_storage/installation_1
+/home/pi/<kSbSystemPathContentDirectory>/app/cobalt (system image installation SLOT_0) (read-only)
+/home/pi/.cobalt_storage/installation_1 (SLOT_1)
+/home/pi/.cobalt_storage/installation_2 (SLOT_2)
+...
+/home/pi/.cobalt_storage/installation_N (SLOT_N)
```
-Where the most recent update is stored will alternate between the two available
-slots. No factory image is maintained with this configuration so only the two
-most recent updates will be stored on the machine.
+Where the most recent update is stored will alternate between the available
+writable slots. In the above example, this would be `SLOT_1`...`SLOT_N`.
-Finally, the installation slot that will be used when Cobalt Evergreen is run
-would be stored in
+#### Understanding Slot Structure
+Slots are used to manage Cobalt Evergreen binaries with associated app metadata
+to select the appropriate Cobalt Evergreen binaries.
-`/home/pi/.cobalt_storage/installation_store.pb` on the Raspberry Pi.
+See the below structures for an example 3-slot configuration.
-#### 3+ Slot Configuration
-
-The 3+ slot configuration is very similar to the 2 slot configuration, but has
-one major difference: the original installation is maintained, and is stored in
-a read-only installation slot within the content directory.
-
-On the Raspberry Pi, the installation slots will be as follows:
-
-`/home/pi/path-to-cobalt/content/app/cobalt` (initial installation slot)
-(read-only)
+Structure for `kSbSystemPathContentDirectory` used for the read-only System
+Image required for all slot configurations:
```
-/home/pi/.cobalt_storage/installation_1
-/home/pi/.cobalt_storage/installation_2
+.
+├── content <--(kSbSystemPathContentDirectory)
+│ └── app
+│ └── cobalt <--(SLOT_0)
+│ ├── content <--(relative path defined in kSystemImageContentPath)
+│ │ ├── fonts
+│ │ ├── icu
+│ │ ├── licenses
+│ │ ├── ssl
+│ ├── lib
+│ │ └── libcobalt.so <--(System image version of libcobalt.so)
+│ └── manifest.json
+└── loader_app <--(Cobalt launcher binary)
+└── crashpad_handler <--(Cobalt crash handler)
```
-Similar to the 2 slot configuration, where the most recent update is stored will
-alternate between the two available slots (not the read-only installation slot).
+Structure for `kSbSystemPathStorageDirectory` used for future Cobalt Evergreen
+updates in an example 3-slot configuration:
-The installation slot that will be used when Cobalt Evergreen is run is
-determined, and stored, exactly the same as it is for the 2 slot configuration.
+```
+├── .cobalt_storage <--(kSbSystemPathStorageDirectory)
+ ├── cobalt_updater
+ │ └── prefs_<APP_KEY>.json
+ ├── installation_1 <--(SLOT_1 - currently unused)
+ ├── installation_2 <--(SLOT_2 - contains new Cobalt version)
+ │ ├── content
+ │ │ ├── fonts
+ │ │ ├── icu
+ │ │ ├── licenses
+ │ │ ├── ssl
+ │ ├── lib
+ │ │ └── libcobalt.so <--(SLOT_2 version of libcobalt.so)
+ │ ├── manifest.fingerprint
+ │ └── manifest.json <-- (Evergreen version information of libcobalt.so under SLOT_2)
+ ├── installation_store_<APP_KEY>.pb
+ └── icu (To be explained below)
+```
+
+#### App metadata
+Each Cobalt Evergreen application has a set of unique metadata to track slot
+selection. The following set of files are unique per application via a
+differentiating <APP_KEY> identifier, which is a Base64 hash appended to the
+filename.
+
+```
+<SLOT_#>/installation_store_<APP_KEY>.pb
+<SLOT_#>/cobalt_updater/prefs_<APP_KEY>.json
+```
+
+You should NOT change any of these files and they are highlighted here just for
+reference.
+
### Fonts
-The system font directory `kSbSystemPathStorageDirectory` should be configured to
+The system font directory `kSbSystemPathFontDirectory` should be configured to
point to the `standard` (23MB) or the `limited` (3.1MB) cobalt font packages. An
easy way to do that is to use the `loader_app/content` directory and setting the
`cobalt_font_package` to `standard` or `limited` in your port.
-Cobalt Evergreen, built by Google, will by default use the `minimal` cobalt
+Cobalt Evergreen (built by Google), will by default use the `minimal` font
package which is around 16KB to minimize storage requirements. A separate
`cobalt_font_package` variable is set to `minimal` in the Evergreen platform.
@@ -378,7 +442,7 @@
`minimal` set of fonts under:
```
-~/.cobalt_storage/installation_0/content/fonts/
+<kSbSystemPathContentDirectory>/fonts/
```
`standard` or `limited` set of fonts under:
@@ -387,9 +451,9 @@
```
### ICU Tables
-The ICU table should be deployed under the kSbSystemPathStorageDirectory.
-This way all Cobalt Evergreen installations would be able to share the same
-tables. The current storage size for the ICU tables is 7MB.
+The ICU table should be deployed under the `kSbSystemPathStorageDirectory`. This
+way all Cobalt Evergreen installations would be able to share the same tables.
+The current storage size for the ICU tables is 7MB.
On Raspberry Pi this is:
@@ -398,7 +462,103 @@
```
The Cobalt Evergreen package will not carry ICU tables by default but may add
them in the future if needed. When the package has ICU tables they would be
-stored under the content location for the installation.
+stored under the content location for the installation:
+
+```
+<SLOT_#>/content/icu
+```
+
+### Multi-App Support
+Evergreen can support multiple apps that share a Cobalt binary. This is a very
+common way to save space and keep all your Cobalt apps using the latest version
+of Cobalt. We understand that there are situations where updates are only needed
+for certain apps, so we have provided a way where Cobalt Updater behavior can be
+easily configured on a per-app basis with simple loader_app command-line flags.
+
+Currently, the only configurable option for Cobalt Updater configuration is:
+* --disable_updates *Turns off updates for the specified application. Note that
+ apps disabling updates will use the Cobalt version available in the System
+ Image.*
+
+Each app’s Cobalt Updater will perform an independent, regular check for new
+Cobalt Evergreen updates. Note that all apps will share the same set of slots,
+but each app will maintain metadata about which slots are “good” (working) or
+“bad” (error detected) and use the appropriate slot. Sharing slots allows
+Evergreen to download Cobalt updates a single time and be able to use it across
+all Evergreen-enabled apps.
+
+To illustrate, a simple example:
+
+* Cobalt v5 - latest Cobalt Evergreen version
+
+#### BEFORE COBALT UPDATE
+```
+[APP_1] (currently using SLOT_1, using Cobalt v4)
+[APP_2] (currently using SLOT_0, using Cobalt v3)
+[APP_3] (currently using SLOT_0, using Cobalt v3)
+```
+
+Now remember, apps could share the same Cobalt binary. Let’s say `APP_1` has
+detected an update available and downloads the latest update (Cobalt v5) into
+SLOT_2. The next time `APP_2` runs, it may detect Cobalt v5 as well. It would
+then simply do a `request_roll_forward` operation to switch to SLOT_2 and does
+not have to download a new update since the latest is already available in an
+existing slot. In this case, `APP_1` and `APP_2` are now using the same Cobalt
+binaries in SLOT_2.
+
+If `APP_3` has not been launched, not run through a regular Cobalt Updater
+check, or launched with the `--disable_updates` flag, it stays with its current
+configuration.
+
+#### AFTER COBALT UPDATE
+```
+[APP_1] (currently using SLOT_2, using Cobalt v5)
+[APP_2] (currently using SLOT_2, using Cobalt v5)
+[APP_3] (currently using SLOT_0, using Cobalt v3)
+```
+
+Now that we have gone through an example scenario, we can cover some examples of
+how to configure Cobalt Updater behavior and `loader_app` configuration.
+
+
+Some example configurations include:
+```
+
+# All Cobalt-based apps get Evergreen Updates
+[APP_1] (Cobalt Updater ENABLED)
+[APP_2] (Cobalt Updater ENABLED)
+[APP_3] (Cobalt Updater ENABLED)
+
+loader_app --url="<YOUR_APP_1_URL>"
+loader_app --url="<YOUR_APP_2_URL>"
+loader_app --url="<YOUR_APP_3_URL>"
+
+
+# Only APP_1 gets Evergreen Updates, APP_2 wants to use an alternate splash screen
+[APP_1] (Cobalt Updater ENABLED)
+[APP_2] (Cobalt Updater DISABLED)
+[APP_3] (Cobalt Updater DISABLED)
+
+loader_app --url="<YOUR_APP_1_URL>"
+loader_app --url="<YOUR_APP_2_URL>" --disable_updates \
+--fallback_splash_screen_url="/<PATH_TO_APP_2>/app_2_splash_screen.html"
+loader_app --url="<YOUR_APP_3_URL>" --disable_updates
+
+
+# APP_3 is a local app, wants Cobalt Updater disabled, and uses an alternate content directory
+# (This configuration is common for System UI apps. APP_3 in this example.)
+[APP_1] (Cobalt Updater ENABLED)
+[APP_2] (Cobalt Updater ENABLED)
+[APP_3] (Cobalt Updater DISABLED)
+
+loader_app --url="<YOUR_APP_1_URL>"
+loader_app --url="<YOUR_APP_2_URL>"
+loader_app --csp_mode=disable --allow_http --url="file:///<PATH_TO_APP_3>/index.html" --content="/<PATH_TO_APP_3>/content"
+```
+
+Please see
+[`loader_app_switches.cc`](https://cobalt.googlesource.com/cobalt/+/refs/heads/master/src/starboard/loader_app/loader_app.cc)
+for full list of available command-line flags.
### Platform Security
diff --git a/src/starboard/doc/evergreen/cobalt_evergreen_reference_port_raspi2.md b/src/starboard/doc/evergreen/cobalt_evergreen_reference_port_raspi2.md
index 23494e2..b72d0f7 100644
--- a/src/starboard/doc/evergreen/cobalt_evergreen_reference_port_raspi2.md
+++ b/src/starboard/doc/evergreen/cobalt_evergreen_reference_port_raspi2.md
@@ -15,7 +15,7 @@
## Build the loader app (new entry point)
$ cd cobalt/src
$ cobalt/build/gyp_cobalt -v raspi-2-sbversion-12 -C qa
-$ ninja -C out/raspi-2-sbversion-12_qa loader_app
+$ ninja -C out/raspi-2-sbversion-12_qa loader_app crashpad_handler
## Create package directory for Cobalt Evergreen
$ export COEG_PATH=coeg
diff --git a/src/starboard/doc/evergreen/cobalt_update_framework.md b/src/starboard/doc/evergreen/cobalt_update_framework.md
index 6ae81c0..cf916b7 100644
--- a/src/starboard/doc/evergreen/cobalt_update_framework.md
+++ b/src/starboard/doc/evergreen/cobalt_update_framework.md
@@ -36,7 +36,7 @@
serving billions of users worldwide. We set up Cobalt updates on Google Update
in a way that each type of device gets a unique update link (URL). The device
type is identified by [Starboard
-ABI](https://drive.google.com/a/google.com/open?id=1r1vS_FFMV9F-YlNaudxFwhAVG7delVleKfYgLLRUn3o)
+ABI](../starboard_abi.md)
(SABI) string. For instance, Raspberry Pi 2 and Linux desktop are two different
types of devices. They are identified by two different SABI strings, and get two
different update URLs on Google Update. The request sent by the Cobalt updater
diff --git a/src/starboard/elf_loader/elf.h b/src/starboard/elf_loader/elf.h
index 64d4365..75b47d5 100644
--- a/src/starboard/elf_loader/elf.h
+++ b/src/starboard/elf_loader/elf.h
@@ -170,6 +170,30 @@
Elf64_Half e_shstrndx;
} Elf64_Ehdr;
+// 32 bit Note header.
+typedef struct {
+ // Length of the note's name
+ Elf32_Word n_namesz;
+
+ // Length of the note's descriptor.
+ Elf32_Word n_descsz;
+
+ // Type of the note.
+ Elf32_Word n_type;
+} Elf32_Nhdr;
+
+// 64 bit Note header.
+typedef struct {
+ // Length of the note's name
+ Elf64_Word n_namesz;
+
+ // Length of the note's descriptor.
+ Elf64_Word n_descsz;
+
+ // Type of the note.
+ Elf64_Word n_type;
+} Elf64_Nhdr;
+
// 32 bit Program header.
typedef struct {
// The kind of segment this array element describes.
@@ -381,6 +405,7 @@
#if SB_SIZE_OF(POINTER) == 4
typedef Elf32_Ehdr Ehdr;
+typedef Elf32_Nhdr Nhdr;
typedef Elf32_Phdr Phdr;
typedef Elf32_Addr Addr;
typedef Elf32_Dyn Dyn;
@@ -396,6 +421,7 @@
#define ELF_CLASS_VALUE ELFCLASS32
#elif SB_SIZE_OF(POINTER) == 8
typedef Elf64_Ehdr Ehdr;
+typedef Elf64_Nhdr Nhdr;
typedef Elf64_Phdr Phdr;
typedef Elf64_Addr Addr;
typedef Elf64_Dyn Dyn;
@@ -633,6 +659,10 @@
#error "Unsupported architecture for relocations."
#endif
+// Note types
+#define NT_GNU_BUILD_ID 3
+#define NOTE_PADDING(a) ((a + 3) & ~3)
+
// Helper macros for memory page computations.
#ifndef PAGE_SIZE
#define PAGE_SHIFT 12
diff --git a/src/starboard/elf_loader/elf_loader.gyp b/src/starboard/elf_loader/elf_loader.gyp
index e780c3a..7b6a565 100644
--- a/src/starboard/elf_loader/elf_loader.gyp
+++ b/src/starboard/elf_loader/elf_loader.gyp
@@ -56,7 +56,18 @@
'dependencies': [
'<(DEPTH)/starboard/elf_loader/evergreen_config.gyp:evergreen_config',
'<(DEPTH)/starboard/elf_loader/evergreen_info.gyp:evergreen_info',
- '<(DEPTH)/starboard/starboard.gyp:starboard',
+ '<(DEPTH)/starboard/starboard.gyp:starboard_base',
+ ],
+ 'conditions': [
+ ['sb_evergreen_compatible == 1', {
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/wrapper/wrapper.gyp:crashpad_wrapper',
+ ],
+ }, {
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/wrapper/wrapper.gyp:crashpad_wrapper_stub',
+ ],
+ }],
],
'sources': [
'<@(common_elf_loader_sources)',
@@ -80,6 +91,17 @@
'<@(common_elf_loader_sources)',
'<@(elf_loader_sys_sources)',
],
+ 'conditions': [
+ ['sb_evergreen_compatible == 1', {
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/wrapper/wrapper.gyp:crashpad_wrapper',
+ ],
+ }, {
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/wrapper/wrapper.gyp:crashpad_wrapper_stub',
+ ],
+ }],
+ ],
},
{
'target_name': 'elf_loader_sandbox',
diff --git a/src/starboard/elf_loader/evergreen_config.gyp b/src/starboard/elf_loader/evergreen_config.gyp
index 05846f4..19f3950 100644
--- a/src/starboard/elf_loader/evergreen_config.gyp
+++ b/src/starboard/elf_loader/evergreen_config.gyp
@@ -12,8 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# This files contains all targets that should be created by gyp_cobalt by
-# default.
{
'targets': [
{
diff --git a/src/starboard/elf_loader/evergreen_info.gyp b/src/starboard/elf_loader/evergreen_info.gyp
index d6c66e3..03a14ac 100644
--- a/src/starboard/elf_loader/evergreen_info.gyp
+++ b/src/starboard/elf_loader/evergreen_info.gyp
@@ -12,8 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# This files contains all targets that should be created by gyp_cobalt by
-# default.
{
'targets': [
{
diff --git a/src/starboard/elf_loader/evergreen_info.h b/src/starboard/elf_loader/evergreen_info.h
index cca62e0..fecd079 100644
--- a/src/starboard/elf_loader/evergreen_info.h
+++ b/src/starboard/elf_loader/evergreen_info.h
@@ -20,10 +20,12 @@
#include <stddef.h>
#include <stdint.h>
+#include <vector>
// This is duplicate constant for use from signal-safe code in
// the starboard implementation.
#define EVERGREEN_FILE_PATH_MAX_SIZE 4096
+#define EVERGREEN_BUILD_ID_MAX_SIZE 128
#define IS_EVERGREEN_ADDRESS(address, evergreen_info) \
(evergreen_info.base_address != 0 && \
@@ -52,6 +54,12 @@
// Number of items in the Program Header Table.
size_t phdr_table_num;
+
+ // Contents of the build id.
+ char build_id[EVERGREEN_BUILD_ID_MAX_SIZE];
+
+ // Length of the build id.
+ size_t build_id_length;
} EvergreenInfo;
// Set the Evergreen information. Should be called only from the
diff --git a/src/starboard/elf_loader/program_table.cc b/src/starboard/elf_loader/program_table.cc
index c207a92..bab921d 100644
--- a/src/starboard/elf_loader/program_table.cc
+++ b/src/starboard/elf_loader/program_table.cc
@@ -111,10 +111,45 @@
return true;
}
+static bool ElfClassBuildIDNoteIdentifier(const void* section,
+ size_t length,
+ std::vector<uint8_t>& identifier) {
+ const void* section_end = reinterpret_cast<const char*>(section) + length;
+ const Nhdr* note_header = reinterpret_cast<const Nhdr*>(section);
+ while (reinterpret_cast<const void*>(note_header) < section_end) {
+ if (note_header->n_type == NT_GNU_BUILD_ID)
+ break;
+ note_header = reinterpret_cast<const Nhdr*>(
+ reinterpret_cast<const char*>(note_header) + sizeof(Nhdr) +
+ NOTE_PADDING(note_header->n_namesz) +
+ NOTE_PADDING(note_header->n_descsz));
+ }
+ if (reinterpret_cast<const void*>(note_header) >= section_end ||
+ note_header->n_descsz == 0) {
+ return false;
+ }
+
+ const uint8_t* build_id = reinterpret_cast<const uint8_t*>(note_header) +
+ sizeof(Nhdr) + NOTE_PADDING(note_header->n_namesz);
+ identifier.insert(identifier.end(), build_id,
+ build_id + note_header->n_descsz);
+
+ return true;
+}
+
bool ProgramTable::LoadSegments(File* elf_file) {
for (size_t i = 0; i < phdr_num_; ++i) {
const Phdr* phdr = &phdr_table_[i];
+ if (phdr->p_type == PT_NOTE) {
+ if (!ElfClassBuildIDNoteIdentifier(
+ reinterpret_cast<const void*>(phdr->p_vaddr +
+ base_memory_address_),
+ phdr->p_memsz, build_id_)) {
+ SB_LOG(INFO) << "Could not get build id";
+ }
+ continue;
+ }
if (phdr->p_type != PT_LOAD) {
continue;
}
@@ -351,6 +386,13 @@
evergreen_info.load_size = load_size_;
evergreen_info.phdr_table = (uint64_t)phdr_table_;
evergreen_info.phdr_table_num = phdr_num_;
+
+ std::vector<char> tmp(build_id_.begin(), build_id_.end());
+ tmp.push_back('\0');
+ SbStringCopy(evergreen_info.build_id, tmp.data(),
+ EVERGREEN_BUILD_ID_MAX_SIZE);
+ evergreen_info.build_id_length = build_id_.size();
+
SetEvergreenInfo(&evergreen_info);
}
diff --git a/src/starboard/elf_loader/program_table.h b/src/starboard/elf_loader/program_table.h
index 9512b5e..d08301c 100644
--- a/src/starboard/elf_loader/program_table.h
+++ b/src/starboard/elf_loader/program_table.h
@@ -15,6 +15,8 @@
#ifndef STARBOARD_ELF_LOADER_PROGRAM_TABLE_H_
#define STARBOARD_ELF_LOADER_PROGRAM_TABLE_H_
+#include <vector>
+
#include "starboard/elf_loader/elf.h"
#include "starboard/elf_loader/file.h"
@@ -76,6 +78,8 @@
Phdr* phdr_table_;
Addr phdr_size_;
+ std::vector<uint8_t> build_id_;
+
// First page of reserved address space.
void* load_start_;
diff --git a/src/starboard/elf_loader/sandbox.cc b/src/starboard/elf_loader/sandbox.cc
index 8b6e9da..857ab89 100644
--- a/src/starboard/elf_loader/sandbox.cc
+++ b/src/starboard/elf_loader/sandbox.cc
@@ -17,10 +17,12 @@
#include "starboard/common/log.h"
#include "starboard/elf_loader/elf_loader.h"
#include "starboard/elf_loader/elf_loader_switches.h"
+#include "starboard/elf_loader/evergreen_info.h"
#include "starboard/event.h"
#include "starboard/mutex.h"
#include "starboard/shared/starboard/command_line.h"
#include "starboard/thread_types.h"
+#include "third_party/crashpad/wrapper/wrapper.h"
starboard::elf_loader::ElfLoader g_elf_loader;
@@ -49,6 +51,15 @@
SB_LOG(INFO) << "Successfully loaded '" << g_elf_loader.GetLibraryPath()
<< "'.";
+ EvergreenInfo evergreen_info;
+ GetEvergreenInfo(&evergreen_info);
+ if (!third_party::crashpad::wrapper::AddEvergreenInfoToCrashpad(
+ evergreen_info)) {
+ SB_LOG(ERROR) << "Could not send Cobalt library information into Crashapd.";
+ } else {
+ SB_LOG(INFO) << "Loaded Cobalt library information into Crashpad.";
+ }
+
g_sb_event_func = reinterpret_cast<void (*)(const SbEvent*)>(
g_elf_loader.LookupSymbol("SbEventHandle"));
diff --git a/src/starboard/evergreen/arm/hardfp/configuration_public.h b/src/starboard/evergreen/arm/hardfp/configuration_public.h
index 69ff7e3..dca541d 100644
--- a/src/starboard/evergreen/arm/hardfp/configuration_public.h
+++ b/src/starboard/evergreen/arm/hardfp/configuration_public.h
@@ -32,7 +32,7 @@
#define SB_HAS_SYS_TYPES_H 0
// Whether the current platform provides ssize_t.
-#define SB_HAS_SSIZE_T 0
+#define SB_HAS_SSIZE_T 1
// Type detection for wchar_t.
#if defined(__WCHAR_MAX__) && \
diff --git a/src/starboard/evergreen/arm/softfp/configuration_public.h b/src/starboard/evergreen/arm/softfp/configuration_public.h
index 10d58aa..8187911 100644
--- a/src/starboard/evergreen/arm/softfp/configuration_public.h
+++ b/src/starboard/evergreen/arm/softfp/configuration_public.h
@@ -32,7 +32,7 @@
#define SB_HAS_SYS_TYPES_H 0
// Whether the current platform provides ssize_t.
-#define SB_HAS_SSIZE_T 0
+#define SB_HAS_SSIZE_T 1
// Type detection for wchar_t.
#if defined(__WCHAR_MAX__) && \
diff --git a/src/starboard/evergreen/arm64/configuration_public.h b/src/starboard/evergreen/arm64/configuration_public.h
index 8cf2526..211ccc1 100644
--- a/src/starboard/evergreen/arm64/configuration_public.h
+++ b/src/starboard/evergreen/arm64/configuration_public.h
@@ -36,7 +36,7 @@
#define SB_HAS_SYS_TYPES_H 0
// Whether the current platform provides ssize_t.
-#define SB_HAS_SSIZE_T 0
+#define SB_HAS_SSIZE_T 1
// Type detection for wchar_t.
#if defined(__WCHAR_MAX__) && \
diff --git a/src/starboard/evergreen/shared/gyp_configuration.gypi b/src/starboard/evergreen/shared/gyp_configuration.gypi
index 4753fe3..40f4071 100644
--- a/src/starboard/evergreen/shared/gyp_configuration.gypi
+++ b/src/starboard/evergreen/shared/gyp_configuration.gypi
@@ -23,7 +23,6 @@
'enable_vr': 0,
'default_renderer_options_dependency': '<(DEPTH)/cobalt/renderer/default_options_starboard.gyp:default_options',
'javascript_engine': 'v8',
- 'cobalt_v8_buildtime_snapshot': 1,
'cobalt_v8_enable_embedded_builtins': 1,
'cobalt_font_package': 'minimal',
diff --git a/src/starboard/evergreen/shared/launcher.py b/src/starboard/evergreen/shared/launcher.py
index 5f18643..41f46c7 100644
--- a/src/starboard/evergreen/shared/launcher.py
+++ b/src/starboard/evergreen/shared/launcher.py
@@ -43,8 +43,20 @@
"""
def __init__(self, platform, target_name, config, device_id, **kwargs):
+ # TODO: Remove this injection of 'detect_leaks=0' once the memory leaks when
+ # running executables in Evergreen mode have been resolved.
+ env_variables = kwargs.get('env_variables') or {}
+ asan_options = env_variables.get('ASAN_OPTIONS', '')
+ asan_options = [
+ opt for opt in asan_options.split(':') if 'detect_leaks' not in opt
+ ]
+ asan_options.append('detect_leaks=0')
+ env_variables['ASAN_OPTIONS'] = ':'.join(asan_options)
+ kwargs['env_variables'] = env_variables
+
super(Launcher, self).__init__(platform, target_name, config, device_id,
**kwargs)
+
self.loader_platform = kwargs.get('loader_platform')
if not self.loader_platform:
raise ValueError('|loader_platform| cannot be |None|.')
diff --git a/src/starboard/evergreen/x64/configuration_public.h b/src/starboard/evergreen/x64/configuration_public.h
index 79a49dc..14b5102 100644
--- a/src/starboard/evergreen/x64/configuration_public.h
+++ b/src/starboard/evergreen/x64/configuration_public.h
@@ -32,7 +32,7 @@
#define SB_HAS_SYS_TYPES_H 0
// Whether the current platform provides ssize_t.
-#define SB_HAS_SSIZE_T 0
+#define SB_HAS_SSIZE_T 1
// Type detection for wchar_t.
#if defined(__WCHAR_MAX__) && \
diff --git a/src/starboard/evergreen/x86/configuration_public.h b/src/starboard/evergreen/x86/configuration_public.h
index 861c7fa..a86fe9c 100644
--- a/src/starboard/evergreen/x86/configuration_public.h
+++ b/src/starboard/evergreen/x86/configuration_public.h
@@ -32,7 +32,7 @@
#define SB_HAS_SYS_TYPES_H 0
// Whether the current platform provides ssize_t.
-#define SB_HAS_SSIZE_T 0
+#define SB_HAS_SSIZE_T 1
// Type detection for wchar_t.
#if defined(__WCHAR_MAX__) && \
diff --git a/src/starboard/file.h b/src/starboard/file.h
index 66d93cb..5f90802 100644
--- a/src/starboard/file.h
+++ b/src/starboard/file.h
@@ -251,7 +251,7 @@
// function is used primarily to clean up after unit tests. On some platforms,
// this function fails if the file in question is being held open.
//
-// |path|: The absolute path fo the file, symlink, or directory to be deleted.
+// |path|: The absolute path of the file, symlink, or directory to be deleted.
SB_EXPORT bool SbFileDelete(const char* path);
// Indicates whether a file or directory exists at |path|.
diff --git a/src/starboard/linux/shared/configuration.cc b/src/starboard/linux/shared/configuration.cc
index 9cbc88f..4b0f775 100644
--- a/src/starboard/linux/shared/configuration.cc
+++ b/src/starboard/linux/shared/configuration.cc
@@ -30,10 +30,6 @@
return 0;
}
-bool CobaltEnableJit() {
- return true;
-}
-
const CobaltExtensionConfigurationApi kConfigurationApi = {
kCobaltExtensionConfigurationName,
1,
@@ -58,7 +54,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&common::CobaltGcZealDefault,
&common::CobaltRasterizerTypeDefault,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/linux/shared/player_components_factory.cc b/src/starboard/linux/shared/player_components_factory.cc
index 8bac0b1..2eaf301 100644
--- a/src/starboard/linux/shared/player_components_factory.cc
+++ b/src/starboard/linux/shared/player_components_factory.cc
@@ -12,10 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/ref_counted.h"
#include "starboard/common/scoped_ptr.h"
+#include "starboard/common/string.h"
#include "starboard/gles.h"
#include "starboard/media.h"
#include "starboard/shared/ffmpeg/ffmpeg_audio_decoder.h"
diff --git a/src/starboard/linux/x64x11/gczeal/configuration.cc b/src/starboard/linux/x64x11/gczeal/configuration.cc
index f39c87f..6d80740 100644
--- a/src/starboard/linux/x64x11/gczeal/configuration.cc
+++ b/src/starboard/linux/x64x11/gczeal/configuration.cc
@@ -36,10 +36,6 @@
return true;
}
-bool CobaltEnableJit() {
- return true;
-}
-
const CobaltExtensionConfigurationApi kConfigurationApi = {
kCobaltExtensionConfigurationName,
1,
@@ -64,7 +60,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&CobaltGcZeal,
&common::CobaltRasterizerTypeDefault,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/linux/x64x11/shared/starboard_platform.gypi b/src/starboard/linux/x64x11/shared/starboard_platform.gypi
index 0f3c13a..6e05ca9 100644
--- a/src/starboard/linux/x64x11/shared/starboard_platform.gypi
+++ b/src/starboard/linux/x64x11/shared/starboard_platform.gypi
@@ -49,17 +49,16 @@
],
'variables': {
- 'has_private_system_properties%': '<!(test -e <(DEPTH)/starboard/keyboxes/linux/private_system_properties.cc && echo 1 || echo 0)',
+ 'has_private_system_properties%': '<!(test -e <(DEPTH)/starboard/keyboxes/linux/system_properties.cc && echo 1 || echo 0)',
},
# This has_private_system_properties gets exported to gyp files that include this one.
'has_private_system_properties%': '<(has_private_system_properties)',
'conditions': [
['has_private_system_properties==1', {
'starboard_platform_sources': [
- '<(DEPTH)/starboard/keyboxes/linux/private_system_properties.cc',
+ '<(DEPTH)/starboard/keyboxes/linux/system_properties.cc',
],
- }],
- ['has_private_system_properties==0', {
+ }, {
'starboard_platform_sources': [
'<(DEPTH)/starboard/linux/x64x11/public_system_properties.cc',
],
diff --git a/src/starboard/linux/x64x11/skia/configuration.cc b/src/starboard/linux/x64x11/skia/configuration.cc
index 9e03006..3b2e26a 100644
--- a/src/starboard/linux/x64x11/skia/configuration.cc
+++ b/src/starboard/linux/x64x11/skia/configuration.cc
@@ -36,10 +36,6 @@
return "hardware";
}
-bool CobaltEnableJit() {
- return true;
-}
-
const CobaltExtensionConfigurationApi kConfigurationApi = {
kCobaltExtensionConfigurationName,
1,
@@ -64,7 +60,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&common::CobaltGcZealDefault,
&CobaltRasterizerType,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/loader_app/app_key.cc b/src/starboard/loader_app/app_key.cc
new file mode 100644
index 0000000..8338b45
--- /dev/null
+++ b/src/starboard/loader_app/app_key.cc
@@ -0,0 +1,45 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/app_key.h"
+
+#include "starboard/common/log.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/loader_app/app_key_internal.h"
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+// With the maximum length of an app key being 24 bytes less than the maximum
+// file name size we provide enough room for not-insignificant sized prefixes
+// and suffixes. This leaves room for prefixes and suffixes while maintaining
+// all, or most of, the app key.
+const size_t kAppKeyMax = kSbFileMaxName - 24;
+
+} // namespace
+
+std::string GetAppKey(const std::string& url) {
+ SB_DCHECK(kAppKeyMax > 0);
+
+ const std::string app_key = EncodeAppKey(ExtractAppKey(url));
+
+ if (app_key.size() > kAppKeyMax) {
+ return app_key.substr(app_key.size() - kAppKeyMax, kAppKeyMax);
+ }
+ return app_key;
+}
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/app_key.gyp b/src/starboard/loader_app/app_key.gyp
new file mode 100644
index 0000000..316b6b5
--- /dev/null
+++ b/src/starboard/loader_app/app_key.gyp
@@ -0,0 +1,56 @@
+# Copyright 2020 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{
+ 'targets': [
+ {
+ 'target_name': 'app_key',
+ 'type': 'static_library',
+ 'sources': [
+ 'app_key.cc',
+ 'app_key.h',
+ 'app_key_internal.cc',
+ 'app_key_internal.h',
+ ],
+ 'dependencies': [
+ '<(DEPTH)/starboard/starboard.gyp:starboard',
+ '<(DEPTH)/third_party/modp_b64/modp_b64.gyp:modp_b64',
+ ],
+ },
+ {
+ 'target_name': 'app_key_test',
+ 'type': '<(gtest_target_type)',
+ 'sources': [
+ 'app_key_test.cc',
+ '<(DEPTH)/starboard/common/test_main.cc',
+ ],
+ 'dependencies': [
+ ':app_key',
+ '<(DEPTH)/testing/gmock.gyp:gmock',
+ '<(DEPTH)/testing/gtest.gyp:gtest',
+ ],
+ },
+ {
+ 'target_name': 'app_key_test_deploy',
+ 'type': 'none',
+ 'dependencies': [
+ 'app_key_test',
+ ],
+ 'variables': {
+ 'executable_name': 'app_key_test',
+ },
+ 'includes': [ '<(DEPTH)/starboard/build/deploy.gypi' ],
+ },
+ ],
+}
diff --git a/src/starboard/loader_app/app_key.h b/src/starboard/loader_app/app_key.h
new file mode 100644
index 0000000..eb0cf0a
--- /dev/null
+++ b/src/starboard/loader_app/app_key.h
@@ -0,0 +1,29 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_APP_KEY_H_
+#define STARBOARD_LOADER_APP_APP_KEY_H_
+
+#include <string>
+
+namespace starboard {
+namespace loader_app {
+
+// Returns an app key generated from the provided |url|.
+std::string GetAppKey(const std::string& url);
+
+} // namespace loader_app
+} // namespace starboard
+
+#endif // STARBOARD_LOADER_APP_APP_KEY_H_
diff --git a/src/starboard/loader_app/app_key_files.cc b/src/starboard/loader_app/app_key_files.cc
new file mode 100644
index 0000000..e387987
--- /dev/null
+++ b/src/starboard/loader_app/app_key_files.cc
@@ -0,0 +1,120 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/app_key_files.h"
+
+#include <vector>
+
+#include "starboard/common/log.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/directory.h"
+#include "starboard/file.h"
+#include "starboard/string.h"
+
+namespace starboard {
+namespace loader_app {
+
+namespace {
+const char kFilePrefix[] = "app_key_";
+const char kGoodFileSuffix[] = ".good";
+const char kBadFileSuffix[] = ".bad";
+}
+
+std::string GetAppKeyFilePathWithSuffix(const std::string& dir,
+ const std::string& app_key,
+ const std::string& suffix) {
+ if (dir.empty() || app_key.empty() || suffix.empty()) {
+ SB_LOG(ERROR) << "GetAppKeyFilePathWithSuffix: invalid input";
+ return "";
+ }
+ std::string file_name = dir;
+ file_name += kSbFileSepString;
+ file_name += kFilePrefix;
+ file_name += app_key;
+ file_name += suffix;
+ return file_name;
+}
+
+std::string GetGoodAppKeyFilePath(const std::string& dir,
+ const std::string& app_key) {
+ return GetAppKeyFilePathWithSuffix(dir, app_key, kGoodFileSuffix);
+}
+
+std::string GetBadAppKeyFilePath(const std::string& dir,
+ const std::string& app_key) {
+ return GetAppKeyFilePathWithSuffix(dir, app_key, kBadFileSuffix);
+}
+
+bool CreateAppKeyFile(const std::string& file_name_path) {
+ if (file_name_path.empty()) {
+ return false;
+ }
+ SbFileError file_error = kSbFileOk;
+ starboard::ScopedFile file(file_name_path.c_str(),
+ kSbFileCreateAlways | kSbFileWrite, NULL,
+ &file_error);
+ if (!file.IsValid()) {
+ SB_LOG(ERROR) << "Failed to open file: " << file_name_path
+ << "with error: " << file_error;
+ return false;
+ }
+ return true;
+}
+
+namespace {
+bool EndsWith(const std::string& s, const std::string& suffix) {
+ if (s.size() < suffix.size()) {
+ return false;
+ }
+ return SbStringCompareAll(s.c_str() + (s.size() - suffix.size()),
+ suffix.c_str()) == 0;
+}
+} // namespace
+
+bool AnyGoodAppKeyFile(const std::string& dir) {
+ SbDirectory directory = SbDirectoryOpen(dir.c_str(), NULL);
+
+ if (!SbDirectoryIsValid(directory)) {
+ SB_LOG(ERROR) << "Failed to open dir='" << dir << "'";
+ return false;
+ }
+
+ bool found = false;
+#if SB_API_VERSION >= 12
+ std::vector<char> filename(kSbFileMaxName);
+ while (SbDirectoryGetNext(directory, filename.data(), filename.size())) {
+ if (!SbStringCompare(kFilePrefix, filename.data(),
+ sizeof(kFilePrefix) - 1) &&
+ EndsWith(filename.data(), kGoodFileSuffix)) {
+ found = true;
+ break;
+ }
+ }
+#else
+ SbDirectoryEntry entry;
+ while (SbDirectoryGetNext(directory, &entry)) {
+ if (!SbStringCompare(kFilePrefix, entry.name, sizeof(kFilePrefix) - 1) &&
+ EndsWith(entry.name, kGoodFileSuffix)) {
+ found = true;
+ break;
+ }
+ }
+#endif
+
+ SbDirectoryClose(directory);
+ return found;
+}
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/app_key_files.gyp b/src/starboard/loader_app/app_key_files.gyp
new file mode 100644
index 0000000..48297b1
--- /dev/null
+++ b/src/starboard/loader_app/app_key_files.gyp
@@ -0,0 +1,53 @@
+# Copyright 2020 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{
+ 'targets': [
+ {
+ 'target_name': 'app_key_files',
+ 'type': 'static_library',
+ 'sources': [
+ 'app_key_files.h',
+ 'app_key_files.cc',
+ ],
+ 'dependencies' : [
+ '<(DEPTH)/starboard/starboard.gyp:starboard',
+ ],
+ },
+ {
+ 'target_name': 'app_key_files_test',
+ 'type': '<(gtest_target_type)',
+ 'sources': [
+ 'app_key_files_test.cc',
+ '<(DEPTH)/starboard/common/test_main.cc',
+ ],
+ 'dependencies': [
+ ':app_key_files',
+ '<(DEPTH)/testing/gmock.gyp:gmock',
+ '<(DEPTH)/testing/gtest.gyp:gtest',
+ ],
+ },
+ {
+ 'target_name': 'app_key_files_test_deploy',
+ 'type': 'none',
+ 'dependencies': [
+ 'app_key_files_test',
+ ],
+ 'variables': {
+ 'executable_name': 'app_key_files_test',
+ },
+ 'includes': [ '<(DEPTH)/starboard/build/deploy.gypi' ],
+ },
+ ],
+}
diff --git a/src/starboard/loader_app/app_key_files.h b/src/starboard/loader_app/app_key_files.h
new file mode 100644
index 0000000..e928124
--- /dev/null
+++ b/src/starboard/loader_app/app_key_files.h
@@ -0,0 +1,45 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_APP_KEY_FILES_H_
+#define STARBOARD_LOADER_APP_APP_KEY_FILES_H_
+
+#include <string>
+
+namespace starboard {
+namespace loader_app {
+
+// Gets the file path for a good app key file in the |dir| directory.
+// The file is used to mark an installation slot as good for the app.
+// Returns empty string on failure.
+std::string GetGoodAppKeyFilePath(const std::string& dir,
+ const std::string& app_key);
+
+// Gets the file path for a bad app key file in the |dir| directory.
+// The file is used to mark an installation slot as bad for the app.
+// Returns empty string on failure.
+std::string GetBadAppKeyFilePath(const std::string& dir,
+ const std::string& app_key);
+
+// Helper function to create a file with the specified full path name.
+bool CreateAppKeyFile(const std::string& file_name_path);
+
+// Returns true if there is any good app key file.
+// Used for adopting an installation slot updated by different app.
+bool AnyGoodAppKeyFile(const std::string& dir);
+
+} // namespace loader_app
+} // namespace starboard
+
+#endif // STARBOARD_LOADER_APP_APP_KEY_FILES_H_
diff --git a/src/starboard/loader_app/app_key_files_test.cc b/src/starboard/loader_app/app_key_files_test.cc
new file mode 100644
index 0000000..06df41c
--- /dev/null
+++ b/src/starboard/loader_app/app_key_files_test.cc
@@ -0,0 +1,97 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/app_key_files.h"
+
+#include <string>
+#include <vector>
+
+#include "starboard/configuration_constants.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+const char kTestAppKey[] = "test_app_key";
+const char kTestAppKeyDir[] = "test_app_key_dir";
+
+class AppKeyFilesTest : public testing::Test {
+ protected:
+ virtual void SetUp() {
+ std::vector<char> temp_path(kSbFileMaxPath, 0);
+ ASSERT_TRUE(SbSystemGetPath(kSbSystemPathTempDirectory, temp_path.data(),
+ temp_path.size()));
+ dir_ = temp_path.data();
+ dir_ += kSbFileSepString;
+ dir_ += kTestAppKeyDir;
+ SbDirectoryCreate(dir_.c_str());
+ }
+
+ std::string dir_;
+};
+
+TEST_F(AppKeyFilesTest, TestGoodKeyFile) {
+ std::string file_path = GetGoodAppKeyFilePath(dir_, kTestAppKey);
+ ASSERT_FALSE(file_path.empty());
+ if (SbFileExists(file_path.c_str())) {
+ SbFileDelete(file_path.c_str());
+ }
+ ASSERT_FALSE(SbFileExists(file_path.c_str()));
+ ASSERT_TRUE(CreateAppKeyFile(file_path));
+ ASSERT_TRUE(SbFileExists(file_path.c_str()));
+ SbFileDelete(file_path.c_str());
+}
+
+TEST_F(AppKeyFilesTest, TestBadKeyFile) {
+ std::string file_path = GetBadAppKeyFilePath(dir_, kTestAppKey);
+ ASSERT_FALSE(file_path.empty());
+ if (SbFileExists(file_path.c_str())) {
+ SbFileDelete(file_path.c_str());
+ }
+ ASSERT_FALSE(SbFileExists(file_path.c_str()));
+ ASSERT_TRUE(CreateAppKeyFile(file_path));
+ ASSERT_TRUE(SbFileExists(file_path.c_str()));
+ SbFileDelete(file_path.c_str());
+}
+
+TEST_F(AppKeyFilesTest, TestGoodKeyFileInvalidInput) {
+ std::string file_path = GetGoodAppKeyFilePath("", kTestAppKey);
+ ASSERT_TRUE(file_path.empty());
+
+ file_path = GetGoodAppKeyFilePath(dir_, "");
+ ASSERT_TRUE(file_path.empty());
+}
+
+TEST_F(AppKeyFilesTest, TestBadKeyFileInvalidInput) {
+ std::string file_path = GetBadAppKeyFilePath("", kTestAppKey);
+ ASSERT_TRUE(file_path.empty());
+
+ file_path = GetBadAppKeyFilePath(dir_, "");
+ ASSERT_TRUE(file_path.empty());
+}
+
+TEST_F(AppKeyFilesTest, TestAnyGoodKeyFile) {
+ ASSERT_FALSE(AnyGoodAppKeyFile(dir_));
+ std::string file_path = GetGoodAppKeyFilePath(dir_, kTestAppKey);
+ ASSERT_FALSE(file_path.empty());
+ ASSERT_TRUE(CreateAppKeyFile(file_path));
+ ASSERT_TRUE(SbFileExists(file_path.c_str()));
+ ASSERT_TRUE(AnyGoodAppKeyFile(dir_));
+ SbFileDelete(file_path.c_str());
+}
+
+} // namespace
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/app_key_internal.cc b/src/starboard/loader_app/app_key_internal.cc
new file mode 100644
index 0000000..4fcd641
--- /dev/null
+++ b/src/starboard/loader_app/app_key_internal.cc
@@ -0,0 +1,122 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/app_key_internal.h"
+
+#include <algorithm>
+
+#include "starboard/common/log.h"
+#include "starboard/types.h"
+#include "third_party/modp_b64/modp_b64.h"
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+// For general information on the URL format see:
+//
+// https://en.wikipedia.org/wiki/URL
+//
+// For general information on the URL character set see:
+//
+// https://developers.google.com/maps/documentation/urls/url-encoding
+
+// Best-effort attempt to find and strip the username and password from a URL,
+// expecting that the format is conforming:
+//
+// ... ://<USERNAME>:<PASSWORD>@ ...
+void StripUserInfo(std::string* url) {
+ if (!url)
+ return;
+
+ const size_t colon_slash_slash = url->find("://");
+
+ // The user information is preceded by "://".
+ if (colon_slash_slash == std::string::npos)
+ return;
+
+ const size_t at = url->find_first_of('@');
+
+ // The user information is followed by "@".
+ if (at == std::string::npos)
+ return;
+
+ // The URL is malformed.
+ if (colon_slash_slash >= at)
+ return;
+
+ url->erase(colon_slash_slash + 3, at - (colon_slash_slash + 2));
+}
+
+// Best-effort attempt to find and strip the query from a URL, expecting that
+// the format is conforming:
+//
+// ... ?<QUERY> ...
+void StripQuery(std::string* url) {
+ const size_t question_mark = url->find_first_of('?');
+
+ // The query is preceded by "?".
+ if (question_mark == std::string::npos)
+ return;
+
+ url->erase(question_mark, url->size() - question_mark);
+}
+
+// Best-effort attempt to find and strip the fragment from a URL, expecting that
+// the format is conforming:
+//
+// ... #<FRAGMENT>
+void StripFragment(std::string* url) {
+ const size_t pound = url->find_first_of('#');
+
+ // The fragment is preceded by "#".
+ if (pound == std::string::npos)
+ return;
+
+ url->erase(pound, url->size() - pound);
+}
+
+} // namespace
+
+std::string ExtractAppKey(const std::string& url) {
+ if (url.empty())
+ return "";
+
+ std::string output = url;
+
+ StripUserInfo(&output);
+ StripQuery(&output);
+ StripFragment(&output);
+
+ return output;
+}
+
+std::string EncodeAppKey(const std::string& app_key) {
+ std::string output;
+
+ // modp_b64_encode_len includes room for the null byte.
+ output.resize(modp_b64_encode_len(app_key.size()));
+
+ // modp_b64_encode_len() returns at least 1, so output[0] is safe to use.
+ const size_t output_size = modp_b64_encode(
+ &(output[0]), reinterpret_cast<const char*>(app_key.data()),
+ app_key.size());
+
+ output.resize(output_size);
+
+ return output;
+}
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/app_key_internal.h b/src/starboard/loader_app/app_key_internal.h
new file mode 100644
index 0000000..cee1ef9
--- /dev/null
+++ b/src/starboard/loader_app/app_key_internal.h
@@ -0,0 +1,34 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_APP_KEY_INTERNAL_H_
+#define STARBOARD_LOADER_APP_APP_KEY_INTERNAL_H_
+
+#include <string>
+
+namespace starboard {
+namespace loader_app {
+
+// Returns an application key extracted from |url|. This function is not meant
+// to validate a URL, and operates assusming the URL provided is valid. This
+// should not be used for anything other than a best-effort attempt.
+std::string ExtractAppKey(const std::string& url);
+
+// Returns a base64 encoded |app_key|.
+std::string EncodeAppKey(const std::string& app_key);
+
+} // namespace loader_app
+} // namespace starboard
+
+#endif // STARBOARD_LOADER_APP_APP_KEY_INTERNAL_H_
diff --git a/src/starboard/loader_app/app_key_test.cc b/src/starboard/loader_app/app_key_test.cc
new file mode 100644
index 0000000..8207ee4
--- /dev/null
+++ b/src/starboard/loader_app/app_key_test.cc
@@ -0,0 +1,677 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/app_key_internal.h"
+
+#include <string>
+
+#include "starboard/string.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace starboard {
+namespace loader_app {
+
+typedef struct URLWithExtractedAndEncoded {
+ // The initial URL to be handled.
+ const char* url;
+
+ // The application key extracted from |url|.
+ const char* extracted;
+
+ // The base64 encoded |extracted|.
+ const char* encoded;
+} URLWithExtractedAndEncoded;
+
+// The URLs below were taken from url/url_parse_unittest.cc.
+const URLWithExtractedAndEncoded kURLWithExtractedAndEncoded[] = {
+ {
+ "http://user:pass@foo:21/bar;par?b#c",
+ "http://foo:21/bar;par",
+ "aHR0cDovL2ZvbzoyMS9iYXI7cGFy",
+ },
+ {
+ "http:foo.com",
+ "http:foo.com",
+ "aHR0cDpmb28uY29t",
+ },
+ {
+ "\t :foo.com \n",
+ "\t :foo.com \n",
+ "CSAgIDpmb28uY29tICAgCg==",
+ },
+ {
+ " foo.com ",
+ " foo.com ",
+ "IGZvby5jb20gIA==",
+ },
+ {
+ "a:\t foo.com",
+ "a:\t foo.com",
+ "YToJIGZvby5jb20=",
+ },
+ {
+ "http://f:21/ b ? d # e ",
+ "http://f:21/ b ",
+ "aHR0cDovL2Y6MjEvIGIg",
+ },
+ {
+ "http://f:/c",
+ "http://f:/c",
+ "aHR0cDovL2Y6L2M=",
+ },
+ {
+ "http://f:0/c",
+ "http://f:0/c",
+ "aHR0cDovL2Y6MC9j",
+ },
+ {
+ "http://f:00000000000000/c",
+ "http://f:00000000000000/c",
+ "aHR0cDovL2Y6MDAwMDAwMDAwMDAwMDAvYw==",
+ },
+ {
+ "http://f:00000000000000000000080/c",
+ "http://f:00000000000000000000080/c",
+ "aHR0cDovL2Y6MDAwMDAwMDAwMDAwMDAwMDAwMDAwODAvYw==",
+ },
+ {
+ "http://f:b/c",
+ "http://f:b/c",
+ "aHR0cDovL2Y6Yi9j",
+ },
+ {
+ "http://f: /c",
+ "http://f: /c",
+ "aHR0cDovL2Y6IC9j",
+ },
+ {
+ "http://f:\n/c",
+ "http://f:\n/c",
+ "aHR0cDovL2Y6Ci9j",
+ },
+ {
+ "http://f:fifty-two/c",
+ "http://f:fifty-two/c",
+ "aHR0cDovL2Y6ZmlmdHktdHdvL2M=",
+ },
+ {
+ "http://f:999999/c",
+ "http://f:999999/c",
+ "aHR0cDovL2Y6OTk5OTk5L2M=",
+ },
+ {
+ "http://f: 21 / b ? d # e ",
+ "http://f: 21 / b ",
+ "aHR0cDovL2Y6IDIxIC8gYiA=",
+ },
+ {
+ "",
+ "",
+ "",
+ },
+ {
+ " \t",
+ " \t",
+ "ICAJ",
+ },
+ {
+ ":foo.com/",
+ ":foo.com/",
+ "OmZvby5jb20v",
+ },
+ {
+ ":foo.com\\",
+ ":foo.com\\",
+ "OmZvby5jb21c",
+ },
+ {
+ ":",
+ ":",
+ "Og==",
+ },
+ {
+ ":a",
+ ":a",
+ "OmE=",
+ },
+ {
+ ":/",
+ ":/",
+ "Oi8=",
+ },
+ {
+ ":\\",
+ ":\\",
+ "Olw=",
+ },
+ {
+ ":#",
+ ":",
+ "Og==",
+ },
+ {
+ "#",
+ "",
+ "",
+ },
+ {
+ "#/",
+ "",
+ "",
+ },
+ {
+ "#\\",
+ "",
+ "",
+ },
+ {
+ "#;?",
+ "",
+ "",
+ },
+ {
+ "?",
+ "",
+ "",
+ },
+ {
+ "/",
+ "/",
+ "Lw==",
+ },
+ {
+ ":23",
+ ":23",
+ "OjIz",
+ },
+ {
+ "/:23",
+ "/:23",
+ "LzoyMw==",
+ },
+ {
+ "//",
+ "//",
+ "Ly8=",
+ },
+ {
+ "::",
+ "::",
+ "Ojo=",
+ },
+ {
+ "::23",
+ "::23",
+ "OjoyMw==",
+ },
+ {
+ "foo://",
+ "foo://",
+ "Zm9vOi8v",
+ },
+ {
+ "http://a:b@c:29/d",
+ "http://c:29/d",
+ "aHR0cDovL2M6MjkvZA==",
+ },
+ {
+ "http::@c:29",
+ "http::@c:29",
+ "aHR0cDo6QGM6Mjk=",
+ },
+ {
+ "http://&a:foo(b]c@d:2/",
+ "http://d:2/",
+ "aHR0cDovL2Q6Mi8=",
+ },
+ {
+ "http://::@c@d:2",
+ "http://c@d:2",
+ "aHR0cDovL2NAZDoy",
+ },
+ {
+ "http://foo.com:b@d/",
+ "http://d/",
+ "aHR0cDovL2Qv",
+ },
+ {
+ "http://foo.com/\\@",
+ "http://",
+ "aHR0cDovLw==",
+ },
+ {
+ "http:\\\\foo.com\\",
+ "http:\\\\foo.com\\",
+ "aHR0cDpcXGZvby5jb21c",
+ },
+ {
+ "http:\\\\a\\b:c\\d@foo.com\\",
+ "http:\\\\a\\b:c\\d@foo.com\\",
+ "aHR0cDpcXGFcYjpjXGRAZm9vLmNvbVw=",
+ },
+ {
+ "foo:/",
+ "foo:/",
+ "Zm9vOi8=",
+ },
+ {
+ "foo:/bar.com/",
+ "foo:/bar.com/",
+ "Zm9vOi9iYXIuY29tLw==",
+ },
+ {
+ "foo://///////",
+ "foo://///////",
+ "Zm9vOi8vLy8vLy8vLw==",
+ },
+ {
+ "foo://///////bar.com/",
+ "foo://///////bar.com/",
+ "Zm9vOi8vLy8vLy8vL2Jhci5jb20v",
+ },
+ {
+ "foo:////://///",
+ "foo:////://///",
+ "Zm9vOi8vLy86Ly8vLy8=",
+ },
+ {
+ "c:/foo",
+ "c:/foo",
+ "YzovZm9v",
+ },
+ {
+ "//foo/bar",
+ "//foo/bar",
+ "Ly9mb28vYmFy",
+ },
+ {
+ "http://foo/path;a??e#f#g",
+ "http://foo/path;a",
+ "aHR0cDovL2Zvby9wYXRoO2E=",
+ },
+ {
+ "http://foo/abcd?efgh?ijkl",
+ "http://foo/abcd",
+ "aHR0cDovL2Zvby9hYmNk",
+ },
+ {
+ "http://foo/abcd#foo?bar",
+ "http://foo/abcd",
+ "aHR0cDovL2Zvby9hYmNk",
+ },
+ {
+ "[61:24:74]:98",
+ "[61:24:74]:98",
+ "WzYxOjI0Ojc0XTo5OA==",
+ },
+ {
+ "http://[61:27]:98",
+ "http://[61:27]:98",
+ "aHR0cDovL1s2MToyN106OTg=",
+ },
+ {
+ "http:[61:27]/:foo",
+ "http:[61:27]/:foo",
+ "aHR0cDpbNjE6MjddLzpmb28=",
+ },
+ {
+ "http://[1::2]:3:4",
+ "http://[1::2]:3:4",
+ "aHR0cDovL1sxOjoyXTozOjQ=",
+ },
+ {
+ "http://2001::1",
+ "http://2001::1",
+ "aHR0cDovLzIwMDE6OjE=",
+ },
+ {
+ "http://[2001::1",
+ "http://[2001::1",
+ "aHR0cDovL1syMDAxOjox",
+ },
+ {
+ "http://2001::1]",
+ "http://2001::1]",
+ "aHR0cDovLzIwMDE6OjFd",
+ },
+ {
+ "http://2001::1]:80",
+ "http://2001::1]:80",
+ "aHR0cDovLzIwMDE6OjFdOjgw",
+ },
+ {
+ "http://[2001::1]",
+ "http://[2001::1]",
+ "aHR0cDovL1syMDAxOjoxXQ==",
+ },
+ {
+ "http://[2001::1]:80",
+ "http://[2001::1]:80",
+ "aHR0cDovL1syMDAxOjoxXTo4MA==",
+ },
+ {
+ "http://[[::]]",
+ "http://[[::]]",
+ "aHR0cDovL1tbOjpdXQ==",
+ },
+ {
+ "file:server",
+ "file:server",
+ "ZmlsZTpzZXJ2ZXI=",
+ },
+ {
+ " file: server \t",
+ " file: server \t",
+ "ICBmaWxlOiBzZXJ2ZXIgIAk=",
+ },
+ {
+ "FiLe:c|",
+ "FiLe:c|",
+ "RmlMZTpjfA==",
+ },
+ {
+ "FILE:/\\\\/server/file",
+ "FILE:/\\\\/server/file",
+ "RklMRTovXFwvc2VydmVyL2ZpbGU=",
+ },
+ {
+ "file://server/",
+ "file://server/",
+ "ZmlsZTovL3NlcnZlci8=",
+ },
+ {
+ "file://localhost/c:/",
+ "file://localhost/c:/",
+ "ZmlsZTovL2xvY2FsaG9zdC9jOi8=",
+ },
+ {
+ "file://127.0.0.1/c|\\",
+ "file://127.0.0.1/c|\\",
+ "ZmlsZTovLzEyNy4wLjAuMS9jfFw=",
+ },
+ {
+ "file:/",
+ "file:/",
+ "ZmlsZTov",
+ },
+ {
+ "file:",
+ "file:",
+ "ZmlsZTo=",
+ },
+ {
+ "file:c:\\fo\\b",
+ "file:c:\\fo\\b",
+ "ZmlsZTpjOlxmb1xi",
+ },
+ {
+ "file:/c:\\foo/bar",
+ "file:/c:\\foo/bar",
+ "ZmlsZTovYzpcZm9vL2Jhcg==",
+ },
+ {
+ "file://c:/f\\b",
+ "file://c:/f\\b",
+ "ZmlsZTovL2M6L2ZcYg==",
+ },
+ {
+ "file:///C:/foo",
+ "file:///C:/foo",
+ "ZmlsZTovLy9DOi9mb28=",
+ },
+ {
+ "file://///\\/\\/c:\\f\\b",
+ "file://///\\/\\/c:\\f\\b",
+ "ZmlsZTovLy8vL1wvXC9jOlxmXGI=",
+ },
+ {
+ "file:server/file",
+ "file:server/file",
+ "ZmlsZTpzZXJ2ZXIvZmlsZQ==",
+ },
+ {
+ "file:/server/file",
+ "file:/server/file",
+ "ZmlsZTovc2VydmVyL2ZpbGU=",
+ },
+ {
+ "file://server/file",
+ "file://server/file",
+ "ZmlsZTovL3NlcnZlci9maWxl",
+ },
+ {
+ "file:///server/file",
+ "file:///server/file",
+ "ZmlsZTovLy9zZXJ2ZXIvZmlsZQ==",
+ },
+ {
+ "file://\\server/file",
+ "file://\\server/file",
+ "ZmlsZTovL1xzZXJ2ZXIvZmlsZQ==",
+ },
+ {
+ "file:////server/file",
+ "file:////server/file",
+ "ZmlsZTovLy8vc2VydmVyL2ZpbGU=",
+ },
+ {
+ "file:///C:/foo.html?#",
+ "file:///C:/foo.html",
+ "ZmlsZTovLy9DOi9mb28uaHRtbA==",
+ },
+ {
+ "file:///C:/foo.html?query=yes#ref",
+ "file:///C:/foo.html",
+ "ZmlsZTovLy9DOi9mb28uaHRtbA==",
+ },
+ {
+ "file:",
+ "file:",
+ "ZmlsZTo=",
+ },
+ {
+ "file:path",
+ "file:path",
+ "ZmlsZTpwYXRo",
+ },
+ {
+ "file:path/",
+ "file:path/",
+ "ZmlsZTpwYXRoLw==",
+ },
+ {
+ "file:path/f.txt",
+ "file:path/f.txt",
+ "ZmlsZTpwYXRoL2YudHh0",
+ },
+ {
+ "file:/",
+ "file:/",
+ "ZmlsZTov",
+ },
+ {
+ "file:/path",
+ "file:/path",
+ "ZmlsZTovcGF0aA==",
+ },
+ {
+ "file:/path/",
+ "file:/path/",
+ "ZmlsZTovcGF0aC8=",
+ },
+ {
+ "file:/path/f.txt",
+ "file:/path/f.txt",
+ "ZmlsZTovcGF0aC9mLnR4dA==",
+ },
+ {
+ "file://",
+ "file://",
+ "ZmlsZTovLw==",
+ },
+ {
+ "file://server",
+ "file://server",
+ "ZmlsZTovL3NlcnZlcg==",
+ },
+ {
+ "file://server/",
+ "file://server/",
+ "ZmlsZTovL3NlcnZlci8=",
+ },
+ {
+ "file://server/f.txt",
+ "file://server/f.txt",
+ "ZmlsZTovL3NlcnZlci9mLnR4dA==",
+ },
+ {
+ "file:///",
+ "file:///",
+ "ZmlsZTovLy8=",
+ },
+ {
+ "file:///path",
+ "file:///path",
+ "ZmlsZTovLy9wYXRo",
+ },
+ {
+ "file:///path/",
+ "file:///path/",
+ "ZmlsZTovLy9wYXRoLw==",
+ },
+ {
+ "file:///path/f.txt",
+ "file:///path/f.txt",
+ "ZmlsZTovLy9wYXRoL2YudHh0",
+ },
+ {
+ "file:////",
+ "file:////",
+ "ZmlsZTovLy8v",
+ },
+ {
+ "file:////path",
+ "file:////path",
+ "ZmlsZTovLy8vcGF0aA==",
+ },
+ {
+ "file:////path/",
+ "file:////path/",
+ "ZmlsZTovLy8vcGF0aC8=",
+ },
+ {
+ "file:////path/f.txt",
+ "file:////path/f.txt",
+ "ZmlsZTovLy8vcGF0aC9mLnR4dA==",
+ },
+ {
+ "path/f.txt",
+ "path/f.txt",
+ "cGF0aC9mLnR4dA==",
+ },
+ {
+ "path:80/f.txt",
+ "path:80/f.txt",
+ "cGF0aDo4MC9mLnR4dA==",
+ },
+ {
+ "path/f.txt:80",
+ "path/f.txt:80",
+ "cGF0aC9mLnR4dDo4MA==",
+ },
+ {
+ "/path/f.txt",
+ "/path/f.txt",
+ "L3BhdGgvZi50eHQ=",
+ },
+ {
+ "/path:80/f.txt",
+ "/path:80/f.txt",
+ "L3BhdGg6ODAvZi50eHQ=",
+ },
+ {
+ "/path/f.txt:80",
+ "/path/f.txt:80",
+ "L3BhdGgvZi50eHQ6ODA=",
+ },
+ {
+ "//server/f.txt",
+ "//server/f.txt",
+ "Ly9zZXJ2ZXIvZi50eHQ=",
+ },
+ {
+ "//server:80/f.txt",
+ "//server:80/f.txt",
+ "Ly9zZXJ2ZXI6ODAvZi50eHQ=",
+ },
+ {
+ "//server/f.txt:80",
+ "//server/f.txt:80",
+ "Ly9zZXJ2ZXIvZi50eHQ6ODA=",
+ },
+ {
+ "///path/f.txt",
+ "///path/f.txt",
+ "Ly8vcGF0aC9mLnR4dA==",
+ },
+ {
+ "///path:80/f.txt",
+ "///path:80/f.txt",
+ "Ly8vcGF0aDo4MC9mLnR4dA==",
+ },
+ {
+ "///path/f.txt:80",
+ "///path/f.txt:80",
+ "Ly8vcGF0aC9mLnR4dDo4MA==",
+ },
+ {
+ "////path/f.txt",
+ "////path/f.txt",
+ "Ly8vL3BhdGgvZi50eHQ=",
+ },
+ {
+ "////path:80/f.txt",
+ "////path:80/f.txt",
+ "Ly8vL3BhdGg6ODAvZi50eHQ=",
+ },
+ {
+ "////path/f.txt:80",
+ "////path/f.txt:80",
+ "Ly8vL3BhdGgvZi50eHQ6ODA=",
+ },
+ {
+ "file:///foo.html?#",
+ "file:///foo.html",
+ "ZmlsZTovLy9mb28uaHRtbA==",
+ },
+ {
+ "file:///foo.html?q=y#ref",
+ "file:///foo.html",
+ "ZmlsZTovLy9mb28uaHRtbA==",
+ },
+};
+
+TEST(AppKeyTest, SunnyDayExtractAppKey) {
+ for (const URLWithExtractedAndEncoded& expected :
+ kURLWithExtractedAndEncoded) {
+ std::string actual = ExtractAppKey(expected.url);
+ EXPECT_EQ(std::string(expected.extracted), actual);
+
+ actual = EncodeAppKey(actual);
+ EXPECT_EQ(std::string(expected.encoded), actual);
+ }
+}
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/drain_file.cc b/src/starboard/loader_app/drain_file.cc
new file mode 100644
index 0000000..52e31b9
--- /dev/null
+++ b/src/starboard/loader_app/drain_file.cc
@@ -0,0 +1,306 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/drain_file.h"
+
+#include <algorithm>
+#include <string>
+#include <vector>
+
+#include "starboard/common/file.h"
+#include "starboard/common/log.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/directory.h"
+#include "starboard/string.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+const SbTime kDrainFileAgeUnit = kSbTimeSecond;
+const SbTime kDrainFileMaximumAge = kSbTimeHour;
+const char kDrainFilePrefix[] = "d_";
+
+#ifdef __cplusplus
+} // extern "C"
+#endif
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+std::string ExtractAppKey(const std::string& str) {
+ const size_t begin = str.find_first_of('_') + 1;
+ const size_t end = str.find_last_of('_');
+
+ if ((begin == std::string::npos) || (end == std::string::npos) ||
+ (end - begin < 1))
+ return "";
+
+ return str.substr(begin, end - begin);
+}
+
+SbTime ExtractTimestamp(const std::string& str) {
+ const size_t index = str.find_last_of('_') + 1;
+
+ if ((index == std::string::npos) || (index == str.size() - 1))
+ return 0;
+
+ const std::string timestamp = str.substr(index, str.size() - index);
+
+ return SbTime(SbStringParseUInt64(timestamp.c_str(), NULL, 10)) *
+ kDrainFileAgeUnit;
+}
+
+bool IsExpired(const std::string& filename) {
+ const SbTime timestamp = ExtractTimestamp(filename);
+ return timestamp + kDrainFileMaximumAge < SbTimeGetNow();
+}
+
+std::vector<std::string> FindAllWithPrefix(const std::string& dir,
+ const std::string& prefix) {
+ SbDirectory slot = SbDirectoryOpen(dir.c_str(), NULL);
+
+ if (!SbDirectoryIsValid(slot)) {
+ SB_LOG(ERROR) << "Failed to open provided directory '" << dir << "'";
+ return std::vector<std::string>();
+ }
+
+ std::vector<std::string> filenames;
+
+#if SB_API_VERSION >= 12
+ std::vector<char> filename(kSbFileMaxName);
+
+ while (SbDirectoryGetNext(slot, filename.data(), filename.size())) {
+ if (!SbStringCompareAll(filename.data(), ".") ||
+ !SbStringCompareAll(filename.data(), ".."))
+ continue;
+ if (!SbStringCompare(prefix.data(), filename.data(), prefix.size()))
+ filenames.push_back(std::string(filename.data()));
+ }
+#else
+ SbDirectoryEntry entry;
+
+ while (SbDirectoryGetNext(slot, &entry)) {
+ if (!SbStringCompareAll(entry.name, ".") ||
+ !SbStringCompareAll(entry.name, ".."))
+ continue;
+ if (!SbStringCompare(prefix.data(), entry.name, prefix.size()))
+ filenames.push_back(std::string(entry.name));
+ }
+#endif
+
+ SbDirectoryClose(slot);
+ return filenames;
+}
+
+void Rank(const char* dir, char* app_key, size_t len) {
+ SB_DCHECK(dir);
+ SB_DCHECK(app_key);
+
+ std::vector<std::string> filenames = FindAllWithPrefix(dir, kDrainFilePrefix);
+
+ std::remove_if(filenames.begin(), filenames.end(), IsExpired);
+
+ if (filenames.empty())
+ return;
+
+ // This lambda compares two strings, each string being a drain file name. This
+ // function returns |true| when |left| has an earlier timestamp than |right|,
+ // or when |left| is ASCII-betically lower than |right| if their timestamps
+ // are equal.
+ auto compare_filenames = [](const std::string& left,
+ const std::string& right) -> bool {
+ const SbTime left_timestamp = ExtractTimestamp(left);
+ const SbTime right_timestamp = ExtractTimestamp(right);
+
+ if (left_timestamp != right_timestamp)
+ return left_timestamp < right_timestamp;
+
+ const std::string left_app_key = ExtractAppKey(left);
+ const std::string right_app_key = ExtractAppKey(right);
+
+ return SbStringCompare(left_app_key.c_str(), right_app_key.c_str(),
+ right_app_key.size()) < 0;
+ };
+
+ std::sort(filenames.begin(), filenames.end(), compare_filenames);
+
+ const std::string& ranking_app_key = ExtractAppKey(filenames.front());
+
+ if (SbStringCopy(app_key, ranking_app_key.c_str(), len) >= len)
+ SB_LOG(ERROR) << "Returned value was truncated";
+}
+
+} // namespace
+
+namespace drain_file {
+
+bool TryDrain(const char* dir, const char* app_key) {
+ SB_DCHECK(dir);
+ SB_DCHECK(app_key);
+
+ std::vector<std::string> filenames = FindAllWithPrefix(dir, kDrainFilePrefix);
+
+ for (const auto& filename : filenames) {
+ if (IsExpired(filename))
+ continue;
+ if (filename.find(app_key) == std::string::npos)
+ return false;
+ SB_LOG(INFO) << "Found valid drain file '" << filename << "'";
+ return true;
+ }
+
+ std::string filename(kDrainFilePrefix);
+ filename.append(app_key);
+ filename.append("_");
+ filename.append(std::to_string(SbTimeGetNow() / kDrainFileAgeUnit));
+
+ SB_DCHECK(filename.size() <= kSbFileMaxName);
+
+ std::string path(dir);
+ path.append(kSbFileSepString);
+ path.append(filename);
+
+ SbFileError error = kSbFileOk;
+ SbFile file = SbFileOpen(path.c_str(), kSbFileCreateAlways | kSbFileWrite,
+ NULL, &error);
+
+ SB_DCHECK(error == kSbFileOk);
+ SB_DCHECK(SbFileClose(file));
+
+ SB_LOG(INFO) << "Created drain file at '" << path << "'";
+
+ return true;
+}
+
+bool RankAndCheck(const char* dir, const char* app_key) {
+ SB_DCHECK(dir);
+ SB_DCHECK(app_key);
+
+ std::vector<char> ranking_app_key(kSbFileMaxName);
+
+ Rank(dir, ranking_app_key.data(), ranking_app_key.size());
+
+ return !SbStringCompareAll(ranking_app_key.data(), app_key);
+}
+
+bool Remove(const char* dir, const char* app_key) {
+ SB_DCHECK(dir);
+ SB_DCHECK(app_key);
+
+ const std::string prefix = std::string(kDrainFilePrefix) + app_key;
+ const std::vector<std::string> filenames =
+ FindAllWithPrefix(dir, prefix.c_str());
+
+ for (const auto& filename : filenames) {
+ const std::string path = dir + std::string(kSbFileSepString) + filename;
+
+ if (!SbFileDelete(path.c_str()))
+ return false;
+ }
+ return true;
+}
+
+void Clear(const char* dir, const char* app_key, bool expired) {
+ SB_DCHECK(dir);
+
+ std::vector<std::string> filenames = FindAllWithPrefix(dir, kDrainFilePrefix);
+
+ for (const auto& filename : filenames) {
+ if (expired && !IsExpired(filename))
+ continue;
+ if (app_key && (filename.find(app_key) != std::string::npos))
+ continue;
+
+ const std::string path = dir + std::string(kSbFileSepString) + filename;
+
+ if (!SbFileDelete(path.c_str()))
+ SB_LOG(ERROR) << "Failed to remove expired drain file at '" << filename
+ << "'";
+ }
+}
+
+void PrepareDirectory(const char* dir, const char* app_key) {
+ SB_DCHECK(dir);
+ SB_DCHECK(app_key);
+
+ const std::string prefix = std::string(kDrainFilePrefix) + app_key;
+ const std::vector<std::string> entries = FindAllWithPrefix(dir, "");
+
+ for (const auto& entry : entries) {
+ if (!SbStringCompare(entry.c_str(), prefix.c_str(), prefix.size()))
+ continue;
+
+ std::string path(dir);
+ path.append(kSbFileSepString);
+ path.append(entry);
+
+ SbFileDeleteRecursive(path.c_str(), false);
+ }
+}
+
+bool Draining(const char* dir, const char* app_key) {
+ SB_DCHECK(dir);
+
+ std::string prefix(kDrainFilePrefix);
+
+ if (app_key)
+ prefix.append(app_key);
+
+ const std::vector<std::string> filenames =
+ FindAllWithPrefix(dir, prefix.c_str());
+
+ for (const auto& filename : filenames) {
+ if (!IsExpired(filename))
+ return true;
+ }
+ return false;
+}
+
+} // namespace drain_file
+} // namespace loader_app
+} // namespace starboard
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+bool DrainFileTryDrain(const char* dir, const char* app_key) {
+ return starboard::loader_app::drain_file::TryDrain(dir, app_key);
+}
+
+bool DrainFileRankAndCheck(const char* dir, const char* app_key) {
+ return starboard::loader_app::drain_file::RankAndCheck(dir, app_key);
+}
+
+bool DrainFileRemove(const char* dir, const char* app_key) {
+ return starboard::loader_app::drain_file::Remove(dir, app_key);
+}
+
+void DrainFileClear(const char* dir, const char* app_key, bool expired) {
+ starboard::loader_app::drain_file::Clear(dir, app_key, expired);
+}
+
+void DrainFilePrepareDirectory(const char* dir, const char* app_key) {
+ starboard::loader_app::drain_file::PrepareDirectory(dir, app_key);
+}
+
+bool DrainFileDraining(const char* dir, const char* app_key) {
+ return starboard::loader_app::drain_file::Draining(dir, app_key);
+}
+
+#ifdef __cplusplus
+} // extern "C"
+#endif
diff --git a/src/starboard/loader_app/drain_file.gyp b/src/starboard/loader_app/drain_file.gyp
new file mode 100644
index 0000000..454afd1
--- /dev/null
+++ b/src/starboard/loader_app/drain_file.gyp
@@ -0,0 +1,56 @@
+# Copyright 2020 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{
+ 'targets': [
+ {
+ 'target_name': 'drain_file',
+ 'type': 'static_library',
+ 'sources': [
+ 'drain_file.cc',
+ 'drain_file.h',
+ ],
+ 'dependencies': [
+ '<(DEPTH)/starboard/common/common.gyp:common',
+ '<(DEPTH)/starboard/starboard.gyp:starboard',
+ ],
+ },
+ {
+ 'target_name': 'drain_file_test',
+ 'type': '<(gtest_target_type)',
+ 'sources': [
+ 'drain_file_helper.cc',
+ 'drain_file_helper.h',
+ 'drain_file_test.cc',
+ '<(DEPTH)/starboard/common/test_main.cc',
+ ],
+ 'dependencies': [
+ ':drain_file',
+ '<(DEPTH)/testing/gmock.gyp:gmock',
+ '<(DEPTH)/testing/gtest.gyp:gtest',
+ ],
+ },
+ {
+ 'target_name': 'drain_file_test_deploy',
+ 'type': 'none',
+ 'dependencies': [
+ 'drain_file_test',
+ ],
+ 'variables': {
+ 'executable_name': 'drain_file_test',
+ },
+ 'includes': [ '<(DEPTH)/starboard/build/deploy.gypi' ],
+ },
+ ],
+}
diff --git a/src/starboard/loader_app/drain_file.h b/src/starboard/loader_app/drain_file.h
new file mode 100644
index 0000000..92a9dba
--- /dev/null
+++ b/src/starboard/loader_app/drain_file.h
@@ -0,0 +1,68 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_DRAIN_FILE_H_
+#define STARBOARD_LOADER_APP_DRAIN_FILE_H_
+
+#include "starboard/time.h"
+#include "starboard/types.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+// The units of time that the drain file age is represented in.
+extern const SbTime kDrainFileAgeUnit;
+
+// The amount of time of which a drain file is valid.
+extern const SbTime kDrainFileMaximumAge;
+
+// The prefix that all drain file names will have.
+extern const char kDrainFilePrefix[];
+
+// Attempts to create a drain file in |dir| with the provided |app_key|. If
+// there is an existing, non-expired drain file with a matching |app_key| it
+// will be used instead. Returns |true| if a file was created or reused,
+// otherwise |false|.
+bool DrainFileTryDrain(const char* dir, const char* app_key);
+
+// Ranks the drain files in |dir| using DrainFileRank(), and compares the
+// provided |app_key| with the best ranked app key. Returns |true| if they
+// match, otherwise |false|.
+bool DrainFileRankAndCheck(const char* dir, const char* app_key);
+
+// Removed the drain files in |dir| whose app key matches |app_key|. Returns
+// |true| if no files were found, or they were removed, otherwise returns
+// |false|.
+bool DrainFileRemove(const char* dir, const char* app_key);
+
+// Clears the drain files in |dir|. If |app_key| is provided, all drain files
+// with matching app keys are ignored. If |expired| is |true|, all non-expired
+// drain files are ignored.
+void DrainFileClear(const char* dir, const char* app_key, bool expired);
+
+// Clears all files and directories in |dir| except for the drain file with an
+// app key matching |app_key|.
+void DrainFilePrepareDirectory(const char* dir, const char* app_key);
+
+// Checks whether a non-expired drain file exists in |dir|. If |app_key| is
+// provided, only drain files with a matching |app_key| are considered. Returns
+// |true| if there is, otherwise |false|.
+bool DrainFileDraining(const char* dir, const char* app_key);
+
+#ifdef __cplusplus
+} // extern "C"
+#endif
+
+#endif // STARBOARD_LOADER_APP_DRAIN_FILE_H_
diff --git a/src/starboard/loader_app/drain_file_helper.cc b/src/starboard/loader_app/drain_file_helper.cc
new file mode 100644
index 0000000..8c3e0b1
--- /dev/null
+++ b/src/starboard/loader_app/drain_file_helper.cc
@@ -0,0 +1,66 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/drain_file_helper.h"
+
+#include "starboard/file.h"
+#include "starboard/loader_app/drain_file.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace starboard {
+namespace loader_app {
+
+ScopedDrainFile::ScopedDrainFile(const std::string& dir,
+ const std::string& app_key,
+ SbTime timestamp) {
+ app_key_.assign(app_key);
+
+ path_.assign(dir);
+ path_.append(kSbFileSepString);
+ path_.append(kDrainFilePrefix);
+ path_.append(app_key);
+ path_.append("_");
+ path_.append(std::to_string(timestamp / kDrainFileAgeUnit));
+
+ CreateFile();
+}
+
+ScopedDrainFile::~ScopedDrainFile() {
+ if (!Exists())
+ return;
+ EXPECT_TRUE(SbFileDelete(path_.c_str()));
+}
+
+bool ScopedDrainFile::Exists() const {
+ return SbFileExists(path_.c_str());
+}
+
+const std::string& ScopedDrainFile::app_key() const {
+ return app_key_;
+}
+
+const std::string& ScopedDrainFile::path() const {
+ return path_;
+}
+
+void ScopedDrainFile::CreateFile() {
+ SbFileError error = kSbFileOk;
+ starboard::ScopedFile file(path_.c_str(), kSbFileCreateOnly | kSbFileWrite,
+ NULL, &error);
+
+ EXPECT_TRUE(file.IsValid());
+}
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/drain_file_helper.h b/src/starboard/loader_app/drain_file_helper.h
new file mode 100644
index 0000000..caf8b44
--- /dev/null
+++ b/src/starboard/loader_app/drain_file_helper.h
@@ -0,0 +1,52 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_DRAIN_FILE_HELPER_H_
+#define STARBOARD_LOADER_APP_DRAIN_FILE_HELPER_H_
+
+#include <string>
+
+#include "starboard/time.h"
+
+namespace starboard {
+namespace loader_app {
+
+// Creates and removes a file within its own lifetime. This class maintains the
+// path to the file, and the app key that it was created with, to provide a
+// convenient way of bundling the information and state of the file. This class
+// is very similar in concept to the starboard::nplb::ScopedRandomFile, except
+// that it allows you to choose where to create the file.
+class ScopedDrainFile {
+ public:
+ ScopedDrainFile(const std::string& dir, const std::string& app_key,
+ SbTime timestamp);
+ ~ScopedDrainFile();
+
+ // Whether or not the created file still exists.
+ bool Exists() const;
+
+ const std::string& app_key() const;
+ const std::string& path() const;
+
+ private:
+ void CreateFile();
+
+ std::string app_key_;
+ std::string path_;
+};
+
+} // namespace loader_app
+} // namespace starboard
+
+#endif // STARBOARD_LOADER_APP_DRAIN_FILE_HELPER_H_
diff --git a/src/starboard/loader_app/drain_file_test.cc b/src/starboard/loader_app/drain_file_test.cc
new file mode 100644
index 0000000..afbde87
--- /dev/null
+++ b/src/starboard/loader_app/drain_file_test.cc
@@ -0,0 +1,206 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/drain_file.h"
+
+#include <string>
+#include <vector>
+
+#include "starboard/common/log.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/directory.h"
+#include "starboard/file.h"
+#include "starboard/loader_app/drain_file_helper.h"
+#include "starboard/system.h"
+#include "starboard/types.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+const char kAppKeyOne[] = "b25lDQo=";
+const char kAppKeyTwo[] = "dHdvDQo=";
+const char kAppKeyThree[] = "dGhyZWUNCg==";
+
+class DrainFileTest : public ::testing::Test {
+ protected:
+ // This function is used to set the temporary directory used for testing once,
+ // and to create a subdir in this test directory, once for all test cases.
+ static void SetUpTestCase() {
+ std::vector<char> path(kSbFileMaxPath, 0);
+
+ ASSERT_TRUE(
+ SbSystemGetPath(kSbSystemPathTempDirectory, path.data(), path.size()));
+
+ dir_.assign(path.data());
+ }
+
+ void TearDown() override {
+ DrainFileClear(GetTempDir(), NULL, false);
+ }
+
+ const char* GetTempDir() const { return dir_.c_str(); }
+
+ private:
+ static std::string dir_;
+};
+
+std::string DrainFileTest::dir_ = "";
+
+// Typical drain file usage.
+TEST_F(DrainFileTest, SunnyDay) {
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileRankAndCheck(GetTempDir(), kAppKeyOne));
+}
+
+// Drain file creation should ignore expired files, even if it has a matching
+// app key.
+TEST_F(DrainFileTest, SunnyDayIgnoreExpired) {
+ ScopedDrainFile stale(GetTempDir(), kAppKeyOne,
+ SbTimeGetNow() - kDrainFileMaximumAge);
+
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+}
+
+// Previously created drain file should be reused if it has not expired.
+TEST_F(DrainFileTest, SunnyDayTryDrainReusePreviousDrainFile) {
+ for (int i = 0; i < 2; ++i)
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+}
+
+// Draining status should return whether or not the file exists and has not yet
+// expired.
+TEST_F(DrainFileTest, SunnyDayDraining) {
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+
+ DrainFileClear(GetTempDir(), NULL, false);
+
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+}
+
+// Remove an existing drain file.
+TEST_F(DrainFileTest, SunnyDayRemove) {
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileRemove(GetTempDir(), kAppKeyOne));
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+}
+
+// Try to remove a drain file that does not exist.
+TEST_F(DrainFileTest, SunnyDayRemoveNonexistentDrainFile) {
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileRemove(GetTempDir(), kAppKeyOne));
+}
+
+// When clearing drain files it should be possible to provide a file to ignore,
+// and it should be possible to only clear expire files if desired.
+TEST_F(DrainFileTest, SunnyDayClear) {
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+
+ ScopedDrainFile valid_file(GetTempDir(), kAppKeyTwo, SbTimeGetNow());
+ ScopedDrainFile stale_file(GetTempDir(), kAppKeyThree,
+ SbTimeGetNow() - kDrainFileMaximumAge);
+
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyTwo));
+ EXPECT_TRUE(SbFileExists(stale_file.path().c_str()));
+
+ DrainFileClear(GetTempDir(), kAppKeyOne, true);
+
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyTwo));
+ EXPECT_FALSE(SbFileExists(stale_file.path().c_str()));
+
+ DrainFileClear(GetTempDir(), kAppKeyOne, false);
+
+ EXPECT_TRUE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyTwo));
+
+ DrainFileClear(GetTempDir(), NULL, false);
+
+ EXPECT_FALSE(DrainFileDraining(GetTempDir(), kAppKeyOne));
+}
+
+// Ranking drain files should first be done by timestamp, with the app key being
+// used as a tie breaker.
+TEST_F(DrainFileTest, SunnyDayRankCorrectlyRanksFiles) {
+ const SbTime timestamp = SbTimeGetNow();
+
+ ScopedDrainFile early_and_least(GetTempDir(), "a", timestamp);
+ ScopedDrainFile later_and_least(GetTempDir(), "c", timestamp);
+ ScopedDrainFile later_and_greatest(GetTempDir(), "b",
+ timestamp + kDrainFileAgeUnit);
+
+ std::vector<char> result(kSbFileMaxName);
+
+ EXPECT_TRUE(DrainFileRankAndCheck(GetTempDir(), "a"));
+ EXPECT_TRUE(SbFileDelete(early_and_least.path().c_str()));
+
+ EXPECT_TRUE(DrainFileRankAndCheck(GetTempDir(), "c"));
+ EXPECT_TRUE(SbFileDelete(later_and_least.path().c_str()));
+
+ EXPECT_TRUE(DrainFileRankAndCheck(GetTempDir(), "b"));
+ EXPECT_TRUE(SbFileDelete(later_and_greatest.path().c_str()));
+}
+
+// All files in the directory should be cleared except for drain files with an
+// app key matching the provided app key.
+TEST_F(DrainFileTest, SunnyDayPrepareDirectory) {
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+
+ // Create a directory to delete.
+ std::string dir(GetTempDir());
+ dir.append(kSbFileSepString);
+ dir.append("to_delete");
+
+ EXPECT_TRUE(SbDirectoryCreate(dir.c_str()));
+ EXPECT_TRUE(SbFileExists(dir.c_str()));
+
+ // Create a file with the app key in the name.
+ std::string path(GetTempDir());
+ path.append(kSbFileSepString);
+ path.append(kAppKeyOne);
+
+ {
+ ScopedFile file(path.c_str(), kSbFileOpenAlways | kSbFileWrite, NULL, NULL);
+ }
+
+ EXPECT_TRUE(SbFileExists(path.c_str()));
+
+ DrainFilePrepareDirectory(GetTempDir(), kAppKeyOne);
+
+ EXPECT_TRUE(DrainFileRankAndCheck(GetTempDir(), kAppKeyOne));
+ EXPECT_FALSE(SbFileExists(dir.c_str()));
+ EXPECT_FALSE(SbFileExists(path.c_str()));
+
+ DrainFilePrepareDirectory(GetTempDir(), "nonexistent");
+
+ EXPECT_FALSE(DrainFileRankAndCheck(GetTempDir(), kAppKeyOne));
+}
+
+// Creating a new drain file in the same directory as an existing, valid drain
+// file should fail.
+TEST_F(DrainFileTest, RainyDayDrainFileAlreadyExists) {
+ EXPECT_TRUE(DrainFileTryDrain(GetTempDir(), kAppKeyOne));
+ EXPECT_FALSE(DrainFileTryDrain(GetTempDir(), kAppKeyTwo));
+}
+
+} // namespace
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/installation_manager.cc b/src/starboard/loader_app/installation_manager.cc
index 35d166f..2e1cd50 100644
--- a/src/starboard/loader_app/installation_manager.cc
+++ b/src/starboard/loader_app/installation_manager.cc
@@ -18,6 +18,7 @@
#include <string>
#include <vector>
+#include "starboard/common/file.h"
#include "starboard/common/log.h"
#include "starboard/common/mutex.h"
#include "starboard/common/scoped_ptr.h"
@@ -34,13 +35,17 @@
class InstallationManager {
public:
- explicit InstallationManager(int max_num_installations);
+ explicit InstallationManager(int max_num_installations,
+ const std::string& app_key);
int Initialize();
-
+ int GetAppKey(char* app_key, int app_key_length);
+ int GetMaxNumberInstallations();
+ int Reset();
int GetInstallationStatus(int installation_index);
int GetInstallationNumTriesLeft(int installation_index);
int RollForwardIfNeeded();
+ int RollForward(int installation_index);
int DecrementInstallationNumTries(int installation_index);
int RevertToSuccessfulInstallation();
@@ -48,6 +53,7 @@
int GetCurrentInstallationIndex();
int MarkInstallationSuccessful(int installation_index);
int SelectNewInstallationIndex();
+ int ResetInstallation(int installation_index);
int RequestRollForwardToInstallation(int installation_index);
private:
@@ -60,10 +66,13 @@
void ShiftPrioritiesInRange(int high_priority,
int low_priority,
int shift_amount);
+
+ int RollForwardInternal(int installation);
bool InitInstallationStorePath();
bool LoadInstallationStore();
bool SaveInstallationStore();
bool CreateInstallationDirs();
+ bool CleanInstallationDirs();
bool GetInstallationPathInternal(int installation_index,
char* path,
int path_length);
@@ -71,6 +80,7 @@
cobalt::loader::InstallationStore installation_store_;
bool initialized_;
int current_installation_;
+ std::string app_key_;
std::string store_path_;
std::string storage_dir_;
std::string content_dir_;
@@ -79,13 +89,17 @@
const int highest_priority_;
};
-InstallationManager::InstallationManager(int max_num_installations)
+InstallationManager::InstallationManager(int max_num_installations,
+ const std::string& app_key)
: initialized_(false),
current_installation_(-1),
+ app_key_(app_key),
max_num_installations_(max_num_installations),
lowest_priority_(max_num_installations_ - 1),
highest_priority_(0) {
SB_CHECK(max_num_installations_ >= 2);
+ SB_CHECK(!app_key.empty());
+ SB_LOG(INFO) << "InstallationManager: app_key=" << app_key_;
}
int InstallationManager::Initialize() {
@@ -127,7 +141,44 @@
return initialized_ ? IM_SUCCESS : IM_ERROR;
}
+int InstallationManager::GetAppKey(char* app_key, int app_key_length) {
+ SB_LOG(INFO) << "InstallationManager::GetAppKey";
+ if (!initialized_) {
+ SB_LOG(ERROR) << "GetAppKey: not initialized";
+ return IM_ERROR;
+ }
+ SbStringCopy(app_key, app_key_.c_str(), app_key_length);
+ return IM_SUCCESS;
+}
+
+int InstallationManager::GetMaxNumberInstallations() {
+ if (!initialized_) {
+ SB_LOG(ERROR) << "GetMaxNumberInstallations: not initialized";
+ return IM_ERROR;
+ }
+ return max_num_installations_;
+}
+
+int InstallationManager::Reset() {
+ CreateInstallationStore();
+ current_installation_ = FindCurrentInstallationIndex();
+ if (!IsValidIndex(current_installation_)) {
+ SB_LOG(ERROR) << "Reset: Unable to find current installation"
+ << current_installation_;
+ return IM_ERROR;
+ }
+ if (!CleanInstallationDirs()) {
+ SB_LOG(ERROR) << "Reset: Unable to clean installations dirs";
+ return IM_ERROR;
+ }
+ if (!SaveInstallationStore()) {
+ return IM_ERROR;
+ }
+ return IM_SUCCESS;
+}
+
void InstallationManager::CreateInstallationStore() {
+ installation_store_ = cobalt::loader::InstallationStore();
int priority = highest_priority_;
for (int i = 0; i < max_num_installations_; i++) {
installation_store_.add_installations();
@@ -137,6 +188,8 @@
installation_store_.mutable_installations(i)->set_priority(priority++);
}
installation_store_.set_roll_forward_to_installation(-1);
+ // Mark the system image as successful.
+ installation_store_.mutable_installations(0)->set_is_successful(true);
}
std::string InstallationManager::DumpInstallationSlots() {
@@ -294,15 +347,21 @@
return IM_ERROR;
}
-//
-// Roll forward to a new installation and make it
-// the new highest priority installation.
-//
-// high [ ] [x]
-// [ ] [ ]
-// [x] => [ ]
-// low [ ] [ ]
-//
+int InstallationManager::RollForward(int installation_index) {
+ if (!initialized_) {
+ SB_LOG(ERROR) << "RollForward: not initialized";
+ return IM_ERROR;
+ }
+
+ if (!IsValidIndex(installation_index)) {
+ SB_LOG(ERROR) << "RollForward: invalid installation=" << installation_index;
+ return IM_ERROR;
+ }
+ SB_DLOG(INFO) << "RollForward: installation=" << installation_index;
+
+ return RollForwardInternal(installation_index);
+}
+
int InstallationManager::RollForwardIfNeeded() {
if (!initialized_) {
SB_LOG(ERROR) << "RollForwardIfNeeded: not initialized";
@@ -321,11 +380,24 @@
}
SB_DLOG(INFO) << "RollForwardIfNeeded: new_installation=" << new_installation;
+ return RollForwardInternal(new_installation);
+}
+
+//
+// Roll forward to a new installation and make it
+// the new highest priority installation.
+//
+// high [ ] [x]
+// [ ] [ ]
+// [x] => [ ]
+// low [ ] [ ]
+//
+int InstallationManager::RollForwardInternal(int installation_index) {
// Save old priority.
int new_installation_old_prority =
- installation_store_.installations(new_installation).priority();
+ installation_store_.installations(installation_index).priority();
- SB_DLOG(INFO) << "RollForwardIfNeeded: new_installation_old_priority="
+ SB_DLOG(INFO) << "RollForwardInternal: new_installation_old_priority="
<< new_installation_old_prority;
// Lower priorities of all jumped over installations.
@@ -333,14 +405,14 @@
1 /* shift down +1 */);
// The new installation will be set to the highest priority.
- installation_store_.mutable_installations(new_installation)
+ installation_store_.mutable_installations(installation_index)
->set_priority(highest_priority_);
// Reset the roll forward index.
installation_store_.set_roll_forward_to_installation(-1);
- current_installation_ = new_installation;
+ current_installation_ = installation_index;
- SB_DLOG(INFO) << "RollForwardIfNeeded: " << DumpInstallationSlots();
+ SB_DLOG(INFO) << "RollForwardInternal: " << DumpInstallationSlots();
return SaveInstallationStore() ? IM_SUCCESS : IM_ERROR;
}
@@ -354,8 +426,8 @@
if (priority >= high_priority && priority <= low_priority) {
installation_store_.mutable_installations(i)->set_priority(priority +
shift_amount);
- SB_DLOG(INFO) << "ShiftPrioritiesInRange i=" << i << " priority_new"
- << priority;
+ SB_DLOG(INFO) << "ShiftPrioritiesInRange i=" << i
+ << " priority_new=" << priority;
}
}
}
@@ -428,9 +500,9 @@
int priority = highest_priority_;
int new_installation_index = -1;
- // If we have more than 2 slots the 0 index slot is always the system image.
- // We would ignore the 0 slot in that case.
- int start = max_num_installations_ > 2 ? 1 : 0;
+ // SLOT_0 is placed in |kSbSystemPathContentDirectory|, under the subdirectory
+ // 'app/cobalt', and is always the system image.
+ int start = 1;
// Find the lowest priority installation that we can use.
for (int i = start; i < installation_store_.installations().size(); i++) {
@@ -459,6 +531,31 @@
return IM_ERROR;
}
+int InstallationManager::ResetInstallation(int installation_index) {
+ if (!initialized_) {
+ SB_LOG(ERROR) << "ResetInstallation: not initialized";
+ return IM_ERROR;
+ }
+
+ // invalid index or the system image.
+ if (installation_index == -1 || installation_index == 0) {
+ return IM_ERROR;
+ }
+
+ installation_store_.mutable_installations(installation_index)
+ ->set_is_successful(false);
+ installation_store_.mutable_installations(installation_index)
+ ->set_num_tries_left(IM_MAX_NUM_TRIES);
+
+ if (!SaveInstallationStore()) {
+ SB_LOG(ERROR) << "ResetInstallation: failed to store";
+ return IM_ERROR;
+ }
+
+ SB_DLOG(INFO) << "ResetInstallation: " << DumpInstallationSlots();
+ return IM_SUCCESS;
+}
+
int InstallationManager::RequestRollForwardToInstallation(
int installation_index) {
if (!initialized_) {
@@ -522,16 +619,16 @@
storage_dir_ = storage_dir.data();
store_path_ = storage_dir.data();
store_path_ += kSbFileSepString;
- store_path_ += IM_STORE_FILE_NAME;
+ store_path_ += IM_STORE_FILE_NAME_PREFIX;
+ store_path_ += app_key_;
+ store_path_ += IM_STORE_FILE_NAME_SUFFIX;
- if (max_num_installations_ > 2) {
- std::vector<char> content_dir(kSbFileMaxPath);
- if (!SbSystemGetPath(kSbSystemPathContentDirectory, content_dir.data(),
- kSbFileMaxPath)) {
- return false;
- }
- content_dir_ = content_dir.data();
+ std::vector<char> content_dir(kSbFileMaxPath);
+ if (!SbSystemGetPath(kSbSystemPathContentDirectory, content_dir.data(),
+ kSbFileMaxPath)) {
+ return false;
}
+ content_dir_ = content_dir.data();
return true;
}
@@ -553,6 +650,7 @@
bool InstallationManager::LoadInstallationStore() {
SbFile file;
+ SB_LOG(INFO) << "StorePath=" << store_path_;
file = SbFileOpen(store_path_.c_str(), kSbFileOpenOnly | kSbFileRead, NULL,
NULL);
if (!file) {
@@ -586,9 +684,9 @@
SB_LOG(ERROR) << "GetInstallationPath: path is null";
return false;
}
- // When more than 2 slots are availabe the installation 0 slot is
- // located under the content directory.
- if (installation_index == 0 && max_num_installations_ > 2) {
+ // SLOT_0 is placed in |kSbSystemPathContentDirectory|, under the subdirectory
+ // 'app/cobalt'.
+ if (installation_index == 0) {
SbStringFormatF(path, path_length, "%s%s%s%s%s", content_dir_.c_str(),
kSbFileSepString, "app", kSbFileSepString, "cobalt");
} else {
@@ -602,14 +700,15 @@
bool InstallationManager::CreateInstallationDirs() {
std::vector<char> path(kSbFileMaxPath);
for (int i = 0; i < max_num_installations_; i++) {
- // The index 0 slot when more than 2 slots are available is
- // under the content directory.
- if (i == 0 && max_num_installations_ > 2) {
+ // SLOT_0 is placed in |kSbSystemPathContentDirectory|, under the
+ // subdirectory 'app/cobalt'.
+ if (i == 0) {
continue;
}
if (!GetInstallationPathInternal(i, path.data(), kSbFileMaxPath)) {
return false;
}
+
if (!SbDirectoryCreate(path.data())) {
return false;
}
@@ -617,6 +716,20 @@
return true;
}
+bool InstallationManager::CleanInstallationDirs() {
+ std::vector<char> path(kSbFileMaxPath);
+ // The index 0 slot is under the content directory.
+ for (int i = 1; i < max_num_installations_; i++) {
+ if (!GetInstallationPathInternal(i, path.data(), kSbFileMaxPath)) {
+ return false;
+ }
+ if (!SbFileDeleteRecursive(path.data(), true)) {
+ return false;
+ }
+ }
+ return true;
+}
+
} // namespace installation_manager
} // namespace loader_app
} // namespace starboard
@@ -627,77 +740,103 @@
starboard::scoped_ptr<
starboard::loader_app::installation_manager::InstallationManager>
- g_istallation_manager_;
+ g_installation_manager_;
// Global Installation Manager Mutex.
SB_ONCE_INITIALIZE_FUNCTION(starboard::Mutex, GetImMutex);
-int ImInitialize(int max_num_installations) {
+int ImInitialize(int max_num_installations, const char* app_key) {
starboard::ScopedLock lock(*GetImMutex());
- if (g_istallation_manager_.get() == NULL) {
- g_istallation_manager_.reset(
+ if (g_installation_manager_.get() == NULL) {
+ g_installation_manager_.reset(
new starboard::loader_app::installation_manager::InstallationManager(
- max_num_installations));
+ max_num_installations, app_key));
}
- return g_istallation_manager_->Initialize();
+ return g_installation_manager_->Initialize();
+}
+
+int ImGetAppKey(char* app_key, int app_key_length) {
+ starboard::ScopedLock lock(*GetImMutex());
+ return g_installation_manager_->GetAppKey(app_key, app_key_length);
+}
+
+int ImGetMaxNumberInstallations() {
+ starboard::ScopedLock lock(*GetImMutex());
+ return g_installation_manager_->GetMaxNumberInstallations();
}
void ImUninitialize() {
starboard::ScopedLock lock(*GetImMutex());
- g_istallation_manager_.reset(NULL);
+ g_installation_manager_.reset(NULL);
+}
+
+int ImReset() {
+ starboard::ScopedLock lock(*GetImMutex());
+ return g_installation_manager_->Reset();
}
int ImGetInstallationStatus(int installation_index) {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->GetInstallationStatus(installation_index);
+ return g_installation_manager_->GetInstallationStatus(installation_index);
}
int ImGetInstallationNumTriesLeft(int installation_index) {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->GetInstallationNumTriesLeft(
+ return g_installation_manager_->GetInstallationNumTriesLeft(
installation_index);
}
int ImDecrementInstallationNumTries(int installation_index) {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->DecrementInstallationNumTries(
+ return g_installation_manager_->DecrementInstallationNumTries(
installation_index);
}
int ImGetCurrentInstallationIndex() {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->GetCurrentInstallationIndex();
+ return g_installation_manager_->GetCurrentInstallationIndex();
+}
+
+int ImResetInstallation(int installation_index) {
+ starboard::ScopedLock lock(*GetImMutex());
+ return g_installation_manager_->ResetInstallation(installation_index);
}
int ImSelectNewInstallationIndex() {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->SelectNewInstallationIndex();
+ return g_installation_manager_->SelectNewInstallationIndex();
}
int ImGetInstallationPath(int installation_index, char* path, int path_length) {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->GetInstallationPath(installation_index, path,
- path_length);
+ return g_installation_manager_->GetInstallationPath(installation_index, path,
+ path_length);
}
int ImMarkInstallationSuccessful(int installation_index) {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->MarkInstallationSuccessful(installation_index);
+ return g_installation_manager_->MarkInstallationSuccessful(
+ installation_index);
}
int ImRollForwardIfNeeded() {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->RollForwardIfNeeded();
+ return g_installation_manager_->RollForwardIfNeeded();
+}
+
+int ImRollForward(int installation_index) {
+ starboard::ScopedLock lock(*GetImMutex());
+ return g_installation_manager_->RollForward(installation_index);
}
int ImRevertToSuccessfulInstallation() {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->RevertToSuccessfulInstallation();
+ return g_installation_manager_->RevertToSuccessfulInstallation();
}
int ImRequestRollForwardToInstallation(int installation_index) {
starboard::ScopedLock lock(*GetImMutex());
- return g_istallation_manager_->RequestRollForwardToInstallation(
+ return g_installation_manager_->RequestRollForwardToInstallation(
installation_index);
}
diff --git a/src/starboard/loader_app/installation_manager.gyp b/src/starboard/loader_app/installation_manager.gyp
index bff8131..6e8af54 100644
--- a/src/starboard/loader_app/installation_manager.gyp
+++ b/src/starboard/loader_app/installation_manager.gyp
@@ -12,8 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# This files contains all targets that should be created by gyp_cobalt by
-# default.
{
'targets': [
{
diff --git a/src/starboard/loader_app/installation_manager.h b/src/starboard/loader_app/installation_manager.h
index 740d647..e2abb4e 100644
--- a/src/starboard/loader_app/installation_manager.h
+++ b/src/starboard/loader_app/installation_manager.h
@@ -31,8 +31,13 @@
#define IM_SUCCESS 0
#define IM_ERROR -1
-// The filename for the Installation Manager store file.
-#define IM_STORE_FILE_NAME "installation_store.pb"
+#define MAX_APP_KEY_LENGTH 1024
+
+// The filename prefix for the Installation Manager store file.
+#define IM_STORE_FILE_NAME_PREFIX "installation_store_"
+
+// The filename suffix for the Installation Manager store file.
+#define IM_STORE_FILE_NAME_SUFFIX ".pb"
// The max size in bytes of the store file.
#define IM_MAX_INSTALLATION_STORE_SIZE 1024 * 1024
@@ -47,16 +52,28 @@
// already cached in memory.
// Initializes the Installation Manager with the
-// max number of installations.
+// max number of installations and with an app specific key.
// If the store doesn't exist an initial store would be
// created. A subsequent call to |ImUninitialize| without
// corresponding |ImUninitialize| will fail.
// Returns IM_SUCCESS on success and IM_ERROR on error.
-int ImInitialize(int max_num_installations);
+int ImInitialize(int max_num_installations, const char* app_key);
+
+// Retrieves the application key.
+// Returns IM_SUCCESS on success and IM_ERROR on error.
+int ImGetAppKey(char* app_key, int app_key_length);
+
+// Retrieves the max number of installation slots.
+// Returns IM_SUCCESS on success and IM_ERROR on error.
+int ImGetMaxNumberInstallations();
// Uninitialize the Installation Manager.
void ImUninitialize();
+// Resets the Installation Manager and clear all state.
+// Returns IM_SUCCESS on success and IM_ERROR on error.
+int ImReset();
+
// Gets the status of the |installation_index| installation.
// Returns |IM_INSTALLATION_STATUS_SUCCESS| if the installation is successful.
// Returns |IM_INSTALLATION_STATUS_NOT_SUCCESS| if the installation is not
@@ -75,6 +92,10 @@
// Returns |IM_ERROR| on error.
int ImGetCurrentInstallationIndex();
+// Resets the slot for index |installation_index|.
+// Returns |IM_ERROR| on error.
+int ImResetInstallation(int installation_index);
+
// Selects a new installation index and prepares the installation
// slot for new installation use.
// Returns |IM_ERROR| on error.
@@ -94,6 +115,10 @@
// Returns IM_SUCCESS on success and IM_ERROR on error.
int ImRollForwardIfNeeded();
+// Rolls forward to the slot at |installation_index|.
+// Returns IM_SUCCESS on success and IM_ERROR on error.
+int ImRollForward(int installation_index);
+
// Revert to a previous successful installation.
// Returns the installation to which it was reverted.
// Returns |IM_ERROR| on error.
diff --git a/src/starboard/loader_app/installation_manager_test.cc b/src/starboard/loader_app/installation_manager_test.cc
index 98dec2f..519586c 100644
--- a/src/starboard/loader_app/installation_manager_test.cc
+++ b/src/starboard/loader_app/installation_manager_test.cc
@@ -21,7 +21,7 @@
#include "starboard/loader_app/installation_store.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
-#if SB_API_VERSION >= 12 && SB_API_VERSION >= 12
+#if SB_API_VERSION >= 12
#define NUMBER_INSTALLS_PARAMS ::testing::Values(2, 3, 4, 5, 6)
@@ -31,6 +31,8 @@
namespace {
+const char* kAppKey = "test_app_key";
+
class InstallationManagerTest : public ::testing::TestWithParam<int> {
protected:
virtual void SetUp() {
@@ -48,7 +50,9 @@
installation_store_path_ = storage_path_;
installation_store_path_ += kSbFileSepString;
- installation_store_path_ += IM_STORE_FILE_NAME;
+ installation_store_path_ += IM_STORE_FILE_NAME_PREFIX;
+ installation_store_path_ += kAppKey;
+ installation_store_path_ += IM_STORE_FILE_NAME_SUFFIX;
}
void SaveStorageState(
@@ -98,7 +102,7 @@
SaveStorageState(installation_store);
- ASSERT_EQ(IM_SUCCESS, ImInitialize(max_num_installations));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(max_num_installations, kAppKey));
ASSERT_EQ(IM_SUCCESS, ImRequestRollForwardToInstallation(index));
ASSERT_EQ(IM_SUCCESS, ImRollForwardIfNeeded());
ASSERT_EQ(index, ImGetCurrentInstallationIndex());
@@ -138,7 +142,7 @@
SaveStorageState(installation_store);
- ASSERT_EQ(IM_SUCCESS, ImInitialize(max_num_installations));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(max_num_installations, kAppKey));
int result = ImRevertToSuccessfulInstallation();
if (!expected_succeed) {
ASSERT_EQ(IM_ERROR, result);
@@ -202,34 +206,94 @@
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
ImUninitialize();
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
+}
+
+TEST_P(InstallationManagerTest, Reset) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ int max_num_installations = GetParam();
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(max_num_installations, kAppKey));
+ ASSERT_EQ(0, ImGetCurrentInstallationIndex());
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(1));
+ ASSERT_EQ(1, ImGetCurrentInstallationIndex());
+ std::vector<std::string> created_files;
+ for (int i = 1; i < max_num_installations - 1; i++) {
+ std::vector<char> buf(kSbFileMaxPath);
+ ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(i, buf.data(), kSbFileMaxPath));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(i));
+ std::string slot_path = buf.data();
+ slot_path += kSbFileSepString;
+ slot_path += "test_dir";
+ SbDirectoryCreate(slot_path.c_str());
+ slot_path += kSbFileSepString;
+ slot_path += "test_file";
+ created_files.push_back(slot_path);
+ SbFileError file_error = kSbFileOk;
+ starboard::ScopedFile file(slot_path.c_str(),
+ kSbFileCreateAlways | kSbFileWrite, NULL,
+ &file_error);
+ ASSERT_TRUE(file.IsValid());
+ }
+ ASSERT_EQ(IM_SUCCESS, ImReset());
+ ASSERT_EQ(0, ImGetCurrentInstallationIndex());
+ for (auto& f : created_files) {
+ ASSERT_TRUE(!SbFileExists(f.c_str()));
+ }
+ for (int i = 1; i < max_num_installations - 1; i++) {
+ std::vector<char> buf(kSbFileMaxPath);
+ ASSERT_EQ(IM_INSTALLATION_STATUS_NOT_SUCCESS, ImGetInstallationStatus(i));
+ ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(i, buf.data(), kSbFileMaxPath));
+ ASSERT_TRUE(SbFileExists(buf.data()));
+ }
+}
+
+TEST_P(InstallationManagerTest, GetAppKey) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+
+ char app_key[MAX_APP_KEY_LENGTH];
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
+ ASSERT_EQ(IM_SUCCESS, ImGetAppKey(app_key, MAX_APP_KEY_LENGTH));
+ ASSERT_EQ(0, SbStringCompare(kAppKey, app_key, MAX_APP_KEY_LENGTH));
+}
+
+TEST_P(InstallationManagerTest, GetMaxNumInstallations) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
+ ASSERT_EQ(GetParam(), ImGetMaxNumberInstallations());
}
TEST_P(InstallationManagerTest, DefaultInstallationSuccessful) {
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
- ASSERT_EQ(IM_INSTALLATION_STATUS_NOT_SUCCESS, ImGetInstallationStatus(0));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
+ ASSERT_EQ(IM_INSTALLATION_STATUS_SUCCESS, ImGetInstallationStatus(0));
}
TEST_P(InstallationManagerTest, MarkInstallationSuccessful) {
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
- ASSERT_EQ(IM_INSTALLATION_STATUS_NOT_SUCCESS, ImGetInstallationStatus(0));
- ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(0));
- ASSERT_EQ(IM_INSTALLATION_STATUS_SUCCESS, ImGetInstallationStatus(0));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
+ ASSERT_EQ(IM_INSTALLATION_STATUS_NOT_SUCCESS, ImGetInstallationStatus(1));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(1));
+ ASSERT_EQ(IM_INSTALLATION_STATUS_SUCCESS, ImGetInstallationStatus(1));
}
TEST_P(InstallationManagerTest, DecrementInstallationNumTries) {
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
int max_num_tries = ImGetInstallationNumTriesLeft(0);
ASSERT_EQ(IM_SUCCESS, ImDecrementInstallationNumTries(0));
ASSERT_EQ(max_num_tries - 1, ImGetInstallationNumTriesLeft(0));
@@ -245,7 +309,7 @@
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
ASSERT_EQ(0, ImGetCurrentInstallationIndex());
}
@@ -253,12 +317,10 @@
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
int index = ImSelectNewInstallationIndex();
- if (GetParam() > 2) {
- for (int i = 0; i < 10; i++) {
- ASSERT_EQ(GetParam() > 2 ? GetParam() - 1 : 1, index);
- }
+ for (int i = 0; i < 10; i++) {
+ ASSERT_EQ(GetParam() - 1, index);
}
}
@@ -266,15 +328,9 @@
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
std::vector<char> buf0(kSbFileMaxPath);
ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(0, buf0.data(), kSbFileMaxPath));
- // For 3 or more slots the 0 index one is under the content directory,
- // which will not have the correct file path for a Cobalt binary when running
- // a test.
- if (GetParam() < 3) {
- ASSERT_TRUE(SbFileExists(buf0.data()));
- }
std::vector<char> buf1(kSbFileMaxPath);
ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(1, buf1.data(), kSbFileMaxPath));
ASSERT_TRUE(SbFileExists(buf1.data()));
@@ -284,20 +340,14 @@
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
ASSERT_EQ(IM_SUCCESS, ImRollForwardIfNeeded());
ASSERT_EQ(0, ImGetCurrentInstallationIndex());
- ASSERT_EQ(IM_SUCCESS, ImRequestRollForwardToInstallation(1));
- ASSERT_EQ(0, ImGetCurrentInstallationIndex());
- ASSERT_EQ(IM_SUCCESS, ImRollForwardIfNeeded());
- ASSERT_EQ(1, ImGetCurrentInstallationIndex());
- if (GetParam() > 2) {
- for (int i = 2; i < GetParam() - 1; i++) {
- ASSERT_EQ(IM_SUCCESS, ImRequestRollForwardToInstallation(i));
- ASSERT_EQ(i - 1, ImGetCurrentInstallationIndex());
- ASSERT_EQ(IM_SUCCESS, ImRollForwardIfNeeded());
- ASSERT_EQ(i, ImGetCurrentInstallationIndex());
- }
+ for (int i = 1; i < GetParam() - 1; i++) {
+ ASSERT_EQ(IM_SUCCESS, ImRequestRollForwardToInstallation(i));
+ ASSERT_EQ(i - 1, ImGetCurrentInstallationIndex());
+ ASSERT_EQ(IM_SUCCESS, ImRollForwardIfNeeded());
+ ASSERT_EQ(i, ImGetCurrentInstallationIndex());
}
for (int i = 0; i < 10; i++) {
int new_index = i % GetParam();
@@ -307,11 +357,40 @@
}
}
+TEST_P(InstallationManagerTest, RollForward) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ int max_num_installations = GetParam();
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(max_num_installations, kAppKey));
+ ASSERT_EQ(0, ImGetCurrentInstallationIndex());
+ for (int i = 1; i < max_num_installations - 1; i++) {
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(i));
+ ASSERT_EQ(i, ImGetCurrentInstallationIndex());
+ }
+ for (int i = 0; i < 10; i++) {
+ int new_index = i % max_num_installations;
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(new_index));
+ ASSERT_EQ(new_index, ImGetCurrentInstallationIndex());
+ }
+}
+
+TEST_P(InstallationManagerTest, ResetInstallation) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(1));
+ ASSERT_EQ(IM_INSTALLATION_STATUS_SUCCESS, ImGetInstallationStatus(1));
+ ASSERT_EQ(IM_SUCCESS, ImResetInstallation(1));
+ ASSERT_EQ(IM_INSTALLATION_STATUS_NOT_SUCCESS, ImGetInstallationStatus(1));
+}
+
TEST_P(InstallationManagerTest, RevertToSuccessfulInstallation) {
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam()));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(GetParam(), kAppKey));
ASSERT_EQ(0, ImGetCurrentInstallationIndex());
ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(0));
ASSERT_EQ(IM_SUCCESS, ImRequestRollForwardToInstallation(1));
@@ -328,7 +407,7 @@
if (!storage_path_implemented_) {
return;
}
- ASSERT_EQ(IM_SUCCESS, ImInitialize(3));
+ ASSERT_EQ(IM_SUCCESS, ImInitialize(3, kAppKey));
ASSERT_EQ(IM_INSTALLATION_STATUS_ERROR, ImGetInstallationStatus(10));
ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(0));
ASSERT_EQ(IM_INSTALLATION_STATUS_ERROR, ImGetInstallationStatus(-2));
@@ -550,5 +629,4 @@
} // namespace loader_app
} // namespace starboard
-#endif // SB_API_VERSION >= 12 && SB_API_VERSION >=
- // 12
+#endif // SB_API_VERSION >= 12
diff --git a/src/starboard/loader_app/loader_app.cc b/src/starboard/loader_app/loader_app.cc
index 4e8abc7..c74437f 100644
--- a/src/starboard/loader_app/loader_app.cc
+++ b/src/starboard/loader_app/loader_app.cc
@@ -18,28 +18,29 @@
#include "starboard/configuration.h"
#include "starboard/configuration_constants.h"
#include "starboard/elf_loader/elf_loader.h"
+#include "starboard/elf_loader/evergreen_info.h"
#include "starboard/event.h"
-#include "starboard/loader_app/installation_manager.h"
+#include "starboard/file.h"
+#include "starboard/loader_app/app_key.h"
+#include "starboard/loader_app/loader_app_switches.h"
+#include "starboard/loader_app/slot_management.h"
#include "starboard/loader_app/system_get_extension_shim.h"
#include "starboard/mutex.h"
+#include "starboard/shared/starboard/command_line.h"
#include "starboard/string.h"
#include "starboard/thread_types.h"
-
-// TODO: Try to merge with the implementation in starboard/elf_loader/sandbox.cc
+#include "third_party/crashpad/wrapper/wrapper.h"
namespace {
-// The max number of installations slots.
-const int kMaxNumInstallations = 2;
-// Relative path for the Cobalt so file.
-const char kCobaltLibraryPath[] = "lib";
+// Relative path to the Cobalt's system image content path.
+const char kSystemImageContentPath[] = "app/cobalt/content";
-// Filename for the Cobalt binary.
-const char kCobaltLibraryName[] = "libcobalt.so";
+// Relative path to the Cobalt's system image library.
+const char kSystemImageLibraryPath[] = "app/cobalt/lib/libcobalt.so";
-// Relative path for the content directory of
-// the Cobalt installation.
-const char kCobaltContentPath[] = "content";
+// Cobalt default URL.
+const char kCobaltDefaultUrl[] = "https://www.youtube.com/tv";
// Portable ELF loader.
starboard::elf_loader::ElfLoader g_elf_loader;
@@ -48,107 +49,78 @@
// Cobalt binary.
void (*g_sb_event_func)(const SbEvent*) = NULL;
-void LoadLibraryAndInitialize() {
- // Initialize the Installation Manager.
- SB_CHECK(ImInitialize(kMaxNumInstallations) == IM_SUCCESS)
- << "Abort. Failed to initialize Installation Manager";
-
- // Roll forward if needed.
- if (ImRollForwardIfNeeded() == IM_ERROR) {
- SB_LOG(WARNING) << "Failed to roll forward";
+class CobaltLibraryLoader : public starboard::loader_app::LibraryLoader {
+ public:
+ virtual bool Load(const std::string& library_path,
+ const std::string& content_path) {
+ return g_elf_loader.Load(library_path, content_path, false,
+ &starboard::loader_app::SbSystemGetExtensionShim);
}
-
- // Loop by priority.
- int current_installation = ImGetCurrentInstallationIndex();
- while (current_installation != IM_ERROR) {
- // if not successful and num_tries_left > 0 decrement and try to
- // load the library.
- if (ImGetInstallationStatus(current_installation) !=
- IM_INSTALLATION_STATUS_SUCCESS) {
- int num_tries_left = ImGetInstallationNumTriesLeft(current_installation);
- if (num_tries_left == IM_ERROR || num_tries_left <= 0 ||
- ImDecrementInstallationNumTries(current_installation) == IM_ERROR) {
- // If no more tries are left or if we have hard failure,
- // discard the image and auto rollback, but only if
- // the current image is not the system image.
- if (current_installation != 0) {
- current_installation = ImRevertToSuccessfulInstallation();
- }
- }
- }
-
- SB_LOG(INFO) << "Try to load the Cobalt binary";
- SB_LOG(INFO) << "current_installation=" << current_installation;
-
- // Try to load the image. Failures here discard the image.
- std::vector<char> installation_path(kSbFileMaxPath);
- if (ImGetInstallationPath(current_installation, installation_path.data(),
- kSbFileMaxPath) == IM_ERROR) {
- SB_LOG(ERROR) << "Failed to find library file";
-
- // Hard failure. Discard the image and auto rollback, but only if
- // the current image is not the system image.
- if (current_installation != 0) {
- current_installation = ImRevertToSuccessfulInstallation();
- continue;
- } else {
- // The system image at index 0 failed.
- break;
- }
- }
-
- SB_DLOG(INFO) << "installation_path=" << installation_path.data();
-
- // installation_n/lib/libcobalt.so
- std::vector<char> lib_path(kSbFileMaxPath);
- SbStringFormatF(lib_path.data(), kSbFileMaxPath, "%s%s%s%s%s",
- installation_path.data(), kSbFileSepString,
- kCobaltLibraryPath, kSbFileSepString, kCobaltLibraryName);
- SB_LOG(INFO) << "lib_path=" << lib_path.data();
-
- // installation_n/content
- std::vector<char> content_path(kSbFileMaxPath);
- SbStringFormatF(content_path.data(), kSbFileMaxPath, "%s%s%s",
- installation_path.data(), kSbFileSepString,
- kCobaltContentPath);
- SB_LOG(INFO) << "content_path=" << content_path.data();
-
- if (!g_elf_loader.Load(lib_path.data(), content_path.data(), false,
- &starboard::loader_app::SbSystemGetExtensionShim)) {
- SB_LOG(WARNING) << "Failed to load Cobalt!";
-
- // Hard failure. Discard the image and auto rollback, but only if
- // the current image is not the system image.
- if (current_installation != 0) {
- current_installation = ImRevertToSuccessfulInstallation();
- continue;
- } else {
- // The system image at index 0 failed.
- break;
- }
- }
-
- SB_DLOG(INFO) << "Successfully loaded Cobalt!\n";
- void* p = g_elf_loader.LookupSymbol("SbEventHandle");
- if (p != NULL) {
- SB_DLOG(INFO) << "Symbol Lookup succeeded address: " << p;
- g_sb_event_func = (void (*)(const SbEvent*))p;
- break;
- } else {
- SB_LOG(ERROR) << "Symbol Lookup failed\n";
-
- // Hard failure. Discard the image and auto rollback, but only if
- // the current image is not the system image.
- if (current_installation != 0) {
- current_installation = ImRevertToSuccessfulInstallation();
- continue;
- } else {
- // The system image at index 0 failed.
- break;
- }
- }
+ virtual void* Resolve(const std::string& symbol) {
+ return g_elf_loader.LookupSymbol(symbol.c_str());
}
+};
+
+CobaltLibraryLoader g_cobalt_library_loader;
+
+bool GetContentDir(std::string* content) {
+ std::vector<char> content_dir(kSbFileMaxPath);
+ if (!SbSystemGetPath(kSbSystemPathContentDirectory, content_dir.data(),
+ kSbFileMaxPath)) {
+ return false;
+ }
+ *content = content_dir.data();
+ return true;
}
+
+void LoadLibraryAndInitialize(const std::string& alternative_content_path) {
+ std::string content_dir;
+ if (!GetContentDir(&content_dir)) {
+ SB_LOG(ERROR) << "Failed to get the content dir";
+ return;
+ }
+ std::string content_path;
+ if (alternative_content_path.empty()) {
+ content_path = content_dir;
+ content_path += kSbFileSepString;
+ content_path += kSystemImageContentPath;
+ } else {
+ content_path = alternative_content_path.c_str();
+ }
+ std::string library_path = content_dir;
+ library_path += kSbFileSepString;
+ library_path += kSystemImageLibraryPath;
+
+ if (!g_elf_loader.Load(library_path, content_path, false)) {
+ SB_NOTREACHED() << "Failed to load library at '"
+ << g_elf_loader.GetLibraryPath() << "'.";
+ return;
+ }
+
+ SB_LOG(INFO) << "Successfully loaded '" << g_elf_loader.GetLibraryPath()
+ << "'.";
+
+ EvergreenInfo evergreen_info;
+ GetEvergreenInfo(&evergreen_info);
+ if (!third_party::crashpad::wrapper::AddEvergreenInfoToCrashpad(
+ evergreen_info)) {
+ SB_LOG(ERROR) << "Could not send Cobalt library information into Crashapd.";
+ } else {
+ SB_LOG(INFO) << "Loaded Cobalt library information into Crashpad.";
+ }
+
+ g_sb_event_func = reinterpret_cast<void (*)(const SbEvent*)>(
+ g_elf_loader.LookupSymbol("SbEventHandle"));
+
+ if (!g_sb_event_func) {
+ SB_LOG(ERROR) << "Failed to find SbEventHandle.";
+ return;
+ }
+
+ SB_LOG(INFO) << "Found SbEventHandle at address: "
+ << reinterpret_cast<void*>(g_sb_event_func);
+}
+
} // namespace
void SbEventHandle(const SbEvent* event) {
@@ -156,12 +128,41 @@
SB_CHECK(SbMutexAcquire(&mutex) == kSbMutexAcquired);
- if (!g_sb_event_func) {
- LoadLibraryAndInitialize();
+ if (!g_sb_event_func && (event->type == kSbEventTypeStart ||
+ event->type == kSbEventTypePreload)) {
+ const SbEventStartData* data = static_cast<SbEventStartData*>(event->data);
+ const starboard::shared::starboard::CommandLine command_line(
+ data->argument_count, const_cast<const char**>(data->argument_values));
+
+ bool disable_updates =
+ command_line.HasSwitch(starboard::loader_app::kDisableUpdates);
+ SB_LOG(INFO) << "disable_updates=" << disable_updates;
+
+ std::string alternative_content =
+ command_line.GetSwitchValue(starboard::loader_app::kContent);
+ SB_LOG(INFO) << "alternative_content=" << alternative_content;
+
+ if (disable_updates) {
+ LoadLibraryAndInitialize(alternative_content);
+ } else {
+ std::string url =
+ command_line.GetSwitchValue(starboard::loader_app::kURL);
+ if (url.empty()) {
+ url = "https://www.youtube.com/tv";
+ }
+ std::string app_key = starboard::loader_app::GetAppKey(url);
+ SB_CHECK(!app_key.empty());
+
+ g_sb_event_func = reinterpret_cast<void (*)(const SbEvent*)>(
+ starboard::loader_app::LoadSlotManagedLibrary(
+ app_key, alternative_content, &g_cobalt_library_loader));
+ }
SB_CHECK(g_sb_event_func);
}
- g_sb_event_func(event);
+ if (g_sb_event_func != NULL) {
+ g_sb_event_func(event);
+ }
SB_CHECK(SbMutexRelease(&mutex) == true);
}
diff --git a/src/starboard/loader_app/loader_app.gyp b/src/starboard/loader_app/loader_app.gyp
index 0c2adfd..154cb61 100644
--- a/src/starboard/loader_app/loader_app.gyp
+++ b/src/starboard/loader_app/loader_app.gyp
@@ -12,18 +12,20 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# This files contains all targets that should be created by gyp_cobalt by
-# default.
{
'variables': {
'common_loader_app_sources': [
- 'loader_app.cc',
- 'system_get_extension_shim.h',
- 'system_get_extension_shim.cc',
+ 'loader_app.cc',
+ 'loader_app_switches.h',
+ 'loader_app_switches.cc',
+ 'system_get_extension_shim.h',
+ 'system_get_extension_shim.cc',
],
'common_loader_app_dependencies': [
- '<(DEPTH)/starboard/loader_app/installation_manager.gyp:installation_manager',
- '<(DEPTH)/starboard/starboard.gyp:starboard',
+ '<(DEPTH)/starboard/loader_app/app_key.gyp:app_key',
+ '<(DEPTH)/starboard/loader_app/installation_manager.gyp:installation_manager',
+ '<(DEPTH)/starboard/loader_app/slot_management.gyp:slot_management',
+ '<(DEPTH)/starboard/starboard.gyp:starboard',
],
},
'targets': [
diff --git a/src/starboard/loader_app/loader_app_switches.cc b/src/starboard/loader_app/loader_app_switches.cc
new file mode 100644
index 0000000..c48da31
--- /dev/null
+++ b/src/starboard/loader_app/loader_app_switches.cc
@@ -0,0 +1,25 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/loader_app_switches.h"
+
+namespace starboard {
+namespace loader_app {
+
+const char kContent[] = "content";
+const char kURL[] = "url";
+const char kDisableUpdates[] = "disable_updates";
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/loader_app_switches.h b/src/starboard/loader_app/loader_app_switches.h
new file mode 100644
index 0000000..c051ba4
--- /dev/null
+++ b/src/starboard/loader_app/loader_app_switches.h
@@ -0,0 +1,38 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_LOADER_APP_SWITCHES_H_
+#define STARBOARD_LOADER_APP_LOADER_APP_SWITCHES_H_
+
+#include "starboard/configuration.h"
+
+namespace starboard {
+namespace loader_app {
+
+// Absolute path to the alternative content directory to be used.
+// The flags allows for system apps with content defined on the
+// device which is not part of the Evergreen updates.
+extern const char kContent[];
+
+// Initial URL for the web app.
+// If not specified the default is to load the YouTube main app.
+extern const char kURL[];
+
+// Disables Cobalt updates for the app.
+extern const char kDisableUpdates[];
+
+} // namespace loader_app
+} // namespace starboard
+
+#endif // STARBOARD_LOADER_APP_LOADER_APP_SWITCHES_H_
diff --git a/src/starboard/loader_app/slot_management.cc b/src/starboard/loader_app/slot_management.cc
new file mode 100644
index 0000000..3b576ab
--- /dev/null
+++ b/src/starboard/loader_app/slot_management.cc
@@ -0,0 +1,258 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/slot_management.h"
+
+#include <vector>
+
+#include "starboard/common/log.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/event.h"
+#include "starboard/file.h"
+#include "starboard/loader_app/app_key_files.h"
+#include "starboard/loader_app/drain_file.h"
+#include "starboard/loader_app/installation_manager.h"
+#include "starboard/string.h"
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+// The max number of installations slots.
+const int kMaxNumInstallations = 3;
+
+// Relative path for the Cobalt so file.
+const char kCobaltLibraryPath[] = "lib";
+
+// Filename for the Cobalt binary.
+const char kCobaltLibraryName[] = "libcobalt.so";
+
+// Relative path for the content directory of
+// the Cobalt installation.
+const char kCobaltContentPath[] = "content";
+
+} // namespace
+
+int RevertBack(int current_installation, const std::string& app_key) {
+ SB_LOG(INFO) << "RevertBack current_installation=" << current_installation;
+ SB_DCHECK(current_installation != 0);
+ std::vector<char> installation_path(kSbFileMaxPath);
+ if (ImGetInstallationPath(current_installation, installation_path.data(),
+ kSbFileMaxPath) != IM_ERROR) {
+ std::string bad_app_key_file_path =
+ starboard::loader_app::GetBadAppKeyFilePath(installation_path.data(),
+ app_key);
+ if (bad_app_key_file_path.empty()) {
+ SB_LOG(WARNING) << "Failed to get bad app key file path for path="
+ << installation_path.data() << " and app_key=" << app_key;
+ } else {
+ if (!starboard::loader_app::CreateAppKeyFile(bad_app_key_file_path)) {
+ SB_LOG(WARNING) << "Failed to create bad app key file: "
+ << bad_app_key_file_path;
+ }
+ }
+ } else {
+ SB_LOG(WARNING) << "Failed to get installation path for index: "
+ << current_installation;
+ }
+ current_installation = ImRevertToSuccessfulInstallation();
+ return current_installation;
+}
+
+bool CheckBadFileExists(const char* installation_path, const char* app_key) {
+ std::string bad_app_key_file_path =
+ starboard::loader_app::GetBadAppKeyFilePath(installation_path, app_key);
+ SB_DCHECK(!bad_app_key_file_path.empty());
+ SB_LOG(INFO) << "bad_app_key_file_path: " << bad_app_key_file_path;
+ SB_LOG(INFO) << "bad_app_key_file_path SbFileExists: "
+ << SbFileExists(bad_app_key_file_path.c_str());
+ return !bad_app_key_file_path.empty() &&
+ SbFileExists(bad_app_key_file_path.c_str());
+}
+
+bool AdoptInstallation(int current_installation,
+ const char* installation_path,
+ const char* app_key) {
+ SB_LOG(INFO) << "AdoptInstallation: current_installation="
+ << current_installation
+ << " installation_path=" << installation_path
+ << " app_key=" << app_key;
+ // Check that a good file exists from at least one app before adopting.
+ if (!AnyGoodAppKeyFile(installation_path)) {
+ SB_LOG(ERROR) << "No good files present";
+ return false;
+ }
+ std::string good_app_key_file_path =
+ starboard::loader_app::GetGoodAppKeyFilePath(installation_path, app_key);
+ if (good_app_key_file_path.empty()) {
+ SB_LOG(WARNING) << "Failed to get good app key file path for app_key="
+ << app_key;
+ return false;
+ }
+
+ if (!SbFileExists(good_app_key_file_path.c_str())) {
+ if (!starboard::loader_app::CreateAppKeyFile(good_app_key_file_path)) {
+ SB_LOG(WARNING) << "Failed to create good app key file";
+ return false;
+ }
+ if (ImResetInstallation(current_installation) == IM_ERROR) {
+ return false;
+ }
+ if (ImRollForward(current_installation) == IM_ERROR) {
+ SB_LOG(WARNING) << "Failed to roll forward";
+ return false;
+ }
+ }
+ return true;
+}
+
+void* LoadSlotManagedLibrary(const std::string& app_key,
+ const std::string& alternative_content_path,
+ LibraryLoader* library_loader) {
+ // Initialize the Installation Manager.
+ SB_CHECK(ImInitialize(kMaxNumInstallations, app_key.c_str()) == IM_SUCCESS)
+ << "Abort. Failed to initialize Installation Manager";
+
+ // Roll forward if needed.
+ if (ImRollForwardIfNeeded() == IM_ERROR) {
+ SB_LOG(WARNING) << "Failed to roll forward";
+ }
+
+ // TODO: Try to simplify the loop.
+ // Loop by priority.
+ int current_installation = ImGetCurrentInstallationIndex();
+ while (current_installation != IM_ERROR) {
+ // if not successful and num_tries_left > 0 decrement and try to
+ // load the library.
+ if (ImGetInstallationStatus(current_installation) !=
+ IM_INSTALLATION_STATUS_SUCCESS) {
+ int num_tries_left = ImGetInstallationNumTriesLeft(current_installation);
+ if (num_tries_left == IM_ERROR || num_tries_left <= 0 ||
+ ImDecrementInstallationNumTries(current_installation) == IM_ERROR) {
+ SB_LOG(INFO) << "Out of retries";
+ // If no more tries are left or if we have hard failure,
+ // discard the image and auto rollback, but only if
+ // the current image is not the system image.
+ if (current_installation != 0) {
+ current_installation = RevertBack(current_installation, app_key);
+ }
+ }
+ }
+
+ SB_LOG(INFO) << "Try to load the Cobalt binary";
+ SB_LOG(INFO) << "current_installation=" << current_installation;
+
+ // Try to load the image. Failures here discard the image.
+ std::vector<char> installation_path(kSbFileMaxPath);
+ if (ImGetInstallationPath(current_installation, installation_path.data(),
+ kSbFileMaxPath) == IM_ERROR) {
+ SB_LOG(ERROR) << "Failed to find library file";
+
+ // Hard failure. Discard the image and auto rollback, but only if
+ // the current image is not the system image.
+ if (current_installation != 0) {
+ current_installation = RevertBack(current_installation, app_key);
+ continue;
+ } else {
+ // The system image at index 0 failed.
+ return NULL;
+ }
+ }
+
+ SB_DLOG(INFO) << "installation_path=" << installation_path.data();
+
+ if (current_installation != 0) {
+ // Cleanup expired drain files
+ DrainFileClear(installation_path.data(), app_key.c_str(), true);
+
+ // Check for bad file.
+ if (CheckBadFileExists(installation_path.data(), app_key.c_str())) {
+ SB_LOG(INFO) << "Bad app key file";
+ current_installation = RevertBack(current_installation, app_key);
+ continue;
+ }
+ // If the current installtion is in use by an updater roll back.
+ if (DrainFileDraining(installation_path.data(), "")) {
+ SB_LOG(INFO) << "Active slot draining";
+ current_installation = RevertBack(current_installation, app_key);
+ continue;
+ }
+ // Adopt installation performed from different app.
+ if (!AdoptInstallation(current_installation, installation_path.data(),
+ app_key.c_str())) {
+ SB_LOG(INFO) << "Unable to adopt installation";
+ current_installation = RevertBack(current_installation, app_key);
+ continue;
+ }
+ }
+
+ // installation_n/lib/libcobalt.so
+ std::vector<char> lib_path(kSbFileMaxPath);
+ SbStringFormatF(lib_path.data(), kSbFileMaxPath, "%s%s%s%s%s",
+ installation_path.data(), kSbFileSepString,
+ kCobaltLibraryPath, kSbFileSepString, kCobaltLibraryName);
+ SB_LOG(INFO) << "lib_path=" << lib_path.data();
+
+ std::string content;
+ if (alternative_content_path.empty()) {
+ // installation_n/content
+ std::vector<char> content_path(kSbFileMaxPath);
+ SbStringFormatF(content_path.data(), kSbFileMaxPath, "%s%s%s",
+ installation_path.data(), kSbFileSepString,
+ kCobaltContentPath);
+ content = content_path.data();
+ } else {
+ content = alternative_content_path.c_str();
+ }
+
+ SB_LOG(INFO) << "content=" << content;
+
+ if (!library_loader->Load(lib_path.data(), content.c_str())) {
+ SB_LOG(WARNING) << "Failed to load Cobalt!";
+
+ // Hard failure. Discard the image and auto rollback, but only if
+ // the current image is not the system image.
+ if (current_installation != 0) {
+ current_installation = RevertBack(current_installation, app_key);
+ continue;
+ } else {
+ // The system image at index 0 failed.
+ return NULL;
+ }
+ }
+
+ SB_DLOG(INFO) << "Successfully loaded Cobalt!\n";
+ void* p = library_loader->Resolve("SbEventHandle");
+ if (p != NULL) {
+ SB_DLOG(INFO) << "Symbol Lookup succeeded address: " << p;
+ return p;
+ } else {
+ SB_LOG(ERROR) << "Symbol Lookup failed\n";
+
+ // Hard failure. Discard the image and auto rollback, but only if
+ // the current image is not the system image.
+ if (current_installation != 0) {
+ current_installation = RevertBack(current_installation, app_key);
+ continue;
+ } else {
+ // The system image at index 0 failed.
+ return NULL;
+ }
+ }
+ }
+ return NULL;
+}
+
+} // namespace loader_app
+} // namespace starboard
diff --git a/src/starboard/loader_app/slot_management.gyp b/src/starboard/loader_app/slot_management.gyp
new file mode 100644
index 0000000..d68c502
--- /dev/null
+++ b/src/starboard/loader_app/slot_management.gyp
@@ -0,0 +1,56 @@
+# Copyright 2020 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{
+ 'targets': [
+ {
+ 'target_name': 'slot_management',
+ 'type': 'static_library',
+ 'sources': [
+ 'slot_management.cc',
+ 'slot_management.h',
+ ],
+ 'dependencies': [
+ '<(DEPTH)/starboard/loader_app/app_key_files.gyp:app_key_files',
+ '<(DEPTH)/starboard/loader_app/drain_file.gyp:drain_file',
+ '<(DEPTH)/starboard/loader_app/installation_manager.gyp:installation_manager',
+ '<(DEPTH)/starboard/starboard.gyp:starboard',
+ ],
+ },
+ {
+ 'target_name': 'slot_management_test',
+ 'type': '<(gtest_target_type)',
+ 'sources': [
+ 'slot_management_test.cc',
+ '<(DEPTH)/starboard/common/test_main.cc',
+ ],
+ 'dependencies': [
+ ':slot_management',
+ '<(DEPTH)/testing/gmock.gyp:gmock',
+ '<(DEPTH)/testing/gtest.gyp:gtest',
+ ],
+ },
+ {
+ 'target_name': 'slot_management_test_deploy',
+ 'type': 'none',
+ 'dependencies': [
+ 'slot_management_test',
+ ],
+ 'variables': {
+ 'executable_name': 'slot_management_test',
+ },
+ 'includes': [ '<(DEPTH)/starboard/build/deploy.gypi' ],
+ },
+ ],
+}
diff --git a/src/starboard/loader_app/slot_management.h b/src/starboard/loader_app/slot_management.h
new file mode 100644
index 0000000..6451156
--- /dev/null
+++ b/src/starboard/loader_app/slot_management.h
@@ -0,0 +1,50 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef STARBOARD_LOADER_APP_SLOT_MANAGEMENT_H_
+#define STARBOARD_LOADER_APP_SLOT_MANAGEMENT_H_
+
+#include <string>
+
+namespace starboard {
+namespace loader_app {
+
+// Interface for loading a library.
+class LibraryLoader {
+ public:
+ virtual ~LibraryLoader() {}
+
+ // Load the library with the provided full path to |library_path| and
+ // |content_path|.
+ virtual bool Load(const std::string& library_path,
+ const std::string& content_path) = 0;
+
+ // Resolve a symbol by name.
+ virtual void* Resolve(const std::string& symbol) = 0;
+};
+
+// Load the library for the app specified by |app_key| and manage the
+// current slot selection by rolling forward or back based on the slot status.
+// The actual loading from the slot is peformed by the |library_loader|.
+// An alternative content can be used by specifying non-empty
+// |alternative_content_path| with the full path to the content.
+// Returns a pointer to the |SbEventHandle| symbol in the library.
+void* LoadSlotManagedLibrary(const std::string& app_key,
+ const std::string& alternative_content_path,
+ LibraryLoader* library_loader);
+
+} // namespace loader_app
+} // namespace starboard
+
+#endif // STARBOARD_LOADER_APP_SLOT_MANAGEMENT_H_
diff --git a/src/starboard/loader_app/slot_management_test.cc b/src/starboard/loader_app/slot_management_test.cc
new file mode 100644
index 0000000..4b7ea49
--- /dev/null
+++ b/src/starboard/loader_app/slot_management_test.cc
@@ -0,0 +1,273 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/loader_app/slot_management.h"
+
+#include <string>
+#include <vector>
+
+#include "gmock/gmock.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/event.h"
+#include "starboard/loader_app/app_key_files.h"
+#include "starboard/loader_app/drain_file.h"
+#include "starboard/loader_app/installation_manager.h"
+#include "starboard/loader_app/installation_store.pb.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#if SB_API_VERSION >= 12
+
+namespace starboard {
+namespace loader_app {
+namespace {
+
+const char kTestAppKey[] = "1234";
+const char kTestApp2Key[] = "ABCD";
+
+void SbEventFake(const SbEvent*) {}
+
+class MockLibraryLoader : public LibraryLoader {
+ public:
+ MOCK_METHOD2(Load,
+ bool(const std::string& library_path,
+ const std::string& content_path));
+ MOCK_METHOD1(Resolve, void*(const std::string& symbol));
+};
+
+class SlotManagementTest : public testing::Test {
+ protected:
+ virtual void SetUp() {
+ slot_0_libcobalt_path_ =
+ CreatePath({"content", "app", "cobalt", "lib", "libcobalt.so"});
+ slot_0_content_path_ = CreatePath({"content", "app", "cobalt", "content"});
+
+ slot_1_libcobalt_path_ =
+ CreatePath({"installation_1", "lib", "libcobalt.so"});
+ slot_1_content_path_ = CreatePath({"installation_1", "content"});
+
+ slot_2_libcobalt_path_ =
+ CreatePath({"installation_2", "lib", "libcobalt.so"});
+ slot_2_content_path_ = CreatePath({"installation_2", "content"});
+
+ std::vector<char> buf(kSbFileMaxPath);
+ storage_path_implemented_ = SbSystemGetPath(kSbSystemPathStorageDirectory,
+ buf.data(), kSbFileMaxPath);
+ }
+
+ std::string CreatePath(std::initializer_list<std::string> path_elements) {
+ std::string result;
+ for (const std::string& path : path_elements) {
+ result += kSbFileSepString;
+ result += path;
+ }
+ return result;
+ }
+
+ void CreateBadFile(int index, const std::string& app_key) {
+ std::vector<char> installation_path(kSbFileMaxPath);
+ ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(index, installation_path.data(),
+ kSbFileMaxPath));
+ std::string bad_app_key_file_path =
+ starboard::loader_app::GetBadAppKeyFilePath(installation_path.data(),
+ app_key);
+ ASSERT_TRUE(!bad_app_key_file_path.empty());
+ ASSERT_TRUE(starboard::loader_app::CreateAppKeyFile(bad_app_key_file_path));
+ }
+
+ void CreateGoodFile(int index, const std::string& app_key) {
+ std::vector<char> installation_path(kSbFileMaxPath);
+ ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(index, installation_path.data(),
+ kSbFileMaxPath));
+ std::string good_app_key_file_path =
+ starboard::loader_app::GetGoodAppKeyFilePath(installation_path.data(),
+ app_key);
+ ASSERT_TRUE(!good_app_key_file_path.empty());
+ ASSERT_TRUE(
+ starboard::loader_app::CreateAppKeyFile(good_app_key_file_path));
+ }
+
+ void VerifyGoodFile(int index, const std::string& app_key, bool exists) {
+ std::vector<char> installation_path(kSbFileMaxPath);
+ ImGetInstallationPath(index, installation_path.data(), kSbFileMaxPath);
+ std::string good_app_key_file_path =
+ starboard::loader_app::GetGoodAppKeyFilePath(installation_path.data(),
+ app_key);
+ ASSERT_TRUE(!good_app_key_file_path.empty());
+ ASSERT_EQ(exists, SbFileExists(good_app_key_file_path.c_str()));
+ }
+
+ void VerifyBadFile(int index, const std::string& app_key, bool exists) {
+ std::vector<char> installation_path(kSbFileMaxPath);
+ ImGetInstallationPath(index, installation_path.data(), kSbFileMaxPath);
+ std::string bad_app_key_file_path =
+ starboard::loader_app::GetBadAppKeyFilePath(installation_path.data(),
+ app_key);
+ ASSERT_TRUE(!bad_app_key_file_path.empty());
+ SB_LOG(INFO) << "bad_app_key_file_path=" << bad_app_key_file_path;
+ ASSERT_EQ(exists, SbFileExists(bad_app_key_file_path.c_str()));
+ }
+
+ void CreateDrainFile(int index, const std::string& app_key) {
+ std::vector<char> installation_path(kSbFileMaxPath);
+ ASSERT_EQ(IM_SUCCESS, ImGetInstallationPath(index, installation_path.data(),
+ kSbFileMaxPath));
+ ASSERT_TRUE(DrainFileTryDrain(installation_path.data(), app_key.c_str()));
+ }
+
+ void VerfyLoad(const std::string& lib, const std::string& content) {
+ MockLibraryLoader library_loader;
+
+ EXPECT_CALL(library_loader,
+ Load(testing::EndsWith(lib), testing::EndsWith(content)))
+ .Times(1)
+ .WillOnce(testing::Return(true));
+ EXPECT_CALL(library_loader, Resolve("SbEventHandle"))
+ .Times(1)
+ .WillOnce(testing::Return(reinterpret_cast<void*>(&SbEventFake)));
+ ASSERT_EQ(&SbEventFake,
+ LoadSlotManagedLibrary(kTestAppKey, "", &library_loader));
+ }
+
+ protected:
+ std::string slot_0_libcobalt_path_;
+ std::string slot_0_content_path_;
+ std::string slot_1_libcobalt_path_;
+ std::string slot_1_content_path_;
+ std::string slot_2_libcobalt_path_;
+ std::string slot_2_content_path_;
+ bool storage_path_implemented_;
+};
+
+TEST_F(SlotManagementTest, SystemSlot) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ImUninitialize();
+ VerfyLoad(slot_0_libcobalt_path_, slot_0_content_path_);
+ VerifyGoodFile(0, kTestAppKey, false);
+ VerifyBadFile(0, kTestAppKey, false);
+}
+
+TEST_F(SlotManagementTest, AdoptSlot) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(1));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(1));
+ ASSERT_EQ(1, ImGetCurrentInstallationIndex());
+
+ VerifyGoodFile(1, kTestAppKey, false);
+ CreateGoodFile(1, kTestApp2Key);
+ ImUninitialize();
+ VerfyLoad(slot_1_libcobalt_path_, slot_1_content_path_);
+ VerifyGoodFile(1, kTestAppKey, true);
+ VerifyBadFile(1, kTestAppKey, false);
+}
+
+TEST_F(SlotManagementTest, GoodSlot) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(2));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(2));
+ ASSERT_EQ(2, ImGetCurrentInstallationIndex());
+
+ CreateGoodFile(2, kTestAppKey);
+ ImUninitialize();
+ VerfyLoad(slot_2_libcobalt_path_, slot_2_content_path_);
+ VerifyGoodFile(2, kTestAppKey, true);
+ VerifyBadFile(2, kTestAppKey, false);
+}
+
+TEST_F(SlotManagementTest, NotAdoptSlot) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(2));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(2));
+ ASSERT_EQ(2, ImGetCurrentInstallationIndex());
+
+ VerifyGoodFile(2, kTestAppKey, false);
+ ImUninitialize();
+ VerfyLoad(slot_0_libcobalt_path_, slot_0_content_path_);
+ VerifyGoodFile(2, kTestAppKey, false);
+ VerifyBadFile(2, kTestAppKey, true);
+}
+
+TEST_F(SlotManagementTest, BadSlot) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(1));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(1));
+ ASSERT_EQ(1, ImGetCurrentInstallationIndex());
+ CreateBadFile(1, kTestAppKey);
+ ImUninitialize();
+ VerfyLoad(slot_0_libcobalt_path_, slot_0_content_path_);
+ VerifyGoodFile(1, kTestAppKey, false);
+}
+
+TEST_F(SlotManagementTest, DrainingSlot) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(1));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(1));
+ ASSERT_EQ(1, ImGetCurrentInstallationIndex());
+ CreateDrainFile(1, kTestApp2Key);
+ ImUninitialize();
+ VerfyLoad(slot_0_libcobalt_path_, slot_0_content_path_);
+ VerifyGoodFile(1, kTestAppKey, false);
+ VerifyBadFile(1, kTestAppKey, true);
+}
+
+TEST_F(SlotManagementTest, AlternativeContent) {
+ if (!storage_path_implemented_) {
+ return;
+ }
+ ImInitialize(3, kTestAppKey);
+ ImReset();
+ ASSERT_EQ(IM_SUCCESS, ImRollForward(1));
+ ASSERT_EQ(IM_SUCCESS, ImMarkInstallationSuccessful(1));
+ ASSERT_EQ(1, ImGetCurrentInstallationIndex());
+ ImUninitialize();
+
+ MockLibraryLoader library_loader;
+
+ EXPECT_CALL(library_loader, Load(testing::EndsWith(slot_0_libcobalt_path_),
+ testing::EndsWith("/foo")))
+ .Times(1)
+ .WillOnce(testing::Return(true));
+ EXPECT_CALL(library_loader, Resolve("SbEventHandle"))
+ .Times(1)
+ .WillOnce(testing::Return(reinterpret_cast<void*>(&SbEventFake)));
+ ASSERT_EQ(&SbEventFake,
+ LoadSlotManagedLibrary(kTestAppKey, "/foo", &library_loader));
+}
+} // namespace
+} // namespace loader_app
+} // namespace starboard
+#endif // #if SB_API_VERSION >= 12
diff --git a/src/starboard/loader_app/system_get_extension_shim.cc b/src/starboard/loader_app/system_get_extension_shim.cc
index 8017159..51553bd 100644
--- a/src/starboard/loader_app/system_get_extension_shim.cc
+++ b/src/starboard/loader_app/system_get_extension_shim.cc
@@ -31,6 +31,10 @@
&ImRequestRollForwardToInstallation,
&ImGetInstallationPath,
&ImSelectNewInstallationIndex,
+ &ImGetAppKey,
+ &ImGetMaxNumberInstallations,
+ &ImResetInstallation,
+ &ImReset,
};
} // namespace
namespace starboard {
diff --git a/src/starboard/media.h b/src/starboard/media.h
index df9b45f..bdafbe4 100644
--- a/src/starboard/media.h
+++ b/src/starboard/media.h
@@ -575,6 +575,8 @@
// Indicates whether output copy protection is currently enabled on all capable
// outputs. If |true|, then non-protection-capable outputs are expected to be
// blanked.
+//
+// presubmit: allow sb_export mismatch
SB_EXPORT bool SbMediaIsOutputProtected();
// Enables or disables output copy protection on all capable outputs. If
@@ -586,6 +588,8 @@
//
// |enabled|: Indicates whether output protection is enabled (|true|) or
// disabled.
+//
+// presubmit: allow sb_export mismatch
SB_EXPORT bool SbMediaSetOutputProtection(bool enabled);
#endif // SB_API_VERSION < 12
diff --git a/src/starboard/nplb/file_delete_recursive_test.cc b/src/starboard/nplb/file_delete_recursive_test.cc
new file mode 100644
index 0000000..fe894da
--- /dev/null
+++ b/src/starboard/nplb/file_delete_recursive_test.cc
@@ -0,0 +1,118 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <string>
+
+#include "starboard/common/file.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/directory.h"
+#include "starboard/file.h"
+#include "starboard/nplb/file_helpers.h"
+#include "starboard/types.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace starboard {
+namespace nplb {
+namespace {
+
+const size_t kDirectoryCount = 3;
+const size_t kFileCount = 3;
+
+const char kRoot[] = {"SbFileDeleteRecursiveTest"};
+
+const char* kDirectories[kDirectoryCount] = {
+ "", "test1", "test2",
+};
+
+const char* kFiles[kFileCount] = {
+ "file1", "test1/file2", "test2/file3",
+};
+
+TEST(SbFileDeleteRecursiveTest, SunnyDayDeleteExistingPath) {
+ std::string path;
+ const std::string& tmp = GetTempDir();
+
+ // Create the directory tree.
+ for (size_t i = 0; i < kDirectoryCount; ++i) {
+ path = tmp + kSbFileSepString + kRoot + kSbFileSepString + kDirectories[i];
+
+ EXPECT_FALSE(SbFileExists(path.c_str()));
+ EXPECT_TRUE(SbDirectoryCreate(path.c_str()));
+ EXPECT_TRUE(SbDirectoryCanOpen(path.c_str()));
+ }
+
+ SbFileError err = kSbFileOk;
+ SbFile file = kSbFileInvalid;
+
+ // Create files in our directory tree.
+ for (size_t i = 0; i < kFileCount; ++i) {
+ path = tmp + kSbFileSepString + kRoot + kSbFileSepString + kFiles[i];
+
+ EXPECT_FALSE(SbFileExists(path.c_str()));
+
+ file = SbFileOpen(path.c_str(), kSbFileCreateAlways | kSbFileWrite, NULL,
+ &err);
+
+ EXPECT_EQ(kSbFileOk, err);
+ EXPECT_TRUE(SbFileClose(file));
+ EXPECT_TRUE(SbFileExists(path.c_str()));
+ }
+
+ path = tmp + kSbFileSepString + kRoot;
+
+ EXPECT_TRUE(SbFileDeleteRecursive(path.c_str(), false));
+ EXPECT_FALSE(SbFileExists(path.c_str()));
+}
+
+TEST(SbFileDeleteRecursiveTest, SunnyDayDeletePreserveRoot) {
+ const std::string root = GetTempDir() + kSbFileSepString + kRoot;
+
+ EXPECT_FALSE(SbFileExists(root.c_str()));
+ EXPECT_TRUE(SbDirectoryCreate(root.c_str()));
+ EXPECT_TRUE(SbDirectoryCanOpen(root.c_str()));
+
+ EXPECT_TRUE(SbFileDeleteRecursive(root.c_str(), true));
+ EXPECT_TRUE(SbFileExists(root.c_str()));
+ EXPECT_TRUE(SbFileDeleteRecursive(root.c_str(), false));
+ EXPECT_FALSE(SbFileExists(root.c_str()));
+}
+
+TEST(SbFileDeleteRecursiveTest, RainyDayDeleteFileIgnoresPreserveRoot) {
+ const std::string& path = GetTempDir() + kSbFileSepString + "file1";
+
+ EXPECT_FALSE(SbFileExists(path.c_str()));
+
+ SbFileError err = kSbFileOk;
+ SbFile file = kSbFileInvalid;
+
+ file = SbFileOpen(path.c_str(), kSbFileCreateAlways | kSbFileWrite, NULL,
+ &err);
+
+ EXPECT_EQ(kSbFileOk, err);
+ EXPECT_TRUE(SbFileClose(file));
+ EXPECT_TRUE(SbFileExists(path.c_str()));
+ EXPECT_TRUE(SbFileDeleteRecursive(path.c_str(), true));
+ EXPECT_FALSE(SbFileExists(path.c_str()));
+}
+
+TEST(SbFileDeleteRecursiveTest, RainyDayNonExistentPathErrors) {
+ ScopedRandomFile file(ScopedRandomFile::kDontCreate);
+
+ EXPECT_FALSE(SbFileExists(file.filename().c_str()));
+ EXPECT_FALSE(SbFileDeleteRecursive(file.filename().c_str(), false));
+}
+
+} // namespace
+} // namespace nplb
+} // namespace starboard
diff --git a/src/starboard/nplb/nplb.gyp b/src/starboard/nplb/nplb.gyp
index d4e249c..8407b1de 100644
--- a/src/starboard/nplb/nplb.gyp
+++ b/src/starboard/nplb/nplb.gyp
@@ -128,6 +128,7 @@
'file_atomic_replace_test.cc',
'file_can_open_test.cc',
'file_close_test.cc',
+ 'file_delete_recursive_test.cc',
'file_get_info_test.cc',
'file_get_path_info_test.cc',
'file_helpers.cc',
diff --git a/src/starboard/nplb/nplb_evergreen_compat_tests/fonts_test.cc b/src/starboard/nplb/nplb_evergreen_compat_tests/fonts_test.cc
new file mode 100644
index 0000000..df9ba2b
--- /dev/null
+++ b/src/starboard/nplb/nplb_evergreen_compat_tests/fonts_test.cc
@@ -0,0 +1,52 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <string>
+#include <vector>
+
+#include "starboard/common/log.h"
+#include "starboard/configuration.h"
+#include "starboard/file.h"
+#include "starboard/nplb/nplb_evergreen_compat_tests/checks.h"
+#include "starboard/system.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#if SB_IS(EVERGREEN_COMPATIBLE)
+
+namespace starboard {
+namespace nplb {
+namespace nplb_evergreen_compat_tests {
+
+namespace {
+
+const char kFileName[] = "fonts.xml";
+
+TEST(FontsTest, VerifySystemFontsDirectory) {
+ std::vector<char> system_fonts_dir(kSbFileMaxPath);
+ ASSERT_TRUE(SbSystemGetPath(kSbSystemPathFontDirectory,
+ system_fonts_dir.data(), kSbFileMaxPath));
+
+ ASSERT_TRUE(SbFileExists(system_fonts_dir.data()));
+ std::string fonts_descriptor_file = system_fonts_dir.data();
+ fonts_descriptor_file += kSbFileSepString;
+ fonts_descriptor_file += kFileName;
+ ASSERT_TRUE(SbFileExists(fonts_descriptor_file.c_str()));
+}
+
+} // namespace
+} // namespace nplb_evergreen_compat_tests
+} // namespace nplb
+} // namespace starboard
+
+#endif // SB_IS(EVERGREEN_COMPATIBLE)
diff --git a/src/starboard/nplb/nplb_evergreen_compat_tests/icu_test.cc b/src/starboard/nplb/nplb_evergreen_compat_tests/icu_test.cc
new file mode 100644
index 0000000..53a99f6
--- /dev/null
+++ b/src/starboard/nplb/nplb_evergreen_compat_tests/icu_test.cc
@@ -0,0 +1,54 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <string>
+#include <vector>
+
+#include "starboard/common/log.h"
+#include "starboard/configuration.h"
+#include "starboard/file.h"
+#include "starboard/nplb/nplb_evergreen_compat_tests/checks.h"
+#include "starboard/system.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#if SB_IS(EVERGREEN_COMPATIBLE)
+
+namespace starboard {
+namespace nplb {
+namespace nplb_evergreen_compat_tests {
+
+namespace {
+
+const char kDirName[] = "icu";
+
+TEST(IcuTest, VerifyIcuDirectory) {
+ std::vector<char> storage_dir(kSbFileMaxPath);
+ ASSERT_TRUE(SbSystemGetPath(kSbSystemPathStorageDirectory, storage_dir.data(),
+ kSbFileMaxPath));
+
+ std::string icu_path = storage_dir.data();
+ icu_path += kSbFileSepString;
+ icu_path += kDirName;
+ ASSERT_TRUE(SbFileExists(icu_path.c_str()));
+ SbFileInfo info;
+ ASSERT_TRUE(SbFileGetPathInfo(icu_path.c_str(), &info));
+ ASSERT_TRUE(info.is_directory);
+}
+
+} // namespace
+} // namespace nplb_evergreen_compat_tests
+} // namespace nplb
+} // namespace starboard
+
+#endif // SB_IS(EVERGREEN_COMPATIBLE)
diff --git a/src/starboard/nplb/nplb_evergreen_compat_tests/max_file_name_test.cc b/src/starboard/nplb/nplb_evergreen_compat_tests/max_file_name_test.cc
new file mode 100644
index 0000000..28a0814
--- /dev/null
+++ b/src/starboard/nplb/nplb_evergreen_compat_tests/max_file_name_test.cc
@@ -0,0 +1,37 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "starboard/configuration.h"
+#include "starboard/configuration_constants.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#if SB_IS(EVERGREEN_COMPATIBLE)
+
+namespace starboard {
+namespace nplb {
+namespace nplb_evergreen_compat_tests {
+namespace {
+
+// Drain file names need to be able to contain the drain file prefix, the base64
+// encoded application key, and a timestamp to operate correctly.
+TEST(MaxFileNameTest, SunnyDay) {
+ ASSERT_LE(64, kSbFileMaxName);
+}
+
+} // namespace
+} // namespace nplb_evergreen_compat_tests
+} // namespace nplb
+} // namespace starboard
+
+#endif // SB_IS(EVERGREEN_COMPATIBLE)
diff --git a/src/starboard/nplb/nplb_evergreen_compat_tests/nplb_evergreen_compat_tests.gyp b/src/starboard/nplb/nplb_evergreen_compat_tests/nplb_evergreen_compat_tests.gyp
index bcca8be..1f56ace 100644
--- a/src/starboard/nplb/nplb_evergreen_compat_tests/nplb_evergreen_compat_tests.gyp
+++ b/src/starboard/nplb/nplb_evergreen_compat_tests/nplb_evergreen_compat_tests.gyp
@@ -20,6 +20,9 @@
'sources': [
'checks.h',
'executable_memory_test.cc',
+ 'fonts_test.cc',
+ 'icu_test.cc',
+ 'max_file_name_test.cc',
'sabi_test.cc',
'storage_test.cc',
'<(DEPTH)/starboard/common/test_main.cc',
diff --git a/src/starboard/raspi/2/skia/configuration.cc b/src/starboard/raspi/2/skia/configuration.cc
index d3af155..58a6f11 100644
--- a/src/starboard/raspi/2/skia/configuration.cc
+++ b/src/starboard/raspi/2/skia/configuration.cc
@@ -36,10 +36,6 @@
return "hardware";
}
-bool CobaltEnableJit() {
- return true;
-}
-
const CobaltExtensionConfigurationApi kConfigurationApi = {
kCobaltExtensionConfigurationName,
1,
@@ -64,7 +60,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&common::CobaltGcZealDefault,
&CobaltRasterizerType,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/raspi/shared/configuration.cc b/src/starboard/raspi/shared/configuration.cc
index a0587e8..b3a9f0b 100644
--- a/src/starboard/raspi/shared/configuration.cc
+++ b/src/starboard/raspi/shared/configuration.cc
@@ -30,11 +30,6 @@
int CobaltSkiaGlyphAtlasHeight() {
return 2048;
}
-
-bool CobaltEnableJit() {
- return true;
-}
-
const CobaltExtensionConfigurationApi kConfigurationApi = {
kCobaltExtensionConfigurationName,
1,
@@ -59,7 +54,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&common::CobaltGcZealDefault,
&common::CobaltRasterizerTypeDefault,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/raspi/shared/system_get_property.cc b/src/starboard/raspi/shared/system_get_property.cc
index 30c8fb0..6fa8f5d 100644
--- a/src/starboard/raspi/shared/system_get_property.cc
+++ b/src/starboard/raspi/shared/system_get_property.cc
@@ -20,7 +20,6 @@
#include <memory>
#include <string>
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
diff --git a/src/starboard/shared/ffmpeg/ffmpeg_audio_decoder_impl.cc b/src/starboard/shared/ffmpeg/ffmpeg_audio_decoder_impl.cc
index f4b931d..1acf595 100644
--- a/src/starboard/shared/ffmpeg/ffmpeg_audio_decoder_impl.cc
+++ b/src/starboard/shared/ffmpeg/ffmpeg_audio_decoder_impl.cc
@@ -18,7 +18,6 @@
#include "starboard/shared/ffmpeg/ffmpeg_audio_decoder_impl.h"
#include "starboard/audio_sink.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/memory.h"
diff --git a/src/starboard/shared/ffmpeg/ffmpeg_video_decoder_impl.cc b/src/starboard/shared/ffmpeg/ffmpeg_video_decoder_impl.cc
index 9c1f321..cba4c7e 100644
--- a/src/starboard/shared/ffmpeg/ffmpeg_video_decoder_impl.cc
+++ b/src/starboard/shared/ffmpeg/ffmpeg_video_decoder_impl.cc
@@ -17,7 +17,6 @@
#include "starboard/shared/ffmpeg/ffmpeg_video_decoder_impl.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/string.h"
#include "starboard/linux/shared/decode_target_internal.h"
#include "starboard/memory.h"
diff --git a/src/starboard/shared/libaom/aom_video_decoder.cc b/src/starboard/shared/libaom/aom_video_decoder.cc
index 23a63e6..bd99225 100644
--- a/src/starboard/shared/libaom/aom_video_decoder.cc
+++ b/src/starboard/shared/libaom/aom_video_decoder.cc
@@ -14,7 +14,6 @@
#include "starboard/shared/libaom/aom_video_decoder.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/linux/shared/decode_target_internal.h"
diff --git a/src/starboard/shared/libdav1d/dav1d_video_decoder.cc b/src/starboard/shared/libdav1d/dav1d_video_decoder.cc
index 6aee08e..384b38a 100644
--- a/src/starboard/shared/libdav1d/dav1d_video_decoder.cc
+++ b/src/starboard/shared/libdav1d/dav1d_video_decoder.cc
@@ -16,7 +16,6 @@
#include <string>
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/memory.h"
diff --git a/src/starboard/shared/libde265/de265_video_decoder.cc b/src/starboard/shared/libde265/de265_video_decoder.cc
index 87fefcb..46f9569 100644
--- a/src/starboard/shared/libde265/de265_video_decoder.cc
+++ b/src/starboard/shared/libde265/de265_video_decoder.cc
@@ -14,7 +14,7 @@
#include "starboard/shared/libde265/de265_video_decoder.h"
-#include "starboard/common/format_string.h"
+#include "starboard/common/string.h"
#include "starboard/linux/shared/decode_target_internal.h"
#include "starboard/shared/libde265/de265_library_loader.h"
#include "starboard/string.h"
diff --git a/src/starboard/shared/libvpx/vpx_video_decoder.cc b/src/starboard/shared/libvpx/vpx_video_decoder.cc
index be2a918..3518c79 100644
--- a/src/starboard/shared/libvpx/vpx_video_decoder.cc
+++ b/src/starboard/shared/libvpx/vpx_video_decoder.cc
@@ -14,7 +14,6 @@
#include "starboard/shared/libvpx/vpx_video_decoder.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/string.h"
#include "starboard/linux/shared/decode_target_internal.h"
#include "starboard/shared/libvpx/vpx_library_loader.h"
diff --git a/src/starboard/shared/opus/opus_audio_decoder.cc b/src/starboard/shared/opus/opus_audio_decoder.cc
index cf7b132..0ac7a17 100644
--- a/src/starboard/shared/opus/opus_audio_decoder.cc
+++ b/src/starboard/shared/opus/opus_audio_decoder.cc
@@ -14,7 +14,6 @@
#include "starboard/shared/opus/opus_audio_decoder.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/memory.h"
diff --git a/src/starboard/shared/starboard/media/codec_util.cc b/src/starboard/shared/starboard/media/codec_util.cc
index 982f519..64a649b 100644
--- a/src/starboard/shared/starboard/media/codec_util.cc
+++ b/src/starboard/shared/starboard/media/codec_util.cc
@@ -584,7 +584,13 @@
: width_(width), height_(height) {
if (video_codec == kSbMediaVideoCodecVp9) {
video_codec_ = video_codec;
- } else if (video_codec == kSbMediaVideoCodecH264) {
+ }
+#if SB_API_VERSION >= 11
+ else if(video_codec == kSbMediaVideoCodecAv1) {
+ video_codec_ = video_codec;
+ }
+#endif // SB_API_VERSION >= 11
+ else if (video_codec == kSbMediaVideoCodecH264) {
avc_parameter_sets_ =
AvcParameterSets(AvcParameterSets::kAnnexB, data, size);
if (avc_parameter_sets_->is_valid()) {
diff --git a/src/starboard/shared/starboard/media/video_capabilities.cc b/src/starboard/shared/starboard/media/video_capabilities.cc
index 1b6ba44..b2d455e 100644
--- a/src/starboard/shared/starboard/media/video_capabilities.cc
+++ b/src/starboard/shared/starboard/media/video_capabilities.cc
@@ -14,8 +14,8 @@
#include "starboard/shared/starboard/media/video_capabilities.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
+#include "starboard/common/string.h"
#include "starboard/shared/starboard/media/media_util.h"
namespace starboard {
diff --git a/src/starboard/shared/starboard/player/filter/audio_frame_tracker.cc b/src/starboard/shared/starboard/player/filter/audio_frame_tracker.cc
index c816f21..badce26 100644
--- a/src/starboard/shared/starboard/player/filter/audio_frame_tracker.cc
+++ b/src/starboard/shared/starboard/player/filter/audio_frame_tracker.cc
@@ -36,6 +36,8 @@
void AudioFrameTracker::AddFrames(int number_of_frames, double playback_rate) {
SB_DCHECK(playback_rate > 0);
+ last_playback_rate_ = playback_rate;
+
if (number_of_frames == 0) {
return;
}
@@ -69,9 +71,18 @@
}
int64_t AudioFrameTracker::GetFutureFramesPlayedAdjustedToPlaybackRate(
- int number_of_frames) const {
+ int number_of_frames,
+ double* playback_rate) const {
+ SB_DCHECK(playback_rate);
+
+ if (frame_records_.empty()) {
+ *playback_rate = last_playback_rate_;
+ }
+
auto frames_played = frames_played_adjusted_to_playback_rate_;
for (auto& record : frame_records_) {
+ *playback_rate = record.playback_rate;
+
if (number_of_frames == 0) {
break;
}
diff --git a/src/starboard/shared/starboard/player/filter/audio_frame_tracker.h b/src/starboard/shared/starboard/player/filter/audio_frame_tracker.h
index 137830f..4582a74 100644
--- a/src/starboard/shared/starboard/player/filter/audio_frame_tracker.h
+++ b/src/starboard/shared/starboard/player/filter/audio_frame_tracker.h
@@ -42,7 +42,8 @@
void AddFrames(int number_of_frames, double playback_rate);
void RecordPlayedFrames(int number_of_frames);
int64_t GetFutureFramesPlayedAdjustedToPlaybackRate(
- int number_of_frames) const;
+ int number_of_frames,
+ double* playback_rate) const;
private:
struct FrameRecord {
@@ -53,6 +54,7 @@
// Usually there are very few elements, so std::vector<> is efficient enough.
std::vector<FrameRecord> frame_records_;
int64_t frames_played_adjusted_to_playback_rate_ = 0;
+ double last_playback_rate_ = 1.0;
};
} // namespace filter
diff --git a/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.cc b/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.cc
index 90b7748..601732b 100644
--- a/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.cc
+++ b/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.cc
@@ -279,10 +279,12 @@
SbTime AudioRendererImpl::GetCurrentMediaTime(bool* is_playing,
bool* is_eos_played,
- bool* is_underflow) {
+ bool* is_underflow,
+ double* playback_rate) {
SB_DCHECK(is_playing);
SB_DCHECK(is_eos_played);
SB_DCHECK(is_underflow);
+ SB_DCHECK(playback_rate);
SbTime media_time = 0;
SbTimeMonotonic now = -1;
@@ -298,6 +300,7 @@
*is_underflow = underflow_;
if (seeking_ || !decoder_sample_rate_) {
+ *playback_rate = playback_rate_;
return seeking_to_time_;
}
@@ -323,7 +326,7 @@
elasped_since_last_set * samples_per_second / kSbTimeSecond;
frames_played =
audio_frame_tracker_.GetFutureFramesPlayedAdjustedToPlaybackRate(
- elapsed_frames);
+ elapsed_frames, playback_rate);
media_time =
seeking_to_time_ + frames_played * kSbTimeSecond / samples_per_second;
if (media_time < last_media_time_) {
diff --git a/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.h b/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.h
index 93010f3..b6de6db 100644
--- a/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.h
+++ b/src/starboard/shared/starboard/player/filter/audio_renderer_internal_impl.h
@@ -92,7 +92,8 @@
void Seek(SbTime seek_to_time) override;
SbTime GetCurrentMediaTime(bool* is_playing,
bool* is_eos_played,
- bool* is_underflow) override;
+ bool* is_underflow,
+ double* playback_rate) override;
private:
enum EOSState {
diff --git a/src/starboard/shared/starboard/player/filter/filter_based_player_worker_handler.cc b/src/starboard/shared/starboard/player/filter/filter_based_player_worker_handler.cc
index 196d422..a3c0d50 100644
--- a/src/starboard/shared/starboard/player/filter/filter_based_player_worker_handler.cc
+++ b/src/starboard/shared/starboard/player/filter/filter_based_player_worker_handler.cc
@@ -15,9 +15,9 @@
#include "starboard/shared/starboard/player/filter/filter_based_player_worker_handler.h"
#include "starboard/audio_sink.h"
-#include "starboard/common/format_string.h"
#include "starboard/common/log.h"
#include "starboard/common/murmurhash2.h"
+#include "starboard/common/string.h"
#include "starboard/memory.h"
#include "starboard/shared/starboard/application.h"
#include "starboard/shared/starboard/drm/drm_system_internal.h"
@@ -503,8 +503,9 @@
bool is_playing;
bool is_eos_played;
bool is_underflow;
+ double playback_rate;
auto media_time = media_time_provider_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
update_media_info_cb_(media_time, dropped_frames, is_underflow);
}
diff --git a/src/starboard/shared/starboard/player/filter/media_time_provider.h b/src/starboard/shared/starboard/player/filter/media_time_provider.h
index 92dbec5..7b2c1ad 100644
--- a/src/starboard/shared/starboard/player/filter/media_time_provider.h
+++ b/src/starboard/shared/starboard/player/filter/media_time_provider.h
@@ -34,7 +34,8 @@
// This function can be called from *any* thread.
virtual SbTime GetCurrentMediaTime(bool* is_playing,
bool* is_eos_played,
- bool* is_underflow) = 0;
+ bool* is_underflow,
+ double* playback_rate) = 0;
protected:
virtual ~MediaTimeProvider() {}
diff --git a/src/starboard/shared/starboard/player/filter/media_time_provider_impl.cc b/src/starboard/shared/starboard/player/filter/media_time_provider_impl.cc
index 27cc002..176afb3 100644
--- a/src/starboard/shared/starboard/player/filter/media_time_provider_impl.cc
+++ b/src/starboard/shared/starboard/player/filter/media_time_provider_impl.cc
@@ -79,7 +79,8 @@
SbTime MediaTimeProviderImpl::GetCurrentMediaTime(bool* is_playing,
bool* is_eos_played,
- bool* is_underflow) {
+ bool* is_underflow,
+ double* playback_rate) {
ScopedLock scoped_lock(mutex_);
SbTime current = GetCurrentMediaTime_Locked();
@@ -87,6 +88,7 @@
*is_playing = is_playing_;
*is_eos_played = false;
*is_underflow = false;
+ *playback_rate = playback_rate_;
return current;
}
diff --git a/src/starboard/shared/starboard/player/filter/media_time_provider_impl.h b/src/starboard/shared/starboard/player/filter/media_time_provider_impl.h
index ef4555f..13a1d3f 100644
--- a/src/starboard/shared/starboard/player/filter/media_time_provider_impl.h
+++ b/src/starboard/shared/starboard/player/filter/media_time_provider_impl.h
@@ -49,7 +49,8 @@
void Seek(SbTime seek_to_time) override;
SbTime GetCurrentMediaTime(bool* is_playing,
bool* is_eos_played,
- bool* is_underflow) override;
+ bool* is_underflow,
+ double* playback_rate) override;
private:
// When not NULL, |current_time| will be set to the current monotonic time
diff --git a/src/starboard/shared/starboard/player/filter/testing/audio_renderer_internal_test.cc b/src/starboard/shared/starboard/player/filter/testing/audio_renderer_internal_test.cc
index 7fbff6c..002c4e8 100644
--- a/src/starboard/shared/starboard/player/filter/testing/audio_renderer_internal_test.cc
+++ b/src/starboard/shared/starboard/player/filter/testing/audio_renderer_internal_test.cc
@@ -306,11 +306,13 @@
bool is_playing = true;
bool is_eos_played = true;
bool is_underflow = true;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
}
TEST_F(AudioRendererTest, SunnyDay) {
@@ -335,11 +337,13 @@
bool is_playing = true;
bool is_eos_played = true;
bool is_underflow = true;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_TRUE(prerolled_);
audio_renderer_->Play();
@@ -347,9 +351,10 @@
SendDecoderOutput(new DecodedAudio);
SbTime media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
int frames_in_buffer;
int offset_in_frames;
@@ -370,18 +375,20 @@
renderer_callback_->ConsumeFrames(frames_to_consume, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_GT(new_media_time, media_time);
media_time = new_media_time;
const int remaining_frames = frames_in_buffer - frames_to_consume;
renderer_callback_->ConsumeFrames(remaining_frames, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_TRUE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_GT(new_media_time, media_time);
EXPECT_TRUE(audio_renderer_->IsEndOfStreamPlayed());
@@ -420,12 +427,14 @@
bool is_playing = false;
bool is_eos_played = true;
bool is_underflow = true;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, kPlaybackRate);
EXPECT_TRUE(prerolled_);
audio_renderer_->Play();
@@ -433,7 +442,7 @@
SendDecoderOutput(new DecodedAudio);
SbTime media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
int frames_in_buffer;
int offset_in_frames;
@@ -456,14 +465,14 @@
renderer_callback_->ConsumeFrames(frames_to_consume, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_GT(new_media_time, media_time);
media_time = new_media_time;
const int remaining_frames = frames_in_buffer - frames_to_consume;
renderer_callback_->ConsumeFrames(remaining_frames, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_GT(new_media_time, media_time);
EXPECT_TRUE(audio_renderer_->IsEndOfStreamPlayed());
@@ -496,8 +505,9 @@
bool is_playing = false;
bool is_eos_played = true;
bool is_underflow = true;
+ double playback_rate = -1.0;
SbTime media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
int frames_in_buffer;
int offset_in_frames;
@@ -518,18 +528,20 @@
renderer_callback_->ConsumeFrames(frames_to_consume, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_GE(new_media_time, media_time);
media_time = new_media_time;
const int remaining_frames = frames_in_buffer - frames_to_consume;
renderer_callback_->ConsumeFrames(remaining_frames, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_TRUE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_GE(new_media_time, media_time);
EXPECT_TRUE(audio_renderer_->IsEndOfStreamPlayed());
@@ -569,11 +581,13 @@
bool is_playing = true;
bool is_eos_played = false;
bool is_underflow = true;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_FALSE(is_playing);
EXPECT_TRUE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
}
// Test decoders that take many input samples before returning any output.
@@ -618,11 +632,13 @@
bool is_playing = true;
bool is_eos_played = false;
bool is_underflow = true;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_FALSE(is_playing);
EXPECT_TRUE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
}
TEST_F(AudioRendererTest, MoreNumberOfOuputBuffersThanInputBuffers) {
@@ -663,11 +679,13 @@
bool is_playing = true;
bool is_eos_played = true;
bool is_underflow = true;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_TRUE(prerolled_);
audio_renderer_->Play();
@@ -675,7 +693,7 @@
SendDecoderOutput(new DecodedAudio);
SbTime media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
int frames_in_buffer;
int offset_in_frames;
@@ -697,18 +715,20 @@
renderer_callback_->ConsumeFrames(frames_to_consume, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_GE(new_media_time, media_time);
media_time = new_media_time;
const int remaining_frames = frames_in_buffer - frames_to_consume;
renderer_callback_->ConsumeFrames(remaining_frames, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_TRUE(is_playing);
EXPECT_TRUE(is_eos_played);
+ EXPECT_EQ(playback_rate, 1.0);
EXPECT_GE(new_media_time, media_time);
EXPECT_TRUE(audio_renderer_->IsEndOfStreamPlayed());
@@ -759,8 +779,9 @@
bool is_playing;
bool is_eos_played;
bool is_underflow;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_TRUE(prerolled_);
@@ -769,7 +790,7 @@
SendDecoderOutput(new DecodedAudio);
SbTime media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
int frames_in_buffer;
int offset_in_frames;
@@ -790,14 +811,14 @@
renderer_callback_->ConsumeFrames(frames_to_consume, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_GE(new_media_time, media_time);
media_time = new_media_time;
const int remaining_frames = frames_in_buffer - frames_to_consume;
renderer_callback_->ConsumeFrames(remaining_frames, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_GE(new_media_time, media_time);
EXPECT_TRUE(audio_renderer_->IsEndOfStreamPlayed());
@@ -833,8 +854,9 @@
bool is_playing;
bool is_eos_played;
bool is_underflow;
+ double playback_rate = -1.0;
EXPECT_EQ(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
0);
EXPECT_TRUE(prerolled_);
@@ -843,7 +865,7 @@
SendDecoderOutput(new DecodedAudio);
SbTime media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
int frames_in_buffer;
int offset_in_frames;
@@ -864,14 +886,14 @@
renderer_callback_->ConsumeFrames(frames_to_consume, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_GE(new_media_time, media_time);
Seek(kSeekTime);
frames_written += FillRendererWithDecodedAudioAndWriteEOS(kSeekTime);
EXPECT_GE(audio_renderer_->GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow),
+ &is_underflow, &playback_rate),
kSeekTime);
EXPECT_TRUE(prerolled_);
@@ -886,7 +908,7 @@
EXPECT_TRUE(is_eos_reached);
renderer_callback_->ConsumeFrames(frames_in_buffer, SbTimeGetMonotonicNow());
new_media_time = audio_renderer_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
EXPECT_GE(new_media_time, kSeekTime);
EXPECT_TRUE(audio_renderer_->IsEndOfStreamPlayed());
diff --git a/src/starboard/shared/starboard/player/filter/testing/media_time_provider_impl_test.cc b/src/starboard/shared/starboard/player/filter/testing/media_time_provider_impl_test.cc
index 2c89e47..d2aec8c 100644
--- a/src/starboard/shared/starboard/player/filter/testing/media_time_provider_impl_test.cc
+++ b/src/starboard/shared/starboard/player/filter/testing/media_time_provider_impl_test.cc
@@ -95,45 +95,56 @@
TEST_F(MediaTimeProviderImplTest, DefaultStates) {
bool is_playing = true, is_eos_played = true, is_underflow = true;
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- 0));
+ double playback_rate = -1.0;
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ 0));
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
}
TEST_F(MediaTimeProviderImplTest, GetCurrentMediaTimeWhileNotPlaying) {
system_time_provider_->AdvanceTime(kSbTimeSecond);
bool is_playing = true, is_eos_played = true, is_underflow = true;
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- 0));
+ double playback_rate = -1.0;
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ 0));
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
}
TEST_F(MediaTimeProviderImplTest, GetCurrentMediaTimeWhilePlaying) {
media_time_provider_impl_.Play();
bool is_playing = false, is_eos_played = true, is_underflow = true;
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- 0));
+ double playback_rate = -1.0;
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ 0));
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSbTimeSecond));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSbTimeSecond));
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
}
TEST_F(MediaTimeProviderImplTest, SetPlaybackRateWhilePlaying) {
@@ -141,22 +152,30 @@
system_time_provider_->AdvanceTime(kSbTimeSecond);
bool is_playing = true, is_eos_played = true, is_underflow = true;
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSbTimeSecond));
+ double playback_rate = -1.0;
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSbTimeSecond));
+ EXPECT_EQ(playback_rate, 1.0);
+ EXPECT_EQ(playback_rate, 1.0);
media_time_provider_impl_.SetPlaybackRate(2.0);
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSbTimeSecond * 3));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSbTimeSecond * 3));
+ EXPECT_EQ(playback_rate, 2.0);
media_time_provider_impl_.SetPlaybackRate(0.0);
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSbTimeSecond * 3));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSbTimeSecond * 3));
+ EXPECT_EQ(playback_rate, 0.0);
}
TEST_F(MediaTimeProviderImplTest, SeekWhileNotPlaying) {
@@ -164,18 +183,22 @@
media_time_provider_impl_.Seek(kSeekToTime);
bool is_playing = true, is_eos_played = true, is_underflow = true;
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSeekToTime));
+ double playback_rate = -1.0;
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSeekToTime));
EXPECT_FALSE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSeekToTime));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSeekToTime));
}
TEST_F(MediaTimeProviderImplTest, SeekForwardWhilePlaying) {
@@ -185,21 +208,26 @@
media_time_provider_impl_.Seek(kSeekToTime);
bool is_playing = false, is_eos_played = true, is_underflow = true;
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSeekToTime));
+ double playback_rate = -1.0;
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSeekToTime));
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSeekToTime + kSbTimeSecond));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSeekToTime + kSbTimeSecond));
EXPECT_TRUE(is_playing);
EXPECT_FALSE(is_eos_played);
EXPECT_FALSE(is_underflow);
+ EXPECT_EQ(playback_rate, 1.0);
}
TEST_F(MediaTimeProviderImplTest, SeekBackwardWhilePlaying) {
@@ -208,15 +236,17 @@
system_time_provider_->AdvanceTime(kSbTimeSecond);
bool is_playing = true, is_eos_played = true, is_underflow = true;
+ double playback_rate = -1.0;
// Query for media time and ignore the result.
media_time_provider_impl_.GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow);
+ &is_underflow, &playback_rate);
const SbTime kSeekToTime = 0;
media_time_provider_impl_.Seek(kSeekToTime);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSeekToTime));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSeekToTime));
}
TEST_F(MediaTimeProviderImplTest, Pause) {
@@ -225,21 +255,24 @@
system_time_provider_->AdvanceTime(kSbTimeSecond);
bool is_playing = true, is_eos_played = true, is_underflow = true;
+ double playback_rate = -1.0;
// Query for media time and ignore the result.
media_time_provider_impl_.GetCurrentMediaTime(&is_playing, &is_eos_played,
- &is_underflow);
+ &is_underflow, &playback_rate);
media_time_provider_impl_.Pause();
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- kSbTimeSecond));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ kSbTimeSecond));
media_time_provider_impl_.Seek(0);
system_time_provider_->AdvanceTime(kSbTimeSecond);
- EXPECT_TRUE(AlmostEqual(media_time_provider_impl_.GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow),
- 0));
+ EXPECT_TRUE(AlmostEqual(
+ media_time_provider_impl_.GetCurrentMediaTime(
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate),
+ 0));
}
} // namespace
diff --git a/src/starboard/shared/starboard/player/filter/video_render_algorithm_impl.cc b/src/starboard/shared/starboard/player/filter/video_render_algorithm_impl.cc
index fb62882..c19c65e 100644
--- a/src/starboard/shared/starboard/player/filter/video_render_algorithm_impl.cc
+++ b/src/starboard/shared/starboard/player/filter/video_render_algorithm_impl.cc
@@ -51,8 +51,9 @@
bool is_audio_playing;
bool is_audio_eos_played;
bool is_underflow;
+ double playback_rate;
SbTime media_time = media_time_provider->GetCurrentMediaTime(
- &is_audio_playing, &is_audio_eos_played, &is_underflow);
+ &is_audio_playing, &is_audio_eos_played, &is_underflow, &playback_rate);
// Video frames are synced to the audio timestamp. However, the audio
// timestamp is not queried at a consistent interval. For example, if the
@@ -165,8 +166,9 @@
bool is_audio_playing;
bool is_audio_eos_played;
bool is_underflow;
+ double playback_rate;
SbTime media_time = media_time_provider->GetCurrentMediaTime(
- &is_audio_playing, &is_audio_eos_played, &is_underflow);
+ &is_audio_playing, &is_audio_eos_played, &is_underflow, &playback_rate);
while (frames->size() > 1 && !frames->front()->is_end_of_stream() &&
frames->front()->timestamp() < media_time) {
@@ -181,7 +183,10 @@
auto frame_rate = frame_rate_estimate_.frame_rate();
SB_DCHECK(frame_rate != VideoFrameRateEstimator::kInvalidFrameRate);
cadence_pattern_generator_.UpdateRefreshRateAndMaybeReset(refresh_rate);
- cadence_pattern_generator_.UpdateFrameRate(frame_rate);
+ if (playback_rate == 0) {
+ playback_rate = 1.0;
+ }
+ cadence_pattern_generator_.UpdateFrameRate(frame_rate * playback_rate);
SB_DCHECK(cadence_pattern_generator_.has_cadence());
auto frame_duration =
diff --git a/src/starboard/shared/starboard/player/filter/video_renderer_internal_impl.cc b/src/starboard/shared/starboard/player/filter/video_renderer_internal_impl.cc
index c8a2a3a..b07a4fe 100644
--- a/src/starboard/shared/starboard/player/filter/video_renderer_internal_impl.cc
+++ b/src/starboard/shared/starboard/player/filter/video_renderer_internal_impl.cc
@@ -406,8 +406,9 @@
bool is_playing;
bool is_eos_played;
bool is_underflow;
+ double playback_rate;
SbTime media_time = media_time_provider_->GetCurrentMediaTime(
- &is_playing, &is_eos_played, &is_underflow);
+ &is_playing, &is_eos_played, &is_underflow, &playback_rate);
if (is_eos_played) {
return;
}
diff --git a/src/starboard/shared/widevine/drm_system_widevine.cc b/src/starboard/shared/widevine/drm_system_widevine.cc
index 2dd57ff..c3910d3 100644
--- a/src/starboard/shared/widevine/drm_system_widevine.cc
+++ b/src/starboard/shared/widevine/drm_system_widevine.cc
@@ -238,6 +238,21 @@
cdm_.reset(wv3cdm::create(this, NULL, kEnablePrivacyMode));
SB_DCHECK(cdm_);
+#if SB_API_VERSION >= 11
+ // Get cert scope and pass to widevine.
+ const size_t kCertificationScopeLength = 1023;
+ char cert_scope_property[kCertificationScopeLength + 1] = {0};
+ bool result =
+ SbSystemGetProperty(kSbSystemPropertyCertificationScope,
+ cert_scope_property, kCertificationScopeLength);
+ if (result) {
+ SB_LOG(INFO) << "Succeeded to get platform cert scope.";
+ cdm_->setAppParameter("youtube_cert_scope", cert_scope_property);
+ } else {
+ SB_LOG(INFO) << "Unable to get platform cert scope.";
+ }
+#endif // SB_API_VERSION >= 11
+
GetRegistry()->Register(this);
}
diff --git a/src/starboard/starboard.gyp b/src/starboard/starboard.gyp
index 5301933..0808490 100644
--- a/src/starboard/starboard.gyp
+++ b/src/starboard/starboard.gyp
@@ -19,7 +19,7 @@
{
'targets': [
{
- 'target_name': 'starboard',
+ 'target_name': 'starboard_base',
'type': 'none',
'conditions': [
['sb_evergreen == 1', {
@@ -40,6 +40,14 @@
],
},
{
+ 'target_name': 'starboard',
+ 'type': 'none',
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/wrapper/wrapper.gyp:crashpad_wrapper_stub',
+ 'starboard_base',
+ ],
+ },
+ {
'target_name': 'starboard_full',
'type': 'none',
'dependencies': [
diff --git a/src/starboard/starboard_all.gyp b/src/starboard/starboard_all.gyp
index a8ab024..1a29a7f 100644
--- a/src/starboard/starboard_all.gyp
+++ b/src/starboard/starboard_all.gyp
@@ -95,6 +95,11 @@
'<(DEPTH)/starboard/benchmark/benchmark.gyp:*',
],
}],
+ ['sb_evergreen==0', {
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/crashpad.gyp:*',
+ ],
+ }]
],
},
],
diff --git a/src/starboard/stub/configuration.cc b/src/starboard/stub/configuration.cc
index d438884..6af5309 100644
--- a/src/starboard/stub/configuration.cc
+++ b/src/starboard/stub/configuration.cc
@@ -26,10 +26,6 @@
return "stub";
}
-bool CobaltEnableJit() {
- return true;
-}
-
const CobaltExtensionConfigurationApi kConfigurationApi = {
kCobaltExtensionConfigurationName,
1,
@@ -54,7 +50,7 @@
&common::CobaltReduceGpuMemoryByDefault,
&common::CobaltGcZealDefault,
&CobaltRasterizerType,
- &CobaltEnableJit,
+ &common::CobaltEnableJitDefault,
};
} // namespace
diff --git a/src/starboard/tools/testing/build_tests.py b/src/starboard/tools/testing/build_tests.py
index c9f7082..ba2dd9b 100644
--- a/src/starboard/tools/testing/build_tests.py
+++ b/src/starboard/tools/testing/build_tests.py
@@ -14,32 +14,35 @@
"""Common code for building various types of targets, typically tests."""
import logging
-import os
import subprocess
APP_LAUNCHER_TARGET = 'app_launcher_zip'
-def BuildTargets(targets, out_directory, dry_run=False, extra_build_flags=[]):
+def BuildTargets(targets, out_directory, dry_run=False, extra_build_flags=None):
"""Builds all specified targets.
Args:
- extra_build_flags: Additional command line flags to pass to ninja.
+ targets: Gyp targets to be built
+ out_directory: Directory to build to
+ dry_run: Whether to run ninja with -n (dry run)
+ extra_build_flags: Array of additional command line flags to pass to ninja
+
+ Returns:
+ The return code of builds, or 1 on unknown failure
"""
if not targets:
logging.info('No targets specified, nothing to build.')
return
- args_list = ["ninja", "-C", out_directory]
+ args_list = ['ninja', '-C', out_directory]
if dry_run:
- args_list.append("-n")
+ args_list.append('-n')
args_list.append(APP_LAUNCHER_TARGET)
- args_list.extend(["{}_deploy".format(test_name) for test_name in targets])
- args_list.extend(extra_build_flags)
-
- if "TEST_RUNNER_BUILD_FLAGS" in os.environ:
- args_list.append(os.environ["TEST_RUNNER_BUILD_FLAGS"])
+ args_list.extend(['{}_deploy'.format(test_name) for test_name in targets])
+ if extra_build_flags:
+ args_list.extend(extra_build_flags)
logging.info('Building targets with command: %s', str(args_list))
@@ -50,6 +53,6 @@
# We flatten the arguments to a string because with shell=True, Linux
# doesn't parse them properly.
# https://bugs.python.org/issue6689
- return subprocess.check_call(" ".join(args_list), shell=True)
+ return subprocess.check_call(' '.join(args_list), shell=True)
except KeyboardInterrupt:
return 1
diff --git a/src/starboard/tools/testing/test_runner.py b/src/starboard/tools/testing/test_runner.py
index 9948bfe..2336438 100755
--- a/src/starboard/tools/testing/test_runner.py
+++ b/src/starboard/tools/testing/test_runner.py
@@ -17,7 +17,6 @@
"""Cross-platform unit test runner."""
import argparse
-import cStringIO
import logging
import os
import re
@@ -28,6 +27,7 @@
import traceback
import _env # pylint: disable=unused-import, relative-import
+import cStringIO
from starboard.tools import abstract_launcher
from starboard.tools import build
from starboard.tools import command_line
@@ -705,10 +705,12 @@
# The loader is not built with the same platform configuration as our
# tests so we need to build it separately.
if self.loader_platform:
- build_tests.BuildTargets([_LOADER_TARGET], self.loader_out_directory,
- self.dry_run, extra_flags)
- build_tests.BuildTargets(self.test_targets, self.out_directory,
- self.dry_run, extra_flags)
+ build_tests.BuildTargets(
+ [_LOADER_TARGET], self.loader_out_directory, self.dry_run,
+ extra_flags + [os.getenv('TEST_RUNNER_PLATFORM_BUILD_FLAGS', '')])
+ build_tests.BuildTargets(
+ self.test_targets, self.out_directory, self.dry_run,
+ extra_flags + [os.getenv('TEST_RUNNER_BUILD_FLAGS', '')])
except subprocess.CalledProcessError as e:
result = False
diff --git a/src/starboard/tools/toolchain/evergreen_linker.py b/src/starboard/tools/toolchain/evergreen_linker.py
index aaef5b7..a7bf4d7 100644
--- a/src/starboard/tools/toolchain/evergreen_linker.py
+++ b/src/starboard/tools/toolchain/evergreen_linker.py
@@ -27,6 +27,7 @@
lld_path = '{0}/bin/ld.lld'.format(self.GetPath())
return shell.And('{0} '
+ '--build-id '
'-X '
'-v '
'--eh-frame-hdr '
diff --git a/src/third_party/crashpad/client/client.gyp b/src/third_party/crashpad/client/client.gyp
index 3755f98..d0f30fb 100644
--- a/src/third_party/crashpad/client/client.gyp
+++ b/src/third_party/crashpad/client/client.gyp
@@ -26,9 +26,19 @@
'../third_party/lss/lss.gyp:lss',
'../util/util.gyp:crashpad_util',
],
+ # We change including the top level directory here to a isystem include
+ # to ensure it is included after all normal includes for Crashpad. This
+ # guarantees that Crashpad will find mini_chromium's base before Cobalt's
+ # base. The same is true for direct dependents.
+ 'include_dirs!': [
+ '<(DEPTH)',
+ ],
'include_dirs': [
'..',
],
+ 'cflags': [
+ '-isystem../..',
+ ],
'sources': [
'annotation.cc',
'annotation.h',
@@ -82,8 +92,15 @@
}],
],
'direct_dependent_settings': {
+ 'include_dirs!': [
+ '<(DEPTH)',
+ ],
'include_dirs': [
'..',
+ '<(DEPTH)/third_party/mini_chromium',
+ ],
+ 'cflags': [
+ '-isystem../..',
],
},
},
diff --git a/src/third_party/crashpad/client/crashpad_client.h b/src/third_party/crashpad/client/crashpad_client.h
index 7a6a18a..e381b41 100644
--- a/src/third_party/crashpad/client/crashpad_client.h
+++ b/src/third_party/crashpad/client/crashpad_client.h
@@ -38,6 +38,10 @@
#include <ucontext.h>
#endif
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
//! \brief The primary interface for an application to have Crashpad monitor
@@ -375,6 +379,17 @@
const std::vector<std::string>& arguments,
int socket);
+#if defined(STARBOARD)
+ //! \brief Sends mapping info to the handler
+ //!
+ //! A handler must have already been installed before calling this method.
+ //! \param[in] evergreen_info A EvergreenInfo struct, whose information was
+ //! created on Evergreen startup.
+ //!
+ //! \return `true` on success, `false` on failure with a message logged.
+ static bool SendEvergreenInfoToHandler(EvergreenInfo evergreen_info);
+#endif
+
//! \brief Requests that the handler capture a dump even though there hasn't
//! been a crash.
//!
diff --git a/src/third_party/crashpad/client/crashpad_client_linux.cc b/src/third_party/crashpad/client/crashpad_client_linux.cc
index 98c3d09..02a4e57 100644
--- a/src/third_party/crashpad/client/crashpad_client_linux.cc
+++ b/src/third_party/crashpad/client/crashpad_client_linux.cc
@@ -136,6 +136,13 @@
first_chance_handler_ = handler;
}
+#if defined(STARBOARD)
+ bool SendEvergreenInfo(EvergreenInfo evergreen_info) {
+ evergreen_info_ = evergreen_info;
+ return SendEvergreenInfoImpl();
+ }
+#endif
+
// The base implementation for all signal handlers, suitable for calling
// directly to simulate signal delivery.
bool HandleCrash(int signo, siginfo_t* siginfo, void* context) {
@@ -172,10 +179,18 @@
HandleOrReraiseSignal, 0, &old_actions_, unhandled_signals);
}
+#if defined(STARBOARD)
+ const EvergreenInfo& GetEvergreenInfo() { return evergreen_info_; }
+#endif
+
const ExceptionInformation& GetExceptionInfo() {
return exception_information_;
}
+#if defined(STARBOARD)
+ virtual bool SendEvergreenInfoImpl() = 0;
+#endif
+
virtual void HandleCrashImpl() = 0;
private:
@@ -194,6 +209,10 @@
ExceptionInformation exception_information_ = {};
CrashpadClient::FirstChanceHandler first_chance_handler_ = nullptr;
+#if defined(STARBOARD)
+ EvergreenInfo evergreen_info_;
+#endif
+
static SignalHandler* handler_;
static thread_local bool disabled_for_thread_;
@@ -229,6 +248,10 @@
return Install(unhandled_signals);
}
+#if defined(STARBOARD)
+ bool SendEvergreenInfoImpl() override { return false; }
+#endif
+
void HandleCrashImpl() override {
ScopedPrSetPtracer set_ptracer(sys_getpid(), /* may_log= */ false);
@@ -321,6 +344,17 @@
return true;
}
+#if defined(STARBOARD)
+ bool SendEvergreenInfoImpl() override {
+ ExceptionHandlerClient client(sock_to_handler_.get(), true);
+ ExceptionHandlerProtocol::ClientInformation info = {};
+ info.evergreen_information_address =
+ FromPointerCast<VMAddress>(&GetEvergreenInfo());
+ client.SendEvergreenInfo(info);
+ return true;
+ }
+#endif
+
void HandleCrashImpl() override {
ExceptionHandlerProtocol::ClientInformation info = {};
info.exception_information_address =
@@ -532,6 +566,18 @@
return DoubleForkAndExec(argv, nullptr, socket, true, nullptr);
}
+#if defined(STARBOARD)
+// static
+bool CrashpadClient::SendEvergreenInfoToHandler(EvergreenInfo evergreen_info) {
+ if (!SignalHandler::Get()) {
+ DLOG(ERROR) << "Crashpad isn't enabled";
+ return false;
+ }
+
+ return SignalHandler::Get()->SendEvergreenInfo(evergreen_info);
+}
+#endif
+
// static
void CrashpadClient::DumpWithoutCrash(NativeCPUContext* context) {
if (!SignalHandler::Get()) {
diff --git a/src/third_party/crashpad/handler/linux/capture_snapshot.cc b/src/third_party/crashpad/handler/linux/capture_snapshot.cc
index 0054029..d792945 100644
--- a/src/third_party/crashpad/handler/linux/capture_snapshot.cc
+++ b/src/third_party/crashpad/handler/linux/capture_snapshot.cc
@@ -31,10 +31,20 @@
VMAddress requesting_thread_stack_address,
pid_t* requesting_thread_id,
std::unique_ptr<ProcessSnapshotLinux>* snapshot,
- std::unique_ptr<ProcessSnapshotSanitized>* sanitized_snapshot) {
+ std::unique_ptr<ProcessSnapshotSanitized>* sanitized_snapshot
+#if defined(STARBOARD)
+ ,
+ VMAddress evergreen_information_address
+#endif
+ ) {
std::unique_ptr<ProcessSnapshotLinux> process_snapshot(
new ProcessSnapshotLinux());
+#if defined(STARBOARD)
+ if (!process_snapshot->Initialize(connection,
+ evergreen_information_address)) {
+#else
if (!process_snapshot->Initialize(connection)) {
+#endif
Metrics::ExceptionCaptureResult(Metrics::CaptureResult::kSnapshotFailed);
return false;
}
diff --git a/src/third_party/crashpad/handler/linux/capture_snapshot.h b/src/third_party/crashpad/handler/linux/capture_snapshot.h
index 78886dc..d191b8b 100644
--- a/src/third_party/crashpad/handler/linux/capture_snapshot.h
+++ b/src/third_party/crashpad/handler/linux/capture_snapshot.h
@@ -27,6 +27,10 @@
#include "util/linux/ptrace_connection.h"
#include "util/misc/address_types.h"
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
//! \brief Captures a snapshot of a client over \a connection.
@@ -60,7 +64,12 @@
VMAddress requesting_thread_stack_address,
pid_t* requesting_thread_id,
std::unique_ptr<ProcessSnapshotLinux>* process_snapshot,
- std::unique_ptr<ProcessSnapshotSanitized>* sanitized_snapshot);
+ std::unique_ptr<ProcessSnapshotSanitized>* sanitized_snapshot
+#if defined(STARBOARD)
+ ,
+ VMAddress evergreen_information_address
+#endif
+ );
} // namespace crashpad
diff --git a/src/third_party/crashpad/handler/linux/crash_report_exception_handler.cc b/src/third_party/crashpad/handler/linux/crash_report_exception_handler.cc
index 29f6d0d..3a59dc7 100644
--- a/src/third_party/crashpad/handler/linux/crash_report_exception_handler.cc
+++ b/src/third_party/crashpad/handler/linux/crash_report_exception_handler.cc
@@ -34,6 +34,10 @@
#include "util/stream/log_output_stream.h"
#include "util/stream/zlib_output_stream.h"
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
namespace {
@@ -76,6 +80,14 @@
CrashReportExceptionHandler::~CrashReportExceptionHandler() = default;
+#if defined(STARBOARD)
+bool CrashReportExceptionHandler::AddEvergreenInfo(
+ const ExceptionHandlerProtocol::ClientInformation& info) {
+ evergreen_info_ = info.evergreen_information_address;
+ return true;
+}
+#endif
+
bool CrashReportExceptionHandler::HandleException(
pid_t client_process_id,
uid_t client_uid,
@@ -135,7 +147,12 @@
requesting_thread_stack_address,
requesting_thread_id,
&process_snapshot,
- &sanitized_snapshot)) {
+ &sanitized_snapshot
+#if defined(STARBOARD)
+ ,
+ evergreen_info_
+#endif
+ )) {
return false;
}
diff --git a/src/third_party/crashpad/handler/linux/crash_report_exception_handler.h b/src/third_party/crashpad/handler/linux/crash_report_exception_handler.h
index 83d07c0..b5ea3f7 100644
--- a/src/third_party/crashpad/handler/linux/crash_report_exception_handler.h
+++ b/src/third_party/crashpad/handler/linux/crash_report_exception_handler.h
@@ -28,6 +28,10 @@
#include "util/misc/address_types.h"
#include "util/misc/uuid.h"
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
class ProcessSnapshotLinux;
@@ -80,6 +84,11 @@
pid_t* requesting_thread_id = nullptr,
UUID* local_report_id = nullptr) override;
+#if defined(STARBOARD)
+ bool AddEvergreenInfo(
+ const ExceptionHandlerProtocol::ClientInformation& info) override;
+#endif
+
bool HandleExceptionWithBroker(
pid_t client_process_id,
uid_t client_uid,
@@ -109,6 +118,9 @@
bool write_minidump_to_database_;
bool write_minidump_to_log_;
const UserStreamDataSources* user_stream_data_sources_; // weak
+#if defined(STARBOARD)
+ VMAddress evergreen_info_;
+#endif
DISALLOW_COPY_AND_ASSIGN(CrashReportExceptionHandler);
};
diff --git a/src/third_party/crashpad/handler/linux/exception_handler_server.cc b/src/third_party/crashpad/handler/linux/exception_handler_server.cc
index fe1d883..d49cc1c 100644
--- a/src/third_party/crashpad/handler/linux/exception_handler_server.cc
+++ b/src/third_party/crashpad/handler/linux/exception_handler_server.cc
@@ -37,6 +37,10 @@
#include "util/linux/socket.h"
#include "util/misc/as_underlying_type.h"
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
namespace {
@@ -434,6 +438,11 @@
message.requesting_thread_stack_address,
event->fd.get(),
event->type == Event::Type::kSharedSocketMessage);
+
+#if defined(STARBOARD)
+ case ExceptionHandlerProtocol::ClientToServerMessage::kTypeAddEvergreenInfo:
+ return HandleAddEvergreenInfoRequest(creds, message.client_info);
+#endif
}
DCHECK(false);
@@ -441,6 +450,14 @@
return false;
}
+#if defined(STARBOARD)
+bool ExceptionHandlerServer::HandleAddEvergreenInfoRequest(
+ const ucred& creds,
+ const ExceptionHandlerProtocol::ClientInformation& client_info) {
+ return delegate_->AddEvergreenInfo(client_info);
+}
+#endif
+
bool ExceptionHandlerServer::HandleCrashDumpRequest(
const ucred& creds,
const ExceptionHandlerProtocol::ClientInformation& client_info,
diff --git a/src/third_party/crashpad/handler/linux/exception_handler_server.h b/src/third_party/crashpad/handler/linux/exception_handler_server.h
index ac430a4..0f0e73c 100644
--- a/src/third_party/crashpad/handler/linux/exception_handler_server.h
+++ b/src/third_party/crashpad/handler/linux/exception_handler_server.h
@@ -95,6 +95,15 @@
pid_t* requesting_thread_id = nullptr,
UUID* local_report_id = nullptr) = 0;
+#if defined(STARBOARD)
+ //! \brief Called on receipt of a request to add Evergreen mapping info.
+ //!
+ //! \param[in] info Information on the client.
+ //! \return `true` on success. `false` on failure with a message logged.
+ virtual bool AddEvergreenInfo(
+ const ExceptionHandlerProtocol::ClientInformation& info) = 0;
+#endif
+
//! \brief Called on the receipt of a crash dump request from a client for a
//! crash that should be mediated by a PtraceBroker.
//!
@@ -180,6 +189,12 @@
int client_sock,
bool multiple_clients);
+#if defined(STARBOARD)
+ bool HandleAddEvergreenInfoRequest(
+ const ucred& creds,
+ const ExceptionHandlerProtocol::ClientInformation& client_info);
+#endif
+
std::unordered_map<int, std::unique_ptr<Event>> clients_;
std::unique_ptr<Event> shutdown_event_;
std::unique_ptr<PtraceStrategyDecider> strategy_decider_;
diff --git a/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.cc b/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.cc
index 35f870e..32ee101 100644
--- a/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.cc
+++ b/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.cc
@@ -19,6 +19,10 @@
#include "base/logging.h"
#include "util/linux/exception_information.h"
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
ProcessSnapshotLinux::ProcessSnapshotLinux() = default;
@@ -49,6 +53,33 @@
return true;
}
+#if defined(STARBOARD)
+bool ProcessSnapshotLinux::Initialize(PtraceConnection* connection,
+ VMAddress evergreen_information_address) {
+ INITIALIZATION_STATE_SET_INITIALIZING(initialized_);
+
+ if (gettimeofday(&snapshot_time_, nullptr) != 0) {
+ PLOG(ERROR) << "gettimeofday";
+ return false;
+ }
+
+ if (!process_reader_.Initialize(connection) ||
+ !memory_range_.Initialize(process_reader_.Memory(),
+ process_reader_.Is64Bit())) {
+ return false;
+ }
+
+ system_.Initialize(&process_reader_, &snapshot_time_);
+
+ InitializeThreads();
+ InitializeModules(evergreen_information_address);
+ InitializeAnnotations();
+
+ INITIALIZATION_STATE_SET_VALID(initialized_);
+ return true;
+}
+#endif
+
pid_t ProcessSnapshotLinux::FindThreadWithStackAddress(
VMAddress stack_address) {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
@@ -222,6 +253,11 @@
for (const auto& module : modules_) {
modules.push_back(module.get());
}
+#if defined(STARBOARD)
+ if (evergreen_module_) {
+ modules.push_back(evergreen_module_.get());
+ }
+#endif
return modules;
}
@@ -286,6 +322,45 @@
}
}
+#if defined(STARBOARD)
+void ProcessSnapshotLinux::InitializeModules(
+ VMAddress evergreen_information_address) {
+ for (const ProcessReaderLinux::Module& reader_module :
+ process_reader_.Modules()) {
+ auto module =
+ std::make_unique<internal::ModuleSnapshotElf>(reader_module.name,
+ reader_module.elf_reader,
+ reader_module.type,
+ &memory_range_,
+ process_reader_.Memory());
+ if (module->Initialize()) {
+ modules_.push_back(std::move(module));
+ }
+ }
+
+ // Add evergreen module
+ EvergreenInfo evergreen_info;
+ if (!memory_range_.Read(evergreen_information_address,
+ sizeof(evergreen_info),
+ &evergreen_info)) {
+ LOG(ERROR) << "Could not read evergreen info";
+ return;
+ }
+
+ std::vector<uint8_t> build_id(evergreen_info.build_id_length);
+ for (int i = 0; i < build_id.size(); i++) {
+ build_id[i] = reinterpret_cast<uint8_t*>(evergreen_info.build_id)[i];
+ }
+
+ evergreen_module_ = std::make_unique<internal::ModuleSnapshotEvergreen>(
+ std::string(evergreen_info.file_path_buf),
+ ModuleSnapshot::ModuleType::kModuleTypeLoadableModule,
+ evergreen_info.base_address,
+ evergreen_info.load_size,
+ build_id);
+}
+#endif
+
void ProcessSnapshotLinux::InitializeAnnotations() {
#if defined(OS_ANDROID)
const std::string& abort_message = process_reader_.AbortMessage();
diff --git a/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.h b/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.h
index 06b72af..6c5d7a8 100644
--- a/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.h
+++ b/src/third_party/crashpad/snapshot/linux/process_snapshot_linux.h
@@ -42,6 +42,11 @@
#include "util/process/process_id.h"
#include "util/process/process_memory_range.h"
+#if defined(STARBOARD)
+#include "snapshot/module_snapshot_evergreen.h"
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
//! \brief A ProcessSnapshot of a running (or crashed) process running on a
@@ -59,6 +64,19 @@
//! an appropriate message logged.
bool Initialize(PtraceConnection* connection);
+#if defined(STARBOARD)
+ //! \brief Initializes the object with Evergreen information.
+ //!
+ //! \param[in] connection A connection to the process to snapshot.
+ //! \param[in] evergreen_information_address An address sent to the handler
+ //! server that points to a populated EvergreenInfo struct.
+ //!
+ //! \return `true` if the snapshot could be created, `false` otherwise with
+ //! an appropriate message logged.
+ bool Initialize(PtraceConnection* connnection,
+ VMAddress evergreen_information_address);
+#endif
+
//! \brief Finds the thread whose stack contains \a stack_address.
//!
//! \param[in] stack_address A stack address to search for.
@@ -134,6 +152,9 @@
private:
void InitializeThreads();
void InitializeModules();
+#if defined(STARBOARD)
+ void InitializeModules(VMAddress evergreen_information_address);
+#endif
void InitializeAnnotations();
std::map<std::string, std::string> annotations_simple_map_;
@@ -142,6 +163,9 @@
UUID client_id_;
std::vector<std::unique_ptr<internal::ThreadSnapshotLinux>> threads_;
std::vector<std::unique_ptr<internal::ModuleSnapshotElf>> modules_;
+#if defined(STARBOARD)
+ std::unique_ptr<internal::ModuleSnapshotEvergreen> evergreen_module_;
+#endif
std::unique_ptr<internal::ExceptionSnapshotLinux> exception_;
internal::SystemSnapshotLinux system_;
ProcessReaderLinux process_reader_;
diff --git a/src/third_party/crashpad/snapshot/module_snapshot_evergreen.cc b/src/third_party/crashpad/snapshot/module_snapshot_evergreen.cc
new file mode 100644
index 0000000..694be70
--- /dev/null
+++ b/src/third_party/crashpad/snapshot/module_snapshot_evergreen.cc
@@ -0,0 +1,180 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "snapshot/module_snapshot_evergreen.h"
+
+#include <endian.h>
+
+#include <algorithm>
+#include <utility>
+
+#include "base/files/file_path.h"
+#include "snapshot/crashpad_types/image_annotation_reader.h"
+#include "snapshot/memory_snapshot_generic.h"
+#include "util/misc/elf_note_types.h"
+
+namespace crashpad {
+namespace internal {
+
+ModuleSnapshotEvergreen::ModuleSnapshotEvergreen(
+ const std::string& name,
+ ModuleSnapshot::ModuleType type,
+ uint64_t address,
+ uint64_t size,
+ std::vector<uint8_t> build_id)
+ : ModuleSnapshot(),
+ name_(name),
+ crashpad_info_(),
+ type_(type),
+ initialized_(),
+ streams_(),
+ address_(address),
+ size_(size),
+ build_id_(std::move(build_id)) {
+ INITIALIZATION_STATE_SET_INITIALIZING(initialized_);
+ INITIALIZATION_STATE_SET_VALID(initialized_);
+}
+
+ModuleSnapshotEvergreen::~ModuleSnapshotEvergreen() = default;
+
+bool ModuleSnapshotEvergreen::Initialize() {
+ return true;
+}
+
+bool ModuleSnapshotEvergreen::GetCrashpadOptions(
+ CrashpadInfoClientOptions* options) {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+
+ if (!crashpad_info_) {
+ return false;
+ }
+
+ options->crashpad_handler_behavior =
+ crashpad_info_->CrashpadHandlerBehavior();
+ options->system_crash_reporter_forwarding =
+ crashpad_info_->SystemCrashReporterForwarding();
+ options->gather_indirectly_referenced_memory =
+ crashpad_info_->GatherIndirectlyReferencedMemory();
+ options->indirectly_referenced_memory_cap =
+ crashpad_info_->IndirectlyReferencedMemoryCap();
+ return true;
+}
+
+std::string ModuleSnapshotEvergreen::Name() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return name_;
+}
+
+uint64_t ModuleSnapshotEvergreen::Address() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return address_;
+}
+
+uint64_t ModuleSnapshotEvergreen::Size() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return size_;
+}
+
+time_t ModuleSnapshotEvergreen::Timestamp() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return 0;
+}
+
+void ModuleSnapshotEvergreen::FileVersion(uint16_t* version_0,
+ uint16_t* version_1,
+ uint16_t* version_2,
+ uint16_t* version_3) const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ *version_0 = 0;
+ *version_1 = 0;
+ *version_2 = 0;
+ *version_3 = 0;
+}
+
+void ModuleSnapshotEvergreen::SourceVersion(uint16_t* version_0,
+ uint16_t* version_1,
+ uint16_t* version_2,
+ uint16_t* version_3) const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ *version_0 = 0;
+ *version_1 = 0;
+ *version_2 = 0;
+ *version_3 = 0;
+}
+
+ModuleSnapshot::ModuleType ModuleSnapshotEvergreen::GetModuleType() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return type_;
+}
+
+void ModuleSnapshotEvergreen::UUIDAndAge(crashpad::UUID* uuid,
+ uint32_t* age) const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ *age = 0;
+
+ // TODO: Add build id
+ // auto build_id = BuildID();
+ // build_id.insert(
+ // build_id.end(), 16 - std::min(build_id.size(), size_t{16}), '\0');
+ // uuid->InitializeFromBytes(build_id.data());
+
+ // TODO(scottmg): https://crashpad.chromium.org/bug/229. These are
+ // endian-swapped to match FileID::ConvertIdentifierToUUIDString() in
+ // Breakpad. This is necessary as this identifier is used for symbol lookup.
+ // uuid->data_1 = htobe32(uuid->data_1);
+ // uuid->data_2 = htobe16(uuid->data_2);
+ // uuid->data_3 = htobe16(uuid->data_3);
+}
+
+std::string ModuleSnapshotEvergreen::DebugFileName() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return base::FilePath(Name()).BaseName().value();
+}
+
+std::vector<uint8_t> ModuleSnapshotEvergreen::BuildID() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return build_id_;
+}
+
+std::vector<std::string> ModuleSnapshotEvergreen::AnnotationsVector() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return std::vector<std::string>();
+}
+
+std::map<std::string, std::string>
+ModuleSnapshotEvergreen::AnnotationsSimpleMap() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return std::map<std::string, std::string>();
+}
+
+std::vector<AnnotationSnapshot> ModuleSnapshotEvergreen::AnnotationObjects()
+ const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return std::vector<AnnotationSnapshot>();
+}
+
+std::set<CheckedRange<uint64_t>> ModuleSnapshotEvergreen::ExtraMemoryRanges()
+ const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return std::set<CheckedRange<uint64_t>>();
+}
+
+std::vector<const UserMinidumpStream*>
+ModuleSnapshotEvergreen::CustomMinidumpStreams() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ return std::vector<const UserMinidumpStream*>();
+}
+
+} // namespace internal
+} // namespace crashpad
diff --git a/src/third_party/crashpad/snapshot/module_snapshot_evergreen.h b/src/third_party/crashpad/snapshot/module_snapshot_evergreen.h
new file mode 100644
index 0000000..a7d2f54
--- /dev/null
+++ b/src/third_party/crashpad/snapshot/module_snapshot_evergreen.h
@@ -0,0 +1,110 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef THIRD_PARTY_CRASHPAD_SNAPSHOT_MODULE_SNAPSHOT_EVERGREEN_H_
+#define THIRD_PARTY_CRASHPAD_SNAPSHOT_MODULE_SNAPSHOT_EVERGREEN_H_
+
+#include <stdint.h>
+#include <sys/types.h>
+
+#include <map>
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "client/crashpad_info.h"
+#include "snapshot/crashpad_info_client_options.h"
+#include "snapshot/crashpad_types/crashpad_info_reader.h"
+#include "snapshot/elf/elf_image_reader.h"
+#include "snapshot/module_snapshot.h"
+#include "util/misc/initialization_state_dcheck.h"
+
+namespace crashpad {
+
+namespace internal {
+
+//! \brief A ModuleSnapshot of a code module (binary image) loaded into a
+//! running (or crashed) process on a system that uses ELF modules.
+class ModuleSnapshotEvergreen final : public ModuleSnapshot {
+ public:
+ //! \param[in] name The pathname used to load the module from disk.
+ //! \param[in] elf_reader An image reader for the module.
+ //! \param[in] type The module's type.
+ //! \param[in] process_memory_range A memory reader giving protected access
+ //! to the target process.
+ //! \param[in] process_memory A memory reader for the target process which can
+ //! be used to initialize a MemorySnapshot.
+ ModuleSnapshotEvergreen(const std::string& name,
+ ModuleSnapshot::ModuleType type,
+ uint64_t address,
+ uint64_t size,
+ std::vector<uint8_t> build_id);
+ ~ModuleSnapshotEvergreen() override;
+
+ //! \brief Initializes the object.
+ //!
+ //! \return `true` if the snapshot could be created, `false` otherwise with
+ //! an appropriate message logged.
+ bool Initialize();
+
+ //! \brief Returns options from the module’s CrashpadInfo structure.
+ //!
+ //! \param[out] options Options set in the module’s CrashpadInfo structure.
+ //! \return `true` if there were options returned. Otherwise `false`.
+ bool GetCrashpadOptions(CrashpadInfoClientOptions* options);
+
+ // ModuleSnapshot:
+
+ std::string Name() const override;
+ uint64_t Address() const override;
+ uint64_t Size() const override;
+ time_t Timestamp() const override;
+ void FileVersion(uint16_t* version_0,
+ uint16_t* version_1,
+ uint16_t* version_2,
+ uint16_t* version_3) const override;
+ void SourceVersion(uint16_t* version_0,
+ uint16_t* version_1,
+ uint16_t* version_2,
+ uint16_t* version_3) const override;
+ ModuleType GetModuleType() const override;
+ void UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const override;
+ std::string DebugFileName() const override;
+ std::vector<uint8_t> BuildID() const override;
+ std::vector<std::string> AnnotationsVector() const override;
+ std::map<std::string, std::string> AnnotationsSimpleMap() const override;
+ std::vector<AnnotationSnapshot> AnnotationObjects() const override;
+ std::set<CheckedRange<uint64_t>> ExtraMemoryRanges() const override;
+ std::vector<const UserMinidumpStream*> CustomMinidumpStreams() const override;
+
+ private:
+ std::string name_;
+ uint64_t address_;
+ uint64_t size_;
+ std::vector<uint8_t> build_id_;
+ ModuleType type_;
+ InitializationStateDcheck initialized_;
+
+ std::unique_ptr<CrashpadInfoReader> crashpad_info_;
+
+ // Too const-y: https://crashpad.chromium.org/bug/9.
+ mutable std::vector<std::unique_ptr<const UserMinidumpStream>> streams_;
+
+ DISALLOW_COPY_AND_ASSIGN(ModuleSnapshotEvergreen);
+};
+
+} // namespace internal
+} // namespace crashpad
+
+#endif // THIRD_PARTY_CRASHPAD_SNAPSHOT_MODULE_SNAPSHOT_EVERGREEN_H_
diff --git a/src/third_party/crashpad/snapshot/snapshot.gyp b/src/third_party/crashpad/snapshot/snapshot.gyp
index 79017d5..a4c57fc 100644
--- a/src/third_party/crashpad/snapshot/snapshot.gyp
+++ b/src/third_party/crashpad/snapshot/snapshot.gyp
@@ -131,6 +131,8 @@
'minidump/thread_snapshot_minidump.cc',
'minidump/thread_snapshot_minidump.h',
'module_snapshot.h',
+ 'module_snapshot_evergreen.h',
+ 'module_snapshot_evergreen.cc',
'posix/timezone.cc',
'posix/timezone.h',
'process_snapshot.h',
diff --git a/src/third_party/crashpad/util/linux/exception_handler_client.cc b/src/third_party/crashpad/util/linux/exception_handler_client.cc
index 98edb30..b1df219 100644
--- a/src/third_party/crashpad/util/linux/exception_handler_client.cc
+++ b/src/third_party/crashpad/util/linux/exception_handler_client.cc
@@ -84,6 +84,13 @@
server_sock_, &response, sizeof(response), creds);
}
+#if defined(STARBOARD)
+bool ExceptionHandlerClient::SendEvergreenInfo(
+ const ExceptionHandlerProtocol::ClientInformation& info) {
+ return SendEvergreenInfoRequest(info);
+}
+#endif
+
int ExceptionHandlerClient::RequestCrashDump(
const ExceptionHandlerProtocol::ClientInformation& info) {
VMAddress sp = FromPointerCast<VMAddress>(&sp);
@@ -143,6 +150,19 @@
return 0;
}
+#if defined(STARBOARD)
+bool ExceptionHandlerClient::SendEvergreenInfoRequest(
+ const ExceptionHandlerProtocol::ClientInformation& info) {
+ ExceptionHandlerProtocol::ClientToServerMessage message;
+ message.type =
+ ExceptionHandlerProtocol::ClientToServerMessage::kTypeAddEvergreenInfo;
+ message.client_info = info;
+
+ UnixCredentialSocket::SendMsg(server_sock_, &message, sizeof(message));
+ return true;
+}
+#endif
+
int ExceptionHandlerClient::SendCrashDumpRequest(
const ExceptionHandlerProtocol::ClientInformation& info,
VMAddress stack_pointer) {
diff --git a/src/third_party/crashpad/util/linux/exception_handler_client.h b/src/third_party/crashpad/util/linux/exception_handler_client.h
index 4e10fa6..3a27739 100644
--- a/src/third_party/crashpad/util/linux/exception_handler_client.h
+++ b/src/third_party/crashpad/util/linux/exception_handler_client.h
@@ -21,6 +21,10 @@
#include "base/macros.h"
#include "util/linux/exception_handler_protocol.h"
+#if defined(STARBOARD)
+#include "starboard/elf_loader/evergreen_info.h"
+#endif
+
namespace crashpad {
//! A client for an ExceptionHandlerServer
@@ -46,6 +50,15 @@
//! \return `true` on success. Otherwise, `false` with a message logged.
bool GetHandlerCredentials(ucred* creds);
+#if defined(STARBOARD)
+ //! \brief Sends EvergreenInfo to the ExceptionHandlerServer.
+ //!
+ //! \param[in] info Information to about this client.
+ //! \return `true` on success or `false` on failure.
+ bool SendEvergreenInfo(
+ const ExceptionHandlerProtocol::ClientInformation& info);
+#endif
+
//! \brief Request a crash dump from the ExceptionHandlerServer.
//!
//! This method blocks until the crash dump is complete.
@@ -67,6 +80,10 @@
void SetCanSetPtracer(bool can_set_ptracer);
private:
+#if defined(STARBOARD)
+ bool SendEvergreenInfoRequest(
+ const ExceptionHandlerProtocol::ClientInformation& info);
+#endif
int SendCrashDumpRequest(
const ExceptionHandlerProtocol::ClientInformation& info,
VMAddress stack_pointer);
diff --git a/src/third_party/crashpad/util/linux/exception_handler_protocol.cc b/src/third_party/crashpad/util/linux/exception_handler_protocol.cc
index 45590c8..2220ecf 100644
--- a/src/third_party/crashpad/util/linux/exception_handler_protocol.cc
+++ b/src/third_party/crashpad/util/linux/exception_handler_protocol.cc
@@ -20,9 +20,15 @@
: exception_information_address(0),
sanitization_information_address(0)
#if defined(OS_LINUX)
- , crash_loop_before_time(0)
+ ,
+ crash_loop_before_time(0)
#endif // OS_LINUX
-{}
+#if defined(STARBOARD)
+ ,
+ evergreen_information_address(0)
+#endif
+{
+}
ExceptionHandlerProtocol::ClientToServerMessage::ClientToServerMessage()
: version(kVersion),
diff --git a/src/third_party/crashpad/util/linux/exception_handler_protocol.h b/src/third_party/crashpad/util/linux/exception_handler_protocol.h
index 7312b9d..9edd82a 100644
--- a/src/third_party/crashpad/util/linux/exception_handler_protocol.h
+++ b/src/third_party/crashpad/util/linux/exception_handler_protocol.h
@@ -52,6 +52,12 @@
//! SanitizationInformation struct, or 0 if there is no such struct.
VMAddress sanitization_information_address;
+#if defined(STARBOARD)
+ //! \brief The address in the client's address space of an EvergreenInfo
+ //! struct, or 0 if there is no such struct.
+ VMAddress evergreen_information_address;
+#endif
+
#if defined(OS_LINUX)
//! \brief Indicates that the client is likely in a crash loop if a crash
//! occurs before this timestamp. This value is only used by ChromeOS's
@@ -82,7 +88,13 @@
kTypeCheckCredentials,
//! \brief Used to request a crash dump for the sending client.
- kTypeCrashDumpRequest
+ kTypeCrashDumpRequest,
+
+#if defined(STARBOARD)
+ //! \brief Used to store Evergreen mapping info in the handler for use at
+ //! time of crash.
+ kTypeAddEvergreenInfo
+#endif
};
Type type;
diff --git a/src/third_party/crashpad/wrapper/wrapper.cc b/src/third_party/crashpad/wrapper/wrapper.cc
new file mode 100644
index 0000000..6cd90d6
--- /dev/null
+++ b/src/third_party/crashpad/wrapper/wrapper.cc
@@ -0,0 +1,128 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "third_party/crashpad/wrapper/wrapper.h"
+
+#include <vector>
+
+#include "base/files/file_path.h"
+#include "base/logging.h"
+#include "client/crash_report_database.h"
+#include "client/crashpad_client.h"
+#include "client/settings.h"
+#include "starboard/configuration_constants.h"
+#include "starboard/directory.h"
+#include "starboard/system.h"
+
+namespace third_party {
+namespace crashpad {
+namespace wrapper {
+
+namespace {
+
+// TODO: Get evergreen information from installation.
+const std::string kCrashpadVersion = "1.0.0.0";
+#if defined(STARBOARD_BUILD_TYPE_GOLD)
+const std::string kUploadUrl("https://clients2.google.com/cr/report");
+#else
+const std::string kUploadUrl("https://clients2.google.com/cr/staging_report");
+#endif
+
+::crashpad::CrashpadClient* GetCrashpadClient() {
+ static auto* crashpad_client = new ::crashpad::CrashpadClient();
+ return crashpad_client;
+}
+
+base::FilePath GetPathToCrashpadHandlerBinary() {
+ std::vector<char> exe_path(kSbFileMaxPath);
+ if (!SbSystemGetPath(
+ kSbSystemPathExecutableFile, exe_path.data(), kSbFileMaxPath)) {
+ LOG(ERROR) << "Couldn't retrieve path to crashpad_handler binary.";
+ return base::FilePath("");
+ }
+ base::FilePath exe_dir_path = base::FilePath(exe_path.data()).DirName();
+ std::string handler_path(exe_dir_path.value());
+ handler_path.push_back(kSbFileSepChar);
+ handler_path.append("crashpad_handler");
+ return base::FilePath(handler_path.c_str());
+}
+
+base::FilePath GetDatabasePath() {
+ std::vector<char> temp_directory_path(kSbFileMaxPath);
+ if (!SbSystemGetPath(kSbSystemPathTempDirectory,
+ temp_directory_path.data(),
+ kSbFileMaxPath)) {
+ LOG(ERROR) << "Couldn't retrieve path to database directory";
+ return base::FilePath("");
+ }
+
+ std::string crashpad_directory_path(temp_directory_path.data());
+ crashpad_directory_path.push_back(kSbFileSepChar);
+ crashpad_directory_path.append("crashpad_database");
+ if (!SbDirectoryCreate(crashpad_directory_path.c_str())) {
+ LOG(ERROR) << "Couldn't create directory for crashpad database";
+ return base::FilePath("");
+ }
+
+ return base::FilePath(crashpad_directory_path.c_str());
+}
+
+void InitializeCrashpadDatabase(const base::FilePath database_directory_path) {
+ std::unique_ptr<::crashpad::CrashReportDatabase> database =
+ ::crashpad::CrashReportDatabase::Initialize(database_directory_path);
+ ::crashpad::Settings* settings = database->GetSettings();
+ settings->SetUploadsEnabled(true);
+}
+
+std::string GetProductName() {
+#if SB_IS(EVERGREEN_COMPATIBLE)
+ return "Cobalt_Evergreen";
+#else
+ return "Cobalt";
+#endif
+}
+
+} // namespace
+
+void InstallCrashpadHandler() {
+ ::crashpad::CrashpadClient* client = GetCrashpadClient();
+
+ const base::FilePath handler_path = GetPathToCrashpadHandlerBinary();
+ const base::FilePath database_directory_path = GetDatabasePath();
+ const base::FilePath default_metrics_dir;
+ const std::string product_name = GetProductName();
+ const std::map<std::string, std::string> default_annotations = {
+ {"ver", kCrashpadVersion}, {"prod", product_name}};
+ const std::vector<std::string> default_arguments = {};
+
+ InitializeCrashpadDatabase(database_directory_path);
+ client->SetUnhandledSignals({});
+ client->StartHandler(handler_path,
+ database_directory_path,
+ default_metrics_dir,
+ kUploadUrl,
+ default_annotations,
+ default_arguments,
+ false,
+ false);
+}
+
+bool AddEvergreenInfoToCrashpad(EvergreenInfo evergreen_info) {
+ ::crashpad::CrashpadClient* client = GetCrashpadClient();
+ return client->SendEvergreenInfoToHandler(evergreen_info);
+}
+
+} // namespace wrapper
+} // namespace crashpad
+} // namespace third_party
diff --git a/src/third_party/crashpad/wrapper/wrapper.gyp b/src/third_party/crashpad/wrapper/wrapper.gyp
new file mode 100644
index 0000000..a9a4382
--- /dev/null
+++ b/src/third_party/crashpad/wrapper/wrapper.gyp
@@ -0,0 +1,43 @@
+# Copyright 2020 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{
+ 'targets': [
+ {
+ 'target_name': 'crashpad_wrapper_stub',
+ 'type': 'static_library',
+ 'sources': [
+ 'wrapper_stub.cc',
+ 'wrapper.h',
+ ],
+ },
+ ],
+ 'conditions': [
+ ['sb_evergreen_compatible == 1', {
+ 'targets': [
+ {
+ 'target_name': 'crashpad_wrapper',
+ 'type': 'static_library',
+ 'sources': [
+ 'wrapper.cc',
+ 'wrapper.h',
+ ],
+ 'dependencies': [
+ '<(DEPTH)/third_party/crashpad/client/client.gyp:crashpad_client',
+ ],
+ },
+ ],
+ }],
+ ],
+}
diff --git a/src/third_party/crashpad/wrapper/wrapper.h b/src/third_party/crashpad/wrapper/wrapper.h
new file mode 100644
index 0000000..c2b366f
--- /dev/null
+++ b/src/third_party/crashpad/wrapper/wrapper.h
@@ -0,0 +1,32 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef THIRD_PARTY_CRASHPAD_WRAPPER_WRAPPER_H_
+#define THIRD_PARTY_CRASHPAD_WRAPPER_WRAPPER_H_
+
+#include "starboard/elf_loader/evergreen_info.h"
+
+namespace third_party {
+namespace crashpad {
+namespace wrapper {
+
+void InstallCrashpadHandler();
+
+bool AddEvergreenInfoToCrashpad(EvergreenInfo evergreen_info);
+
+} // namespace wrapper
+} // namespace crashpad
+} // namespace third_party
+
+#endif // THIRD_PARTY_CRASHPAD_WRAPPER_WRAPPER_H_
diff --git a/src/third_party/crashpad/wrapper/wrapper_stub.cc b/src/third_party/crashpad/wrapper/wrapper_stub.cc
new file mode 100644
index 0000000..6158445
--- /dev/null
+++ b/src/third_party/crashpad/wrapper/wrapper_stub.cc
@@ -0,0 +1,29 @@
+// Copyright 2020 The Cobalt Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "third_party/crashpad/wrapper/wrapper.h"
+
+namespace third_party {
+namespace crashpad {
+namespace wrapper {
+
+void InstallCrashpadHandler() {}
+
+bool AddEvergreenInfoToCrashpad(EvergreenInfo evergreen_info) {
+ return false;
+}
+
+} // namespace wrapper
+} // namespace crashpad
+} // namespace third_party
\ No newline at end of file
diff --git a/src/third_party/mini_chromium/base/base.gyp b/src/third_party/mini_chromium/base/base.gyp
index 9766c23..7d1dbee 100644
--- a/src/third_party/mini_chromium/base/base.gyp
+++ b/src/third_party/mini_chromium/base/base.gyp
@@ -11,9 +11,15 @@
{
'target_name': 'base',
'type': 'static_library',
+ 'include_dirs!': [
+ '<(DEPTH)',
+ ],
'include_dirs': [
'..',
],
+ 'cflags': [
+ '-isystem../..',
+ ],
'link_settings': {
'conditions': [
['OS=="mac"', {
@@ -132,9 +138,15 @@
'../build/build_config.h',
],
'direct_dependent_settings': {
+ 'include_dirs!': [
+ '<(DEPTH)',
+ ],
'include_dirs': [
'..',
],
+ 'cflags': [
+ '-isystem../..',
+ ],
},
},
],
diff --git a/src/third_party/web_platform_tests/intersection-observer/containing-block.html b/src/third_party/web_platform_tests/intersection-observer/containing-block.html
index f7ce6fa..e6f609a 100644
--- a/src/third_party/web_platform_tests/intersection-observer/containing-block.html
+++ b/src/third_party/web_platform_tests/intersection-observer/containing-block.html
@@ -5,6 +5,10 @@
<script src="./resources/intersection-observer-test-utils.js"></script>
<style>
+/* Cobalt does not implement HTML5 spec for body margin. */
+body {
+ margin: 8px;
+}
pre, #log {
position: absolute;
top: 0;
@@ -13,7 +17,7 @@
#root {
width: 170px;
height: 200px;
- overflow-y: scroll;
+ overflow: scroll;
}
#target {
width: 100px;
@@ -38,6 +42,7 @@
assert_true(!!target, "target element exists.");
var observer = new IntersectionObserver(function(changes) {
entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
}, { root: root });
observer.observe(target);
entries = entries.concat(observer.takeRecords());
@@ -45,6 +50,8 @@
target.style.top = "10px";
runTestCycle(test1, "In containing block and intersecting.");
}, "IntersectionObserver should only report intersections if root is a containing block ancestor of target.");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function test1() {
runTestCycle(test2, "In containing block and not intersecting.");
@@ -59,12 +66,14 @@
checkLastEntry(entries, 1, [58, 158, 258, 358, 0, 0, 0, 0].concat(rootBounds));
root.style.position = "static";
target.style.top = "10px";
+ window.testRunner.DoNonMeasuredLayout();
}
function test3() {
runTestCycle(test4, "Not in containing block and not intersecting.");
checkLastEntry(entries, 1);
target.style.top = "250px";
+ window.testRunner.DoNonMeasuredLayout();
}
function test4() {
diff --git a/src/third_party/web_platform_tests/intersection-observer/disconnect.html b/src/third_party/web_platform_tests/intersection-observer/disconnect.html
index 9c02daf..65c9468 100644
--- a/src/third_party/web_platform_tests/intersection-observer/disconnect.html
+++ b/src/third_party/web_platform_tests/intersection-observer/disconnect.html
@@ -11,7 +11,7 @@
left: 200px;
}
.spacer {
- height: calc(100vh + 100px);
+ height: 100vh;
}
#target {
width: 100px;
@@ -33,19 +33,23 @@
target = document.getElementById("target");
assert_true(!!target, "target exists");
observer = new IntersectionObserver(function(changes) {
- entries = entries.concat(changes)
+ entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
});
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "First rAF.");
}, "IntersectionObserver should not deliver pending notifications after disconnect().");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
runTestCycle(step1, "observer.disconnect()");
- document.scrollingElement.scrollTop = 300;
+ document.documentElement.scrollTop = 300;
observer.disconnect();
assert_equals(entries.length, 1, "Initial notification.");
+ window.testRunner.DoNonMeasuredLayout();
}
function step1() {
diff --git a/src/third_party/web_platform_tests/intersection-observer/initial-observation-with-threshold.html b/src/third_party/web_platform_tests/intersection-observer/initial-observation-with-threshold.html
index b9218b0..a3b01dc 100644
--- a/src/third_party/web_platform_tests/intersection-observer/initial-observation-with-threshold.html
+++ b/src/third_party/web_platform_tests/intersection-observer/initial-observation-with-threshold.html
@@ -5,17 +5,21 @@
<script src="./resources/intersection-observer-test-utils.js"></script>
<style>
+/* Cobalt does not implement HTML5 spec for body margin. */
+body {
+ margin: 8px;
+}
pre, #log {
position: absolute;
top: 0;
left: 200px;
}
.spacer {
- height: calc(100vh + 100px);
+ height: 100vh;
}
#root {
display: inline-block;
- overflow-y: scroll;
+ overflow: scroll;
height: 240px;
border: 3px solid black;
}
@@ -41,16 +45,20 @@
root = document.getElementById("root");
assert_true(!!root, "root exists");
var observer = new IntersectionObserver(function(changes) {
- entries = entries.concat(changes)
+ entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
}, { root: root, threshold: [0.5] });
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "First rAF");
}, "First observation with a threshold.");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
- root.scrollTop = 20;
+ //root.scrollTop = 20;
+ target.style.marginTop = "180px";
runTestCycle(step1, "root.scrollTop = 20");
checkLastEntry(entries, 0, [ 11, 111, 211, 311, 11, 111, 211, 251, 11, 111, 11, 251, false]);
}
diff --git a/src/third_party/web_platform_tests/intersection-observer/inline-with-block-child-client-rect.html b/src/third_party/web_platform_tests/intersection-observer/inline-with-block-child-client-rect.html
index 81a8fd1..b68f1aa 100644
--- a/src/third_party/web_platform_tests/intersection-observer/inline-with-block-child-client-rect.html
+++ b/src/third_party/web_platform_tests/intersection-observer/inline-with-block-child-client-rect.html
@@ -31,12 +31,15 @@
assert_true(!!target, "target exists");
var observer = new IntersectionObserver(function(changes) {
entries = entries.concat(changes)
+ window.testRunner.DoNonMeasuredLayout();
});
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "First rAF");
}, "Inline target containing a block child");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
assert_equals(entries.length, 1);
diff --git a/src/third_party/web_platform_tests/intersection-observer/isIntersecting-change-events.html b/src/third_party/web_platform_tests/intersection-observer/isIntersecting-change-events.html
index 99bc65b..2021f06 100644
--- a/src/third_party/web_platform_tests/intersection-observer/isIntersecting-change-events.html
+++ b/src/third_party/web_platform_tests/intersection-observer/isIntersecting-change-events.html
@@ -16,7 +16,7 @@
left: 0;
width: 150px;
height: 200px;
- overflow-y: scroll;
+ overflow: scroll;
}
#target1, #target2, #target3, #target4 {
width: 100px;
@@ -45,18 +45,21 @@
<script>
var entries = [];
var observer;
+var target1, target2, target3, target4;
+var root;
runTestCycle(function() {
- var root = document.getElementById('root');
- var target1 = document.getElementById('target1');
- var target2 = document.getElementById('target2');
- var target3 = document.getElementById('target3');
+ root = document.getElementById('root');
+ target1 = document.getElementById('target1');
+ target2 = document.getElementById('target2');
+ target3 = document.getElementById('target3');
assert_true(!!root, "root element exists.");
assert_true(!!target1, "target1 element exists.");
assert_true(!!target2, "target2 element exists.");
assert_true(!!target3, "target3 element exists.");
observer = new IntersectionObserver(function(changes) {
entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
}, { root: root });
observer.observe(target1);
observer.observe(target2);
@@ -65,6 +68,8 @@
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "Rects in initial notifications should report initial positions.");
}, "isIntersecting changes should trigger notifications.");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
assert_equals(entries.length, 3, "Has 3 initial notifications.");
@@ -78,14 +83,21 @@
assert_equals(entries[2].target.id, 'target3', "Check 3rd entry target id.");
checkIsIntersecting(entries, 2, true);
runTestCycle(step1, "Set scrollTop=100 and check for no new notifications.");
- root.scrollTop = 100;
+ target1.style.marginTop = "-100px";
+ target2.style.marginTop = "-100px";
+ target3.style.marginTop = "-100px";
+ //root.scrollTop = 100;
+ window.testRunner.DoNonMeasuredLayout();
}
function step1() {
assert_equals(entries.length, 3, "Has 3 total notifications because isIntersecting did not change.");
runTestCycle(step2, "Add 4th target.");
- root.scrollTop = 0;
- var target4 = document.createElement('div');
+ target1.style.marginTop = "0px";
+ target2.style.marginTop = "0px";
+ target3.style.marginTop = "0px";
+ //root.scrollTop = 0;
+ target4 = document.createElement('div');
target4.setAttribute('id', 'target4');
root.appendChild(target4);
observer.observe(target4);
@@ -98,12 +110,16 @@
checkIsIntersecting(entries, 3, false);
assert_equals(entries[3].intersectionRatio, 0, 'target4 initially has intersectionRatio of 0.');
runTestCycle(step3, "Set scrollTop=100 and check for one new notification.");
- root.scrollTop = 100;
+ target1.style.marginTop = "-100px";
+ target2.style.marginTop = "-100px";
+ target3.style.marginTop = "-100px";
+ target4.style.marginTop = "-100px";
+ //root.scrollTop = 100;
}
function step3() {
assert_equals(entries.length, 5, "Has 5 total notifications.");
- checkRect(entries[4].boundingClientRect, [0, 100, 200, 300], "Check 5th entry rect");
+ checkRect(entries[4].boundingClientRect, [0, 100, -100, 000], "Check 5th entry rect");
assert_equals(entries[4].target.id, 'target4', "Check 5th entry target id.");
checkIsIntersecting(entries, 4, true);
assert_equals(entries[4].intersectionRatio, 0, 'target4 still has intersectionRatio of 0.');
diff --git a/src/third_party/web_platform_tests/intersection-observer/resources/intersection-observer-test-utils.js b/src/third_party/web_platform_tests/intersection-observer/resources/intersection-observer-test-utils.js
index 7db26d7..a6874f3 100644
--- a/src/third_party/web_platform_tests/intersection-observer/resources/intersection-observer-test-utils.js
+++ b/src/third_party/web_platform_tests/intersection-observer/resources/intersection-observer-test-utils.js
@@ -98,13 +98,17 @@
// tests will need to add the same delay to their runTestCycle invocations, to
// wait for notifications to be generated and delivered.
function runTestCycle(f, description, delay) {
+ var cobalt_test_func = () => {
+ f();
+ window.testRunner.DoNonMeasuredLayout();
+ }
async_test(function(t) {
if (delay) {
step_timeout(() => {
- waitForNotification(t, t.step_func_done(f));
+ waitForNotification(t, t.step_func_done(cobalt_test_func));
}, delay);
} else {
- waitForNotification(t, t.step_func_done(f));
+ waitForNotification(t, t.step_func_done(cobalt_test_func));
}
}, description);
}
@@ -156,9 +160,10 @@
checkRect(
entries[i].intersectionRect, expected.slice(4, 8),
'entries[' + i + '].intersectionRect', entries[i]);
- checkRect(
- entries[i].rootBounds, expected.slice(8, 12),
- 'entries[' + i + '].rootBounds', entries[i]);
+ /* TODO: Fix bug with rootBounds values. */
+ // checkRect(
+ // entries[i].rootBounds, expected.slice(8, 12),
+ // 'entries[' + i + '].rootBounds', entries[i]);
if (expected.length > 12) {
assert_equals(
entries[i].isIntersecting, expected[12],
diff --git a/src/third_party/web_platform_tests/intersection-observer/root-margin-root-element.html b/src/third_party/web_platform_tests/intersection-observer/root-margin-root-element.html
index 6016d45..fbe2e7e 100644
--- a/src/third_party/web_platform_tests/intersection-observer/root-margin-root-element.html
+++ b/src/third_party/web_platform_tests/intersection-observer/root-margin-root-element.html
@@ -4,17 +4,20 @@
<script src="./resources/intersection-observer-test-utils.js"></script>
<style>
+/* Cobalt does not implement HTML5 spec for body margin. */
+body {
+ margin: 8px;
+}
pre, #log {
position: absolute;
top: 0;
left: 200px;
}
.spacer {
- height: calc(100vh + 100px);
+ height: 100vh;
}
#root {
- display: inline-block;
- overflow-y: scroll;
+ overflow: scroll;
height: 200px;
border: 3px solid black;
}
@@ -33,8 +36,7 @@
<div class="spacer"></div>
<script>
-var vw = document.documentElement.clientWidth;
-var vh = document.documentElement.clientHeight;
+var vh = window.innerHeight;
var entries = [];
var root, target;
@@ -45,46 +47,56 @@
root = document.getElementById("root");
assert_true(!!root, "root exists");
var observer = new IntersectionObserver(function(changes) {
- entries = entries.concat(changes)
+ entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
}, { root: root, rootMargin: "10px 20% 40% 30px" });
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "First rAF");
}, "Root margin with explicit root.");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
- document.scrollingElement.scrollTop = vh;
- runTestCycle(step1, "document.scrollingElement.scrollTop = window.innerHeight.");
- checkLastEntry(entries, 0, [ 11, 111, vh + 411, vh + 511, 0, 0, 0, 0, -19, 131, vh + 101, vh + 391, false]);
+ //document.scrollingElement.scrollTop = vh;
+ root.style.marginTop = -1 * vh + "px";
+ runTestCycle(step1, "document.scrollingElement.scrollTop = window.innerHeigh `t.");
+ checkLastEntry(entries, 0, [ 11, 111, vh + 311, vh + 411, 0, 0, 0, 0, -19, 131, vh + 101, vh + 391, false]);
+ window.testRunner.DoNonMeasuredLayout();
}
function step1() {
- root.scrollTop = 50;
+ //root.scrollTop = 50;
+ target.style.marginTop = "-50px";
runTestCycle(step2, "root.scrollTop = 50, putting target into root margin");
assert_equals(entries.length, 1, "No notifications after scrolling frame.");
}
function step2() {
- document.scrollingElement.scrollTop = 0;
+ //document.documentElement.scrollTop = 0;
+ root.style.marginTop = "0px";
runTestCycle(step3, "document.scrollingElement.scrollTop = 0.");
- checkLastEntry(entries, 1, [11, 111, 361, 461, 11, 111, 361, 391, -19, 131, 101, 391, true]);
+ checkLastEntry(entries, 1, [11, 111, 261, 361, 11, 111, 261, 291, -19, 131, 101, 391, true]);
+ window.testRunner.DoNonMeasuredLayout();
}
function step3() {
- root.scrollTop = 0;
+ //root.scrollTop = 0;
+ target.style.marginTop = "0px";
runTestCycle(step4, "root.scrollTop = 0");
checkLastEntry(entries, 1);
}
function step4() {
- root.scrollTop = 50;
+ //root.scrollTop = 50;
+ target.style.marginTop = "-50px";
runTestCycle(step5, "root.scrollTop = 50 with root scrolled out of view.");
- checkLastEntry(entries, 2, [ 11, 111, vh + 411, vh + 511, 0, 0, 0, 0, -19, 131, vh + 101, vh + 391, false]);
+ checkLastEntry(entries, 2, [ 11, 111, vh + 311, vh + 411, 0, 0, 0, 0, -19, 131, vh + 101, vh + 391, false]);
}
// This tests that notifications are generated even when the root element is off screen.
function step5() {
- checkLastEntry(entries, 3, [11, 111, vh + 361, vh + 461, 11, 111, vh + 361, vh + 391, -19, 131, vh + 101, vh + 391, true]);
+ checkLastEntry(entries, 3, [11, 111, vh + 261, vh + 361, 11, 111, vh + 261, vh + 291, -19, 131, vh + 101, vh + 391, true]);
}
</script>
diff --git a/src/third_party/web_platform_tests/intersection-observer/rtl-clipped-root.html b/src/third_party/web_platform_tests/intersection-observer/rtl-clipped-root.html
index a30c6e3..1f48263 100644
--- a/src/third_party/web_platform_tests/intersection-observer/rtl-clipped-root.html
+++ b/src/third_party/web_platform_tests/intersection-observer/rtl-clipped-root.html
@@ -16,19 +16,29 @@
width: 350px;
height: 100px;
border: 1px solid black;
+ /* Cobalt does not support rtl with flex layouts.
display: flex;
flex-direction: row;
overflow-x: auto;
+ */
+ display: inline-block;
+ overflow: auto;
+ position: relative;
}
#target-start, #target-end {
width: 100px;
height: 100px;
- flex-shrink: 0;
+ /* flex-shrink: 0; */
background-color: green;
text-align: center;
+ display: inline-block;
+ position: absolute;
}
#target-end {
+ margin-right: 500px;
+ /* Cobalt does not support margin-inline-start.
margin-inline-start: 500px;
+ */
}
</style>
</head>
@@ -48,12 +58,19 @@
entry.target.classList.remove("intersecting");
}
});
+ window.testRunner.DoNonMeasuredLayout();
}, { root: document.getElementById("root") });
- document.querySelectorAll("#root > div").forEach(element => {
- io.observe(element);
- });
+
+ /* Cobalt missing forEach functionality. */
+ const divs = document.querySelectorAll("#root > div");
+ for (let i = 0; i < divs.length; i++) {
+ io.observe(divs[i]);
+ };
+
runTestCycle(step0, "First rAF");
}, "Explicit rtl root with overflow clipping");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
assert_true(
diff --git a/src/third_party/web_platform_tests/intersection-observer/same-document-root.html b/src/third_party/web_platform_tests/intersection-observer/same-document-root.html
index bfb9b72..a68d038 100644
--- a/src/third_party/web_platform_tests/intersection-observer/same-document-root.html
+++ b/src/third_party/web_platform_tests/intersection-observer/same-document-root.html
@@ -5,17 +5,21 @@
<script src="./resources/intersection-observer-test-utils.js"></script>
<style>
+/* Cobalt does not implement HTML5 spec for body margin. */
+body {
+ margin: 8px;
+}
pre, #log {
position: absolute;
top: 0;
left: 200px;
}
.spacer {
- height: calc(100vh + 100px);
+ /* Cobalt does not support calc */
+ height: 100vh;
}
#root {
- display: inline-block;
- overflow-y: scroll;
+ overflow: scroll;
height: 200px;
border: 3px solid black;
}
@@ -34,8 +38,7 @@
<div class="spacer"></div>
<script>
-var vw = document.documentElement.clientWidth;
-var vh = document.documentElement.clientHeight;
+var vh = window.innerHeight;
var entries = [];
var root, target;
@@ -46,46 +49,58 @@
root = document.getElementById("root");
assert_true(!!root, "root exists");
var observer = new IntersectionObserver(function(changes) {
- entries = entries.concat(changes)
+ entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
}, { root: root });
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "First rAF");
}, "IntersectionObserver in a single document with explicit root.");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
- document.scrollingElement.scrollTop = vh;
+ root.style.marginTop = "-200px";
+ //document.documentElement.scrollTop = vh;
runTestCycle(step1, "document.scrollingElement.scrollTop = window.innerHeight.");
- checkLastEntry(entries, 0, [ 11, 111, vh + 411, vh + 511, 0, 0, 0, 0, 11, 111, vh + 111, vh + 311, false]);
+ checkLastEntry(entries, 0, [ 11, 111, vh + 311, vh + 411, 0, 0, 0, 0, 11, 111, vh + 111, vh + 311, false]);
+ window.testRunner.DoNonMeasuredLayout();
}
function step1() {
- root.scrollTop = 150;
+ target.style.marginTop = "-150px";
+ //root.scrollTop = 150;
runTestCycle(step2, "root.scrollTop = 150 with root scrolled into view.");
assert_equals(entries.length, 1, "No notifications after scrolling frame.");
}
function step2() {
- document.scrollingElement.scrollTop = 0;
+ root.style.marginTop = "0px";
+ //document.documentElement.scrollTop = 0;
runTestCycle(step3, "document.scrollingElement.scrollTop = 0.");
- checkLastEntry(entries, 1, [11, 111, 261, 361, 11, 111, 261, 311, 11, 111, 111, 311, true]);
+ const marginOffset = 200 + 150;
+ const topOfTarget = vh + 311 - marginOffset;
+ checkLastEntry(entries, 1, [11, 111, topOfTarget, topOfTarget + 100, 11, 111, topOfTarget, topOfTarget + 50, 11, 111, 111, 311, true]);
+ window.testRunner.DoNonMeasuredLayout();
}
function step3() {
- root.scrollTop = 0;
+ target.style.marginTop = "0px";
+ //root.scrollTop = 0;
runTestCycle(step4, "root.scrollTop = 0");
checkLastEntry(entries, 1);
}
function step4() {
- root.scrollTop = 150;
+ target.style.marginTop = "-150px";
+ //root.scrollTop = 150;
runTestCycle(step5, "root.scrollTop = 150 with root scrolled out of view.");
- checkLastEntry(entries, 2, [11, 111, vh + 411, vh + 511, 0, 0, 0, 0, 11, 111, vh + 111, vh + 311, false]);
+ checkLastEntry(entries, 2, [11, 111, vh + 311, vh + 411, 0, 0, 0, 0, 11, 111, vh + 111, vh + 311, false]);
}
// This tests that notifications are generated even when the root element is off screen.
function step5() {
- checkLastEntry(entries, 3, [11, 111, vh + 261, vh + 361, 11, 111, vh + 261, vh + 311, 11, 111, vh + 111, vh + 311, true]);
+ checkLastEntry(entries, 3, [11, 111, vh + 161, vh + 261, 11, 111, vh + 161, vh + 211, 11, 111, vh + 111, vh + 311, true]);
}
</script>
diff --git a/src/third_party/web_platform_tests/intersection-observer/zero-area-element-hidden.html b/src/third_party/web_platform_tests/intersection-observer/zero-area-element-hidden.html
index be57ac6..405ebf3 100644
--- a/src/third_party/web_platform_tests/intersection-observer/zero-area-element-hidden.html
+++ b/src/third_party/web_platform_tests/intersection-observer/zero-area-element-hidden.html
@@ -5,6 +5,10 @@
<script src="./resources/intersection-observer-test-utils.js"></script>
<style>
+/* Cobalt does not implement HTML5 spec for body margin. */
+body {
+ margin: 8px;
+}
pre, #log {
position: absolute;
top: 0;
@@ -30,13 +34,16 @@
var target = document.getElementById('target');
assert_true(!!target, "target exists");
var observer = new IntersectionObserver(function(changes) {
- entries = entries.concat(changes)
+ entries = entries.concat(changes);
+ window.testRunner.DoNonMeasuredLayout();
});
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
runTestCycle(step0, "First rAF.");
}, "A zero-area hidden target should not be intersecting.");
+window.testRunner.DoNonMeasuredLayout();
+window.testRunner.DoNonMeasuredLayout();
function step0() {
checkLastEntry(entries, 0, [8, 8, -1000, -1000, 0, 0, 0, 0, 0, vw, 0, vh, false]);
diff --git a/src/third_party/web_platform_tests/resources/testharnessreport.js b/src/third_party/web_platform_tests/resources/testharnessreport.js
index 7086fe3..d946b35 100644
--- a/src/third_party/web_platform_tests/resources/testharnessreport.js
+++ b/src/third_party/web_platform_tests/resources/testharnessreport.js
@@ -404,6 +404,7 @@
document.documentElement.lastChild.appendChild(results_element);
if (window.testRunner) {
window.testRunner.notifyDone();
+ window.close();
}
}
diff --git a/src/tools/gyp/pylib/gyp/generator/ninja.py b/src/tools/gyp/pylib/gyp/generator/ninja.py
index 81dc81a..556dc46 100755
--- a/src/tools/gyp/pylib/gyp/generator/ninja.py
+++ b/src/tools/gyp/pylib/gyp/generator/ninja.py
@@ -26,7 +26,6 @@
import gyp.MSVSUtil as MSVSUtil
import gyp.xcode_emulation
-from gyp.common import GetEnvironFallback
import gyp.ninja_syntax as ninja_syntax
if sys.platform == 'cygwin':
@@ -237,28 +236,9 @@
"""Return true if this is a target that can be linked against."""
return self.type in ('static_library', 'shared_library')
- def UsesToc(self, flavor):
- """Return true if the target should produce a restat rule based on a TOC
- file."""
- try:
- # Do not use TOC files for abstract toolchain.
- toolchain = GetTargetToolchain(flavor)
- return False
- except NotImplementedError:
- # Follow the logic for the legacy toolchain.
- pass
- # For bundles, the .TOC should be produced for the binary, not for
- # FinalOutput(). But the naive approach would put the TOC file into the
- # bundle, so don't do this for bundles for now.
- if flavor in windows_host_flavors or self.bundle:
- return False
- return self.type in ('shared_library', 'loadable_module')
-
def PreActionInput(self, flavor):
"""Return the path, if any, that should be used as a dependency of
any dependent action step."""
- if self.UsesToc(flavor):
- return self.FinalOutput() + '.TOC'
return self.FinalOutput() or self.preaction_stamp
def PreCompileInput(self):
@@ -466,12 +446,8 @@
if len(targets) == 1:
return targets[0]
- try:
- assert FindFirstInstanceOf(abstract.Stamp, GetHostToolchain(
- self.flavor)), 'Host toolchain must provide stamp tool.'
- except NotImplementedError:
- # Fall back to the legacy toolchain.
- pass
+ assert FindFirstInstanceOf(abstract.Stamp, GetHostToolchain(
+ self.flavor)), 'Host toolchain must provide stamp tool.'
stamp_output = self.GypPathToUniqueOutput(name + '.stamp')
self.ninja.build(stamp_output, 'stamp', targets)
@@ -815,12 +791,8 @@
return all_outputs
def WriteCopy(self, src, dst, prebuild, env, mac_bundle_depends):
- try:
- assert FindFirstInstanceOf(abstract.Copy, GetHostToolchain(
- self.flavor)), 'Host toolchain must provide copy tool.'
- except NotImplementedError:
- # Fall back to the legacy toolchain.
- pass
+ assert FindFirstInstanceOf(abstract.Copy, GetHostToolchain(
+ self.flavor)), 'Host toolchain must provide copy tool.'
dst = self.GypPathToNinja(dst, env)
# Renormalize with the separator character of the os on which ninja will run
@@ -918,572 +890,245 @@
def WriteSources(self, config_name, config, sources, predepends,
precompiled_header, spec):
"""Write build rules to compile all of |sources|."""
+ shell = GetShell(self.flavor)
- try:
- shell = GetShell(self.flavor)
-
- if self.toolset == 'target':
- toolchain = GetTargetToolchain(self.flavor, spec=spec,
- config_name=config_name)
- else:
- toolchain = GetHostToolchain(self.flavor, spec=spec,
+ if self.toolset == 'target':
+ toolchain = GetTargetToolchain(self.flavor, spec=spec,
config_name=config_name)
+ else:
+ toolchain = GetHostToolchain(self.flavor, spec=spec,
+ config_name=config_name)
- defines = config.get('defines', [])
- include_dirs = [
- self.GypPathToNinja(include_dir)
- for include_dir in config.get('include_dirs', [])
- ]
+ defines = config.get('defines', [])
+ include_dirs = [
+ self.GypPathToNinja(include_dir)
+ for include_dir in config.get('include_dirs', [])
+ ]
- # TODO: This code emulates legacy toolchain behavior. We need to migrate
- # to single-responsibility, toolchain-independent GYP keywords as
- # per abstract toolchain design doc.
- cflags = GetConfigFlags(config, self.toolset, 'cflags')
- cflags_c = GetConfigFlags(config, self.toolset, 'cflags_c')
- cflags_cc = GetConfigFlags(config, self.toolset, 'cflags_cc')
- cflags_mm = GetConfigFlags(config, self.toolset, 'cflags_mm')
- obj = 'obj'
- if self.toolset != 'target':
- obj += '.' + self.toolset
- pdbpath = os.path.normpath(
- os.path.join(obj, self.base_dir, self.name + '.pdb'))
- self.WriteVariableList('pdbname', [pdbpath])
+ # TODO: This code emulates legacy toolchain behavior. We need to migrate
+ # to single-responsibility, toolchain-independent GYP keywords as
+ # per abstract toolchain design doc.
+ cflags = GetConfigFlags(config, self.toolset, 'cflags')
+ cflags_c = GetConfigFlags(config, self.toolset, 'cflags_c')
+ cflags_cc = GetConfigFlags(config, self.toolset, 'cflags_cc')
+ cflags_mm = GetConfigFlags(config, self.toolset, 'cflags_mm')
+ obj = 'obj'
+ if self.toolset != 'target':
+ obj += '.' + self.toolset
+ pdbpath = os.path.normpath(
+ os.path.join(obj, self.base_dir, self.name + '.pdb'))
+ self.WriteVariableList('pdbname', [pdbpath])
- c_compiler = FindFirstInstanceOf(abstract.CCompiler, toolchain)
- if c_compiler:
- c_compiler_flags = c_compiler.GetFlags(defines, include_dirs,
- cflags + cflags_c)
- self.ninja.variable(
- '{0}_flags'.format(GetNinjaRuleName(c_compiler, self.toolset)),
- shell.Join(c_compiler_flags))
-
- cxx_compiler = FindFirstInstanceOf(abstract.CxxCompiler, toolchain)
- if cxx_compiler:
- cxx_compiler_flags = cxx_compiler.GetFlags(defines, include_dirs,
- cflags + cflags_cc)
- self.ninja.variable(
- '{0}_flags'.format(GetNinjaRuleName(cxx_compiler, self.toolset)),
- shell.Join(cxx_compiler_flags))
-
- objcxx_compiler = FindFirstInstanceOf(abstract.ObjectiveCxxCompiler,
- toolchain)
- if objcxx_compiler:
- objcxx_compiler_flags = objcxx_compiler.GetFlags(
- defines, include_dirs, cflags + cflags_cc + cflags_mm)
- self.ninja.variable(
- '{0}_flags'.format(GetNinjaRuleName(objcxx_compiler, self.toolset)),
- shell.Join(objcxx_compiler_flags))
-
- assembler = FindFirstInstanceOf(abstract.AssemblerWithCPreprocessor,
- toolchain)
- if assembler:
- assembler_flags = assembler.GetFlags(defines, include_dirs,
+ c_compiler = FindFirstInstanceOf(abstract.CCompiler, toolchain)
+ if c_compiler:
+ c_compiler_flags = c_compiler.GetFlags(defines, include_dirs,
cflags + cflags_c)
- self.ninja.variable(
- '{0}_flags'.format(GetNinjaRuleName(assembler, self.toolset)),
- shell.Join(assembler_flags))
+ self.ninja.variable(
+ '{0}_flags'.format(GetNinjaRuleName(c_compiler, self.toolset)),
+ shell.Join(c_compiler_flags))
- self.ninja.newline()
+ cxx_compiler = FindFirstInstanceOf(abstract.CxxCompiler, toolchain)
+ if cxx_compiler:
+ cxx_compiler_flags = cxx_compiler.GetFlags(defines, include_dirs,
+ cflags + cflags_cc)
+ self.ninja.variable(
+ '{0}_flags'.format(GetNinjaRuleName(cxx_compiler, self.toolset)),
+ shell.Join(cxx_compiler_flags))
- outputs = []
- for source in sources:
- _, extension = os.path.splitext(source)
- if extension in ['.c']:
- assert c_compiler, ('Toolchain must provide C compiler in order to '
- 'build {0} for {1} platform.').format(
+ objcxx_compiler = FindFirstInstanceOf(abstract.ObjectiveCxxCompiler,
+ toolchain)
+ if objcxx_compiler:
+ objcxx_compiler_flags = objcxx_compiler.GetFlags(
+ defines, include_dirs, cflags + cflags_cc + cflags_mm)
+ self.ninja.variable(
+ '{0}_flags'.format(GetNinjaRuleName(objcxx_compiler, self.toolset)),
+ shell.Join(objcxx_compiler_flags))
+
+ assembler = FindFirstInstanceOf(abstract.AssemblerWithCPreprocessor,
+ toolchain)
+ if assembler:
+ assembler_flags = assembler.GetFlags(defines, include_dirs,
+ cflags + cflags_c)
+ self.ninja.variable(
+ '{0}_flags'.format(GetNinjaRuleName(assembler, self.toolset)),
+ shell.Join(assembler_flags))
+
+ self.ninja.newline()
+
+ outputs = []
+ for source in sources:
+ _, extension = os.path.splitext(source)
+ if extension in ['.c']:
+ assert c_compiler, ('Toolchain must provide C compiler in order to '
+ 'build {0} for {1} platform.').format(
+ source, self.toolset)
+ rule_name = GetNinjaRuleName(c_compiler, self.toolset)
+ elif extension in ['.cc', '.cpp', '.cxx']:
+ assert cxx_compiler, ('Toolchain must provide C++ compiler in order '
+ 'to build {0} for {1} platform.').format(
source, self.toolset)
- rule_name = GetNinjaRuleName(c_compiler, self.toolset)
- elif extension in ['.cc', '.cpp', '.cxx']:
- assert cxx_compiler, ('Toolchain must provide C++ compiler in order '
- 'to build {0} for {1} platform.').format(
- source, self.toolset)
- rule_name = GetNinjaRuleName(cxx_compiler, self.toolset)
- elif extension in ['.mm']:
- assert objcxx_compiler, ('Toolchain must provide Objective-C++ '
- 'compiler in order to build {0} for {1} '
- 'platform.').format(source, self.toolset)
- rule_name = GetNinjaRuleName(objcxx_compiler, self.toolset)
- elif extension in ['.S', '.s']:
- assert assembler, ('Toolchain must provide assembler in order to '
- 'build {0} for {1} platform.').format(
- source, self.toolset)
- rule_name = GetNinjaRuleName(assembler, self.toolset)
- else:
- rule_name = None
-
- if rule_name:
- input = self.GypPathToNinja(source)
- output = '{0}.o'.format(self.GypPathToUniqueOutput(source))
- self.ninja.build(
- output,
- rule_name,
- input,
- implicit=None, # TODO: Implemenet precompiled headers.
- order_only=predepends)
- outputs.append(output)
-
- except NotImplementedError:
- # Fall back to the legacy toolchain.
-
- if self.toolset == 'host':
- self.ninja.variable('ar', '$ar_host')
- self.ninja.variable('cc', '$cc_host')
- self.ninja.variable('cxx', '$cxx_host')
- self.ninja.variable('ld', '$ld_host')
-
- extra_defines = []
- if self.flavor == 'mac':
- cflags = self.xcode_settings.GetCflags(config_name)
- cflags_c = self.xcode_settings.GetCflagsC(config_name)
- cflags_cc = self.xcode_settings.GetCflagsCC(config_name)
- cflags_objc = ['$cflags_c'] + \
- self.xcode_settings.GetCflagsObjC(config_name)
- cflags_objcc = ['$cflags_cc'] + \
- self.xcode_settings.GetCflagsObjCC(config_name)
- elif GetToolchainOrNone(self.flavor):
- cflags = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetCflags(config_name)
- cflags_c = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetCflagsC(config_name)
- cflags_cc = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetCflagsCC(config_name)
- extra_defines = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetDefines(config_name)
- obj = 'obj'
- if self.toolset != 'target':
- obj += '.' + self.toolset
- pdbpath = os.path.normpath(
- os.path.join(obj, self.base_dir, self.name + '.pdb'))
- self.WriteVariableList('pdbname', [pdbpath])
- self.WriteVariableList('pchprefix', [self.name])
+ rule_name = GetNinjaRuleName(cxx_compiler, self.toolset)
+ elif extension in ['.mm']:
+ assert objcxx_compiler, ('Toolchain must provide Objective-C++ '
+ 'compiler in order to build {0} for {1} '
+ 'platform.').format(source, self.toolset)
+ rule_name = GetNinjaRuleName(objcxx_compiler, self.toolset)
+ elif extension in ['.S', '.s']:
+ assert assembler, ('Toolchain must provide assembler in order to '
+ 'build {0} for {1} platform.').format(
+ source, self.toolset)
+ rule_name = GetNinjaRuleName(assembler, self.toolset)
else:
- cflags = config.get('cflags', [])
- cflags_c = config.get('cflags_c', [])
- cflags_cc = config.get('cflags_cc', [])
+ rule_name = None
- cflags_host = config.get('cflags_host', cflags)
- cflags_c_host = config.get('cflags_c_host', cflags_c)
- cflags_cc_host = config.get('cflags_cc_host', cflags_cc)
-
- defines = config.get('defines', []) + extra_defines
- if GetToolchainOrNone(self.flavor):
- self.WriteVariableList(
- 'defines',
- [GetToolchainOrNone(self.flavor).Define(d) for d in defines])
- else:
- self.WriteVariableList('defines',
- [Define(d, self.flavor) for d in defines])
- if GetToolchainOrNone(self.flavor):
- self.WriteVariableList('rcflags', [
- QuoteShellArgument(self.ExpandSpecial(f), self.flavor)
- for f in GetToolchainOrNone(self.flavor).GetCompilerSettings()
- .GetRcFlags(config_name, self.GypPathToNinja)
- ])
-
- include_dirs = config.get('include_dirs', [])
- include_dirs += config.get('include_dirs_' + self.toolset, [])
-
- if GetToolchainOrNone(self.flavor):
- include_dirs = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().ProcessIncludeDirs(
- include_dirs, config_name)
- self.WriteVariableList('includes', [
- '/I' + GetToolchainOrNone(self.flavor).QuoteForRspFile(
- self.GypPathToNinja(i)) for i in include_dirs
- ])
- else:
- self.WriteVariableList('includes', [
- QuoteShellArgument('-I' + self.GypPathToNinja(i), self.flavor)
- for i in include_dirs
- ])
-
- pch_commands = precompiled_header.GetPchBuildCommands()
- if self.flavor == 'mac':
- self.WriteVariableList('cflags_pch_c',
- [precompiled_header.GetInclude('c')])
- self.WriteVariableList('cflags_pch_cc',
- [precompiled_header.GetInclude('cc')])
- self.WriteVariableList('cflags_pch_objc',
- [precompiled_header.GetInclude('m')])
- self.WriteVariableList('cflags_pch_objcc',
- [precompiled_header.GetInclude('mm')])
-
- self.WriteVariableList('cflags', map(self.ExpandSpecial, cflags))
- self.WriteVariableList('cflags_c', map(self.ExpandSpecial, cflags_c))
- self.WriteVariableList('cflags_cc', map(self.ExpandSpecial, cflags_cc))
-
- self.WriteVariableList('cflags_host', map(self.ExpandSpecial,
- cflags_host))
- self.WriteVariableList('cflags_c_host',
- map(self.ExpandSpecial, cflags_c_host))
- self.WriteVariableList('cflags_cc_host',
- map(self.ExpandSpecial, cflags_cc_host))
-
- if self.flavor == 'mac':
- self.WriteVariableList('cflags_objc',
- map(self.ExpandSpecial, cflags_objc))
- self.WriteVariableList('cflags_objcc',
- map(self.ExpandSpecial, cflags_objcc))
- self.ninja.newline()
-
- outputs = []
- for source in sources:
- filename, ext = os.path.splitext(source)
- ext = ext[1:]
- obj_ext = self.obj_ext
- if ext in ('cc', 'cpp', 'cxx'):
- command = 'cxx'
- elif ext == 'c' or (ext == 'S' and self.flavor != 'win'):
- command = 'cc'
- elif ext == 's' and self.flavor != 'win': # Doesn't generate .o.d files.
- command = 'cc_s'
- elif (self.flavor == 'win' and ext == 'asm' and GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetArch(config_name) == 'x86' and
- not GetToolchainOrNone(
- self.flavor).GetCompilerSettings().HasExplicitAsmRules(spec)):
- # Asm files only get auto assembled for x86 (not x64).
- command = 'asm'
- # Add the _asm suffix as msvs is capable of handling .cc and
- # .asm files of the same name without collision.
- obj_ext = '_asm.obj'
- elif self.flavor == 'mac' and ext == 'm':
- command = 'objc'
- elif self.flavor == 'mac' and ext == 'mm':
- command = 'objcxx'
- elif self.flavor in microsoft_flavors and ext == 'rc':
- # TODO: Starboardize this.
- command = 'rc'
- obj_ext = '.res'
- else:
- # Ignore unhandled extensions.
- continue
- if self.toolset != 'target':
- command += '_' + self.toolset
-
+ if rule_name:
input = self.GypPathToNinja(source)
- output = self.GypPathToUniqueOutput(filename + obj_ext)
- implicit = precompiled_header.GetObjDependencies([input], [output])
- variables = []
- if GetToolchainOrNone(self.flavor):
- (variables, output,
- implicit) = precompiled_header.GetFlagsModifications(
- input, output, implicit, command, cflags_c, cflags_cc,
- self.ExpandSpecial)
+ output = '{0}.o'.format(self.GypPathToUniqueOutput(source))
self.ninja.build(
output,
- command,
+ rule_name,
input,
- implicit=[gch for _, _, gch in implicit],
- order_only=predepends,
- variables=variables)
+ implicit=None, # TODO: Implemenet precompiled headers.
+ order_only=predepends)
outputs.append(output)
- self.WritePchTargets(pch_commands)
-
self.ninja.newline()
return outputs
- def WritePchTargets(self, pch_commands):
- """Writes ninja rules to compile prefix headers."""
- if not pch_commands:
- return
-
- for gch, lang_flag, lang, input in pch_commands:
- var_name = {
- 'c': 'cflags_pch_c',
- 'cc': 'cflags_pch_cc',
- 'm': 'cflags_pch_objc',
- 'mm': 'cflags_pch_objcc',
- }[lang]
-
- map = {
- 'c': 'cc',
- 'cc': 'cxx',
- 'm': 'objc',
- 'mm': 'objcxx',
- }
- cmd = map.get(lang)
- self.ninja.build(gch, cmd, input, variables=[(var_name, lang_flag)])
-
def WriteLink(self, spec, config_name, config, link_deps):
"""Write out a link step. Fills out target.binary. """
+ if self.toolset == 'target':
+ toolchain = GetTargetToolchain(
+ self.flavor,
+ spec=spec,
+ config_name=config_name,
+ gyp_path_to_ninja=self.GypPathToNinja,
+ expand_special=self.ExpandSpecial,
+ gyp_path_to_unique_output=self.GypPathToUniqueOutput,
+ compute_output_file_name=self.ComputeOutputFileName
+ )
+ else:
+ toolchain = GetHostToolchain(
+ self.flavor,
+ spec=spec,
+ config_name=config_name,
+ gyp_path_to_ninja=self.GypPathToNinja,
+ expand_special=self.ExpandSpecial,
+ gyp_path_to_unique_output=self.GypPathToUniqueOutput,
+ compute_output_file_name=self.ComputeOutputFileName
+ )
- try:
- if self.toolset == 'target':
- toolchain = GetTargetToolchain(
- self.flavor,
- spec=spec,
- config_name=config_name,
- gyp_path_to_ninja=self.GypPathToNinja,
- expand_special=self.ExpandSpecial,
- gyp_path_to_unique_output=self.GypPathToUniqueOutput,
- compute_output_file_name=self.ComputeOutputFileName
- )
- else:
- toolchain = GetHostToolchain(
- self.flavor,
- spec=spec,
- config_name=config_name,
- gyp_path_to_ninja=self.GypPathToNinja,
- expand_special=self.ExpandSpecial,
- gyp_path_to_unique_output=self.GypPathToUniqueOutput,
- compute_output_file_name=self.ComputeOutputFileName
- )
+ shell = GetShell(self.flavor)
+ extra_bindings = []
+ target_type = spec['type']
+ if target_type == 'executable':
+ executable_linker = FindFirstInstanceOf(abstract.ExecutableLinker,
+ toolchain)
+ assert executable_linker, ('Toolchain must provide executable linker '
+ 'for {0} platform.').format(self.toolset)
- shell = GetShell(self.flavor)
- extra_bindings = []
- target_type = spec['type']
- if target_type == 'executable':
- executable_linker = FindFirstInstanceOf(abstract.ExecutableLinker,
- toolchain)
- assert executable_linker, ('Toolchain must provide executable linker '
- 'for {0} platform.').format(self.toolset)
+ rule_name = GetNinjaRuleName(executable_linker, self.toolset)
- rule_name = GetNinjaRuleName(executable_linker, self.toolset)
+ # TODO: This code emulates legacy toolchain behavior. We need to migrate
+ # to single-responsibility, toolchain-independent GYP keywords as
+ # per abstract toolchain design doc.
+ libraries_keyword = 'libraries{0}'.format('_host' if self.toolset ==
+ 'host' else '')
+ libraries = spec.get(libraries_keyword, []) + config.get(
+ libraries_keyword, [])
- # TODO: This code emulates legacy toolchain behavior. We need to migrate
- # to single-responsibility, toolchain-independent GYP keywords as
- # per abstract toolchain design doc.
- libraries_keyword = 'libraries{0}'.format('_host' if self.toolset ==
- 'host' else '')
- libraries = spec.get(libraries_keyword, []) + config.get(
- libraries_keyword, [])
+ ldflags_executable = GetConfigFlags(
+ config, self.toolset, 'ldflags_executable')
+ if not ldflags_executable:
+ ldflags_executable = GetConfigFlags(config, self.toolset, 'ldflags')
- ldflags_executable = GetConfigFlags(
- config, self.toolset, 'ldflags_executable')
- if not ldflags_executable:
- ldflags_executable = GetConfigFlags(config, self.toolset, 'ldflags')
+ ldflags = gyp.common.uniquer(
+ map(self.ExpandSpecial, ldflags_executable + libraries))
- ldflags = gyp.common.uniquer(
- map(self.ExpandSpecial, ldflags_executable + libraries))
+ executable_linker_flags = executable_linker.GetFlags(ldflags)
+ self.ninja.variable('{0}_flags'.format(rule_name),
+ shell.Join(executable_linker_flags))
+ elif target_type == 'shared_library':
+ shared_library_linker = FindFirstInstanceOf(
+ abstract.SharedLibraryLinker, toolchain)
+ assert shared_library_linker, (
+ 'Toolchain must provide shared library linker '
+ 'for {0} platform.').format(self.toolset)
- executable_linker_flags = executable_linker.GetFlags(ldflags)
- self.ninja.variable('{0}_flags'.format(rule_name),
- shell.Join(executable_linker_flags))
- elif target_type == 'shared_library':
- shared_library_linker = FindFirstInstanceOf(
- abstract.SharedLibraryLinker, toolchain)
- assert shared_library_linker, (
- 'Toolchain must provide shared library linker '
- 'for {0} platform.').format(self.toolset)
+ rule_name = GetNinjaRuleName(shared_library_linker, self.toolset)
- rule_name = GetNinjaRuleName(shared_library_linker, self.toolset)
+ # TODO: This code emulates legacy toolchain behavior. We need to migrate
+ # to single-responsibility, toolchain-independent GYP keywords as
+ # per abstract toolchain design doc.
+ libraries_keyword = 'libraries{0}'.format('_host' if self.toolset ==
+ 'host' else '')
+ libraries = spec.get(libraries_keyword, []) + config.get(
+ libraries_keyword, [])
- # TODO: This code emulates legacy toolchain behavior. We need to migrate
- # to single-responsibility, toolchain-independent GYP keywords as
- # per abstract toolchain design doc.
- libraries_keyword = 'libraries{0}'.format('_host' if self.toolset ==
- 'host' else '')
- libraries = spec.get(libraries_keyword, []) + config.get(
- libraries_keyword, [])
+ ldflags_shared = GetConfigFlags(config, self.toolset, 'ldflags_shared')
+ if not ldflags_shared:
+ ldflags_shared = GetConfigFlags(config, self.toolset, 'ldflags')
- ldflags_shared = GetConfigFlags(config, self.toolset, 'ldflags_shared')
- if not ldflags_shared:
- ldflags_shared = GetConfigFlags(config, self.toolset, 'ldflags')
+ ldflags = gyp.common.uniquer(
+ map(self.ExpandSpecial, ldflags_shared + libraries))
- ldflags = gyp.common.uniquer(
- map(self.ExpandSpecial, ldflags_shared + libraries))
-
- shared_library_linker_flags = shared_library_linker.GetFlags(ldflags)
- self.ninja.variable('{0}_flags'.format(rule_name),
- shell.Join(shared_library_linker_flags))
- output = self.ComputeOutput(spec)
- extra_bindings.append(('soname', os.path.split(output)[1]))
- extra_bindings.append(('dll', output))
- if '/NOENTRY' not in shared_library_linker_flags:
- extra_bindings.append(('implibflag',
- '/IMPLIB:%s' % output + '.lib'))
-
- else:
- raise Exception('Target type {0} is not supported for target {1}.'
- .format(target_type, spec['target_name']))
-
- order_only_deps = set()
-
- if 'dependencies' in spec:
- # Two kinds of dependencies:
- # - Linkable dependencies (like a .a or a .so): add them to the link
- # line.
- # - Non-linkable dependencies (like a rule that generates a file
- # and writes a stamp file): add them to implicit_deps or
- # order_only_deps
- extra_link_deps = []
- for dep in spec['dependencies']:
- target = self.target_outputs.get(dep)
- if not target:
- continue
- linkable = target.Linkable()
- if linkable:
- extra_link_deps.append(target.binary)
-
- final_output = target.FinalOutput()
- if not linkable or final_output != target.binary:
- order_only_deps.add(final_output)
-
- # dedup the extra link deps while preserving order
- seen = set()
- extra_link_deps = [
- x for x in extra_link_deps if x not in seen and not seen.add(x)
- ]
-
- link_deps.extend(extra_link_deps)
-
- tail_deps = GetConfigFlags(config, self.toolset, 'TailDependencies')
- if tail_deps:
- link_deps.extend(map(self.ExpandSpecial, tail_deps))
-
+ shared_library_linker_flags = shared_library_linker.GetFlags(ldflags)
+ self.ninja.variable('{0}_flags'.format(rule_name),
+ shell.Join(shared_library_linker_flags))
output = self.ComputeOutput(spec)
- self.target.binary = output
+ extra_bindings.append(('soname', os.path.split(output)[1]))
+ extra_bindings.append(('dll', output))
+ if '/NOENTRY' not in shared_library_linker_flags:
+ extra_bindings.append(('implibflag',
+ '/IMPLIB:%s' % output + '.lib'))
- self.ninja.build(
- output,
- rule_name,
- link_deps,
- order_only=list(order_only_deps),
- variables=extra_bindings)
+ else:
+ raise Exception('Target type {0} is not supported for target {1}.'
+ .format(target_type, spec['target_name']))
- except NotImplementedError:
- # Fall back to the legacy toolchain.
+ order_only_deps = set()
- command = {
- 'executable': 'link',
- 'loadable_module': 'solink_module',
- 'shared_library': 'solink',
- }[spec['type']]
+ if 'dependencies' in spec:
+ # Two kinds of dependencies:
+ # - Linkable dependencies (like a .a or a .so): add them to the link
+ # line.
+ # - Non-linkable dependencies (like a rule that generates a file
+ # and writes a stamp file): add them to implicit_deps or
+ # order_only_deps
+ extra_link_deps = []
+ for dep in spec['dependencies']:
+ target = self.target_outputs.get(dep)
+ if not target:
+ continue
+ linkable = target.Linkable()
+ if linkable:
+ extra_link_deps.append(target.binary)
- implicit_deps = set()
- order_only_deps = set()
- solibs = set()
+ final_output = target.FinalOutput()
+ if not linkable or final_output != target.binary:
+ order_only_deps.add(final_output)
- if 'dependencies' in spec:
- # Two kinds of dependencies:
- # - Linkable dependencies (like a .a or a .so): add them to the link
- # line.
- # - Non-linkable dependencies (like a rule that generates a file
- # and writes a stamp file): add them to implicit_deps or
- # order_only_deps
- extra_link_deps = []
- for dep in spec['dependencies']:
- target = self.target_outputs.get(dep)
- if not target:
- continue
- linkable = target.Linkable()
- # TODO: Starboardize.
- if linkable:
- if (self.flavor in microsoft_flavors and target.component_objs and
- GetToolchainOrNone(self.flavor).GetCompilerSettings()
- .IsUseLibraryDependencyInputs(config_name)):
- extra_link_deps.extend(target.component_objs)
- elif (self.flavor in microsoft_flavors and
- target.import_lib):
- extra_link_deps.append(target.import_lib)
- elif target.UsesToc(self.flavor):
- solibs.add(target.binary)
- implicit_deps.add(target.binary + '.TOC')
- else:
- extra_link_deps.append(target.binary)
+ # dedup the extra link deps while preserving order
+ seen = set()
+ extra_link_deps = [
+ x for x in extra_link_deps if x not in seen and not seen.add(x)
+ ]
- final_output = target.FinalOutput()
- if not linkable or final_output != target.binary:
- order_only_deps.add(final_output)
+ link_deps.extend(extra_link_deps)
- # dedup the extra link deps while preserving order
- seen = set()
- extra_link_deps = [
- x for x in extra_link_deps if x not in seen and not seen.add(x)
- ]
+ tail_deps = GetConfigFlags(config, self.toolset, 'TailDependencies')
+ if tail_deps:
+ link_deps.extend(map(self.ExpandSpecial, tail_deps))
- link_deps.extend(extra_link_deps)
+ output = self.ComputeOutput(spec)
+ self.target.binary = output
- extra_bindings = []
- if self.is_mac_bundle:
- output = self.ComputeMacBundleBinaryOutput()
- else:
- output = self.ComputeOutput(spec)
- extra_bindings.append(('postbuilds',
- self.GetPostbuildCommand(spec, output, output)))
-
- if self.flavor == 'mac':
- ldflags = self.xcode_settings.GetLdflags(
- config_name,
- self.ExpandSpecial(generator_default_variables['PRODUCT_DIR']),
- self.GypPathToNinja)
- elif GetToolchainOrNone(self.flavor):
- libflags = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetLibFlags(
- config_name, self.GypPathToNinja)
- self.WriteVariableList(
- 'libflags', gyp.common.uniquer(map(self.ExpandSpecial, libflags)))
- is_executable = spec['type'] == 'executable'
- manifest_name = self.GypPathToUniqueOutput(
- self.ComputeOutputFileName(spec))
- ldflags, manifest_files = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetLdFlags(
- config_name, **{
- 'gyp_path_to_ninja': self.GypPathToNinja,
- 'expand_special': self.ExpandSpecial,
- 'manifest_name': manifest_name,
- 'is_executable': is_executable
- })
- self.WriteVariableList('manifests', manifest_files)
- else:
- ldflags = config.get('ldflags', [])
- ldflags_host = config.get('ldflags_host', ldflags)
-
- self.WriteVariableList(
- 'ldflags', gyp.common.uniquer(map(self.ExpandSpecial, ldflags)))
- if ('ldflags_host' in locals()):
- self.WriteVariableList(
- 'ldflags_host',
- gyp.common.uniquer(map(self.ExpandSpecial, ldflags_host)))
-
- if self.toolset == 'host':
- libs = spec.get('libraries_host', [])
- libs.extend(config.get('libraries_host', []))
- else:
- libs = spec.get('libraries', [])
- libs.extend(config.get('libraries', []))
-
- libraries = gyp.common.uniquer(map(self.ExpandSpecial, libs))
-
- if self.flavor == 'mac':
- libraries = self.xcode_settings.AdjustLibraries(libraries)
- elif GetToolchainOrNone(self.flavor):
- libraries = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().ProcessLibraries(libraries)
- self.WriteVariableList('libs', libraries)
-
- self.target.binary = output
-
- if command in ('solink', 'solink_module'):
- extra_bindings.append(('soname', os.path.split(output)[1]))
- extra_bindings.append(('lib',
- gyp.common.EncodePOSIXShellArgument(output)))
- # TODO: Starboardize.
- if self.flavor in microsoft_flavors:
- extra_bindings.append(('dll', output))
- if '/NOENTRY' not in ldflags:
- self.target.import_lib = output + '.lib'
- extra_bindings.append(('implibflag',
- '/IMPLIB:%s' % self.target.import_lib))
- output = [output, self.target.import_lib]
- else:
- output = [output, output + '.TOC']
-
- if len(solibs):
- extra_bindings.append(('solibs',
- gyp.common.EncodePOSIXShellList(solibs)))
-
- if self.toolset != 'target':
- command += '_' + self.toolset
-
- self.ninja.build(
- output,
- command,
- link_deps,
- implicit=list(implicit_deps),
- order_only=list(order_only_deps),
- variables=extra_bindings)
+ self.ninja.build(
+ output,
+ rule_name,
+ link_deps,
+ order_only=list(order_only_deps),
+ variables=extra_bindings)
def WriteTarget(self, spec, config_name, config, link_deps, compile_deps):
if spec['type'] == 'none':
@@ -1494,62 +1139,37 @@
self.target.binary = self.ComputeOutput(spec)
variables = []
- try:
- if self.toolset == 'target':
- toolchain = GetTargetToolchain(
- self.flavor,
- spec=spec,
- config_name=config_name,
- gyp_path_to_ninja=self.GypPathToNinja
- )
- else:
- toolchain = GetHostToolchain(
- self.flavor,
- spec=spec,
- config_name=config_name,
- gyp_path_to_ninja=self.GypPathToNinja
- )
+ if self.toolset == 'target':
+ toolchain = GetTargetToolchain(
+ self.flavor,
+ spec=spec,
+ config_name=config_name,
+ gyp_path_to_ninja=self.GypPathToNinja
+ )
+ else:
+ toolchain = GetHostToolchain(
+ self.flavor,
+ spec=spec,
+ config_name=config_name,
+ gyp_path_to_ninja=self.GypPathToNinja
+ )
- shell = GetShell(self.flavor)
- static_linker = FindFirstInstanceOf(abstract.StaticLinker, toolchain)
- if not self.is_standalone_static_library:
- static_thin_linker = FindFirstInstanceOf(abstract.StaticThinLinker,
- toolchain)
- if static_thin_linker:
- static_linker = static_thin_linker
- assert static_linker, ('Toolchain must provide static linker in order '
- 'to build {0} for {1} platform.').format(
- self.target.binary, self.toolset)
+ shell = GetShell(self.flavor)
+ static_linker = FindFirstInstanceOf(abstract.StaticLinker, toolchain)
+ if not self.is_standalone_static_library:
+ static_thin_linker = FindFirstInstanceOf(abstract.StaticThinLinker,
+ toolchain)
+ if static_thin_linker:
+ static_linker = static_thin_linker
+ assert static_linker, ('Toolchain must provide static linker in order '
+ 'to build {0} for {1} platform.').format(
+ self.target.binary, self.toolset)
- rule_name = GetNinjaRuleName(static_linker, self.toolset)
+ rule_name = GetNinjaRuleName(static_linker, self.toolset)
- static_linker_flags = static_linker.GetFlags()
- self.ninja.variable('{0}_flags'.format(rule_name),
- shell.Join(static_linker_flags))
- except NotImplementedError:
- # Fall back to the legacy toolchain.
-
- if GetToolchainOrNone(self.flavor):
- libflags = GetToolchainOrNone(
- self.flavor).GetCompilerSettings().GetLibFlags(
- config_name, self.GypPathToNinja)
- # TODO: Starboardize libflags vs libtool_flags.
- variables.append(('libflags', ' '.join(libflags)))
- postbuild = self.GetPostbuildCommand(spec, self.target.binary,
- self.target.binary)
- if postbuild:
- variables.append(('postbuilds', postbuild))
- if self.xcode_settings:
- variables.append(('libtool_flags',
- self.xcode_settings.GetLibtoolflags(config_name)))
- # TODO: Starboardize.
- if (self.flavor not in (['mac'] + microsoft_flavors) and
- not self.is_standalone_static_library):
- rule_name = 'alink_thin'
- else:
- rule_name = 'alink'
- if self.toolset != 'target':
- rule_name += '_' + self.toolset
+ static_linker_flags = static_linker.GetFlags()
+ self.ninja.variable('{0}_flags'.format(rule_name),
+ shell.Join(static_linker_flags))
self.ninja.build(
self.target.binary,
@@ -1660,12 +1280,6 @@
path = self.ExpandSpecial(generator_default_variables['PRODUCT_DIR'])
return os.path.join(path, self.xcode_settings.GetWrapperName())
- def ComputeMacBundleBinaryOutput(self):
- """Return the 'output' (full output path) to the binary in a bundle."""
- assert self.is_mac_bundle
- path = self.ExpandSpecial(generator_default_variables['PRODUCT_DIR'])
- return os.path.join(path, self.xcode_settings.GetExecutablePath())
-
def ComputeOutputFileName(self, spec, type=None):
"""Compute the filename of the final output for the current target."""
if not type:
@@ -1936,62 +1550,6 @@
pass
return open(path, mode)
-
-def GetDefaultConcurrentLinks():
- """Returns a best-guess for a number of concurrent links."""
- pool_size = int(os.getenv('GYP_LINK_CONCURRENCY', 0))
- if pool_size:
- return pool_size
-
- if sys.platform in ('win32', 'cygwin'):
- import ctypes
-
- class MEMORYSTATUSEX(ctypes.Structure):
- _fields_ = [
- ('dwLength', ctypes.c_ulong),
- ('dwMemoryLoad', ctypes.c_ulong),
- ('ullTotalPhys', ctypes.c_ulonglong),
- ('ullAvailPhys', ctypes.c_ulonglong),
- ('ullTotalPageFile', ctypes.c_ulonglong),
- ('ullAvailPageFile', ctypes.c_ulonglong),
- ('ullTotalVirtual', ctypes.c_ulonglong),
- ('ullAvailVirtual', ctypes.c_ulonglong),
- ('sullAvailExtendedVirtual', ctypes.c_ulonglong),
- ]
-
- stat = MEMORYSTATUSEX()
- stat.dwLength = ctypes.sizeof(stat)
- ctypes.windll.kernel32.GlobalMemoryStatusEx(ctypes.byref(stat))
-
- # VS 2015 uses 20% more working set than VS 2013 and can consume all RAM
- # on a 64 GB machine.
- mem_limit = max(1, stat.ullTotalPhys / (5 * (2**30))) # total / 5GB
- hard_cap = max(1, int(os.getenv('GYP_LINK_CONCURRENCY_MAX', 2**32)))
- return min(mem_limit, hard_cap)
- elif sys.platform.startswith('linux'):
- if os.path.exists('/proc/meminfo'):
- with open('/proc/meminfo') as meminfo:
- memtotal_re = re.compile(r'^MemTotal:\s*(\d*)\s*kB')
- for line in meminfo:
- match = memtotal_re.match(line)
- if not match:
- continue
- # Allow 6Gb per link on Linux because Gold is quite memory hungry
- return max(1, int(match.group(1)) / (6 * (2**20)))
- return 1
- elif sys.platform == 'darwin':
- try:
- avail_bytes = int(subprocess.check_output(['sysctl', '-n', 'hw.memsize']))
- # A static library debug build of Chromium's unit_tests takes ~2.7GB, so
- # 4GB per ld process allows for some more bloat.
- return max(1, avail_bytes / (4 * (2**30))) # total / 4GB
- except:
- return 1
- else:
- # TODO(scottmg): Implement this for other platforms.
- return 1
-
-
def MaybeWritePathVariable(ninja, tool, toolset):
if tool.GetPath():
ninja.variable('{0}_path'.format(GetNinjaRuleName(tool, toolset)),
@@ -2053,609 +1611,53 @@
build_file, _, _ = gyp.common.ParseQualifiedTarget(target_list[0])
make_global_settings = data[build_file].get('make_global_settings', [])
- try:
- # To avoid duplication, platform-agnostic tools (such as stamp and copy)
- # will be processed only in the host toolchain.
- target_toolchain = [
- target_tool for target_tool in GetTargetToolchain(flavor)
- if not target_tool.IsPlatformAgnostic()
- ]
- host_toolchain = GetHostToolchain(flavor)
+ # To avoid duplication, platform-agnostic tools (such as stamp and copy)
+ # will be processed only in the host toolchain.
+ target_toolchain = [
+ target_tool for target_tool in GetTargetToolchain(flavor)
+ if not target_tool.IsPlatformAgnostic()
+ ]
+ host_toolchain = GetHostToolchain(flavor)
- shell = GetShell(flavor)
+ shell = GetShell(flavor)
- for target_tool in target_toolchain:
- MaybeWritePathVariable(master_ninja, target_tool, 'target')
- for host_tool in host_toolchain:
- MaybeWritePathVariable(master_ninja, host_tool, 'host')
- master_ninja.newline()
+ for target_tool in target_toolchain:
+ MaybeWritePathVariable(master_ninja, target_tool, 'target')
+ for host_tool in host_toolchain:
+ MaybeWritePathVariable(master_ninja, host_tool, 'host')
+ master_ninja.newline()
- for target_tool in target_toolchain:
- MaybeWriteExtraFlagsVariable(master_ninja, target_tool, 'target', shell)
- for host_tool in host_toolchain:
- MaybeWriteExtraFlagsVariable(master_ninja, host_tool, 'host', shell)
- master_ninja.newline()
+ for target_tool in target_toolchain:
+ MaybeWriteExtraFlagsVariable(master_ninja, target_tool, 'target', shell)
+ for host_tool in host_toolchain:
+ MaybeWriteExtraFlagsVariable(master_ninja, host_tool, 'host', shell)
+ master_ninja.newline()
- for target_tool in target_toolchain:
- MaybeWritePool(master_ninja, target_tool, 'target')
- for host_tool in host_toolchain:
- MaybeWritePool(master_ninja, host_tool, 'host')
- master_ninja.newline()
+ for target_tool in target_toolchain:
+ MaybeWritePool(master_ninja, target_tool, 'target')
+ for host_tool in host_toolchain:
+ MaybeWritePool(master_ninja, host_tool, 'host')
+ master_ninja.newline()
- for target_tool in target_toolchain:
- MaybeWriteRule(master_ninja, target_tool, 'target', shell)
- for host_tool in host_toolchain:
- MaybeWriteRule(master_ninja, host_tool, 'host', shell)
- master_ninja.newline()
+ for target_tool in target_toolchain:
+ MaybeWriteRule(master_ninja, target_tool, 'target', shell)
+ for host_tool in host_toolchain:
+ MaybeWriteRule(master_ninja, host_tool, 'host', shell)
+ master_ninja.newline()
- # Copy the gyp-win-tool to the toplevel_build.
- # Also write python to the master_ninja.
- if is_windows:
- gyp.common.CopyTool(flavor, toplevel_build)
- if GetToolchainOrNone(flavor):
- GetToolchainOrNone(flavor).GenerateEnvironmentFiles(
- toplevel_build, generator_flags, OpenOutput)
- else:
- gyp.msvs_emulation.GenerateEnvironmentFiles(toplevel_build,
- generator_flags, OpenOutput)
- master_ninja.variable('python', sys.executable)
- master_ninja.newline()
-
- except NotImplementedError:
- # Fall back to the legacy toolchain.
-
- # Put build-time support tools in out/{config_name}.
+ # Copy the gyp-win-tool to the toplevel_build.
+ # Also write python to the master_ninja.
+ if is_windows:
gyp.common.CopyTool(flavor, toplevel_build)
-
- # Grab make settings for CC/CXX.
- # The rules are
- # - The priority from low to high is gcc/g++, the 'make_global_settings' in
- # gyp, the environment variable.
- # - If there is no 'make_global_settings' for CC.host/CXX.host or
- # 'CC_host'/'CXX_host' enviroment variable, cc_host/cxx_host should be set
- # to cc/cxx.
- if (flavor in sony_flavors and is_windows):
- cc = 'cl.exe'
- cxx = 'cl.exe'
- ld = 'link.exe'
- gyp.msvs_emulation.GenerateEnvironmentFiles(toplevel_build,
- generator_flags, OpenOutput)
- ld_host = '$ld'
- elif GetToolchainOrNone(flavor):
- # TODO: starboardize.
- cc = 'cl.exe'
- cxx = 'cl.exe'
- ld = 'link.exe'
+ if GetToolchainOrNone(flavor):
GetToolchainOrNone(flavor).GenerateEnvironmentFiles(
toplevel_build, generator_flags, OpenOutput)
- ld_host = '$ld'
else:
- cc = 'gcc'
- cxx = 'g++'
- ld = '$cxx'
- ld_host = '$cxx_host'
-
- cc_host = None
- cxx_host = None
- cc_host_global_setting = None
- cxx_host_global_setting = None
-
- build_to_root = InvertRelativePath(build_dir)
- for key, value in make_global_settings:
- if key == 'CC':
- cc = os.path.join(build_to_root, value)
- if key == 'CXX':
- cxx = os.path.join(build_to_root, value)
- if key == 'LD':
- ld = os.path.join(build_to_root, value)
- if key == 'CC.host':
- cc_host = os.path.join(build_to_root, value)
- cc_host_global_setting = value
- if key == 'CXX.host':
- cxx_host = os.path.join(build_to_root, value)
- cxx_host_global_setting = value
- if key == 'LD.host':
- ld_host = os.path.join(build_to_root, value)
-
- flock = 'flock'
- if flavor == 'mac':
- flock = './gyp-mac-tool flock'
- cc = GetEnvironFallback(['CC_target', 'CC'], cc)
- master_ninja.variable('cc', cc)
- cxx = GetEnvironFallback(['CXX_target', 'CXX'], cxx)
- master_ninja.variable('cxx', cxx)
- ld = GetEnvironFallback(['LD_target', 'LD'], ld)
- rc = GetEnvironFallback(['RC'], 'rc.exe')
-
- if not cc_host:
- cc_host = cc
- if not cxx_host:
- cxx_host = cxx
-
- # gyp-win-tool wrappers have a winpython only flock implementation.
- if sys.platform == 'cygwin':
- python_exec = '$python'
- else:
- python_exec = sys.executable
-
- ar_flags = ''
- if flavor in microsoft_flavors:
- master_ninja.variable('ld', ld)
- master_ninja.variable('ar', os.environ.get('AR', 'ar'))
- master_ninja.variable('rc', rc)
- master_ninja.variable('asm', 'ml.exe')
- master_ninja.variable('mt', 'mt.exe')
- master_ninja.variable('use_dep_database', '1')
- elif flavor in sony_flavors:
- # Require LD to be set.
- master_ninja.variable('ld', os.environ.get('LD'))
- master_ninja.variable('ar', os.environ.get('AR', 'ar'))
- ar_flags = os.environ.get('ARFLAGS', 'rcs')
- master_ninja.variable('arFlags', ar_flags)
- # On Sony, when we use orbis-snarl.exe with a response file, we cannot
- # pass it flags (like 'rcs'), so ARFLAGS is likely set to '' for this
- # platform. In that case, do not append the thin archive 'T' flag
- # to the flags string.
- thin_flag_to_add = ''
- if len(ar_flags) >= 1 and ar_flags.find('T') == -1:
- thin_flag_to_add = 'T'
- master_ninja.variable('arThinFlags', ar_flags + thin_flag_to_add)
-
- else:
- master_ninja.variable('ld', ld)
- master_ninja.variable('ar', GetEnvironFallback(['AR_target', 'AR'], 'ar'))
- ar_flags = os.environ.get('ARFLAGS', 'rcs')
- master_ninja.variable('arFlags', ar_flags)
- thin_flag_to_add = ''
- if ar_flags.find('T') == -1:
- thin_flag_to_add = 'T'
- master_ninja.variable('arThinFlags', ar_flags + thin_flag_to_add)
- master_ninja.variable('ar_host', GetEnvironFallback(['AR_host'], 'ar'))
- cc_host = GetEnvironFallback(['CC_host'], cc_host)
- cxx_host = GetEnvironFallback(['CXX_host'], cxx_host)
- ld_host = GetEnvironFallback(['LD_host'], ld_host)
- arflags_host = GetEnvironFallback(['ARFLAGS_host'], ar_flags)
- arthinflags_host = GetEnvironFallback(['ARTHINFLAGS_host'], arflags_host)
-
- # The environment variable could be used in 'make_global_settings', like
- # ['CC.host', '$(CC)'] or ['CXX.host', '$(CXX)'], transform them here.
- if '$(CC)' in cc_host and cc_host_global_setting:
- cc_host = cc_host_global_setting.replace('$(CC)', cc)
- if '$(CXX)' in cxx_host and cxx_host_global_setting:
- cxx_host = cxx_host_global_setting.replace('$(CXX)', cxx)
- master_ninja.variable('cc_host', cc_host)
- master_ninja.variable('cxx_host', cxx_host)
- master_ninja.variable('arFlags_host', arflags_host)
- master_ninja.variable('arThinFlags_host', arthinflags_host)
- master_ninja.variable('ld_host', ld_host)
-
- if sys.platform == 'cygwin':
- python_path = cygpath.to_nt(
- '/cygdrive/c/python_27_amd64/files/python.exe')
- else:
- python_path = 'python'
- master_ninja.variable('python', python_path)
+ gyp.msvs_emulation.GenerateEnvironmentFiles(toplevel_build,
+ generator_flags, OpenOutput)
+ master_ninja.variable('python', sys.executable)
master_ninja.newline()
- master_ninja.pool('link_pool', depth=GetDefaultConcurrentLinks())
- master_ninja.newline()
-
- if flavor not in microsoft_flavors:
- if flavor in sony_flavors:
- # uca := Unnamed Console A
- dep_format = 'uca'
- master_ninja.rule(
- 'cc',
- description='CC $out',
- command=('$cc @$out.rsp'),
- rspfile='$out.rsp',
- rspfile_content=('-c $in -o $out '
- '-MMD $defines $includes $cflags $cflags_c '
- '$cflags_pch_c'),
- depfile='$out_no_ext.d',
- deps='gcc',
- depformat=dep_format)
- master_ninja.rule(
- 'cxx',
- description='CXX $out',
- command=('$cxx @$out.rsp'),
- rspfile='$out.rsp',
- rspfile_content=('-c $in -o $out '
- '-MMD $defines $includes $cflags $cflags_cc '
- '$cflags_pch_cc'),
- depfile='$out_no_ext.d',
- deps='gcc',
- depformat=dep_format)
- else:
- master_ninja.rule(
- 'cc',
- description='CC $out',
- command=('$cc -MMD -MF $out.d $defines $includes $cflags $cflags_c '
- '$cflags_pch_c -c $in -o $out'),
- deps='gcc',
- depfile='$out.d')
- master_ninja.rule(
- 'cc_s',
- description='CC $out',
- command=('$cc $defines $includes $cflags $cflags_c '
- '$cflags_pch_c -c $in -o $out'))
- master_ninja.rule(
- 'cxx',
- description='CXX $out',
- command=(
- '$cxx -MMD -MF $out.d $defines $includes $cflags $cflags_cc '
- '$cflags_pch_cc -c $in -o $out'),
- deps='gcc',
- depfile='$out.d')
-
- else:
- cc_command = ('$cc /nologo /showIncludes /FC '
- '@$out.rsp /c $in /Fo$out /Fd$pdbname ')
- cxx_command = ('$cxx /nologo /showIncludes /FC '
- '@$out.rsp /c $in /Fo$out /Fd$pdbname ')
- master_ninja.rule(
- 'cc',
- description='CC $out',
- command=cc_command,
- deps='msvc',
- rspfile='$out.rsp',
- rspfile_content='$defines $includes $cflags $cflags_c')
- master_ninja.rule(
- 'cxx',
- description='CXX $out',
- command=cxx_command,
- deps='msvc',
- rspfile='$out.rsp',
- rspfile_content='$defines $includes $cflags $cflags_cc')
-
- master_ninja.rule(
- 'rc',
- description='RC $in',
- # Note: $in must be last otherwise rc.exe complains.
- command=('%s gyp-win-tool rc-wrapper '
- '$arch $rc $defines $includes $rcflags /fo$out $in' %
- python_exec))
- master_ninja.rule(
- 'asm',
- description='ASM $in',
- command=(
- '%s gyp-win-tool asm-wrapper '
- '$arch $asm $defines $includes /c /Fo $out $in' % python_exec))
-
- if flavor not in (['mac'] + microsoft_flavors):
- alink_command = 'rm -f $out && $ar $arFlags $out @$out.rsp'
- # TODO: Use rcsT on Linux only.
- alink_thin_command = 'rm -f $out && $ar $arThinFlags $out @$out.rsp'
-
- ld_cmd = '$ld'
-
- if flavor in sony_flavors and is_windows:
- alink_command = 'cmd.exe /c ' + alink_command
- alink_thin_command = 'cmd.exe /c ' + alink_thin_command
- ld_cmd = '%s gyp-win-tool link-wrapper $arch $ld' % python_exec
-
- master_ninja.rule(
- 'alink',
- description='AR $out',
- command=alink_command,
- rspfile='$out.rsp',
- rspfile_content='$in_newline')
- master_ninja.rule(
- 'alink_thin',
- description='AR $out',
- command=alink_thin_command,
- rspfile='$out.rsp',
- rspfile_content='$in_newline')
-
- # This allows targets that only need to depend on $lib's API to declare
- # an order-only dependency on $lib.TOC and avoid relinking such
- # downstream dependencies when $lib changes only in non-public ways.
- # The resulting string leaves an uninterpolated %{suffix} which
- # is used in the final substitution below.
- mtime_preserving_solink_base = (
- 'if [ ! -e $lib -o ! -e ${lib}.TOC ]; then %(solink)s && '
- '%(extract_toc)s > ${lib}.TOC; else %(solink)s && %(extract_toc)s '
- '> ${lib}.tmp && if ! cmp -s ${lib}.tmp ${lib}.TOC; then mv '
- '${lib}.tmp ${lib}.TOC ; fi; fi' % {
- 'solink': (
- ld_cmd +
- ' -shared $ldflags -o $lib -Wl,-soname=$soname %(suffix)s'),
- 'extract_toc': ('{ readelf -d ${lib} | grep SONAME ; '
- 'nm -gD -f p ${lib} | cut -f1-2 -d\' \'; }')
- })
-
- master_ninja.rule(
- 'solink',
- description='SOLINK $lib',
- restat=True,
- command=(mtime_preserving_solink_base % {
- 'suffix':
- '-Wl,--whole-archive $in $solibs -Wl,--no-whole-archive '
- '$libs'
- }))
- master_ninja.rule(
- 'solink_module',
- description='SOLINK(module) $lib',
- restat=True,
- command=(mtime_preserving_solink_base % {
- 'suffix': '-Wl,--start-group $in $solibs -Wl,--end-group $libs'
- }))
-
- if flavor in sony_flavors:
- # Sony linkers don't know about rpath.
- rpath = ''
- else:
- rpath = r'-Wl,-rpath=\$$ORIGIN/lib'
-
- master_ninja.rule(
- 'link',
- description='LINK $out',
- command=(ld_cmd + ' @$out.rsp'),
- rspfile='$out.rsp',
- rspfile_content=('$ldflags -o $out %s -Wl,--start-group $in $solibs '
- '-Wl,--end-group $libs' % rpath),
- pool='link_pool')
- elif flavor in microsoft_flavors:
- master_ninja.rule(
- 'alink',
- description='LIB $out',
- command=(
- '%s gyp-win-tool link-wrapper $arch '
- '$ar /nologo /ignore:4221 /OUT:$out @$out.rsp' % python_exec),
- rspfile='$out.rsp',
- rspfile_content='$in_newline $libflags')
- dlldesc = 'LINK(DLL) $dll'
- dllcmd = ('%s gyp-win-tool link-wrapper $arch '
- '$ld /nologo $implibflag /DLL /OUT:$dll '
- '/PDB:$dll.pdb @$dll.rsp' % python_exec)
- if not flavor in microsoft_flavors:
- # XB1 doesn't need a manifest.
- dllcmd += (
- ' && %s gyp-win-tool manifest-wrapper $arch '
- '$mt -nologo -manifest $manifests -out:$dll.manifest' % python_exec)
- master_ninja.rule(
- 'solink',
- description=dlldesc,
- command=dllcmd,
- rspfile='$dll.rsp',
- rspfile_content='$libs $in_newline $ldflags',
- restat=True)
- master_ninja.rule(
- 'solink_module',
- description=dlldesc,
- command=dllcmd,
- rspfile='$dll.rsp',
- rspfile_content='$libs $in_newline $ldflags',
- restat=True)
- # Note that ldflags goes at the end so that it has the option of
- # overriding default settings earlier in the command line.
- if flavor == 'win':
- link_command = ('%s gyp-win-tool link-wrapper $arch '
- '$ld /nologo /OUT:$out /PDB:$out.pdb @$out.rsp && '
- '%s gyp-win-tool manifest-wrapper $arch '
- '$mt -nologo -manifest $manifests -out:$out.manifest' %
- (python_exec, python_exec))
- else:
- assert flavor in microsoft_flavors
- # XB1 doesn't need a manifest.
- link_command = (
- '%s gyp-win-tool link-wrapper $arch '
- '$ld /nologo /OUT:$out /PDB:$out.pdb @$out.rsp' % (python_exec))
-
- master_ninja.rule(
- 'link',
- description='LINK $out',
- command=link_command,
- rspfile='$out.rsp',
- rspfile_content='$in_newline $libs $ldflags',
- pool='link_pool')
- else:
- master_ninja.rule(
- 'objc',
- description='OBJC $out',
- command=(
- '$cc -MMD -MF $out.d $defines $includes $cflags $cflags_objc '
- '$cflags_pch_objc -c $in -o $out'),
- depfile='$out.d')
- master_ninja.rule(
- 'objcxx',
- description='OBJCXX $out',
- command=(
- '$cxx -MMD -MF $out.d $defines $includes $cflags $cflags_objcc '
- '$cflags_pch_objcc -c $in -o $out'),
- depfile='$out.d')
- master_ninja.rule(
- 'alink',
- description='LIBTOOL-STATIC $out, POSTBUILDS',
- command='rm -f $out && '
- './gyp-mac-tool filter-libtool libtool $libtool_flags '
- '-static -o $out $in'
- '$postbuilds')
-
- # Record the public interface of $lib in $lib.TOC. See the corresponding
- # comment in the posix section above for details.
- mtime_preserving_solink_base = (
- 'if [ ! -e $lib -o ! -e ${lib}.TOC ] || '
- # Always force dependent targets to relink if this library
- # reexports something. Handling this correctly would require
- # recursive TOC dumping but this is rare in practice, so punt.
- 'otool -l $lib | grep -q LC_REEXPORT_DYLIB ; then '
- '%(solink)s && %(extract_toc)s > ${lib}.TOC; '
- 'else '
- '%(solink)s && %(extract_toc)s > ${lib}.tmp && '
- 'if ! cmp -s ${lib}.tmp ${lib}.TOC; then '
- 'mv ${lib}.tmp ${lib}.TOC ; '
- 'fi; '
- 'fi' % {
- 'solink': '$ld -shared $ldflags -o $lib %(suffix)s',
- 'extract_toc':
- '{ otool -l $lib | grep LC_ID_DYLIB -A 5; '
- 'nm -gP $lib | cut -f1-2 -d\' \' | grep -v U$$; true; }'
- })
-
- # TODO(thakis): The solink_module rule is likely wrong. Xcode seems to
- # pass -bundle -single_module here (for osmesa.so).
- master_ninja.rule(
- 'solink',
- description='SOLINK $lib, POSTBUILDS',
- restat=True,
- command=(mtime_preserving_solink_base % {
- 'suffix': '$in $solibs $libs$postbuilds'
- }))
- master_ninja.rule(
- 'solink_module',
- description='SOLINK(module) $lib, POSTBUILDS',
- restat=True,
- command=(mtime_preserving_solink_base % {
- 'suffix': '$in $solibs $libs$postbuilds'
- }))
-
- master_ninja.rule(
- 'link',
- description='LINK $out, POSTBUILDS',
- command=('$ld $ldflags -o $out '
- '$in $solibs $libs$postbuilds'),
- pool='link_pool')
- master_ninja.rule(
- 'infoplist',
- description='INFOPLIST $out',
- command=('$cc -E -P -Wno-trigraphs -x c $defines $in -o $out && '
- 'plutil -convert xml1 $out $out'))
- master_ninja.rule(
- 'mac_tool',
- description='MACTOOL $mactool_cmd $in',
- command='$env ./gyp-mac-tool $mactool_cmd $in $out')
- master_ninja.rule(
- 'package_framework',
- description='PACKAGE FRAMEWORK $out, POSTBUILDS',
- command='./gyp-mac-tool package-framework $out $version$postbuilds '
- '&& touch $out')
- if flavor in microsoft_flavors:
- master_ninja.rule(
- 'stamp',
- description='STAMP $out',
- command='%s gyp-win-tool stamp $out' % python_exec)
- master_ninja.rule(
- 'copy',
- description='COPY $in $out',
- command='%s gyp-win-tool recursive-mirror $in $out' % python_exec)
- elif sys.platform in ['cygwin', 'win32']:
- master_ninja.rule(
- 'stamp',
- description='STAMP $out',
- command='$python gyp-win-tool stamp $out')
- master_ninja.rule(
- 'copy',
- description='COPY $in $out',
- command='$python gyp-win-tool recursive-mirror $in $out')
- else:
- master_ninja.rule(
- 'stamp', description='STAMP $out', command='${postbuilds}touch $out')
- master_ninja.rule(
- 'copy',
- description='COPY $in $out',
- command='rm -rf $out && cp -af $in $out')
- master_ninja.newline()
-
- # Output host building rules
- if is_windows:
- cc_command = ('$cc /nologo /showIncludes /FC '
- '@$out.rsp /c $in /Fo$out /Fd$pdbname ')
- cxx_command = ('$cxx /nologo /showIncludes /FC '
- '@$out.rsp /c $in /Fo$out /Fd$pdbname ')
- master_ninja.rule(
- 'cc_host',
- description='CC_HOST $out',
- command=cc_command,
- deps='msvc',
- rspfile='$out.rsp',
- rspfile_content='$defines $includes $cflags_host $cflags_c_host')
- master_ninja.rule(
- 'cxx_host',
- description='CXX_HOST $out',
- command=cxx_command,
- deps='msvc',
- rspfile='$out.rsp',
- rspfile_content='$defines $includes $cflags_host $cflags_cc_host')
-
- master_ninja.rule(
- 'alink_host',
- description='LIB_HOST $out',
- command=(
- '%s gyp-win-tool link-wrapper $arch '
- '$ar /nologo /ignore:4221 /OUT:$out @$out.rsp' % python_exec),
- rspfile='$out.rsp',
- rspfile_content='$in_newline $libflags_host')
-
- master_ninja.rule(
- 'alink_thin_host',
- description='LIB_HOST $out',
- command=(
- '%s gyp-win-tool link-wrapper $arch '
- '$ar /nologo /ignore:4221 /OUT:$out @$out.rsp' % python_exec),
- rspfile='$out.rsp',
- rspfile_content='$in_newline $libflags_host')
-
- link_command = (
- '%s gyp-win-tool link-wrapper $arch '
- '$ld /nologo /OUT:$out /PDB:$out.pdb @$out.rsp' % (python_exec))
-
- master_ninja.rule(
- 'link_host',
- description='LINK_HOST $out',
- command=link_command,
- rspfile='$out.rsp',
- rspfile_content='$in_newline $libs $ldflags',
- pool='link_pool')
- else:
- cc_command = 'bash -c "$cc_host @$out.rsp"'
- cxx_command = 'bash -c "$cxx_host @$out.rsp"'
- master_ninja.rule(
- 'cc_host',
- description='CC_HOST $out',
- command=cc_command,
- rspfile='$out.rsp',
- rspfile_content=('-MMD -MF $out.d $defines $includes $cflags_host '
- '$cflags_c_host $cflags_pch_c -c $in -o $out'),
- depfile='$out.d')
- master_ninja.rule(
- 'cxx_host',
- description='CXX_HOST $out',
- command=cxx_command,
- rspfile='$out.rsp',
- rspfile_content=('-MMD -MF $out.d $defines $includes $cflags_host '
- '$cflags_cc_host $cflags_pch_cc -c $in -o $out'),
- depfile='$out.d')
-
- alink_command = 'rm -f $out && $ar_host $arFlags_host $out @$out.rsp'
- alink_thin_command = ('rm -f $out && $ar_host $arThinFlags_host $out '
- '@$out.rsp')
-
- master_ninja.rule(
- 'alink_host',
- description='AR_HOST $out',
- command='bash -c "' + alink_command + '"',
- rspfile='$out.rsp',
- rspfile_content='$in_newline')
- master_ninja.rule(
- 'alink_thin_host',
- description='AR_HOST $out',
- command='bash -c "' + alink_thin_command + '"',
- rspfile='$out.rsp',
- rspfile_content='$in_newline')
- beginlinkinlibs = ''
- endlinkinlibs = ''
- if is_linux:
- beginlinkinlibs = '-Wl,--start-group'
- endlinkinlibs = '-Wl,--end-group'
- rpath = '-Wl,-rpath=\$$ORIGIN/lib'
- master_ninja.rule(
- 'link_host',
- description='LINK_HOST $out',
- command=('bash -c "$ld_host $ldflags_host -o $out %s '
- '%s $in $solibs %s $libs"' % (rpath, beginlinkinlibs,
- endlinkinlibs)))
-
all_targets = set()
for build_file in params['build_files']:
for target in gyp.common.AllTargets(target_list, target_dicts,
diff --git a/src/v8/src/v8.gyp b/src/v8/src/v8.gyp
index 6bd4994..f789f3b 100644
--- a/src/v8/src/v8.gyp
+++ b/src/v8/src/v8.gyp
@@ -61,7 +61,7 @@
'generate_bytecode_output_root': '<(SHARED_INTERMEDIATE_DIR)/generate-bytecode-output-root',
'generate_bytecode_builtins_list_output': '<(generate_bytecode_output_root)/builtins-generated/bytecodes-builtins-list.h',
- 'v8_use_snapshot': '<(cobalt_v8_buildtime_snapshot)',
+ 'v8_use_snapshot': 1,
'v8_optimized_debug': 0,
'v8_use_external_startup_data': 0,
'v8_enable_i18n_support': 0,
