Remove 150% hard line length limit for long URLs.
BUG=
Review URL: https://codereview.chromium.org/1033363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294600 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 49ed07c..bba7737 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -368,12 +368,13 @@
if line_len <= file_maxlen:
return True
- if line_len > extra_maxlen:
- return False
-
+ # Allow long URLs of any length.
if any((url in line) for url in ('file://', 'http://', 'https://')):
return True
+ if line_len > extra_maxlen:
+ return False
+
if 'url(' in line and file_extension == 'css':
return True
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index d6cbd09..2196d8d 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2205,20 +2205,20 @@
check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
self.ContentTest(
check,
- ' http:// 0 23 5',
- None,
' http:// 0 23 56',
None,
+ ' foob:// 0 23 56',
+ None,
presubmit.OutputApi.PresubmitPromptWarning)
def testCannedCheckLongLinesFile(self):
check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
self.ContentTest(
check,
- ' file:// 0 23 5',
- None,
' file:// 0 23 56',
None,
+ ' foob:// 0 23 56',
+ None,
presubmit.OutputApi.PresubmitPromptWarning)
def testCannedCheckLongLinesCssUrl(self):
