commit a121127bcea54c43fc8f858e067e8fa3db1231cb
author Sylvain Defresne <sdefresne@chromium.org> Tue Jun 16 12:46:26 2020 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Jun 17 08:16:39 2020 +0000
tree 87579f149ec797d12ab981e4fb2f3c9771926fe8
parent fbe7aec770944d17c9f3006f6cbb5c19e8cd43ea

Disable code signing in generated Xcode project

Since code signing is done as part of the build (via create_bundle),
the generated project must disable the code signing otherwise Xcode
complains.

This is done by configuring an empty code signing identity.

Bug: none
Change-Id: Ifee80ee45659da833380f0b47c58782a6c08ccf3
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/9001
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>

src/gn/xcode_object.cc

diff --git a/src/gn/xcode_object.cc b/src/gn/xcode_object.cc
index 471a201..7948b17 100644
--- a/src/gn/xcode_object.cc
+++ b/src/gn/xcode_object.cc
@@ -812,7 +812,7 @@
                                     const std::string& shell_script) {
   PBXAttributes attributes;
   attributes["CLANG_ENABLE_OBJC_WEAK"] = "YES";
-  attributes["CODE_SIGN_IDENTITY"] = "-";
+  attributes["CODE_SIGN_IDENTITY"] = "";
   attributes["CODE_SIGNING_REQUIRED"] = "NO";
   attributes["CONFIGURATION_BUILD_DIR"] = ".";
   attributes["PRODUCT_NAME"] = name;
@@ -825,7 +825,7 @@
   DCHECK(!target_for_indexing_);
   PBXAttributes attributes;
   attributes["CLANG_ENABLE_OBJC_WEAK"] = "YES";
-  attributes["CODE_SIGN_IDENTITY"] = "-";
+  attributes["CODE_SIGN_IDENTITY"] = "";
   attributes["CODE_SIGNING_REQUIRED"] = "NO";
   attributes["EXECUTABLE_PREFIX"] = "";
   attributes["HEADER_SEARCH_PATHS"] = sources_->path();
@@ -869,7 +869,7 @@
 
   PBXAttributes attributes = extra_attributes;
   attributes["CLANG_ENABLE_OBJC_WEAK"] = "YES";
-  attributes["CODE_SIGN_IDENTITY"] = "-";
+  attributes["CODE_SIGN_IDENTITY"] = "";
   attributes["CODE_SIGNING_REQUIRED"] = "NO";
   attributes["CONFIGURATION_BUILD_DIR"] = output_dir;
   attributes["PRODUCT_NAME"] = product_name;