commit fd3d768bcfd44a8d9639fe278581bd9851d0ce3a
author Nico Weber <thakis@chromium.org> Mon Mar 09 11:52:10 2020 -0400
committer Commit Bot <commit-bot@chromium.org> Mon Mar 09 16:00:16 2020 +0000
tree 30d37d6018ea8fe6ab5aabce530dae75ef00a54f
parent f871e54ef4496fae1e95006e14ba5ea24c7e9ff6

msvc writer: Don't die on generated_file() and create_bundle() targets.

Change-Id: I82c9cb8838f65aa7369bcee161617d0f8e84c079
Bug: chromium:1059666
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/7600
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>

src/gn/visual_studio_writer.cc

diff --git a/src/gn/visual_studio_writer.cc b/src/gn/visual_studio_writer.cc
index dd09055..fd16536 100644
--- a/src/gn/visual_studio_writer.cc
+++ b/src/gn/visual_studio_writer.cc
@@ -351,10 +351,12 @@
 
   for (const Target* target : targets) {
     // Skip actions and bundle targets.
-    if (target->output_type() == Target::COPY_FILES ||
-        target->output_type() == Target::ACTION ||
+    if (target->output_type() == Target::ACTION ||
         target->output_type() == Target::ACTION_FOREACH ||
-        target->output_type() == Target::BUNDLE_DATA) {
+        target->output_type() == Target::BUNDLE_DATA ||
+        target->output_type() == Target::COPY_FILES ||
+        target->output_type() == Target::CREATE_BUNDLE ||
+        target->output_type() == Target::GENERATED_FILE) {
       continue;
     }